From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1CFCC282D1 for ; Thu, 6 Mar 2025 22:08:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A92DE280009; Thu, 6 Mar 2025 17:08:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A43D6280001; Thu, 6 Mar 2025 17:08:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90B41280009; Thu, 6 Mar 2025 17:08:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 73E24280001 for ; Thu, 6 Mar 2025 17:08:45 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 37268A5B04 for ; Thu, 6 Mar 2025 22:08:46 +0000 (UTC) X-FDA: 83192516652.01.AD87503 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) by imf05.hostedemail.com (Postfix) with ESMTP id 56D4A100007 for ; Thu, 6 Mar 2025 22:08:44 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LvlpBzEc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.222.171 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741298924; a=rsa-sha256; cv=none; b=AeqbThpXPQbGBY8ziIPTwXO9C7eGYi+EO8WXTxDqVUygWoQxvyHRTGf5E4p1YRiNv3Kd53 bgfFlitf7tVIH8ZjL5gWPBp9cEc2OG/dw6ug9ROlNbXfkcuU/6kzDGQP6EQf1L8vHVh5v7 XmJdPGXPZQXVY7S5odpq83Y3miY2Dss= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LvlpBzEc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.222.171 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741298924; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tEE7NsftkQUqXiTUuNy6G99jpfQ/qqsTMCdl+H0vwQQ=; b=NYYalDIXwoS3YbMtfbffLhG8I9LQ+kMszHATm+LubEAQ+tZbqaw8mp3ugzefwcxQysp7yA rBsN/wDdAfqziOTspq01MDWj1AOtcI+PeskRsbngMC06m56te+wlDgtSWU80+2OPq8zTtp SwQ2CJae+H2FSB2/Nwxk4K5ERwqPEQU= Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-7c3d9cdb0ccso226134785a.3 for ; Thu, 06 Mar 2025 14:08:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741298923; x=1741903723; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tEE7NsftkQUqXiTUuNy6G99jpfQ/qqsTMCdl+H0vwQQ=; b=LvlpBzEcQ6B9lxG8sM93NL26rfgsbXLCqXNzD1ZRah77altLa6JgBIsNxoyUs+KKYN 6CfXPRvsl7ouFRDkqijGl3ETJXpk9V7XCo8hLY0Ds/0ADbcGMFDW8Lxs3e0X/E9vkEnh xSYjLFy3Ge/NN9vG6OqN7OhBwxRbO6MshITMP8wijKtlmtaoRyBNDJmp8N93Yq0WNVQk C7QZrkuhAPdI83T39qn52Pn9FIozRCx5C+JybYOmTdTuePKDsEhZQLPD3oyVgqYLN+qJ iM7ucUEV/QDOSrNG5trYWwI7qMZXpFNzTMmV0rbJzSQPNrh3rUDxD5n/pdaHaFjj3jQQ CKMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741298923; x=1741903723; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tEE7NsftkQUqXiTUuNy6G99jpfQ/qqsTMCdl+H0vwQQ=; b=r9br0024rIUxnBPUE8qXLdx9d5BrXFn0G9KBoXkI4EIz4u39GdvgzQ7nZMunUpZXyo /MjsZFGV+2FTaMlbumoYc9PG4J/bSsdmgiWzO56QXdyNZuQ3psffvuiPtQ9L7bNcW73K UEnjt7lWc9dDxtqa558VMzbp7VK6yI+BZdAhdibvcuWuFI+OhMprBlYIQSKsCPS8sFH4 rYWK5w0tCV+Lidfg3Il/WZ+j8gM3ubUbh+tTQ46Vw5JHKFfdZrz5Cc2kWh22vEFqHWGd 8bA09H46bKnAYRR8P/mtSBiUrMfn0AQ+7h+EaS/GiexcGvRC/d5r36fVvOBiREdw6iv0 CWsg== X-Forwarded-Encrypted: i=1; AJvYcCVV6++ueaj4Y18yfOQswaeqkciX36y/qHGLuyflbOx9nknQ3HM7g405kLw/X4UYpXSQ3X9XzJtXwg==@kvack.org X-Gm-Message-State: AOJu0YzU355sYRnGjrLXLSdD072tvtrzZxdCEsOLS+UVSnPgQ7y7wKTT WM5dTFk89iYO2FTv/yo1TZydATlXmc7lb+Qz7vHe9Yoo10Go6l3ZEAkBCM4FgtIFx5170CNDvqI wfylg1/EHAL2OsRYiL3rKXII2FkA= X-Gm-Gg: ASbGncuqqce1BBNViEo5s3kn9v5I2R4UqsknCSSgy3A1Cbhnmtf9VSVb10RDihKDple 2dpsmroyZqJdahF8+D268401mt9EqZE6A83s6SVKPRhq5Tbd2Xu/b9pZFMBLnfkDHSW4DXMuxsc katizpNT73h2i0FN2uGr9buYvhzb0IyPtEFdLGlc07mQb08Ofwlfv3IcNYZA== X-Google-Smtp-Source: AGHT+IFS53kcenQGBfnzTlvVjKHX9DytQE+sWxJfhIpYHAPPf3CBZ0Dddj3dsQErG50SQvPWw3rea+2+sKx5Akv5pfY= X-Received: by 2002:a05:620a:284e:b0:7c3:d280:a67c with SMTP id af79cd13be357-7c4e168b415mr130976985a.17.1741298923332; Thu, 06 Mar 2025 14:08:43 -0800 (PST) MIME-Version: 1.0 References: <20250306205011.784787-1-nphamcs@gmail.com> In-Reply-To: From: Nhat Pham Date: Thu, 6 Mar 2025 14:08:32 -0800 X-Gm-Features: AQ5f1Jr6gfeWC2e7UeBsnVNZE9bBatA0QhkDQY4YC0iMXHH8TKPQbnXqksG86Ek Message-ID: Subject: Re: [PATCH v4] page_io: zswap: do not crash the kernel on decompression failure To: Yosry Ahmed Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, chengming.zhou@linux.dev, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 56D4A100007 X-Stat-Signature: tdupjcmnso3cs34mhntnopzzrrp5s5n6 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1741298924-556792 X-HE-Meta: U2FsdGVkX18At5dndHc5LbrQHoPjai6S8tZVqR+WRKRod5XpUQWkex+pZxHl7PMAOzEca5AJ76fcZZONjhTn2mhFDwtKkHQaYYPli+jnUkRiPdLdx/kYtOUCkX6welnQKiAFYMbpcRmoCjq5JqB2sGByLbY6RXktOKVLCs3GIVon7kOWtWRWUMkzPlBnQaJEfno+6xbbR3yJGA46wES8q04rmHdA4OomeKPgT/PyYQSliVcULtIxhNL75IDMuYYHbvBIqE5lTyJ7o0cy/zTLzzX6kdDbBuy+z40eYOksV/l3BA9a6BCPXK9/CeqgXMddnSz/S5DifRHEXudZyWq6yLUCZj4KswAwxWSQCyAMvXz7q4sG/uXpXTE8+LBUGmfcbr3Y+1I0tHYRy46GCAAhCqQFbaisecZQO5o4Zx10PU2SAUE9IilZm21bX3wE9/NODRaCz9ooA3+AFu3OeJG2eQD2todJFWuluHeBrtoMjp+twP2hIIlDBH8Qbh9X5su0Fz75DDeX0taAP+2Jvwj/MRFkZZ5TT0ezi9CzEgmqi1IMZTCa3L3i1tJ2LxiyL4C94jkleNmnzVYNojm0eSBlmfc6CxbFfN6KEXp6+1gJy3ytgpK0P6JsC/uevgmWJC9w8/CAMYI8dwT5gqHWCy7IcMu3AdvxDo6sPuFwvF8ukAA5lAKZGxWyobJfVqHig9Mp/pbb+piB0sSxt4hpK8j5nsgIlb23r3F2vAC1TynKZeeKiK/n7ClNAHbWvSVppaEHl9xUUYQO/bkhtHlMQXuBKD98AyRS+BZhr8R2NKqRo9N1HMO3cyH6Dc89BEqGmV9T4dM1TdFrjHntneqFrMmy3AS9hhFqaTDalT9WCTHett46yB0KLgqoUuVJsMauqQf9RmufLyTp+kseS+b6+rcUpF6kIAhBqeEb8/JSZlxIZMGNoqKq1wqErjN5Y3V4UDj96j0LHJNThz3Nnf74CH+ svAQMtV4 96OhUpsl5GgTmGP1Al70PnJGdBUV/r44TAWpp7uwv5bSNALhd/5hQ/weV9GdsBUIQja2XL2lOHghm2pOk6Tfh3lG9VXwsmxJswRChL08AgK6/b21j+yp3XHFZ60AVm+X2Z6iqE9NYhM48B8DptkNucZZ7nwXxKm0kcaMC9wm8o/GKfQnTGhwyE4Hu5vTedzJCDLC2BaW4Ws85dMYKpiLMAF2fiw45V32N6yzZCHv3Jd3cl3JgXpkECQtauJ0wol5FvzWciReYaNGYvfZmMg/LQOBzscSsiNJT7K/yD3e3VJ5HOMgT6Ay2nA6nMuUZjkeij610Sl55G5UzVr9WnQT9NI4FOiwalfS4D0TYc6yFSVweCFQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.065697, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 6, 2025 at 1:32=E2=80=AFPM Yosry Ahmed = wrote: > > On Thu, Mar 06, 2025 at 12:50:10PM -0800, Nhat Pham wrote: > > Couple of nits below, but otherwise LGTM: > > Acked-by: Yosry Ahmed > > (I did expect the swap zeromap change in the same series, so if you send > it separately make sure to mention it's on top of this one because they > will conflict otherwise) Yeah of course. I actually have already finished that second patch, but wanna spend a bit more time proofreading things :) > > [..] > > @@ -1606,7 +1628,26 @@ bool zswap_store(struct folio *folio) > > return ret; > > } > > > > -bool zswap_load(struct folio *folio) > > +/** > > + * zswap_load() - load a page from zswap > > nit: folio > > > + * @folio: folio to load > > + * > > + * Return: 0 on success, or one of the following error codes: > > nit: Maybe worth mentioning that the folio is unlocked and marked > uptodate on success for completeness. Will do! > > > + * > > + * -EIO: if the swapped out content was in zswap, but could not be lo= aded > > + * into the page due to a decompression failure. The folio is unlocke= d, but > > + * NOT marked up-to-date, so that an IO error is emitted (e.g. do_swa= p_page() > > + * will SIGBUS). > > + * > > + * -EINVAL: if the swapped out content was in zswap, but the page bel= ongs > > + * to a large folio, which is not supported by zswap. The folio is un= locked, > > + * but NOT marked up-to-date, so that an IO error is emitted (e.g. > > + * do_swap_page() will SIGBUS). > > + * > > + * -ENOENT: if the swapped out content was not in zswap. The folio re= mains > > + * locked on return. > > + */ > > +int zswap_load(struct folio *folio) > [..]