From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F9BCC2BD09 for ; Fri, 12 Jul 2024 22:47:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC0DD6B0092; Fri, 12 Jul 2024 18:47:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B718B6B0095; Fri, 12 Jul 2024 18:47:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A39E56B0096; Fri, 12 Jul 2024 18:47:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 859846B0092 for ; Fri, 12 Jul 2024 18:47:44 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2D41CC0D4F for ; Fri, 12 Jul 2024 22:47:44 +0000 (UTC) X-FDA: 82332589248.14.D64A30C Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by imf12.hostedemail.com (Postfix) with ESMTP id 5B43E4000C for ; Fri, 12 Jul 2024 22:47:42 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="CVuU/gvZ"; spf=pass (imf12.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.51 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720824427; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5ngiJf14XEWABtOeJ3ozB6Gsd22dnKoZDQl3XHj467I=; b=BYtWLtfxCqvtZhSi8iKmDoICY+6kgpA7Z3LUWKO44pvkixe1HjTJi/HGLiqucOvF2+xkB6 jFCNHBh7flXyS5dmYLEUWEIN7N6VJAakO+rY6tIVS+upjC+5MimG1cOePlXankh/Z5wKSN TSTKbkUWrbvxpmAggDKk/yHj5tP8/Sk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720824427; a=rsa-sha256; cv=none; b=TH0x1lYDH7ZP20PjJWQr2879+D8xY1Zr7HW4vY4+wKBKjJUfVUipcWQn3mxudAPJF+dA00 MPNMQMv5PG3AJmRfyu3flHzb1PkscGjl8DNNg6TsMgE3SSC7iS/yZc7eZBqLaea6Vg6+6N Qb6v7yzYm08ex9ydbNyt/GPXO9fRq80= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="CVuU/gvZ"; spf=pass (imf12.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.51 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-6b6176e59e7so14271346d6.1 for ; Fri, 12 Jul 2024 15:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720824461; x=1721429261; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5ngiJf14XEWABtOeJ3ozB6Gsd22dnKoZDQl3XHj467I=; b=CVuU/gvZuNTRoppEytwk85VJy39ICwxve5Oe4wrS6bkM2ECVsRGJU8+mX1T8iwZixT v0ozYkQIPbD5rGMu2qIaROC51Bt5sN3SrNDYBAjIgyCZNeQo49hcTsnxcejphJfJuFJT biXAvYVlM/fzlwViFbClkTC+Vl5bbHsK7oSyupOPyPl7Kn2iuyCFkTPqXGieP6/1237Z GDBOs7xoJx8ITwuNNL1UNvKzAsqiEHuuH4b26gTB6XZiyZODWD+aKweYgAlYMY3r/RVT GZQJDfLoQga+vKnTnvSJJUWmA6iZS91zchjpAaiGqocxU4lATsfcNCpVZRN0GjYcUpLN gEZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720824461; x=1721429261; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5ngiJf14XEWABtOeJ3ozB6Gsd22dnKoZDQl3XHj467I=; b=NwFTvTjc74OdOk8NOo9V+rWGv2SiNuAuApBtW07cxkwJqJU9xHNzfgZwan7tR22EkG MUEy+5ib0Lbyy+KmeJMwWjXacMhs844AcBiK3Q0SdVzIE86Te26ZIMGakaE9gj59Unvk p5+KarFju6R4u3AsZSNubGW2QCFOnuI3XI9o8NWrs5Uc9smDz0FrMfYm6F37YdvoFJxA 5arIn/Js0nJjD4nh++yZNkiRQPJAIuwAiU2C9kXhhzo3d7jGAKD1OYyXd7jDN/Sh7KV4 OtqNgmIxUKKftNYuh1NOdXAhGJyEfoHHtOFE9TBDVYtWChpWpWPzU4e6kBIy42WlEXPh rhVQ== X-Forwarded-Encrypted: i=1; AJvYcCWJKcFtAbCQtuXH42SROPokXuGQgeV9D7/Y5A63xWTBVeZhfry0kjPdFPElH8uzFxYDZyM69iLZLI7A/TsSep5Li40= X-Gm-Message-State: AOJu0YzefwtgBeFOGYBKRY28rs/qZiZA4GvPebRuNobgkXqYazns5CI/ nGOIZEY2dr8znvVNoEH35qQOSiUSdZvyuh3JcfoRvagunmaPOxCMS0IaTf4pF7MKvzf1id/qBKA uFNgj8gLp+wY3uEWBSqI9La+AnW8= X-Google-Smtp-Source: AGHT+IGTFXf8puoeZ5MyN9OXLWTgTyU6STMwzKLWRJXmrpsdd3JWi3k+aSwvASu4YXbdUjpZiK89WwJzJgF/GnYNF80= X-Received: by 2002:a05:6214:1c86:b0:6b5:dd7d:f899 with SMTP id 6a1803df08f44-6b61bc7e962mr146069556d6.1.1720824461341; Fri, 12 Jul 2024 15:47:41 -0700 (PDT) MIME-Version: 1.0 References: <20240706022523.1104080-1-flintglass@gmail.com> <20240706022523.1104080-6-flintglass@gmail.com> <0afc769e-241a-404e-b2c9-a6a27bdd3c72@linux.dev> In-Reply-To: From: Nhat Pham Date: Fri, 12 Jul 2024 15:47:30 -0700 Message-ID: Subject: Re: [PATCH v2 5/6] mm: zswap: store incompressible page as-is To: Chengming Zhou Cc: Takero Funaki , Johannes Weiner , Yosry Ahmed , Jonathan Corbet , Andrew Morton , Domenico Cerasuolo , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5B43E4000C X-Stat-Signature: 6yza8y5noca5xxos9wrmxyoadasz1t49 X-HE-Tag: 1720824462-146341 X-HE-Meta: U2FsdGVkX1/qYTOut7oHM6fPof1FBqVJXzWk8c0i9WcOFhJW8OfXvnhL++oMJSJece9360NWIeUKho5BjiAAeO56fRM/IMCp3luFz6Ni+xqTprHYX9iHAyH0srpLL7cimRFUA5U3EuFLUSn7pw2GsAbEj7pl/zXn4szOD91BreEHa86QiycdJ33XB1oqgQTwnKchj1rkG8USrA8njwGHBva6VgAnkqjKvb2jkZjD5PxWYE+Mla50KvLw1e3bdOCzC50+rxRRLGXuGe+gNzXdQa8ZhbI5KpFyWxWJgcT97zUNiwFUjQxCpRFwf9PoPkVX2UDQ7v8vl8pBBtko5BTpcwgsre66j5yzVYV/Y037MxjF7KAZ/9QVR0XZt57cfPl3i/I4KgRhsOzh1OdhQuyhVkeC/+73XHnaKKsMLmMKd5WFpRhooTYP32WqwfvEWL8QLYcHy+Qo/7oxVqLKAw/Zlmn79vhHejxYuFmzNi5r+egRy8PsdzaA6fz+oY0CP4ZPf5fEJ3PcguELW8vHNkv54F8OyxWV6cV0KO7ZsYc5CkPm/5OeYqN7xtCX17vgDf2W5SuKe+wj61fUwpexQ4U8jEnqRBRIwvLJLPISFu5q4wdH6xSQ3Uaj1/4/CF0yNGZv6bvI8fxh0ZThCKf/wz8otTllkLOWHFAgsA1dVmDxugy53bwOHrJHboTI5dFtvuWs6HaO/vbpA+WBCTlwVB7ofToZW1QvTG3NXqZk/cxF7rUILbRZH39wwUFh0ybnpujZ8uDvuj95hzw2H88IB+EC5zUQeTFH7tW9gNCvaCsE6h71t1llq0js45aLG5VF3IydlvjMmIhYoxZVcnif0HrpierB5vgF4HWkTsN+wVo9YdbRuwZGLyP2rv712N2LrTWCbqnXPM7b/VKtRuyPSoQNMz+//QvspuX8mGSfuVeUkQNY4OKLa58lVl/EoS6WAPpGhGMy61ScKpP9kycEE9z 1FfzB8OL a/9Q232oR/sTpE3f+hxWxvd9hTiYGUcFLS/vNJBMyRSVl9yRIRj8CdwUbuqdSRpaHbPv+5YOFmo81epIgUjDboUKluGz1qAMPUOfoHpyygjUB2snVpaxJscaoeX8LUnAbNE8lyRnOnevVFpw9z9u8EY6XNuq++qhMkZGUU3rPAu38tWokte5WR/Movqk/Lbu+d6yICEZaOzhYlUCJ34wwIo05s+OvXRCSAfNtNIzjwhi9gm4H9UcxkLRksEeA5fuVXSngcEFtnWjlGsk+8ext81bcq5pCazmXSNgQ+KYFGh1e9hk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000641, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 9, 2024 at 6:26=E2=80=AFAM Chengming Zhou wrote: > > On 2024/7/8 21:44, Takero Funaki wrote: > > 2024=E5=B9=B47=E6=9C=888=E6=97=A5(=E6=9C=88) 12:56 Chengming Zhou : > > > >>> comp_ret =3D crypto_wait_req(crypto_acomp_compress(acomp_ctx->= req), &acomp_ctx->wait); > >>> dlen =3D acomp_ctx->req->dlen; > >>> - if (comp_ret) > >>> + > >>> + /* coa_compress returns -EINVAL for errors including insufficie= nt dlen */ > >>> + if (comp_ret && comp_ret !=3D -EINVAL) > >>> goto unlock; > >> > >> Seems we don't need to care about? "comp_ret" is useless anymore. > >> > >> Just: > >> > >> if (comp_ret || dlen > PAGE_SIZE - 64) > >> dlen =3D PAGE_SIZE; > >> > >> And remove the checkings of comp_ret at the end. > >> > > > >> > >> We actually don't need to hold mutex if we are just copying folio. > >> > >> Thanks. > >> > > > > Thanks for reviewing. > > > > For comp_ret, can we consolidate all possible error codes as > > incompressible data? > > Maybe we still want these debug counters? I'm not sure. I'm a bit torn, but ATM I have no strong opinions on these two error codes. If you do decide to consolidate these two, may I ask you to separate it into its own patch so that we can review + discuss it separately?