From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9A85C4167B for ; Thu, 9 Nov 2023 00:28:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A53C6B007E; Wed, 8 Nov 2023 19:28:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 354AF6B0089; Wed, 8 Nov 2023 19:28:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F4AC6B0093; Wed, 8 Nov 2023 19:28:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0DB346B007E for ; Wed, 8 Nov 2023 19:28:15 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CECC3140CAD for ; Thu, 9 Nov 2023 00:28:14 +0000 (UTC) X-FDA: 81436528908.18.AF9950B Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by imf05.hostedemail.com (Postfix) with ESMTP id 234A810000C for ; Thu, 9 Nov 2023 00:28:13 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=R+MlsgK0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.53 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699489693; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1lYLDbRd2D1qfONnTpMi6lcuDQ3NJHG1hPpWbdhsIpk=; b=PtwZzExgXU/h6ubpdcXZYMmsezN77AXQZ275wrIOPr1g0qkShnDZo3DtSDAw1zejF1DmGd EBSofpoZ6asbTcNl92rR8t3OdS6zAPXW5BILt70AXxpN8dgbPu7wt++TgZcUC8j4m4140w Su+GT5t14TCDZZyu87dzvEcwROOsdSQ= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=R+MlsgK0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.53 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699489693; a=rsa-sha256; cv=none; b=PPYJQ8+W06kw1KWHEA/KvAytjjTFH5PMYsaWUKYEGEcV/GiFwtd8s2vVFCp3LoaLeTIKKA bdQP6GkW44DPxUVsK9Vi9SSayrnjbOKkLK3kqJwe+wDamJPaRdmYl/r7AdPt2RsOMP6dIF nq9jmPqDRKAXgC6Y6Vy0k7WVgYoDAVY= Received: by mail-io1-f53.google.com with SMTP id ca18e2360f4ac-7ad501cb1f9so11146739f.0 for ; Wed, 08 Nov 2023 16:28:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699489692; x=1700094492; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1lYLDbRd2D1qfONnTpMi6lcuDQ3NJHG1hPpWbdhsIpk=; b=R+MlsgK0IpzY6PhVjA6gXH6JmWJq7nPj6JVPylM8lxm5yDqMnZl58AAvd78fDH+330 xo5con1iXBtFa1vjDToMr91T5KRiJuox/Mg0IdG8zYdgfklMaG9qQzDNqxQeOliNQivJ cyLxJE7CEei7jMdGWqMXOXwR7BuHzhgAL5WFPnRl/mX3sMSsbnNykt6e49bwC7fOwYlx 1PmraUnKmfNQcSzud1Y+hibgRao1T37a8A7OVgdV2A3KTImaknq6r4qXeFj37iiaA9AF ik5Q+y6E8zaTQC46slp9c+wHnom0EjNNUqhfaBORLxMRcDU/y+hmFq7naXjHOmqSHeVs m2QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699489692; x=1700094492; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1lYLDbRd2D1qfONnTpMi6lcuDQ3NJHG1hPpWbdhsIpk=; b=nnRlGd/oTQLq/EcJulbyGlhq3kU8H1Qcemx6CF9WpB4pNdlfBbc7byUQOxbgJlDYqa kEUWcqTikfHQfNeJZwrZFD+g2m1wM/HXwGb0fbJGXPHuL3rsc59OAUGbcimG0GOvwGsk bmN2E6CimrAsLgP6YsdpOFKJU8Z8s41mRp6yYiujPfiyg+8b4fsIDG0CQzxwj3iBn7vA CQ+QAxPFpmkEae/nwDuC8UH4xV+gDXU9yz5XD3BJ1RX5Abt0B4/V6HoPq7osfhTR4FyU /tk2VlZpHD38yIich8buMAeQ1kmC33XHZzmZAhZSYVzAEF3caoR+JyLGdQ3RDmRr8ry6 mv2Q== X-Gm-Message-State: AOJu0Yw0HV3QZCAfy6S6Em8F1RnMPueaQcAyMc7ZQFta5x2CCRNlOIGf o+UFm+VmZESiu6W+aHGiVURwlzCMQ66cbc+XR78= X-Google-Smtp-Source: AGHT+IHkMvqxlBqvnjgkl6EzwG4igTKbhMs/Lw+LnDTYIcihAvDofeJz++IVExJAeWN+iW/MV/pGOOhM8CeXk06wwi4= X-Received: by 2002:a5e:8c16:0:b0:794:eaef:f43e with SMTP id n22-20020a5e8c16000000b00794eaeff43emr188592ioj.1.1699489692185; Wed, 08 Nov 2023 16:28:12 -0800 (PST) MIME-Version: 1.0 References: <20231106183159.3562879-1-nphamcs@gmail.com> In-Reply-To: From: Nhat Pham Date: Wed, 8 Nov 2023 16:28:00 -0800 Message-ID: Subject: Re: [PATCH v5 0/6] workload-specific and memory pressure-driven zswap writeback To: Chris Li Cc: Andrew Morton , Johannes Weiner , Domenico Cerasuolo , Yosry Ahmed , Seth Jennings , Dan Streetman , Vitaly Wool , mhocko@kernel.org, roman.gushchin@linux.dev, Shakeel Butt , muchun.song@linux.dev, linux-mm , kernel-team@meta.com, LKML , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 234A810000C X-Stat-Signature: 3khwn9jfmc66agwr97euyqfqtpcaoz8i X-HE-Tag: 1699489692-817495 X-HE-Meta: U2FsdGVkX1/fO6Ghnlsh7loSGvYsh430w0CjLFED7v9p60HGzjODp+g80fOQYKPPvAnsCBxNMVMsziDNL4BKweog3ojezLTgKkZyNT/5+ZN8QFIAfIkCTlrGOEZocb/P8uV4wVplNuy8YPdzuAnGIazEdicrafO0b5OCx2I1pInjDa5Bi8NM7dQycx4d3jkB5k70EZueTwI3zfl+kqB0zIkxEuD4VjE3ltJ0n+y/nOGyy2LEUITgaBNUf66cHy7OKqXFu7OpO0csAi3UfijCc8rGWe1DtYevgoojSUri9bFXEjUq34wFRGwelyD5VGUFZsE6GCZx26hNnYy6z7HnzMRsLRjQRE1BrQOzbeSRxLzUZ8YXAAesURE4yrJJobSplSeF5v5Gy2JyzajzvoIM6SYGLU3uoZQQIzAavc6TVy8BWyWe710W2xBdkHwx62vn2WnlLT4bZUfanPCfbY3vMiwRQgLDuFeJIm5ewWESyZCt4op7hDTAcfVEob3ZM+VOTfCTGKkCrOYbr85ECvS94OVMJO0aRXDgn3UA5U0AmoeBz2N8Ib5TQjcauSXgAck59o3RCqQADbbYjY2RtbAY6+rjEPJaIcQMDZFWOm3UVWJUCcityRYCb1dFvk6tvEFmh8+BSbTHIKN/4s+crF7xBmotAJvWPDCZOp50eueyOJyODRBR2N3ETgPd4Ab5yZrv7/3eU3DRvWQqLT7FAXJHB/ynkER7sN4YXVj+W/H7LnspB2Kk9Q+miwSm0MNzB2/oKKajOjGVyfgdMvtWYAgsebJ42WhxnENKmHYy79qA1mIaoittaXl8iq2qSIuz+HOgwczuPLueJ2iyeTP6CSs9wuoGP/v6K+oNq8FOzNKYiN9tbWY8ytS2X0ovCnkgziF88Boa6BdENzyb5MV9AtJR6miofPEu8lV1ZGin1kssKwCuEqSQIEfWGV+xVjsVSj0XkiqAd/MVnKbKi71fhSO l5iZH87D K8FOxcIrSgS8z7b7v1NxHfQfkKnvEukOwUCs3LejQ8LcamSuISSFbB3ZjCIdVc1wwQkiIGweGzDFH4SRlbzo4ux5uZis5GouFHO+tuliCwEirbsInExs4Zh80KG7I5UrgYKBrGm2kfW024gYmCI/+2UwZll8Rhr8yjCnPYn8u271XCbD5YElgjNzaLm3r7H9rg2P/I1gczuemFil9IliBJSNFyPfQPV9kFm2GW5fK2TOr8A9Y+OQL3Koc3LPO4OlWaTM9a7/w1V2fmmxfuuk5oaufSDnanQyAMZzMCrIETJe6oSRAqHTLGtDQuT+pvspfi0mKdZnjVhjrGG8JFMWNa07aQIaGqMPykwvtFZJNobWD85xof9ejHO9ywodafzX/XmIVgB7xPq7B60McVfNBqh4fUt3UpS7eeQUUmBxst0XpqRl0gHCo0qHnF54IqLICqFx32UQ34Y7pqreim3b7A9r4KWUs15KWAhHc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000119, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 8, 2023 at 3:12=E2=80=AFPM Chris Li wrote: > > Hi Nhat, > > On Wed, Nov 8, 2023 at 1:15=E2=80=AFPM Nhat Pham wrot= e: > > > > Ah that was meant to be a fixlet - so that on top of the original > > "zswap: make shrinking memcg-aware" patch. The intention was > > to eventually squash it... > > > > But this is getting a bit annoyingly confusing, I admit. I just rebased= to > > mm-unstable + squashed it all again, then sent one single replacement > > patch: > > > > [PATCH v5 3/6 REPLACE] zswap: make shrinking memcg-aware > > Thank you for the quick response. > > Yes, I am able to download your replacement version of patch 3. > Just FYI, I am using "git mailsplit" to split up the mbox into 6 > separate patch files. > On mm-unstable, I am able to apply your replacement patch 3 cleanly. > I also need some help on the patch 0005, it does not apply cleanly either= . > > $ git mailsplit -ozswap-pool-lru > v5_20231106_nphamcs_workload_specific_and_memory_pressure_driven_zswap_wr= iteback.mbx > $ git am patches/zswap-pool-lru/0001 > Applying: list_lru: allows explicit memcg and NUMA node selection > $ git am patches/zswap-pool-lru/0002 > Applying: memcontrol: allows mem_cgroup_iter() to check for onlineness > $ git am patches/zswap-pool-lru/3.replace > Applying: zswap: make shrinking memcg-aware > $ git am patches/zswap-pool-lru/0004 > Applying: mm: memcg: add per-memcg zswap writeback stat > $ git am patches/zswap-pool-lru/0005 > Applying: selftests: cgroup: update per-memcg zswap writeback selftest > error: patch failed: tools/testing/selftests/cgroup/test_zswap.c:50 > error: tools/testing/selftests/cgroup/test_zswap.c: patch does not apply > Patch failed at 0001 selftests: cgroup: update per-memcg zswap > writeback selftest > hint: Use 'git am --show-current-patch=3Ddiff' to see the failed patch > When you have resolved this problem, run "git am --continue". > If you prefer to skip this patch, run "git am --skip" instead. > To restore the original branch and stop patching, run "git am --abort". > > > > > Let me know if this still fails to apply. If not, I'll send the whole t= hing > > again as v6! My sincerest apologies for the troubles and confusion :( > > No problem at all. Thanks for your help on patch 3. > > Chris Hmm my guess is that I probably sent this out based on an outdated mm-unstable. There has since been a new zswap selftest merged to mm-unstable (written by no other than myself - oh the irony), so maybe it does not apply cleanly anymore with git am. I was, however, able to apply the patch with the -3 argument, i.e: git am -3 ../mbox/0005 This will fall back to the 3-way merge if direct application fails. And, FWIW, the kselftest still seems to build. I think you'll have to do the same with the 6th patch as well. My guess is that on my latest rebase attempt, this was done silent and automatically, so I did not notice this. Let me know if this works. Worst case scenario, I can still rebase 'n resend the patch series :)