From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EB2BC36010 for ; Tue, 1 Apr 2025 01:13:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A401280002; Mon, 31 Mar 2025 21:13:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 453C0280001; Mon, 31 Mar 2025 21:13:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31AA6280002; Mon, 31 Mar 2025 21:13:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0A161280001 for ; Mon, 31 Mar 2025 21:13:54 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 56C8BC0ABD for ; Tue, 1 Apr 2025 01:13:55 +0000 (UTC) X-FDA: 83283703230.16.D72240E Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by imf18.hostedemail.com (Postfix) with ESMTP id 843931C000E for ; Tue, 1 Apr 2025 01:13:53 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jKgLb4uB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.160.173 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743470033; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9V6gALXQNYdhz5TmaBOH6ma6nrpJil+JKlbs8/kqK/s=; b=ttn1EM25QHiwQAfE/mnIqsRFhG/n3Nl6ONpThQ96COFCcAMqIsVFzZ0NBsquEU8fi8ew7s zG6wctP8keZLdUCjpvslSQtUNkAqnQvaiNiMdHPXAp2AqBrEjFlK1BJafY3uODTTHK55lC 18A8NIrnvwjRxak8M84QyX5UpyOS0zw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743470033; a=rsa-sha256; cv=none; b=gALs8nOROvqRmE3/ibb/rsJxv90mmk1AvxzXwkqvtEATYublAoR2lQ/W+H42o63Kujc1qu jmxMre7/6iehemauFYBhyd+QbE5jPJDV1YSKaAAtuNGAVg0qtoDfIfYikAbinrPX2PwCjd wyQ2Qmpz+fFNhXDixdJ9Le1PsI/7QI0= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jKgLb4uB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.160.173 as permitted sender) smtp.mailfrom=nphamcs@gmail.com Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-477296dce8dso50229671cf.3 for ; Mon, 31 Mar 2025 18:13:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743470032; x=1744074832; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9V6gALXQNYdhz5TmaBOH6ma6nrpJil+JKlbs8/kqK/s=; b=jKgLb4uBlfqWOtSleV1UYISd+crxyD3kH/4INiPDsmeIhG7BksI1ZYkQ+xcTO6gTI1 0m9N5Bp4cetNpKeBMCtUdwPik3AQ0ijR/FGoLkC8NNWopEiXS4gdHrdTZ20RwY9xT8As RSVYpg5Xz9MyX291gmrM7J6n3S47j9P0Io5zdPR59ES3QyJWuYYL1Ho4SYkLrTMGfB49 7SuQY8jLC9XwzX++cCFRzB0XVi0INHNRLx2n1WrdMlK06QeZIUfn6X7l6dKD6fhl1Thi JeRaxcSLTtUjllH4CQ4KM0YFi6o4sSnAizuRR9f5Cj1O6EiV8tTDqXlj+As6evyGPh8l 3/zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743470032; x=1744074832; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9V6gALXQNYdhz5TmaBOH6ma6nrpJil+JKlbs8/kqK/s=; b=ePzC90ubNXpM6R0izUcW595pk5vNeNUNPLWhWyXqq69+ZhPkI0RFvN+fSS6YfGgesK RV4IxpLB3STx3opVzRrNDh7S06UZjDiHiiAd/JYgrVco0Sn5azsXBp5s/W3kqDvROcIR pkvoPp6UBDmAozNBDxGrgZFKuwFmheMd8N7+38Wycx+xmztIelAG0D/lfBHED5pd++AB RWDvgf0hqTGsOxZOF51BKKbbFRBz2TKR6CLmqMic4isz6d9EwPU1bnH7aDOE9kUVjODF axcFg5p1U9Tn5j4efqqHdQo5TArjBMBSs6GOGdVwOAoA7SB9dzXHvCLA0NSbWKwy+aW0 to2w== X-Gm-Message-State: AOJu0Yw++Q73NIvbBMdcPq6mSqrcFKLW6ZXanDMNpa7VfJmRoZMJ0dcY FejpbT4KajAH3UHNWxv9caa20SWSCY5RoUsykqw0F9DmUist8MnXPwQmgY3cKhGAPGjT5F0TGm0 x92j12JXbTpqXnrMcxO9rP/hltyE= X-Gm-Gg: ASbGncs5fMHvqKtGFC3k8cIpnom+vIAAynzzADcZigw32S1wjN9Qxlnv+63gt7L5cdh VV3zuoFenfG/0GhFAY5zX3rfbAB8foWIORVa5hlDojmh23EwCwo4xBIH7yx/yfmixOu2drSXab/ HEFlOFRIkz3pJGttIoqG5xaAPSiQ== X-Google-Smtp-Source: AGHT+IGczQt7n85+GajfuJEx43dpr5UsqwDzByhTbFO0RDOS1lkyVzr0+4hyaEsExSpG06CA7ZTG4IFeeibLL8dcmeA= X-Received: by 2002:a05:6214:5185:b0:6e4:269f:60fd with SMTP id 6a1803df08f44-6eef5e45d14mr20185076d6.23.1743470032357; Mon, 31 Mar 2025 18:13:52 -0700 (PDT) MIME-Version: 1.0 References: <20250329110230.2459730-1-nphamcs@gmail.com> <20250329110230.2459730-2-nphamcs@gmail.com> <67eb148e1f818_7baf294b9@dwillia2-mobl3.amr.corp.intel.com.notmuch> <67eb23cbcd0b7_11987294fd@dwillia2-xfh.jf.intel.com.notmuch> In-Reply-To: <67eb23cbcd0b7_11987294fd@dwillia2-xfh.jf.intel.com.notmuch> From: Nhat Pham Date: Mon, 31 Mar 2025 18:13:41 -0700 X-Gm-Features: AQ5f1JrJGOvy-PDvwAtqA3caAgZR_fWoNj40h_LFmhLE_INmWOy5f2BIOtp8Vgw Message-ID: Subject: Re: [RFC PATCH 1/2] zsmalloc: let callers select NUMA node to store the compressed objects To: Dan Williams Cc: linux-mm@kvack.org, akpm@linux-foundation.org, hannes@cmpxchg.org, yosry.ahmed@linux.dev, chengming.zhou@linux.dev, sj@kernel.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, gourry@gourry.net, willy@infradead.org, ying.huang@linux.alibaba.com, jonathan.cameron@huawei.com, linux-cxl@vger.kernel.org, minchan@kernel.org, senozhatsky@chromium.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 843931C000E X-Stat-Signature: icfaae1bc8c8pao56uwu9sef75rx6e1p X-Rspam-User: X-HE-Tag: 1743470033-417289 X-HE-Meta: U2FsdGVkX1+ruT1K4AJvfWr1ezNg8s2wce55isWN4VAf8QyjSABA5IeyC/nKgqhPepIpUFbfu6vIenZtdTGG2yBzdfOQ45/coUGS0Omn1GgNlWeq/pFEOtCOfuBfpSOpdGC/GkFcIV28sBC6SMHvKkHz8EHgXbPD9DHJtX5zwHjplVh88udZJ5VSkKAMRZisbrq8XvDcDrDA0w04gkHiDaOR/08KSb1ygcs/xO4S15MCaIyPGy780hcNf2+rtdbUQAB8h+ebYzZTjTlwJ4BULiwvQX6iykXiC/LhfLXMwLGm7eOMnebxQARGqE/1FqPDIY8AFW96C4f5YYUMGetxs6+Xm1eaC+pSlz9vaOElRgJ9ZEyzo/udDVVguoILXAkBW2HXl5H7Iiif/u42qU3wYYgpx+/tll88R40fHalQin4816LaDvlbe7/9DHizi27459PXsbUgRzWfIF75VVSWzuBVqi9FZLGqFmmj+zZS3kgDq8Fy5vOmrkPQA2WtVPpdWqDEX58g+m1yTjEUctKg+5NoavYE27b9mD+GyeV4axXkgSwR/EfjlQxjdbkTXRPVvoqt0mA0sZ4S5lymhdd6O6BobyQlXgxq4I9YntljOcYqXSrfEWl41/cP7fEbl306du6myD4464qxPNRigrEahum8etknk8BEVCaztWCOAT1S5GoRO1TUEp/MaGvPzVWrGxIx+0qAFeMygP7ykgetIwzRUnXgws21CwM171ZuQFHYoXgzWcgdzTbTRpirUhjSB1JMZrb0OjnGSA9DyOg0pHrhqzCfmbg9gqWkLwep5ux3/mbzhT580JVRrpeCPG/45+EZHgaSw/yiTiqD4S9c9lPOR3t29WxLfjr/51z/RLfB2G+x/MS2IV9Xy4hW4df3U2RriWCdTdf/ZTKK7A+VRyP+yihNy8Sy61pDM6EKAuuhdaEptLZ7yvAWNt35w5a/Pc7sf9c8j6Ol4cRDlii ky50n7VD 38IL8hNK6Y/KiLVTQUSX+ND7D7NK02Mzry6i2/jfGVRuUvU5NarXXw6Eylv2g5IgTW4gBC8iESmjFEbnxlueboXYx0SdVHlZ5Q5o9kT4huM7YNzlNCuZQCxazH33Oce9ev1qU3lYLqYX6aFm5ccIzHxB5W3mG0yRcVDWsRR3+i0XqkLSLxTufBzr/kfy45wYdoYYXGxavSTE5nAqdmRNWvlwyuTCv9oQyx5RZAJJqV7TMAaCrEb4JEVgYwjpw7CSDiaFqq0PS0rkVL5P+/lgU1hhhv1pKZDlafccFw5DqNUgOopfsu5mkKgG/LWDWfzHeu1zuzGCscIMlUgUBXquaQLUMmA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.008351, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 31, 2025 at 4:23=E2=80=AFPM Dan Williams wrote: > > Nhat Pham wrote: > [..] > > That still leaves zram though. zram is more complicated than zswap - > > it has multiple allocation paths, so I don't want to touch it quite > > yet (and preferably a zram maintainer/developer should do it). :) Or > > if zram maintainers are happy with NUMA_NO_NODE, then we can > > completely get rid of the pointer arguments etc. > > At a minimum make the argument a "const int *" so it does not look like > the value can be changed by the leaf functions. That's a good idea! I'll incorporate it into the next version. > > ...but I would challenge zram folks to ack/nak that change rather than > maintain old behavior based purely on momentum. I.e. add to the commit > message an "exclude zswap from this policy for $explicit_reason" > statement rather than the current $implicit_guess that the old behavior > is there for "reasons". Yeah I'll take a look at the zram code. There's no conceptual reason why zram can not or should not adopt the same behavior, from my POV - it's just a bit more complicated than zswap, and as such would require more hacking. So I'm leaning towards making the minimal change required to support zswap first, and letting the zram maintainers/developers work it out on the zram side :) We'll see!