From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 898B8C4167B for ; Wed, 6 Dec 2023 19:47:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1018A6B007D; Wed, 6 Dec 2023 14:47:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B1E86B007E; Wed, 6 Dec 2023 14:47:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBAFF6B0080; Wed, 6 Dec 2023 14:47:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DD53D6B007D for ; Wed, 6 Dec 2023 14:47:47 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B2658160276 for ; Wed, 6 Dec 2023 19:47:47 +0000 (UTC) X-FDA: 81537428574.10.11EB6F0 Received: from mail-ua1-f51.google.com (mail-ua1-f51.google.com [209.85.222.51]) by imf19.hostedemail.com (Postfix) with ESMTP id F2EC21A001B for ; Wed, 6 Dec 2023 19:47:45 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CxViQ0Q4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.222.51 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701892066; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V3Uq7Eb3LQAhmgOwGxl2uUmTACv20Da6IjMtrl5hh2k=; b=hdYuEyonodXkaDOipEhNchgfekQHs7KNNhc8CgZ5BKNfk9cDNKDtJtfe3mAW7vNBd+sLwo y1+HYS1hfnPbEQZzZtQ49LhfjBLsM1wVT9HFo3k4PjAQPQTarexVUnoHA20KAi75BDQork Mf7lLOKlURx/JsqFF0iTujBp9/bdEes= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CxViQ0Q4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.222.51 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701892066; a=rsa-sha256; cv=none; b=s9pGkveg80hXfP9HAHEChE5jPbV3L1cGapzH/kltXC0Je8fuPISefQOGv2kElq3UG3Xo+R CDG5BVqqeXjrvUvZnZzDDM2R2jBKOrrxHCr6ZAasWsgGLEkSMy2ykbzhhu/Qvo9wC4Mp4p /0JHyYLhGm40BJYi+El561jlBelbBhk= Received: by mail-ua1-f51.google.com with SMTP id a1e0cc1a2514c-7c44f5f3ca2so44132241.0 for ; Wed, 06 Dec 2023 11:47:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701892065; x=1702496865; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=V3Uq7Eb3LQAhmgOwGxl2uUmTACv20Da6IjMtrl5hh2k=; b=CxViQ0Q4icY1Z018rmfjZ7d4NXif+CTuz78SfY++f4KsfZji88l5n5iuwYKJwrGSzb zeSZRTF/WjAtRPQqhvJNi1IuZYgk4CSPnkQj2WJ3kDuOeO99DsqnDtdN5dEBEFILsb9b rpQCLEtjlV7D8ViWfEIwPcAteNtsGSJP5oEw9ElPWTHOZxupOzXHmS+QXPAd3EE6be6u lt9Y9ecROkJPvcMErZl63FxYf3/P6+fdVRUvWWONc5NKRWY20xTxeQwVUy0dBd95MrFu aXB32C02e57JGyxwwlP5Y18dPBOm6kpRa6DJcnPMbSXetvPi8XoOaQ2LnAiStht9ffbp 4clw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701892065; x=1702496865; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=V3Uq7Eb3LQAhmgOwGxl2uUmTACv20Da6IjMtrl5hh2k=; b=HpDGrxPh+1lEdomnmEcsCt5HEY5n3RAaINF49eS/Lg3eUI2RPC3MYsBA8393Prvty8 uR2K4o+vx5N3ANFda0xyRQr7fPOyFx3szB6ev1wYSgbIKSYguDZzx3p2J1P8Uzn2+8ai Jgx9n2OZDvTG2+45w0HXAubpzY0Y0vFNCUykT4vAwklaTacy2aP9KBTPYi/4fSvVz6Ra lVRoMEBURoubRI96poeNi1601UfrrTzDORK5xcmmJIvskasN0UR8me/Fh9kDk3En3HLi xnkqpCBVQAVNSJZvNRxEC8Jr0nT0q9frlRoThKr6LZMa9ZY2ELFF6/Na0EYt6D8jUntX uWag== X-Gm-Message-State: AOJu0YxXCibNeBM0noCRPjGTvmMmteIbwTvs2QVS6zfzqSowbGZIvzxI fffMCapD/kd7C6HPQ8H5wURwT1wTqpqD/RjMt2w= X-Google-Smtp-Source: AGHT+IHYl1yzcNVSMG13aCy+iy0WYAPTgpbzn6h590/aczcT1C5kVNrn6NnMKuR9NVMHNIVY9l96rBQikhUQLjE3ruQ= X-Received: by 2002:a05:6102:5106:b0:464:8ba6:2a62 with SMTP id bm6-20020a056102510600b004648ba62a62mr1631158vsb.28.1701892064936; Wed, 06 Dec 2023 11:47:44 -0800 (PST) MIME-Version: 1.0 References: <20231130194023.4102148-1-nphamcs@gmail.com> <20231130194023.4102148-7-nphamcs@gmail.com> In-Reply-To: From: Nhat Pham Date: Wed, 6 Dec 2023 11:47:33 -0800 Message-ID: Subject: Re: [PATCH v8 6/6] zswap: shrinks zswap pool based on memory pressure To: Yosry Ahmed Cc: Chengming Zhou , akpm@linux-foundation.org, hannes@cmpxchg.org, cerasuolodomenico@gmail.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, chrisl@kernel.org, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: F2EC21A001B X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: sabu9d76p36k4oswsyiq8ugp3c7ogch8 X-HE-Tag: 1701892065-918391 X-HE-Meta: U2FsdGVkX1+9DPdK53zUczw4dOBrx2SN0Xei67xDck2AqerD4MCxruarvFaBVW0W4QB39fOScPTtLtlUlFQQnPsJZYivUKqXBGnaFnT3vq5m2Qw13PCGOkGnIybWjBVwOjOxQzwy97RjMxcEO9k3+3pX4ZIWimOj4gLdbRyce7n/7ABGLQesjBRlqtGxYs72Y6u7VgpxSMIVXcLEP08d3Qw2CUO28v6KCa6FM/xIjx8enrlT7TQcURiI5FPAEWjVZqQtPuhdqEJX6zN/2q51m7aeiOqU03m/WDup2niWegoFGxsEfGe9/6bx5XGT1LX/waF3IXrobApe6q/1fy4/dQ1d04ufeDdcVKCNJSU1oHK9zwuYdeoq1mnNsBgB84X61ENJaQJ4jSgTYDKu6PsI+L/2dOHxuDgnOv3FxyFDnlMJZ0nsjgHnr51a67Tz9MtpJYcBa/bRBB0ijgO8G0Wmk2SMY0cWeifzyV33Isu0bZn4aldKczgMLcsSWiUb75aJ8kf/OooJypvBZuHhOZ67HgfPYL7LxPKZpBcE9d83oL70gHwKPa2J3NIMLOWcIC3VXIUQlkAFQwyI0ujyCdF94iPUR20ML8ieeLM2HbiqhawE366ZWdJqvxbf6fA/HNyaOi6l/Rgqxb2PX5LjU/mSAw1eA+tKR9YlSGPzZ3Fe2uBzmNpVQq+TrTpLoPghLrUXqRVUp1UpJoxizaYt3Z6rAkHrHJBi4f30BfnVpvX5bBGmeQlekPxu/wB3NRgMnydZgkd+YfMV0HEwjfHdSKrFAtXRMXgjTBbtNiAqK5CFSfj29ydQuKOBrvxWVEEFp+h/DMTMnX/aR0GXsen8A3W0/QscSZbqV0wIdgpG/1fQeYeXrSjNPA5g2SEWQI59vTyUJb2coEmv3lcHjlWpFF/sZUfU1uWfd8BaprmYo9lhCgs6qjm9nRuNWyA71kBcppYuSHLqlNZKS68ZbGB+dSn 3+x/h0Wz s6odR0s4JieQMzPeV5m66abj/Qy72F3P3CqCyQvw41IJb7EZZeVpo9kpUd1M3uTF4VJDsKUxucRKkarP6iAyORiv7/g/KqIwDJiK9RS50DqEKDK+701QblKWXYy3RF+rVJKsraWouDc0fQbNNV/zVtopPLQ97R2mbnq4GBVVYMQofJuFdVSr9iIAm2KU1KVa5bfQJWv3s1LQDS5SiInr1Cs82LT3VebfcN/CnjOFai+gHxbcqp7OGCk0oIT3bZcFsJxMy7+VVDwKGZsZXA1/oPhr5l+zwZ5NwU9DAkjEbABNbZ2vucx8Yu6sGPOV0m5FDwhXwlnGTTJXExJDXQAZhx6cHn/YN6jnqIxHo X-Bogosity: Ham, tests=bogofilter, spamicity=0.001498, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: [...] > > Hmm so how should we proceed from here? How about this: > > a) I can send a fixlet to move the enablement check above the stats > flushing + use mem_cgroup_flush_stats > b) Then maybe, you can send a fixlet to update this new callsite? > > Does that sound reasonable? I just sent out the fixlet. Yosry and Chengming, let me know if that looks good. Thank you both for detecting this issue and proposing the fix!