From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A022C4332F for ; Mon, 12 Dec 2022 16:51:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 796FC8E0005; Mon, 12 Dec 2022 11:51:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 746DF8E0002; Mon, 12 Dec 2022 11:51:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60E178E0005; Mon, 12 Dec 2022 11:51:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 523438E0002 for ; Mon, 12 Dec 2022 11:51:10 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2C5814051C for ; Mon, 12 Dec 2022 16:51:10 +0000 (UTC) X-FDA: 80234244300.27.99CEB33 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by imf07.hostedemail.com (Postfix) with ESMTP id 8FFB14001C for ; Mon, 12 Dec 2022 16:51:08 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Nm57cZd0; spf=pass (imf07.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670863868; a=rsa-sha256; cv=none; b=omfHP1JpxtWMvb0a038CpGIGPtoid8jruyOPDIVQ6FnoIHsGAjQR3rmi+sy6paLVMD0ijM Biudgy/sOidnIcigMnl5YSbfigaKnJ/kRNyCL83ympZdtVo3fTld+vRwXRQ5n2XWUQ4x4c 97yFY692xgrfwD6Vf2BXe6I3y6QzJaA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Nm57cZd0; spf=pass (imf07.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670863868; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zdKYitirjFUvJOqH75WY9wqcicdY0ZKchesIKslPTDk=; b=cezVkmCsG7gfKIM2VA4vIECDOt/jx0taxMmWyNX6Btf9cvKM61QYB5FB11r0DV0ArhxNh4 mY+J9kLqQI4QfGb3uIKkr+PENYJdyWrTtSPJmuxWzLAOc84kiNIrkkjph58lfpdtQ/tSro /uNvjp2Da6GoamXVNDqLGnpwwnphgmY= Received: by mail-wr1-f44.google.com with SMTP id h7so12733031wrs.6 for ; Mon, 12 Dec 2022 08:51:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=zdKYitirjFUvJOqH75WY9wqcicdY0ZKchesIKslPTDk=; b=Nm57cZd02W0zL2/5xwuBi9IHyI8TrElP/I6CSCoax110itKNY5B71nnPey5vGNTI5E D2WdKEFM4MXdvvoW72zhyrH4oGnRjPEVP029fpVn1R2bq8dCKubrCJyrRMNF7ahTXN7D VYYXk7b9s3WSrbyYR3hoqmyiBZbMNPi4k7YxxU2YQyC6wVkgMR2KUDbwWNrPWATQFqWl H24NgXTNsqnVIgXipJqBnFCGgxTy0FMP+Je2mJuJzh3HiftFMYb5tg4jPCekwnfF42rG SiLvMEyWoum5oY6jIUdXdGOalPXT97WuEoqpn/JLfKg4RY4sVTl3A5JfoKvaPoJRrfqX Mbzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zdKYitirjFUvJOqH75WY9wqcicdY0ZKchesIKslPTDk=; b=KMU9NhiQbXGPzr6fXd09P2IPayyKOwU600qPM84ScMmHm4C4/risWJ/z7yQ35QJaWc yAJ9S+o2uJEdkdY3yMB3iIKTcmR440cEl8B1xmdNxMT13l3gzCzRJ82N5uc22BkjSyGg 6M9+qW9lfBWaKyjE26MpgmjZkGFz0lwY3kd37YlE5EnEQdxDjDsqya9Hmd0rn0c8PaOJ eFxfHs4ycdF1baRdZQ1bBpT2yL82DJreDIUkpDEQ+hLxvAzO5R0yfJYKuVwWltLuRJoZ 2q9elg/6JKfSJsNYS4tmoDVWOJFg2ex4JmxNtLHLLGlafM1SkyW0AOrsrmzQPbJK+x7G VAqg== X-Gm-Message-State: ANoB5plAPR73uq9vCuuHCmzWW/3cAEOg18H+DtuSlorfGDFrSvZaQ7+W px9P7ZwwldDgoaWiDDzlDUdeElNTjO1Gl5I8Mrc= X-Google-Smtp-Source: AA0mqf6QxYRdXfCb9/N8S90fQaOuz1jlxeRxtTpJnifImRcjKiCXNKSKfd+xl0nmTotR3FofPs3Z6Yhkij0qrAOLnDw= X-Received: by 2002:adf:df81:0:b0:242:6553:668e with SMTP id z1-20020adfdf81000000b002426553668emr10674273wrl.131.1670863867123; Mon, 12 Dec 2022 08:51:07 -0800 (PST) MIME-Version: 1.0 References: <20221205175140.1543229-1-nphamcs@gmail.com> <20221205175140.1543229-4-nphamcs@gmail.com> In-Reply-To: From: Nhat Pham Date: Mon, 12 Dec 2022 08:50:55 -0800 Message-ID: Subject: Re: [PATCH v2 3/4] cachestat: implement cachestat syscall To: Brian Foster Cc: Al Viro , akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, willy@infradead.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 8FFB14001C X-Rspamd-Server: rspam01 X-Stat-Signature: sfofpkzdn6th3nz8h4euui1ktqnh8bdo X-HE-Tag: 1670863868-193374 X-HE-Meta: U2FsdGVkX18rbO9Rkb5RfDiIeXE7krEt4PDyx9Y2nZYyaEJpu573zgnpl5PMAqv3ABIU9iE5WxEMeWT67BZycgrndOr5X8EFIWXFkjUaMBx7yk1TafnK4RP2EPoSjht2uhVmR5exfUvdWMKCEJPhCpj8j8DUB0Sl42chY8jUjJX+p6vLHJnvZvApEr+gqKfsxaqnYmjjx0PjL7BElvbFDHa5Bj9uvdTxTdMk/jFKx01LTryu5yuci5nECYsJFzYpxNT22Lv8OapBdJYM3s1kEPOzReJEVo+fYJvKWxnP6QRBo8i5CZreFjXqXVcc8B2gzCm7jKVgXKGdqTDTriLUcQQv7y9G52HHVxGirW32DgzK/LpgPtj1A+EarA26VZoVXl8qxkxlqliBsswGxYDlvYJkDbuEuYo/M+ffQCGSKfq+rkoZIgjBOUn3VK7dPU8s6nCIghfnJBu9ugGQ5FNkmT5TaN5hk6HhK2pEXZu/a6oh7TL7RuwOwEoSmsN4S2avDDq7WdcXVx7Wt1VherE97ZWPtG/4UJihHtlKJv52zo/KKpJTSRqZROgNzhvwAiVZRb8K00+XoWWJqf80FkLI6qTPujMoZ1iskJNsQTJwMb0qaQj88x41MpGWIH0p3tI++oet+fCKEI9JL+35IMzS5hkOuIR2Kz/Gar+9qu/NbbMJnL00jBLW2FQohe172rL3eC8evUIQHN4BfNw7Vpfx1zBHAlZWNHtGmB6jfu7Q/h/qlQ/SwMe3lqe/cQRAw1TvaCxP64IvVO/023RA3v3BT9Asir00L3mj0TegnBtKk86FXYLYP/x6Y0N+ID1/7Fy/ZdgDjfAGzrRk0d8sk4wsKRxi8MRRDGgSp/5TnIfLM55NpiTWGirzsw2k8jzLgtuyPu4coDx/DxGM/C6ACKxFH/B3nLSnM2OQsX+qqP4EGXBirURlAZfyjhDhAYqNTMVXL9F2fwJm3usdF7mHKfM UugWIwui hyXmYsFrNiUx+M1ViSeyJAMRkyz08a0MpcH/TPTFIBaek0xA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001178, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 12, 2022 at 5:22 AM Brian Foster wrote: > > On Sat, Dec 10, 2022 at 11:51:32PM +0000, Al Viro wrote: > > On Mon, Dec 05, 2022 at 09:51:39AM -0800, Nhat Pham wrote: > > > > > + if (!access_ok(cstat, sizeof(struct cachestat))) > > > + return -EFAULT; > > > > What for? You are using copy_to_user() later, right? > > > > > + f = fdget(fd); > > > + if (f.file) { > > > > It would be easier to read if you inverted the condition here. > > > > Seconded.. I mentioned the same the last time I looked at this. On > looking again, perhaps it might even make sense to create a > filemap_cachestat() to split up the syscall bits from the associated map > walking bits..? That subsequently raises the question of whether a new > .c file is really necessary.. > > Brian > Personally, I think it's better to add a new .c file for the new syscall. But I'm impartial with respect to the refactoring otherwise. I'll just give it a shot and see if it looks cleaner. (BTW - I just realized this is the v2 thread. I have sent out a v3 - feel free to take a look at that as well! These comments are still valid for the new version though).