From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC3C4C47258 for ; Wed, 31 Jan 2024 23:37:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A55E6B0071; Wed, 31 Jan 2024 18:37:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 456426B0092; Wed, 31 Jan 2024 18:37:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31E5F6B0093; Wed, 31 Jan 2024 18:37:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 21EFB6B0092 for ; Wed, 31 Jan 2024 18:37:52 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F2BDF12058A for ; Wed, 31 Jan 2024 23:37:51 +0000 (UTC) X-FDA: 81741221142.29.F56896E Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by imf01.hostedemail.com (Postfix) with ESMTP id 2FC0140009 for ; Wed, 31 Jan 2024 23:37:49 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TDvPNp4O; spf=pass (imf01.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.42 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706744270; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8L4jEua2PKYDRUm8Nwkw1/0a+FDetF9qtz2GcaOTMnw=; b=DKvCJLF4kI/YHIovQ0gWwBOPkfkzZXxi3wstVdsz4gIpionGRLGZC+91bBSbarYItvH14B 2FXVH6RipshzQUpH6TC7nDDGnswpLY8hekspe6cJX7IUvM5mYt1BlcAgerqro9hU+s0Qk4 Z22+AsFhcfdZlZXRQXjxnTWjPG2NKgo= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TDvPNp4O; spf=pass (imf01.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.42 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706744270; a=rsa-sha256; cv=none; b=TBUc4Jk5X/z+8pBNqaaYCsM2drEm3ghF1zdZmEoEWkATl4QVJD+NeQlhQkFTA81sASxfqG /EYj6g9wkRyc0/qfJ/IGM7/4bmqek3xBPVMSNEgbxZB5A5LOJPeUUVs9QbVTbJTq2snpjA 8ievcDNoGU9Y3ENcJyx7THGkJAiSUzM= Received: by mail-io1-f42.google.com with SMTP id ca18e2360f4ac-7c00128de31so12682339f.3 for ; Wed, 31 Jan 2024 15:37:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706744269; x=1707349069; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8L4jEua2PKYDRUm8Nwkw1/0a+FDetF9qtz2GcaOTMnw=; b=TDvPNp4Ou83ZEbypbU2Q2+Tl05p1ttO3tA2yO8QQRluHjjK+Nf7798JjsyZvoHw0Io TT2DkEY3aJ63jRKIg0yBpu8U2Zl1Ew45g5d2uuR97hsTmPbv3eZ7FfuLGYcpau/Z3NYa S9xSwdYYaI4Wy0UfnKh/xbcKcumGoE7QCs5oz7nFjL5SYtjDaQ8puuF62cUeQrGYLsKL 6ZT3VOHnpZzQB6bFVdp2eoiJx4UKNHmIcXgCebZdRbMab0G7sn4rwBQihyVj6t6bY1WJ cx9SIuxgCV7F1wVqZrQSYjkl9seBAEsZuZO0QzptZxeVdqYenkvojZT+H8KYR/QS9CMF A1aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706744269; x=1707349069; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8L4jEua2PKYDRUm8Nwkw1/0a+FDetF9qtz2GcaOTMnw=; b=c4zdCLY2nKaovZvjhaYvnXDq6lk1EyCwQ8vZlqPAw7cPcre6Vs9MJFeKHG1WAGK4Po OLkl84aCkzpbTcS8fQAx/S4WOOn/6W5uIs8h40NdKIJIX5N91VyN/KiSIlJ8lFLNefdM s+oK3XG1MZUc/PgjLtRaVKbR4FsNlkdSFuJ2uTDuAxzSoMeZJJdFxUGbU73AqkSAWuhH H90bvNLkgPpmUkO9i1i5UOm/kBTyTwbqpBU3nL7vAcR9LJf151BorR4LSq1BFyRAxLbU xmcXtvZbl/Lz02kQpTjgYW0+IuFSWJqbPmlg9/kDNvsyvlWYK9FdmXPH4O8cwidqWnX6 cDaQ== X-Gm-Message-State: AOJu0Yw0TjumNJyglYl9oWuedul+3MzA5DiMI24pCOAbsX/G4VwQhd6h 18S6FmGjbrQGBgWDSCjYTY98KKmcwXinSTcz6ReGzJSx5b+6smB7IBiP2zfS0TF8mrIZiHtMsg+ SfXxWlj0JxLFfFwAUEVP2Pon2PM4= X-Google-Smtp-Source: AGHT+IHWsZVmF3unvlCo18YQ6UwRfBNPRWU7C79GqqBOmTYFJjJhvLB47VXGpmDrUjGTvFrQiIWRPcYx4X/lGX97cww= X-Received: by 2002:a5e:8304:0:b0:7bf:b56c:ac25 with SMTP id x4-20020a5e8304000000b007bfb56cac25mr572354iom.0.1706744269379; Wed, 31 Jan 2024 15:37:49 -0800 (PST) MIME-Version: 1.0 References: <20240130014208.565554-1-hannes@cmpxchg.org> <20240130014208.565554-21-hannes@cmpxchg.org> In-Reply-To: <20240130014208.565554-21-hannes@cmpxchg.org> From: Nhat Pham Date: Wed, 31 Jan 2024 15:37:38 -0800 Message-ID: Subject: Re: [PATCH 20/20] mm: zswap: function ordering: shrink_memcg_cb To: Johannes Weiner Cc: Andrew Morton , Yosry Ahmed , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2FC0140009 X-Rspam-User: X-Stat-Signature: 1g5c33mnxjzmo9h3nwp8ozxbrhr8u6in X-Rspamd-Server: rspam01 X-HE-Tag: 1706744269-48580 X-HE-Meta: U2FsdGVkX1+ydAixUU5gaAxjFDh/ggbiMI2wyAxI4I+On2XtwLvfC01j3dcczT+YaZpTGF+de2pKMXaGCv1DJLt9IJaY5hDAKDFIeCAgZJWrz7sq9El1qIw3iPYvBqrd9x242MClRb/UXhAC8KIM3dprN4ptX6ra8ZjuUeX0SBQHSCTaapkwe+NNWIWu13rzlMxPFLG9FAI/xeoDo/6s7jmbrCl/FUcbUk/HDuUcof7BwrFzay5sGGM3SXLwYiw3KYgKOT82rRDNPZn13KAbP8unkwIlCUIu/40uWfraPaYsjAxnbpACermyS/CU/Kpa8pPNZiKnlJYMs2LDWwJoxRO4kJEZ6xF+uc/6RANx5V0Q/sq3i8rHgaRZ+PYWcWK+ytA3U+GBeiEvJykht+VJxnsXnk68EmlzVpMQlYtHtY6nhxj7zN1f+UObo6BuoPGahJ37GDGWnWkkSslfKEB2H5iPPCJfrn0/4BVeMekenEaLAb/Rirj7EN41klr3vqcOtdR7xs+NSvMn+ULeSEqBL3b0enK4ln5ERpaRhBvqFQAZZ4Bc4PuRUyo8ivjFMmkrORW4TBxW1k1SlIilFlmIbMAKf0YOjRp5+DRNEauBg09o3JNFbQ3ct7OM7KQ6veYa4zOYBLt024M6FNEmVms54aGR0ZQ2/dcIcBwGZWuBlWvhqEXVdx3cZRoOWnwIshJ0/5WOjwjamGVcHLC/cTlpUehB7J0ofDrkKftRM0xNIyHajz9TJKr0MGIq30o+vzNDPav2ef6eXG2mcbEHAqX6XtWRDV8NTWM/ka9dkUA0kwG7JM445xkYdnSMaFQCkFyO0dKY2kzaUirQASaif2An5NMljjuT6HTDeIN92c6hqzYM4WPVTDKDV1KGd6xWpvBekvKRfodnN5GltJqLTPDIZd/u9RITZRQli8IoIPtKJ9tjp/VM9Hcrwr7ZIRW3NxaYSB/VVee+5+SgczPDWWf xLm22AmU I1n5QuUUbadrt8Tf98hfYf6WnXPOswMk5S76XqFIAiL9P+vNIWvv/BLqQd69cc/xyncJ9ukLGG3hu8lepGr3Q48UaEmwcxUTYtCbq6OH87leagLZYS9QVrrOpr9k1g6jG+F4k2H5PTp0jRtuK/wZnEThkqQFay2tQQtcxwlgPtlRnFKU3bLBsqblDy6/BRwEzDGrQ+1YXs45Yw3tsEZfwAeWuahuiv3i9T59KkQDgz9dsWMS4O+F7H5UXHAC9jWltrxfxY9ajF7AY/BQT8+QTyi/mMWpGG7E9ls6PpzU8Nq5yImTSvnmhEzFJxP5rcEZvZ42Qldt9VDFDAzhViSKgxomGOfuX3lDMGWZ5Sh23b4oeecshYc3uPbZsAZMwiOhj0iiECtdz77ebMahdpoBi9YbemdiNMbTCuU4wHyn94IwZabZa0fcOVXsGkWap1PsW9p4KxpnLvACyKjZDjTgMbZjxZRCszEdEDlga X-Bogosity: Ham, tests=bogofilter, spamicity=0.027134, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 29, 2024 at 5:42=E2=80=AFPM Johannes Weiner wrote: > > shrink_memcg_cb() is called by the shrinker and is based on > zswap_writeback_entry(). Move it in between. Save one fwd decl. > > Signed-off-by: Johannes Weiner Reviewed-by: Nhat Pham Nice! I just went through all the patches. LGTM.