From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3761FC54E66 for ; Tue, 12 Mar 2024 09:35:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A59398D0024; Tue, 12 Mar 2024 05:35:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A09AD8D000D; Tue, 12 Mar 2024 05:35:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D1048D0024; Tue, 12 Mar 2024 05:35:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7B75B8D000D for ; Tue, 12 Mar 2024 05:35:55 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4AD4416102A for ; Tue, 12 Mar 2024 09:35:55 +0000 (UTC) X-FDA: 81887880270.15.302CB24 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) by imf06.hostedemail.com (Postfix) with ESMTP id AEAB6180004 for ; Tue, 12 Mar 2024 09:35:53 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Y4zVy3xH; spf=pass (imf06.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.44 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710236153; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ljOGSIOwEPVM9aUkLHCpa36SGLC+SUxtQAmTIrQTJdc=; b=EmR8eYBeiBGsbag6lKZNzzbjf6YfhviDXBgIdH1H+VbzeuOext153ontqV7v8eAUnuTjWz i3YsVvPCvKJygNPsh8In40g5CQNyaUCXLGnm1+a1Ey2aQxhKl1VocGarzo1LuNvbgDGQew VY0uLp7SNE4NhI6X/QlHI3TXcLM1140= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Y4zVy3xH; spf=pass (imf06.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.44 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710236153; a=rsa-sha256; cv=none; b=GFRAzeLVNZi3yVBq1pG94V6MVhoKP7rs2kzIb4zRxCP74FkmWUmsPASpqxMgwu6k/u++Dq HPJzsLa298iEV+bhW2lDguSJ9N20bOvGeWJjteeyx11VlKw0nN/wwrMF6GIN3NjN3t66CO WhDXENVBd/n4kij8oUyxAmBQU9Rdw9M= Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-690c43c5b5aso20185186d6.1 for ; Tue, 12 Mar 2024 02:35:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710236153; x=1710840953; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ljOGSIOwEPVM9aUkLHCpa36SGLC+SUxtQAmTIrQTJdc=; b=Y4zVy3xHHWc5ejmIvbTNSlGeIt20wymAxDfGVTPazNQrmhB2Ajjo+yTZHQLdioo6CJ EgSOuXbHTiP09gANVyy+grY6hwT+glsA6Uz78aePWtIlrshGF23dpi53QCCJijusEkIE 5HghEBiBPtL7qy/BPIh+mgwW1WFutpkkOdayuGTHsJfJWnt/vIzAxFXGEaQefwCCtKzX 1ucFmGRuPNHChdSdVgW7wZ46pnWCjD/E1NG/Jb6jh3wpdPjkq4F7K7hm8dITBCTfAPWK 3gY7vYs/QcoCjvHPMPuWaSNg7P8Ym2oWu7aChBkKE20tyOzbfhW5zzs/2wFr0d8KYm3c JxCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710236153; x=1710840953; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ljOGSIOwEPVM9aUkLHCpa36SGLC+SUxtQAmTIrQTJdc=; b=Rs/jneezdEa2KRKueAwvvnMKHxa4HTfyBvOVEk0zlvhv6xJnviS27TIHbEsHLseDGl J2yvnlt4S33T6joEV5F84WN2ttZZFJ95RK+0C+bwwG2OC4hW4VodiS0fAFKaOIQdXjob AORzhimGkXOL/pS90dk8Riz4SYxMppgD2WE6Hwj6aU5c3JqilrBPJzZLZqYjUUDMVk/b N+AHAawnV6eaz0tl9h5av5lFqnxtN0UmPSJlVjd/saLjKTW6LpzUefu6UJ/wsce3Wbmz 31RtLfkbaX3bqpwSVoof5nno+IosIrnsOOiNrkvoZMsWrvNhLYsnvMHLWxcqc8vzB4iG LYuw== X-Forwarded-Encrypted: i=1; AJvYcCW4dB4mi0M+K2v8Y59QAFMKncM9bnmymcYR8gN6RjMKFbyIeWLPbhGrd16qViNmTg1+asF4U39iJmlKYTJTVRmwA1Q= X-Gm-Message-State: AOJu0YzJ53u+p+OvvnYdqVu4XvaB1e5FYPZR3jzxxYTXNoH+7HJG6mCW FnM23tRwLHUBQIAh6AkwhtJVx5E+7r52PtIV2Zr5QpC3m5QRowRZIIN3WEUbAoCjiO4L895Tb+L mmrvEQ1zSw89y3ZGBj15TJUXLYjI= X-Google-Smtp-Source: AGHT+IEOz3HLcenDvdObsuH5wsmDw9QCUbs4wzbzF9oUlUobqOUbF51k+0xv8+XEDYB8aSqIM7pWOaajyEOWov03HIg= X-Received: by 2002:a0c:e286:0:b0:690:bf98:cdc1 with SMTP id r6-20020a0ce286000000b00690bf98cdc1mr8704861qvl.15.1710236152805; Tue, 12 Mar 2024 02:35:52 -0700 (PDT) MIME-Version: 1.0 References: <20240311235210.2937484-1-yosryahmed@google.com> In-Reply-To: <20240311235210.2937484-1-yosryahmed@google.com> From: Nhat Pham Date: Tue, 12 Mar 2024 16:35:42 +0700 Message-ID: Subject: Re: [PATCH] mm: zswap: remove unnecessary check in zswap_find_zpool() To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: AEAB6180004 X-Rspam-User: X-Stat-Signature: u4ibiz4fbns5xxyewx5xxtsc8qqyo44c X-Rspamd-Server: rspam01 X-HE-Tag: 1710236153-266578 X-HE-Meta: U2FsdGVkX1/BsvbzFA9grj6UusJqy0xR4eQz/wacjwTrvVit2ZccyEzDVbgZGcmN7pMvCkK05rybBsDfCjFqPm32RIYHHUud+pmZ3G9tPTYrNIEotgZigVOQ623IPJIv22hRSXPX8rR5QopoYbaxSntSPwxUx1jKUfPCZv5WedHFwps1UNAalAQ0fskU8RDooHDBPEEA/IfKQeiO4WSdNrhfKyQJhEHG4V6cU/OvAptSvPjgNWU4fJjWSfLR6Ow6Z53bz6DnrOhpRUVVK7sk8kKwHGbvHcZrb7WWFrW1xqVvbxIzMfQVTLo1zydpkr2GAA+f6f8NpuFWpM6EU6WFOK1LD5ZibU9EjyVSzX8FvTdFOoTvoQgH0Jly3t0avjqwwI6T0vm24CTGLeTDbssOkoRVb7ZNRztqaQ13IxHJ+7aHNn8O8iyjJwFYcWCWKAjEL1VpPIiZy2RGqgpZ5ORwDAoDl+cIW701NEa+rEUx/M9j0rfT/BPODS9P59TyfZj+k8i1cmRqU+3/UymI+ZOltWfxyDM9YOw9ppXGghOi0OtxooLa0alDTTGZ0KEeTZruW9TKgUfJPPIk+vO3C4+CyRATbBL+VfzBN0mBv9DuzSU2I0vTt9laGdJrHu96DkWycIEGsGjhErJ7ZutNySnvvdkBBMsb0CpKxw8B4ngK6p6RqWXjeA7a8xtVi1S9xKUY4ED2Ifxk38XVsjnJdz7cQPlzid2+XkYnQtOXHvEoAYDhndF1zETGoZSUnU3Sm292i5NZF3nuEn1cZd5EkISLV6Cfy9R6VoruJ/mkzvzmB79NXuLChOFvhQc74yvvMKBfmF6ENaCNqWz+U1bun3+9yEz61AwAHm7o5bjm7c0NafA6nKVCCFSnrZKfRASD5DWlml5EC/trx7o8U+EMceOnzBlKuSI4YGI3BkPzSn7heAcGHM/N9ze6URytrHIcJfEhviGS8mpcuN9e37POx3x Mj96BlIO AK/VEQBV2GkjoIokiPhHPGuj+9/T6U1EM5B1biClMLlA33Yd6fD4Wy15/JtUOk21c1oDauA9XKwfqJu8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.048732, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 12, 2024 at 6:52=E2=80=AFAM Yosry Ahmed = wrote: > > zswap_find_zpool() checks if ZSWAP_NR_ZPOOLS > 1, which is always true. > This is a remnant from a patch version that had ZSWAP_NR_ZPOOLS as a > config option and never made it upstream. Remove the unnecessary check. Do we need a Fixes: tag for this? I guess it's not a bug hmmm. > > Signed-off-by: Yosry Ahmed Reviewed-by: Nhat Pham