From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1BBFC282C6 for ; Mon, 3 Mar 2025 23:28:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63158280001; Mon, 3 Mar 2025 18:28:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E1506B0083; Mon, 3 Mar 2025 18:28:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4811F280001; Mon, 3 Mar 2025 18:28:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 295746B0082 for ; Mon, 3 Mar 2025 18:28:47 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D7023121107 for ; Mon, 3 Mar 2025 23:28:46 +0000 (UTC) X-FDA: 83181831852.15.33948F6 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) by imf09.hostedemail.com (Postfix) with ESMTP id F3D2D14000C for ; Mon, 3 Mar 2025 23:28:44 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fkMQ8BTq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.41 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741044525; a=rsa-sha256; cv=none; b=a+mR+faxhv3QXm4qlR8Z2xcUXuXdTUiF2y23FCDJ357HdPGbm5EbGRH6GL01RI1lnv97vY xuKVWxxmOGxReiw2kAWRPrLaJiFaXqwA5pb7LgAn/3l2SKwxHjs2+otHIP7A2phPu4tjbv kkOZACyg6845Kj+k3CMln+Lkv86Zdbk= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fkMQ8BTq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.41 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741044525; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZGjr7Oa8WXRDynLG7DHXT9g5o8RV9GYmhggtGAtGgyE=; b=78e41F186wHfGh357W/NU4pZBrL6gfQycB+GSMuu17GrKFly4teHpciWD3A8Z6Nt5lmAyz x9CDXVS8zKGY50e1MmlDUcZso+bSUTAZgAlfDF99doNv9jME0frqNyIkq3RqctsQzJJCOw YI2+LyyuizLRfBV6oaYwSO6pOFblKng= Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-6dd049b5428so45894316d6.2 for ; Mon, 03 Mar 2025 15:28:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741044524; x=1741649324; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZGjr7Oa8WXRDynLG7DHXT9g5o8RV9GYmhggtGAtGgyE=; b=fkMQ8BTqcQzP+aYbnAkSiViPQdsA51bzsLZluvVzobewetqtISn+BOBZUCYqRyCRQd zH126Cnqc/UCHM9GZZVH3ui92fmTZ/fakUMvsNonPynAFIBJMb3nED+lLHQG6fWrjBdH ycC6e5ngsMiYvJKjuLs5f1wJVHeDL7+szKG6bjGqfMGIYu5KJdTbL+JBfoH5d+r8YWDL 3RZ+Ci9Vodk6/eLheHmR12J6kCuzBuYnBBj0H/L/osRq5hHrp7xKho1BMtB85sm2gHmr cAM1k+vHZ/iQy6FFKAj+4eo259xU46FEgGt12iBqjMT+EqYPox67s33bdu46V0fJSR7c iFWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741044524; x=1741649324; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZGjr7Oa8WXRDynLG7DHXT9g5o8RV9GYmhggtGAtGgyE=; b=Imgf6LiAJVW4pw7uTGZa2QPVcoGCtIlralyE14Syw7v5q3ELFA4ZirXx7FrAG38+Co yU55Xc75SpyDU7LryXTQOuegOsvtzmW/L4rbhwQW44xluKvYk7JiSVe1vLA7DBeypl70 uu5ts57evqP6katULoIU2jYmD/EL6CLD0OktYA9ncXeR4TUo34AKDIJt/NyKWxQfKJHZ 6SMVApSq4ip8B+oZAOhlYj3D2uV4giALwRqWwBxbw45bVDj8Km+UDY48Q5IVeK652l1h vVBYILrdFyCnWfImREaVFlEtA7DHufTRLgzCDZ+1sPJSG0d9b1w/5PS8F2CWHcysfmLj KIkw== X-Forwarded-Encrypted: i=1; AJvYcCXWUtZqsicKVXz1diz2SE4eyt8cwREPsgRkXavs08UTQ7mo9uYrDc9tfhcDjrge5zG6rQ+i27YWqg==@kvack.org X-Gm-Message-State: AOJu0YxgKpER6edc13F3eJrpfd8Hv4kWPSQxhpbvbuDv1maFNctz3nhG GlNxAPLxyJXcSt3HOujngBftkYfxhCRT5ObRAuDCSaXiVmwb4VHwGo7hYEr7VRAsUuy0/JelmMP S4036fRbP3CvQzyD2OPf4aLLdrf8= X-Gm-Gg: ASbGnctrhPpVFt5eR7ndF6rYbQZ7ambGvBBcd+G0uAhCkyo+ZxXvQ4ubxlvBCNzB9op Dyi0OaKUKzUPkRBhcK3WO9JgIbwIeVX2bUGDxbPrYGRzB2HR9nskkyisY+s5zOTxCK7YLguMU8q WVUgHeVrUy+Z7sOQY82jVaYuLmEG9y48glHBjIQwM0Mg== X-Google-Smtp-Source: AGHT+IF/nfEV3GTTfM49pFfn3pirjQtmH/n9CTKPHC8wO0WydZ9KrqM1JzDqDCQ5is0NC6ier/PZ9QCkzqvmjd9UbaQ= X-Received: by 2002:ad4:5c6a:0:b0:6d9:2e0c:56c4 with SMTP id 6a1803df08f44-6e8a0c888cbmr216672176d6.1.1741044524000; Mon, 03 Mar 2025 15:28:44 -0800 (PST) MIME-Version: 1.0 References: <20250303200627.2102890-1-nphamcs@gmail.com> <20250303215524.GD120597@cmpxchg.org> <20250303231654.GE120597@cmpxchg.org> In-Reply-To: <20250303231654.GE120597@cmpxchg.org> From: Nhat Pham Date: Mon, 3 Mar 2025 15:28:33 -0800 X-Gm-Features: AQ5f1JrLueY3cU_Xzs4E-j36PMU_qvJ01l53c2jpyuOndFMHn6UNVh_YRZ0ljlQ Message-ID: Subject: Re: [PATCH v3] page_io: zswap: do not crash the kernel on decompression failure To: Johannes Weiner Cc: Yosry Ahmed , akpm@linux-foundation.org, chengming.zhou@linux.dev, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: F3D2D14000C X-Stat-Signature: nzmoha5e5x9353qw18iecpkm6jwymws8 X-Rspam-User: X-HE-Tag: 1741044524-443230 X-HE-Meta: U2FsdGVkX1/ND1sPjn7saqct6wH4TCh2LfsIS0bvrCMGqH75N29tmw4I1LUfmjGDLegT00spkKEtKBNPa0k+6xcMDs8tM7euu52CWohixeHexyPVe3ouws2GaR8lr8Wo164J6s8LbDdTZ0u8+iUUZFgDe2lncUS7qP/POLPEtIMhi1g+vTaqhLNWSpl4c1se112m12cf78ACTOht1FC+7d/ohcx9IYOzHqn+Ug3TKd1ldtJqM/tyb6PZe12GEawfEJSbHz9ovJH2jIQ/cTLmn3ou7oSeyUXTFA1ZzNT9AgP79PKdIyjmknd57jsHJ251QRgfkjdjoqyNVKN8+FC1DGtbx1rttpl/SuSbjiRF4wOtny49GySa2qB0JXTNugkKxz0X3pDBjaOpgd672sUS4aWmGNOyUV6x4SyV9nu4LevAAMvkc9kEpSAwwblwXPLsKNVsNUfjn2PXR5lMdCSInN7r7zPeiyscfuVc5aUJcm7Z4UViPRv4FVYjqS0S7VA0rU7pEzZcyUyMd0yAXQxQhUhySfNtROQky2H3B3QY56kDjhE0owlBeXh+NSgW70HpX1cRV647j12cSKRQSso6oGqDiv4rn8VzKkM0JqCOaKPNghxUqXyqMVbr38LihhZy/GljlX3jdKTxj9ZYqy2oizTmRuJ4Joqk1alrqkmnVS5yUNwj90GSciZTG5P8OaJz+Z9qdK3IMec7Y0moaEowwu1vXanxrt7RNFirLzEzlnyzAvd8SFXssb7Y6GiP8dm+MNvIl6KW9XYFvCzabYwEgru+Lp1+3J8+sgUI9ny1oNSVoyL5lxWsPJ61O/GUnWc4Imo5KNYGYX7sWWtw6dAMiFcjRpMfguee8W8WzlrP4tDLculwFWuPS7eZt+0VRGb+H6iK0065na+VZ6lKEda4xzhmo3nOuFWb6zNkkuoquGV5niSsxi7dRus5sggGy2qc5fMqP4UOyt+5BQwiI4n GiSm1ydl wofiad0Yw7BupHZS0UOU/9Rsw2U0o64VKhuOSzQJOVd6d4gwVbOHn+DcFDlBDLnQ6JJiCixNfHLTz+sDogYm5NuBDDryOWGcRH0Shmfbmbe6vXDFGyyHCXarekWNmQtPR9F9xZLnm/RPKPzhhQLyBmMm0mKB6AllkJj+FuVjNVm4MYgjlARDwsg39dC665+vjEHSLh8ue17Lh1iQQR9QFl0Jr42FNpltTV4/YnFtWXl/sh6sjy4uYwypt+A4hv2AkxVQmQcn4Cfe1E2t5Hgb9/+jjt7miyKsmFEmZZDJomQNQibAokaFz4V+ixG0IrSIFxujCtb7DBygcfUy33C/xv5P7xIWRMTdZprUh794pVHzLW0WwsZxH8Iin2FZWmTTBBoqyQ3Q13OR0f3zkKwhPbxcVL6ghsDj2TMCWUPrPz8oKAtw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 3, 2025 at 3:17=E2=80=AFPM Johannes Weiner = wrote: > > On Mon, Mar 03, 2025 at 10:34:46PM +0000, Yosry Ahmed wrote: > > On Mon, Mar 03, 2025 at 04:55:24PM -0500, Johannes Weiner wrote: > > > pr_alert_ratelimited("Decompression error from zswap (%d:%lu %s %u->%= d)\n", > > > swptype, swpoffset, name, clen, dlen); > > > > Yeah this looks much more concise. It's a bit harder to parser the dmes= g > > as you have to cross check the code, but hopefully this is something > > that people rarely have to do. > > > > I don't feel strongly about adding a helper in this case, unless we wan= t > > to add local variables (like Johannes did above), in which case a helpe= r > > would be a good way to hide them. > > pr_alert_ratelimited("Decompression error from zswap (%d:%lu %s %u->%d)\n= ", > swp_type(entry->swpentry), swp_offset(entry->swpentry), > entry->pool->tfm_name, entry->length, acomp_ctx->req->dle= n); > > Seriously, this does not warrant another function. > > It's also valuable to keep warnings inside the problem context instead > of socking them away somewhere. It makes it clear that decompression > failure is a serious situation. We also expect this to trigger almost > never and it won't be tested routinely, so the best chance to fight > bitrot is to keep all those derefs close by. Imagine if this triggers > and the data is misleading or it crashes the system because some rules > around entry, acomp_ctx, the pool or whatever changed. Or if the work > involved in decompression changed and this is incomplete/unhelpful. I was actually thinking along the line of Yosry's, but you make some good points. Anyway, let's just keep the printing in the OG function. Let's not overthink one print function call. :) (sorry for the duplicate email, Johannes. I accidentally sent this email to you and not cc-ing the rest lol. Resending it)