From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB14EC38159 for ; Wed, 18 Jan 2023 19:27:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF9386B0071; Wed, 18 Jan 2023 14:27:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DA9216B0073; Wed, 18 Jan 2023 14:27:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C70FA6B0074; Wed, 18 Jan 2023 14:27:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B65476B0071 for ; Wed, 18 Jan 2023 14:27:35 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 80556140A8B for ; Wed, 18 Jan 2023 19:27:35 +0000 (UTC) X-FDA: 80368904070.03.BA22B9C Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by imf05.hostedemail.com (Postfix) with ESMTP id E70D0100007 for ; Wed, 18 Jan 2023 19:27:33 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TMiWMlpw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674070054; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gw2OqH8svh6Y9ZQ3ZoPeYoQ8UKFhnjhW8PRKbQptBoM=; b=qhJnbWUSovxy7ibNTvwaUIke+FY1m9b3heMTOkcjrCT0nEX8Cq1ukkz4YPt8I4TJb1zah2 Cz2SddUP0fl0pUge/aoDaT/OpmJvcZSk5FV5KO0a9JcFzvLh6yAeP/HFNZjAuhtfpDg3rY Ou+KOq4O11LoM8H0YPdzr5mY4QdxXsI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TMiWMlpw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674070054; a=rsa-sha256; cv=none; b=n5OeHuPFXjMY4vigTjPpxo6tWuBMN5RTi6FucSNv4zHSZ3jWiQUjxeF74ehuyIgYAwrBij uByjR8uQrvGemLAyD5ITlbBh1HVUikB4gO+XjbEOtxoCoDa+Sffs3qsWmP/+lu94aeDIPT /WvwYznXbjfcMKF2EBIkdPSZ2i8mw5w= Received: by mail-wm1-f43.google.com with SMTP id c10-20020a05600c0a4a00b003db0636ff84so2389467wmq.0 for ; Wed, 18 Jan 2023 11:27:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gw2OqH8svh6Y9ZQ3ZoPeYoQ8UKFhnjhW8PRKbQptBoM=; b=TMiWMlpwLUVOrMAwJfpLSxTLSfISTZxQuoH1QDmbORP0znWZukAADiab8gbClB7yVp rQL+JQtw3269VSA1h/D520aDAeYyuj1F5Y8vKPco5GLPm5YNDKZ1aPTMcIQgm1UJ+2Nb SNZLL9ay6CfI0O10nRLxLocTSD4uCfEkPGQ/Np2tvHG27LDhqqEGdXQ8uMD5pUvTEvCx jHPTPBKcUtO4yiseDDXvitbc1p6SxSxbNARzCdiUmibEBYpyfAn8YwDg8Z0ix53rdEjG 8XKisRtVxGToANgKFGvoIUiLSVzUhQ51n+E7shy43/ClDvFH7Jkk0cjQUOy7k7jJaVxE hdKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gw2OqH8svh6Y9ZQ3ZoPeYoQ8UKFhnjhW8PRKbQptBoM=; b=Za0zbz7QSCoQFxcze8+3ChRbdcN2MS2f6w4Yq+Ya4umC9IITn3FfB5lngPH81PeBoH qB5O8GxgxQXy1lcjBaERmYzzws62uQ2S2AQa8E7aiefOtAt9IfYY/f/tqXcpnbW0ejz+ mQhwPwoJz8+uo8J51pnxDZjQiAmsMJbCZJyNsDGEj3jZDG4PAatoY3E5M4YZ2G+CDd8d LsaWx72bSW9ROpypnmUmahG+LXw7+sD1puUq+yqTtC/fH35DGabaIBd8AtkO5j74T5hT CqaaeNe4/PLQo02xeMkzhAY+A8lhspa8PlU4v6oIFtGNl4WWLLaHPK5ePs9pquRUAsiJ bmjQ== X-Gm-Message-State: AFqh2kr/xPQ6WtaubXiN6zPnH/p1wt4v8gm8eHSlB/vJuaBTzJH4iLDA nQyu7DPHynxxCkdnjro6Nuwmice2FaE5v1x0j5o= X-Google-Smtp-Source: AMrXdXvwK9wnyf69VXXDyY6HPihPRTo5mvUcTmHeoqMoqEkPU5X+Nr4vJQQ7zxMC0AkZfCJrxKLSd/PPlC5rcxanE9s= X-Received: by 2002:a05:600c:a686:b0:3db:104:7821 with SMTP id ip6-20020a05600ca68600b003db01047821mr436651wmb.77.1674070052343; Wed, 18 Jan 2023 11:27:32 -0800 (PST) MIME-Version: 1.0 References: <20230117170507.2651972-1-arnd@kernel.org> In-Reply-To: <20230117170507.2651972-1-arnd@kernel.org> From: Nhat Pham Date: Wed, 18 Jan 2023 11:27:21 -0800 Message-ID: Subject: Re: [PATCH] zsmalloc: avoid unused-function warning To: Arnd Bergmann Cc: Minchan Kim , Sergey Senozhatsky , Andrew Morton , Arnd Bergmann , Sebastian Andrzej Siewior , Alexey Romanov , "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: E70D0100007 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: i4e6rqrecpn5dbxijkxi8rr1twc4i9id X-HE-Tag: 1674070053-830262 X-HE-Meta: U2FsdGVkX1+P1dYnrBqbySBaSBorbonKl6TEaT8idFAENx5K4zNQlzPSmTAc+6XdYSyzsfO2yeqqiBxR/J6RuFj2ulJZAY50feNlQSfrAeztmZoNEwqx7ppul77mVcgu0UdWaqL9M5Ofo68iC7mjZylXAfmLsvEIHumg0e45MDWoZerOG0yUsFaUU3vqUZmQ39oMdy52kzP0qHhRo17Ma9PSmEeRbr/AqpDdf1yWi+Hm0/m/1QvXdRtZ7+grhGXIIuFtFVG4bojYZIz0FDI2V2GOPKhFUWT2t03A2eIN3qpsJfKyh6RE55gaMdVN7EQbC7OHkga7lyw6C+/gm61QbFoK3cSMVIqACmjbohtQZllLNwakiBHxJGUMJUzjYSqRleaJ3UWA5aREvKftORR+7T4SXjq+Rno1rfSz0xeMhMauulZk6jWVz2/Ah/qC1H0dsALksxFCWw63iDm6EZ8j7PdTUB8Ru/wS3NG3aJJJKVYUxW4J6LW2Ok9aKMzPGMhIN1SkvkgqWj8+ATIzt7XyA3lPczqJ5BVsvMlCQ0PuJLUyjxE7h1ydU1il9dX9Hh9EXO1D8u92o2RJeor5FctqNberB0WRXod70PQguOPrjFK1gmFlSvkSo8nKpvXwvWbxK+bcMhW7OMwHK1Mwqz0pDHAclVLaDLOu8OZiaguGaaI6KZERe7dwqmJpcSSOPBN2dweN2eBbC1leF79D8v9ofczG09ox2SlSHSyncnAYDEyKMYifZJ3v9CIs/8NTtpYrK0qWma8wTxSLkwlmkzVy0B4w2uZOXrKQN3vZ8b3pxujdUkY+x2Xh86K2VFg8xZAnHVxg+Ar+WKmFAjiGlXwhmy4HskA97ySBE9sloBVdbty5FqzMtdIGYmaDJ/Sp2nEcrL8jbUxynsc/5oDC39Tso21AG9c11rl4yCHuiSbZBm2ZqBSL3Yu8sMly70PjJaHfJX2rt+qEyhuUq0Eli6m f/K+25zw qj4H954XqUkido8Nu4EzsxmNfFjbW0fWLiZSgzuL6JO2XfX44h81Kmkcu9Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000055, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 17, 2023 at 9:05 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > obj_allocated() can be called from two places that are each > inside of an #ifdef. When both are disabled, the compiler warns: > > mm/zsmalloc.c:900:13: error: 'obj_allocated' defined but not used [-Werror=unused-function] > > Rather than trying to figure out the correct #ifdef, mark the > trivial function as 'inline', which implies __maybe_unused and > shuts up the warning. > > Fixes: 796c71ac728e ("zsmalloc: fix a race with deferred_handles storing") > Signed-off-by: Arnd Bergmann Acked-by: Nhat Pham > --- > mm/zsmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index 723ed56d3fbb..9d27d9b00bce 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -937,7 +937,7 @@ static bool obj_tagged(struct page *page, void *obj, unsigned long *phandle, > return true; > } > > -static bool obj_allocated(struct page *page, void *obj, unsigned long *phandle) > +static inline bool obj_allocated(struct page *page, void *obj, unsigned long *phandle) > { > return obj_tagged(page, obj, phandle, OBJ_ALLOCATED_TAG); > } > -- > 2.39.0 > Tricky one indeed - I definitely missed that. Thanks for the fix!