From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46CE7C021B8 for ; Wed, 26 Feb 2025 08:20:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C7CC828000A; Wed, 26 Feb 2025 03:20:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C2CAB280007; Wed, 26 Feb 2025 03:20:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACCD728000A; Wed, 26 Feb 2025 03:20:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8EA35280007 for ; Wed, 26 Feb 2025 03:20:43 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 371D5C0EE2 for ; Wed, 26 Feb 2025 08:20:43 +0000 (UTC) X-FDA: 83161399566.10.7FA2A10 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by imf05.hostedemail.com (Postfix) with ESMTP id 4C7B4100002 for ; Wed, 26 Feb 2025 08:20:41 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="blC/SpsB"; spf=pass (imf05.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.52 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740558041; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H3qqekXnfCty6pD+u0kExo5lVRho5Ggib5QzzRBW/1Y=; b=j8r4oUlvjxdq7v0lE7Lq+ESVl6Q6t+v0Zz8c/gfxTFJBcV9ehF4WUSr1pgl9zumSWda6+U 7Yi02f7F6VTnU/BEA+tcKXTSrsKM+FjeMQ0hm4LLZmFYPiURv3TJl8Z4jfZfK76RZaTLMs UeJ1wxVdyB0cDEfX0qLS+G9xshcGKfk= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="blC/SpsB"; spf=pass (imf05.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.52 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740558041; a=rsa-sha256; cv=none; b=IJ+ewFbOJxXqcU9K0B+6Mj0BSrotDD5WnaFGSJU8gv6zuigG3p1u1tnXj/dcIEDZWrAVap Mbx7FIr//vG/OR5q8oE5RT6dROxmRC8MTCW+EBB6YXyF5bDc3Tb13zjEg9hiquI7RcAwog 4WV+wL+/JPCRjstlfJ4RiKfITgAE7dE= Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-6e89063f754so389146d6.0 for ; Wed, 26 Feb 2025 00:20:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740558040; x=1741162840; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=H3qqekXnfCty6pD+u0kExo5lVRho5Ggib5QzzRBW/1Y=; b=blC/SpsBF6a+WFxdtNz9lxpVbNocTQKTY8PmYC3dxzBRZEC4NyxrT5IwoI34VxJovY nKmJmIT+SRu46RXu5n4ZoLYYVEmtgdRca5r8OR1v0sOz1u4bCL1BtbfBWvx2YAjri0re lqvzFwJ/lp/TdTL1v/u/3s7grg7TaTksvAjkwfKkzZgBW6LfVIWkc1xc/eqnHt5EeTL7 vd3ltXccddWNQi3qdUu2IVKOCUTi7/dimGSdgeK8VlhXXPqeD+G8RxMjGj8rMTq9qG6W MeQrUfEBvEVE0fugRR8dEZpAuKUlrkd/JPowajNtYIWOhkOdeysMs99YVaZQ5fj375Zm /xfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740558040; x=1741162840; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H3qqekXnfCty6pD+u0kExo5lVRho5Ggib5QzzRBW/1Y=; b=xS1jXwvxVaibJMgxqcqRPkI8ybcC/AgU66pv4QCIEO8kI8hUdoLeLpGwowQYLrW2RX 9vP/RCUvldGXz8rzo2pUfIafVkRzRjE74dCA0OFk1smiES3JcUj5YyVOIg2ypVXZOiJh uZOhw52qrFvtG+VXbcfVFq6ogGzEwr8TqTRlNYO4BtP9uUvQ2U6lnZvcUGwk34FQOCTf JH6M7HDA04wtWShSjWkj1VHVtyG8uj6LNnFuIJ+/Y/1aaze74r0sF11qD9BCAEa5vO0b OZNQlGMIJuPjAl1fb8G6GAsbr3SweDeAyYh7hRYSjaMat5mE2/xIOQdwmd3j9Qh+6VE+ 4XWw== X-Forwarded-Encrypted: i=1; AJvYcCV9N4ROijfbqdoQjeBt9P+B3fy5tJCl2uHEsgB146YI97H6kC3MhUty+LuMu0UF3vvoLtjb3UrAVQ==@kvack.org X-Gm-Message-State: AOJu0YwuypHY6zxr18UzmbOcMgeC+i6JbTNAjtyOvUdKnJzebwXV0HB1 CnSTikpln5pEwB386EOROyIBVszceuOMTi6yP+8UfMb0FsOxlIMSxAXLmRu4g0VgZIN6csFebRW fH9Q4jdXDbAndZOLR1Ezo+6f/rUs= X-Gm-Gg: ASbGncvn+ONwcXhCd51j11lj6Jv1ZpNvDGAM2JOEkIhP6ofEjnhjE7Enyk5Mom1J5Xl a804HOwOo6DXx8Qz72CvW1Rvc+wAXexVTGSY4Ke2Th3sG08w8yX7rRksfg3HWeID5cgtOPKBlmK oys8extB9VHOajdJSRVJJ7VE3QhJkzW0FG1c7QUwM= X-Google-Smtp-Source: AGHT+IEWyd2uoP8O3fxcApPtMrgC2/m3x8IhO6H+6scbI1NVt9HWN6/TkF/gDKS5jyehPOQ6TVBBKpXBXAXeTaf9rYM= X-Received: by 2002:a05:6214:528f:b0:6e4:2e5f:c03b with SMTP id 6a1803df08f44-6e6b00f47f0mr246625216d6.22.1740558040355; Wed, 26 Feb 2025 00:20:40 -0800 (PST) MIME-Version: 1.0 References: <20250226080410.10433-1-sunk67188@gmail.com> In-Reply-To: <20250226080410.10433-1-sunk67188@gmail.com> From: Nhat Pham Date: Wed, 26 Feb 2025 00:20:29 -0800 X-Gm-Features: AQ5f1JrTKv_7Me942Eg9q54wIc5vYl8KAozcwMvYjMii_kjDIxDFDlHyGDse8lI Message-ID: Subject: Re: [PATCH] [fix] mm: zswap: use ATOMIC_LONG_INIT to initialize zswap_stored_pages To: Sun YangKai Cc: Johannes Weiner , Yosry Ahmed , Chengming Zhou , Andrew Morton , "open list:ZSWAP COMPRESSED SWAP CACHING" , open list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 4C7B4100002 X-Stat-Signature: xdgkd1nsbb6ac1878jrwba1d4mxr7g3r X-HE-Tag: 1740558041-576410 X-HE-Meta: U2FsdGVkX1+Tdr+v+RdELh1Ku4uDrzF5EmBX4F4eAcKEnb7MZhfRczZuWNHBC3khzktH56iKv0UrWJdu6AH85G6Pj8//ykJFd/Q/tLWMthf4hoxGFpFvCg3BxY0xahtKsmUDSkDq4cKWddIIPpOhJpmW58/Z2XDtzCR6QcvdS/wXl04IZPksoOsmXq/oICs1cJ1j6jEocGkomPIHWvB2ER1kVM7wquiD19ge4+yURy6ODmSeJONZnnOeWOLTEwOkZZqULobZeylZk6DRdplm8AB2qBxxtYt/cNVlUvcb2UjwncUVW7dJZbnxUcW7DyjffPZgJHNMDl/vXoQO977UUevinCUhU8aNv01FCT2x5f0s8I96uw0RulOabkXRkkrsMo10F/uGt2zj2MbdrU12PvlXiV3ArsZIAeTe3cSRfVjh8Lwo5FpfD1vTpv3Dhp/i3g2YWZizQ6EEAjEZ8w5fgN6wkktzvzD8uSh2kzpwlLMVr1n4ybQKBGyfKhlvA2CDJ1CKvKAHJ+Wccw7Woc3G6ciSA3A14NO6EC4mQP8Ehi3q9Y76L9XrRiEnaCxgEmW7R4zmpqIMUmt3l0oa9/x18N09wn5RS1lIYnhCvQBp7Mq9seQv1hZ+pr2/blo44AK1PNVcjpmb2p86jlZ6p4R1bG+h/3iolLcP48J0iQQqkpcJwApQqjlTAdB0rnOvuiUYxices45VSDqwRiYVl3PjME4PY47vi6mWRszN36wAwMhb4uo2sgZDXajzLncBhDSndEOvvePlm10kho4ShrFDJV0K4Uf6ZJUChLcwU4qSExd4MdvY+EZAM7QDICfbuzKbK7JuvDSauYhAuDLp4ol8iCy20Z81GZHgAhXZ+fKplC3bEIvbZYHoKW3Jsbba56/5WVNVFuEkdF0cuYPLibfqBGM9zxQNknmEBqY5ed1fZqyfXlXyCiDCfmTEa7aWn37fR85iNLmnuuPN8KM892o GbncWdIF 8eZ4qz0iGIJYyw8WCN5OdB7TvW3dkraGOgRIIAPljM7IvJfZw9WAoa72LKuL0sSVSBHhnaEjyut+hD9qkbEuzLrj0sEE1GHFClL8wwtVOK7XsjiwruTj2p7uFrV4bANbL8ndHiHa9l3oJe9XW/ZybaNyJwdpEgfnAL4ZM6XlkLhSNwKd6erpDiYyJK0b2nfhLIUBMehXhkgJfOZCuCIgBO7lEFtxX4qm3Uohowibz5XbTWm0C6Hmei801Uay4zzEw5RwOG7ar3o2f8iM2aCh+sDVgl+AVpa2af1SAu3/R1mqFd/3YrH2qzd8vGJOcC8eVc6vbqnDxt+wBCyn7YzOOJFjdj1K+dGCZxzr0FFhyd93NRYJ3D4tWnXbKwtgJDv9fJvbg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 26, 2025 at 12:04=E2=80=AFAM Sun YangKai = wrote: > > This is currently the only atomic_long_t variable initialized by > ATOMIC_INIT macro found in the kernel by using > `grep -r atomic_long_t | grep ATOMIC_INIT` > nit: patch description seems non-descriptive. Perhaps you can add some context - when was this issue first introduced into our codebase? Also, I think you'll need a fix tag: Fixes: 6e1fa55 ("mm: zswap: modify zswap_stored_pages to be atomic_long_t") since the atomic_long_t type was introduced by that patch. > Signed-off-by: Sun YangKai > --- > mm/zswap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index ac9d299e7d0c..23365e76a3ce 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -43,7 +43,7 @@ > * statistics > **********************************/ > /* The number of compressed pages currently stored in zswap */ > -atomic_long_t zswap_stored_pages =3D ATOMIC_INIT(0); > +atomic_long_t zswap_stored_pages =3D ATOMIC_LONG_INIT(0); Code itself LGTM FWIW :)