From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 943EBC46CD2 for ; Tue, 30 Jan 2024 23:55:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B21A6B007D; Tue, 30 Jan 2024 18:55:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1629B6B007E; Tue, 30 Jan 2024 18:55:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 029866B0080; Tue, 30 Jan 2024 18:55:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E5DD46B007D for ; Tue, 30 Jan 2024 18:55:08 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 97855C0256 for ; Tue, 30 Jan 2024 23:55:07 +0000 (UTC) X-FDA: 81737635854.10.BB2706C Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) by imf07.hostedemail.com (Postfix) with ESMTP id E24D640019 for ; Tue, 30 Jan 2024 23:55:05 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XFZmq28M; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.181 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706658905; a=rsa-sha256; cv=none; b=fJeMgWK+rP+AlBGAk2/tr0CU242PxjMcK8VSDkEr61Yia6u1dMMn81W3Kt6q88h52Tc03M rUVHQLxBNo+V9CZGaC4Gzaua3gcDsYKHh4UvvPBW/rS89AOXQkuTzGaKnkJeKj6WsZRmZ9 WgUVdUPVSroUANTACw9O63k4hCVDm34= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XFZmq28M; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.181 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706658905; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XoyajG9zgygzjGvubxqtKQvmVDhxzndQ43n2v/RUzK4=; b=a1M5YfviObhNuOYmhAUXFBUVLL+DWjrQ8lzQ5q+CewnwbZpygS4KayM3CHqOYTnQuvLrO+ ksbzhENJjLzl2tE3g3WTTww4f9dkRuqrc/y5C93RePrHEmjh0ooyyKQ2Yguq9kOWDKAE0O gGI/XfFflt9LBbYJtk0bH2RnHWrT7nE= Received: by mail-il1-f181.google.com with SMTP id e9e14a558f8ab-36380a1017dso7737215ab.2 for ; Tue, 30 Jan 2024 15:55:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706658905; x=1707263705; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XoyajG9zgygzjGvubxqtKQvmVDhxzndQ43n2v/RUzK4=; b=XFZmq28M/mlieiCQtrZUHeiOwLhubh4u+H+jYrzOiXgXZkAtNKK+couwcJ1f54mub3 PVqhObuUnccmc+5DStus0EemKWrAbv2dTIHsT4aejPo9JY5LBPG3bpvFe6gcRbyTPQZN hzIphLAp5dP4gy55zuL0FwegeAef8off9qo040+yJ32Rbn5xJ/h2hpijc7QYPMKCchs2 PRS7+LMLHaJ2edeZuBTEEu/CHoYKugBMoS1lN+lAE8uVRViJ1lsiKJVnGZ3AbiqmODqr tWfGdvJo1v7RO0QwOlMeXabCi/roHRC6/D1okJnVRpH1bZ1pug++B+QnZTIJE7/XuBsm 03NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706658905; x=1707263705; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XoyajG9zgygzjGvubxqtKQvmVDhxzndQ43n2v/RUzK4=; b=AN8j9bIc5rGe9G5vH9ExkdWNKLYLRLjKRstFoKNYKW+NsQEwOHsX4ElvZoOl6JnLKo zzh4gcjDWL+cSa/pmhPqcmpHbYfKuyxODBMDTtmriHqzcVvlJM9RaZli6KI7A5999TXY 9SRQOWggPLhYekZtaTlCpJuYm1pp4GIMyswzh/y0vdS24V0Jhcw8b4Mr7SqYHSzaCKRS Jn5TmawyE0I22rlwQpNAOAiSASiQbuzMOQ4NT5PVymLMmVdpTrj8X8vtbzQ8x5J0onjt saZwRFDPbCrMVdaupkcDKibdIZqhXtxC7gcGa6uvZwukhCbLOeziuNZ7WZ59PDjRgLfo LrjQ== X-Gm-Message-State: AOJu0YwMhOGm1gM+kQm4zrrzk1aMxq/IQRNB04KOJ2NMrivsxkgJCVDJ BsKKS9IQCW0BUupytowtYPIrQry7HZhTtjuv0teiRZDSm3qVzuzPHZN+/PXay5oI+xoOTHJczT2 EHaY2QrHytI941IzD8UnPjJ324mk= X-Google-Smtp-Source: AGHT+IETZsNcQLEiGMVNE2umkQgxWOthND/H0AIzlBUc7HWf8ZPHF9+8pNML96Cdgzt7I0LUTum2pXtsAqjxjKjUKD8= X-Received: by 2002:a92:d84d:0:b0:363:7985:eee3 with SMTP id h13-20020a92d84d000000b003637985eee3mr99618ilq.24.1706658905012; Tue, 30 Jan 2024 15:55:05 -0800 (PST) MIME-Version: 1.0 References: <20240130014208.565554-1-hannes@cmpxchg.org> In-Reply-To: From: Nhat Pham Date: Tue, 30 Jan 2024 15:54:54 -0800 Message-ID: Subject: Re: [PATCH 00/20] mm: zswap: cleanups To: Yosry Ahmed Cc: Johannes Weiner , Andrew Morton , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E24D640019 X-Stat-Signature: 7mzfqpozixnkoot8yfkuuwdca38c6u4t X-HE-Tag: 1706658905-926349 X-HE-Meta: U2FsdGVkX18Kcg4TxzMCMOI2xAP8jtnwj7bnrqW1l4kMFF02ew0rstQtGzhnW1zjgP1Ms89I0TqCfdWOM7fCf2EllKYQ/Mr17uhlKr5a4yGTgKqzzgDPM3Keq8QtiIbUYvWEcGM82Bh7IvOnkZ/dd7VDt31nXVcU6mFoR5wL9FLTF9O51qHFSrjuM3yhFTCkbKtkw+7gFywHNKi9Yo5jquVNxTq2NRR9Yn8yhqIsaJjuVmXNjTCarUoq5e5eiJDw5J6BefMcOtvelxBfZCt5ZSyW4lrM6MUftogQuDes8PL4JknxQy8VtCN0Qa543Yse8eUXR2WgKyzZrubQLtl9Q3ezzv67+R2qxgj+zLznbuJQaVTQu2zxGFEIUpAC5dfvVtS0/5yNSngBHL7JAeZdKI+Z2fab/Qy2dPG+QucXDNDMHr9iglQrA9cyQUYZD2MggCL3um+eNhjdDiScGkGX7YtjLiwfDdKZ69jkXGBSHPkWJgYZ0jwb2WUaaSeCED328bCOVhSj7KVFYU1fD+5SQmp+OrNBwljOaWxEDQ1+ZAotudbLpjQ7qxCxxaxYKc7DhzMqLGP5TVivCaqLvWOs4g4MqTR3SJbrWpU+eRolzXHqIRkmFpTWbKl5VP0YT2OQKn105AsYyetPHScc0gkOeA80wmZka+odlrmu2/hPAq+vgdYaN3+Fmgd/sPoDp5MfUZnmo9TZNQsVZVM6/AX3bmHtzjBcEI1reRi6FeibH9B+m4klETSGH9ClxrkwN1/oi7z7nLSbZCWcMKWfu/gf5lo1bWEaD5R1uM18n6vtgYm9XauYANmJ2VksiIPzGutnZNBUrI7JHL1dmbXnZtAmef3QuNjJdoLHaDbFWZNCdo3UuAJrvw6TRWFaSP2JmWYIfuVrjxmIgftbULSr0cECLH3niiPzjqRlyplgWz8/wVQz9HZrrf7WQeGZz/BM0FL/vO0WHVDnSUCWTE+MPwb USzxu/CM Tnuqa5BvGFmPNoqPYzSAGO0y7H03Xdv5IS/xxlM95Oa6SD1slUjgCN+tkJr7dot/Rz7Pr1WX/z2WtZkJVkWBatZl8ENcnNvnT6Uyi0TTFht7JChNx8FoSYMIO5dp4yf/hTft+DrUkJD5WnVDTufbgnTdQ+EdNS/ChHjyePhTBg+IS+4+x0aGkQFHxT1LES5z29gXhIbeFSGeJ7Oh2+GN16nbxrQ4KO0qVv3qzmFqRsuqmpnIyoKC+iOvgROAK+Rmns3eBw+dn+11cQSSH515ZNPiLuaPD4HGpLdmG1oec8R0AKakKsmEvph+HXYKplxq8rRNRHIx8SNemsbQaeNBorVu9HaBe7dO3OrkGSPGpvqGtCKc1LVn8LFOdvQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000198, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 30, 2024 at 12:16=E2=80=AFAM Yosry Ahmed wrote: > > Hey Johannes, > > On Mon, Jan 29, 2024 at 08:36:36PM -0500, Johannes Weiner wrote: > > Cleanups and maintenance items that accumulated while reviewing zswap > > patches. Based on akpm/mm-unstable + the UAF fix I sent just now. > > Patches 1 to 9 LGTM, thanks for the great cleanups! > > I am less excited about patches 10 to 20 though. Don't get me wrong, I > am all of logically ordering the code. However, it feels like in this > case, we will introduce unnecessary layers in the git history in a lot > of places where I find myself checking the history regularly. > Personally, I tend to jump around the file using vim search or using a > cscope extension to find references/definitions, so I don't feel a need > for such reordering. > > I am not objecting to it, but I just find it less appealing that the > rest of the series. As a frequent user of git blame, I kinda agree with it. That said, zswap functions ordering hurts my brain a lot. So I vote for the reordering, and for paying the price sooner rather than later. The alternative is reordering sometimes in the future (which is just delaying the pain), or never re-order at all (which sucks). > > > > > mm/zswap.c | 1961 +++++++++++++++++++++++++++++-----------------------= ------ > > 1 file changed, 971 insertions(+), 990 deletions(-) > >