From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9A85C0015E for ; Tue, 15 Aug 2023 18:07:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45316940025; Tue, 15 Aug 2023 14:07:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DCCB8D0001; Tue, 15 Aug 2023 14:07:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25566940025; Tue, 15 Aug 2023 14:07:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 102918D0001 for ; Tue, 15 Aug 2023 14:07:19 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7088F160D4C for ; Tue, 15 Aug 2023 18:07:18 +0000 (UTC) X-FDA: 81127120956.21.EE88F51 Received: from mail-il1-f180.google.com (mail-il1-f180.google.com [209.85.166.180]) by imf19.hostedemail.com (Postfix) with ESMTP id 9A3641A000E for ; Tue, 15 Aug 2023 18:07:15 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=a7Nk99b2; spf=pass (imf19.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.180 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692122835; a=rsa-sha256; cv=none; b=0E85RJG+bKT2N95Ww3t07ugkpG8N6DNfo+7mFjAN1EqxBZn4rRcsv9y+DWbelviCQ6oOP3 b4Ehd/ax6Dbj9SOTlNnfJtONUyRu1CW+OWJroz1lnK+QQITBATKLcdDVn1WLyaxUNQO0RB FhZWLdC9PmVKPCfNWtxpbpJzre1OmCI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=a7Nk99b2; spf=pass (imf19.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.180 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692122835; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1VPx8QGORtNg5bUCZpRkMX7Gr4rCncHGCoyJkqRF/4g=; b=dvyK428aSLk9P5uSBxkBb4wSQ5DaYcgrSIGNd+uvAHraoxP5sy2Po8Oc6xeT9XVZhsY8xi R7usgZxP9sDm1Z0+cPKL2Sy0tN+XD3gvY2D4mJeiDgNbfbJ2A8G6M7T7IHu23eOmBXEEGZ F/x/qN7U88nWKJhxko15l1XGGpl/aUE= Received: by mail-il1-f180.google.com with SMTP id e9e14a558f8ab-34aa1a16b14so8014365ab.3 for ; Tue, 15 Aug 2023 11:07:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692122834; x=1692727634; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1VPx8QGORtNg5bUCZpRkMX7Gr4rCncHGCoyJkqRF/4g=; b=a7Nk99b2Wjv/TDe7+U4g7ZdqAqL/N/lNcJx3oQHGk/kHE6JMVQkP2s9XUIjY+m4A9R 9zSnWzI7dTfp3fs+jM7AUueRIWd+6iOXz+6pW/Nm9gRvRi04osKK+eWstmb+REheziJj /R7vHX5WefZ236SmK2qXUQnbWK7OD6RKAaOMuTrKkKxPmA4OsufHyGbtuv5bKc0MDVIh lGr3L7ZYpb6THtqM0j14RLBl2iz0koU3t248teffMzNO1CLUrubDoQ8pFsja7vEF8Ah+ NvzwYffRRN6jUeNNfQS0eVfxSA8tKq2dwQaioddpM0BXvQ/k2Y8mU6FMhfuyksBwwzoJ nfJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692122834; x=1692727634; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1VPx8QGORtNg5bUCZpRkMX7Gr4rCncHGCoyJkqRF/4g=; b=kNms4hJtpta6DGT1icOJ4UzmszTcJ4WA+10A+tL9BxgXgb258Ji18jnpgRxtxEi7Xb Xn/I5wrlqhf/eI1NxC9N6PW+VwbRx12277h0PeKJxt02K9lgH/bfp3/Nkto69Kulg6V2 0b7hOwEoG1gpUnECmX54k15HzPVhLbKU41UEvSJNekiMZ6hhnWTzm0kw17vPiJHVcdjw AJ3dXIdKuhddxKv5B0x1A14uzgKmglG4dYotXhpHLSdzuSdbmWltR/ivB6mC9O/zwIjm aRmURMZ4D4HjBhF/yAaFYjF7kddDirOwfMQLBISifH1AnVSPf3ePYIUg0gsbvV5D1a5H JUVg== X-Gm-Message-State: AOJu0YzJqZZ8iNqKLxSTekVAxFWxLa4w9WY+F1uzR57+wMtuSdtFjhyr exLd5A5C+cK/sQyQQKkwSbB43Q9On+dZiSZtR2w= X-Google-Smtp-Source: AGHT+IHeLOuQP7iwwLLTQZPtYaapj6AB8sXE5zlz/r9WRsB//3BgeG3DTERDW+dm3uKTF1DhwZEmqfwIODxDuy6+48w= X-Received: by 2002:a05:6e02:2197:b0:346:d51:9922 with SMTP id j23-20020a056e02219700b003460d519922mr22291641ila.13.1692122834538; Tue, 15 Aug 2023 11:07:14 -0700 (PDT) MIME-Version: 1.0 References: <20230815155612.2535947-1-andre.przywara@arm.com> In-Reply-To: <20230815155612.2535947-1-andre.przywara@arm.com> From: Nhat Pham Date: Tue, 15 Aug 2023 11:07:03 -0700 Message-ID: Subject: Re: [PATCH 0/3] selftests: cachestat: fix build and run on older kernels To: Andre Przywara Cc: Shuah Khan , Johannes Weiner , linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 9A3641A000E X-Stat-Signature: zfrwnergy687o75otq74z9y75c4ysabh X-Rspam-User: X-HE-Tag: 1692122835-753548 X-HE-Meta: U2FsdGVkX180+JPuaDqeWS41cSzklm2dG18M0NgylCp99MY1EQGYvV0GHNMM1vrq/gHn/+MSRIay3Ij+XPJkeYX8YDnsY05CWdu0JvXH4yrV2ciQpeRvv1AxK3HOtSJ+rdQFs4jWi7S0mLMbAB/CCIXasV/NtEEFNGFp9fckdkoEC5ZISMZs1qQSkqzTseim/U8PseB4Qz+qbq9tbwo+MKkhhrCaJ1SAhiKjhbgyJWypbIMBx5FZaXmGYDmjAd2LXwE+KP28i3hIlOe7hdkCWJMgFBaCY11RipFmrFHzsd9tpC1M/YiTpZSGceHjIfF2vhrLzmR1H+/A9wp4Wz3ghRS7tap+QFhiMP+mzK0CRcAPZj6Mjzq/WajOrPd5E42WMnZ51jkrGPBlFWWjKbCaSv2LeSYCEmf/fh/106pBoJq7qM/ZxvqYUFm4lmjT0s4ujEbGgfRBlMP510hCxgrqXi6v5aJP8ndgqkDzTMeejwhxmeSkvm7RH0nXymyH7fLoSc0Qfr0MQu/gmqadfiT04Np2ORRCsyZukRfDe1QVvkJRtd4jJVbv+5DSUZyUg4Tu8sI/7hsOYlF+kZ3NY565KikcOAbDDekTK60svvDKPdDsc+lACWc640MaSaJdfNrIGcS0zCTx8SEg7r8upZn7Ue/9AXi58LJYk59vJnZlG7uJphNYMnFxDHocEitft2ulKNSx4HVvo8r9+DOneCaWvPiQozyQ+HwQ3W92ZqDDo8NRs/h3ie4xu1NWVRX4PUM+V552e/rX6WR844mGLhapAyk4NjtjRuI4Xw9QPu72ExeDYLQan9nxdZS73rTIOVi2EEgXDqYe5s7W7iPclxgDY9B4/Uk05YGUm2v1xs8AQ9r5rlJNe8J5l5l87rIdUprTA8dYa1i5MQam+KzqkmKlGON08ktsleartstjbzdOaD0Z1kuEuGoe/veMsLCeve4yYhBWOSzjpaunDdwFfcC sdNuIo3+ YpqbTb89shaX2bXZA5l7U8O2ZkATAfdfHclq3epJyeVQ9Rd07t2rTDkNLZBIbqmSEsrIa23LdeXj2VolbstG8F0xf0/mVx1f9no3MtwNjuBV3KzrM9ObLBZCamP/YF8tngWlaz+V1coZsRRgkFbdtZTCn9FKna4Mr6CgC33+nLn9cHO+aoC9S34qEOqb4/IoLQi+F+Ac793/k7l4FKA7QRuQceEn9QtSj/3z0c0k5+lQDbnrh2V0MPHkLzlHZvBpGEK7HOgODYMtXfpl7PTNvKCRHtlzNnna9C2vmtIvgyP5zJXY0g6NXOoJTPaBX70gdr2Wj4Dqhei5DG5jftEOcry3s1N06ql2DhNIIIOGqw38sp+r/NTzGulB60yDlPHyUKjR21I+LUunfXELItBZzdxXN80Bf0efDdAZ2GipR6XNPcFGDgUjeOiqh9MQ+axa3IzR+ajlW6/ir/XNOkehPXwtuSkWobUqEPat2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 15, 2023 at 8:56=E2=80=AFAM Andre Przywara wrote: > > I ran all kernel selftests on some test machine, and stumbled upon > cachestat failing (among others). > Those patches fix the cachestat test compilation and run on older > kernels. > > Also I found that the but-last test (on a normal file) fails when run on > a tmpfs mounted directory, as it happens on an initramfs-only system, or > when the current directory happens to be /dev/shm or /tmp: > # Create/open tmpfilecachestat > # Cachestat call returned 0 > # Using cachestat: Cached: 4, Dirty: 4, Writeback: 0, Evicted: 0, Recentl= y Evicted: 0 > # Cachestat call (after fsync) returned 0 > # Using cachestat: Cached: 4, Dirty: 4, Writeback: 0, Evicted: 0, Recentl= y Evicted: 0 > # Number of dirty should be zero after fsync. > not ok 6 cachestat fails with normal file > > That same test binary succeeds on the same machine right afterwards if > the current directory is changed to an ext4 filesystem. Ah, if I recall correctly, these kinds of fs have no-op fsync, correct? Something along the line of: https://github.com/torvalds/linux/blob/91aa6c4/mm/shmem.c#L4111 The fsync logic would fail indeed. Thanks for pointing that out! > > I don't really know if this is expected, and whether we should try to > figure out if the test file lives on a tmpfs filesystem, or whether the This would be nice. I think there's a userspace method to check this, right? There's a TMPFS_MAGIC here - not sure if relevant: https://man7.org/linux/man-pages/man2/statfs.2.html > test itself is not strict enough, and requires more "flushing" > (drop_caches?) to cover tmpfs directories as well. > > Any ideas how to fix this would be appreciated. > > Cheers, > Andre > > Andre Przywara (3): > selftests: cachestat: properly link in librt > selftests: cachestat: use proper syscall number macro > selftests: cachestat: test for cachestat availability > > tools/testing/selftests/cachestat/Makefile | 2 +- > .../selftests/cachestat/test_cachestat.c | 29 +++++++++++++++---- > 2 files changed, 25 insertions(+), 6 deletions(-) > > -- > 2.25.1 >