From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64F5EC4332F for ; Sat, 31 Dec 2022 08:36:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C9378E0002; Sat, 31 Dec 2022 03:36:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 579718E0001; Sat, 31 Dec 2022 03:36:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 441718E0002; Sat, 31 Dec 2022 03:36:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 343208E0001 for ; Sat, 31 Dec 2022 03:36:05 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F2B54140353 for ; Sat, 31 Dec 2022 08:36:04 +0000 (UTC) X-FDA: 80301943848.17.5E7C8B8 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by imf23.hostedemail.com (Postfix) with ESMTP id 50DA8140008 for ; Sat, 31 Dec 2022 08:36:03 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TJUbR3uu; spf=pass (imf23.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672475763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xRvy8oO39JOzDKdsh3QNHLbIdKU2kzaSMxLVfuymv7s=; b=TO8ce+7gD43nqD3CtbZnTW0sNmBQXH5e8xQRaYS0LWjlxQXIA3VT+K2TMQVuIhde4braCq MILRGmbSCYbbM3mAtFFcJnSwAuR515rL4Okwpzo3vnvMSAKUuuhPJa3jPlu+DArMih9B1j wMvFW9PZ4AW7gtVPsM/RJJ0yRbFk0cA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TJUbR3uu; spf=pass (imf23.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672475763; a=rsa-sha256; cv=none; b=DkaKX9e7gqwr7t5jRwx9v0VTVvboz9g+EyN+79MYM/hviJWknnBy92IRv58NvNXRyuA3kk A497HJ0iqHTpLBCZf969k/Ld0GhKhkLKvPzBLqOj39lb3ZsBAdG1lj5jZ/GJigfpgM8Cy5 w6g0LPhpn9pCswfktKRH3CM5RlpcRV4= Received: by mail-wr1-f46.google.com with SMTP id bn26so2515639wrb.0 for ; Sat, 31 Dec 2022 00:36:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=xRvy8oO39JOzDKdsh3QNHLbIdKU2kzaSMxLVfuymv7s=; b=TJUbR3uuauG2QvzeiFsk1SaHBP0WD5E5Q+HyTFRWqv6cMDsWwj1IY4lbDg0guZJkBz nMrSRHr49wiz0ha2FOPb5WU4DGaVPJRYIXDUunrUoJWIgKX1uOOY0BIL1fE06rn2VNHT uILGC6p7RbiIixd1d0jQubpB0t7DPysjEIOMqvyqxlKeunYJyU+koHh3WZ9qoTQh+quS Wtc5TKwmCqgdBkjRVEkeVkV9CBSxa2jfTQWXU6T0csUK/S9IoP7wdl4BCUwNpoet7S34 uaE+C1WaUHwq0n31BzcIgKUIHIhgoAeeWIAaMN/ZkGPAdRIgcIouS4N2HHKsgyzibRC5 nA8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xRvy8oO39JOzDKdsh3QNHLbIdKU2kzaSMxLVfuymv7s=; b=fhN4CWEI0+yFvTGUHMve7DeE1l2/OyKdNFps3xwFpnrrk9nSd56A8770tKKyNKad64 9/zGN+0kLB4kmS4TVndks8iiROUDG7w4ZtYjsiTnFOMKk9cGA6kCuqe1P+zXzwT2XLlV tj2c+yGUxQqJmm3Q/ySs/to6rM3QwqrLz+If/aWUk3liAydXQsxESnxzfqChiHQyosZJ CDT/3Ui2kHXjTcCfBM9pW6HZ19lAceFaNpT0U8paph1C93K4HcZlEt7okKGUK0R8X+Ec 2I7Mnbutr8wV3FwSJjmxFWGE0eSWSBFFlDgWFfcVGl4QlmC00o9BONv4NXLuEA2IxrQz z8qw== X-Gm-Message-State: AFqh2kqeQKItGLa6OnKe8HU9+2lB6NnP6sqYPOXCq88QTkBtFT4M7k78 Z4Lc9sLVQgTHL4OQB9pDTDj6o/CoQaTYAiRwkEc= X-Google-Smtp-Source: AMrXdXvSdbIabREV/E2VrX0Gcx4yCE3QDQBhrdQaoKCgIT46j7qIN6+NkGwYwAqb5nsibf+LfrWXyMehlB6B0SxPZlw= X-Received: by 2002:adf:e890:0:b0:276:70cc:7b47 with SMTP id d16-20020adfe890000000b0027670cc7b47mr1242913wrm.131.1672475761713; Sat, 31 Dec 2022 00:36:01 -0800 (PST) MIME-Version: 1.0 References: <20221216192149.3902877-4-nphamcs@gmail.com> <202212170645.rxqFnDky-lkp@intel.com> In-Reply-To: <202212170645.rxqFnDky-lkp@intel.com> From: Nhat Pham Date: Sat, 31 Dec 2022 00:35:50 -0800 Message-ID: Subject: Re: [PATCH v4 3/4] cachestat: implement cachestat syscall To: kernel test robot Cc: akpm@linux-foundation.org, oe-kbuild-all@lists.linux.dev, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bfoster@redhat.com, willy@infradead.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: yghk94uotu8y8dakmqhjrmeoush6y8p5 X-Rspam-User: X-Rspamd-Queue-Id: 50DA8140008 X-Rspamd-Server: rspam06 X-HE-Tag: 1672475763-998840 X-HE-Meta: U2FsdGVkX18LkaKRJ1WxZL1GnHBFsV68+KE4Coyb8vtT6p9Zl6lRUqXmooF6EQHmB1OusH+uBdcr+/axj9nq4fD/EY6DLseq0LSL2U2fmLSwm15FTMeQavY9dmFSLNBGfACGuPH4tUQ/FZY7uyW4+ZlnDJtosBpaWYERM2jFORes1eplhFVn4xpHAakLWCweeXTWeCqhiOfhOVo0SJKSm/mbQG2EROpowKW/dWq6bZUl7L99M1sXw2NIe5Sl94gNoR51FAPg0EDVP1JHOiczqh/4uOLsFRxD249gWPxwG8SJZCX5an1uJQVDyzcBrjqlu/u7E7m1rriQ0Cz21DBQy0Wadhc1reRpDYuForwcFLP5X8nYj6E3ObhViacseValB+ZHruT0YiuXCq+wLMSdKHr8YHDSmPBvlBpuDMo52PdALyOo+jjK2Fs2OGOJI7B3KUuvI5bLVS9ltTK8YAHO8kQwyFwz6fTRd6YKQc1u2Xr3tcNBoy9ddXFESTmsb/kZHqwO0OZy3pp9j14OAOSNQQAgQijn7pxQS9n0Qh/bUCSh5Irj7Yk14GKe2OTwlFaFUTLgz/JSo/9cEemtVz3E3Lt4tWBlaotfL023VbYiUI8nYGEIi5WDiqC1nGv0MPd/HYcEzRcNcsODX1/zY5cAjGoGuZgTlIacZFLxK3qEOfaxrhikMGTiLRSRoITgd778FkjYztEgldPW6QSZAqtjljQ7LWsW7PgbTfSm9+b60W67pOdw3fWGQcMtziR7FzElWGyKt54sMV8d61Lf1phlgBKncuSxzsmzi1tCJ1CAgo0ESp6RhnzpZ5rX764fdH0h4oYw+rScOmTj8cNsGlDfqbCL9wEm0/xXspAXdicqDi+ow8DKSw7nAxzjkYCol/fkMGuRAAsERHgIFSb0QdtkhaW7VyRLqQ/nsBCfpMtDO9c/4gyxu7dVyBdDzQFVopOitwEJToty/ZLgzrf/bpf k7QDjh3G 85un1t9WhS/6mOtCsGy40Y81KUAmT8NeEhTZ5NTMqePmDeIIsJ+xk5OeYaQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 16, 2022 at 2:27 PM kernel test robot wrote: > > Hi Nhat, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on shuah-kselftest/next] > [also build test ERROR on akpm-mm/mm-everything linus/master v6.1 next-20221216] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Nhat-Pham/cachestat-a-new-syscall-for-page-cache-state-of-files/20221217-032254 > base: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next > patch link: https://lore.kernel.org/r/20221216192149.3902877-4-nphamcs%40gmail.com > patch subject: [PATCH v4 3/4] cachestat: implement cachestat syscall > config: s390-allmodconfig > compiler: s390-linux-gcc (GCC) 12.1.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/85fdb04584b3d9a3b90d2c63794ec65e8d996b18 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Nhat-Pham/cachestat-a-new-syscall-for-page-cache-state-of-files/20221217-032254 > git checkout 85fdb04584b3d9a3b90d2c63794ec65e8d996b18 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 olddefconfig > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash arch/s390/kvm/ > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot > > All error/warnings (new ones prefixed by >>): > > In file included from include/uapi/asm-generic/mman.h:5, > from ./arch/s390/include/generated/uapi/asm/mman.h:1, > from include/uapi/linux/mman.h:5, > from include/linux/fs.h:49, > from include/linux/huge_mm.h:8, > from include/linux/mm.h:737, > from include/linux/kvm_host.h:16, > from arch/s390/kvm/kvm-s390.h:17, > from arch/s390/kvm/gaccess.c:16: > >> include/uapi/asm-generic/mman-common.h:16:25: error: expected identifier before numeric constant > 16 | #define PROT_NONE 0x0 /* page can not be accessed */ > | ^~~ > arch/s390/kvm/gaccess.c:493:9: note: in expansion of macro 'PROT_NONE' > 493 | PROT_NONE, > | ^~~~~~~~~ > arch/s390/kvm/gaccess.c: In function 'trans_exc_ending': > >> arch/s390/kvm/gaccess.c:516:17: error: duplicate case value > 516 | case PROT_TYPE_LA: > | ^~~~ > arch/s390/kvm/gaccess.c:509:17: note: previously used here > 509 | case PROT_NONE: > | ^~~~ > In file included from include/linux/compiler_types.h:79, > from : > >> include/linux/compiler_attributes.h:223:41: warning: attribute 'fallthrough' not preceding a case label or default label > 223 | # define fallthrough __attribute__((__fallthrough__)) > | ^~~~~~~~~~~~~ > arch/s390/kvm/gaccess.c:515:25: note: in expansion of macro 'fallthrough' > 515 | fallthrough; > | ^~~~~~~~~~~ > > > vim +16 include/uapi/asm-generic/mman-common.h > > 5f6164f3092832 include/asm-generic/mman.h Michael S. Tsirkin 2006-02-15 9 > 5f6164f3092832 include/asm-generic/mman.h Michael S. Tsirkin 2006-02-15 10 #define PROT_READ 0x1 /* page can be read */ > 5f6164f3092832 include/asm-generic/mman.h Michael S. Tsirkin 2006-02-15 11 #define PROT_WRITE 0x2 /* page can be written */ > 5f6164f3092832 include/asm-generic/mman.h Michael S. Tsirkin 2006-02-15 12 #define PROT_EXEC 0x4 /* page can be executed */ > 5f6164f3092832 include/asm-generic/mman.h Michael S. Tsirkin 2006-02-15 13 #define PROT_SEM 0x8 /* page may be used for atomic ops */ > d41938d2cbee92 include/uapi/asm-generic/mman-common.h Dave Martin 2019-12-11 14 /* 0x10 reserved for arch-specific use */ > d41938d2cbee92 include/uapi/asm-generic/mman-common.h Dave Martin 2019-12-11 15 /* 0x20 reserved for arch-specific use */ > 5f6164f3092832 include/asm-generic/mman.h Michael S. Tsirkin 2006-02-15 @16 #define PROT_NONE 0x0 /* page can not be accessed */ > 5f6164f3092832 include/asm-generic/mman.h Michael S. Tsirkin 2006-02-15 17 #define PROT_GROWSDOWN 0x01000000 /* mprotect flag: extend change to start of growsdown vma */ > 5f6164f3092832 include/asm-generic/mman.h Michael S. Tsirkin 2006-02-15 18 #define PROT_GROWSUP 0x02000000 /* mprotect flag: extend change to end of growsup vma */ > 5f6164f3092832 include/asm-generic/mman.h Michael S. Tsirkin 2006-02-15 19 > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp These build errors (and the ones reported by the later kernel test robot emails) seem to come from my refactoring, which adds: #include to include/linux/fs.h. Several other files (which chain-include fs.h) also define several same constants elsewhere. This include seems unnecessary, as I can just replace it with: struct cachestat; This should be fixed in the next version of the patch series.