From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1829CC54E67 for ; Tue, 26 Mar 2024 21:57:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C72A6B0087; Tue, 26 Mar 2024 17:57:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 977906B0088; Tue, 26 Mar 2024 17:57:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F2376B0089; Tue, 26 Mar 2024 17:57:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6CEB16B0087 for ; Tue, 26 Mar 2024 17:57:22 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0F8CE1A039A for ; Tue, 26 Mar 2024 21:57:22 +0000 (UTC) X-FDA: 81940551924.02.58E763A Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) by imf21.hostedemail.com (Postfix) with ESMTP id 333001C000E for ; Tue, 26 Mar 2024 21:57:19 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ddo0z7q8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.43 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711490240; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jXtqhW7TrzvsAEXyOy5z64mjAY/B+CgwYFFgZL+QG1k=; b=rDgJfxVPAZxbCh6lkgfpCp5OJ9DjADLfGdGXf1reMAzjgNZ+8y5xBu0ZczyovYpEN928c6 vqvkp2yBbn4+/veXgh2mNK+VS80AbB4c0GIFic0Kg1uiYUPRfN709OVdSOsU5coYZ6OZaC eR5OdLbCYZhL+Ew+mBQNvffB3cy7RrA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ddo0z7q8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.43 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711490240; a=rsa-sha256; cv=none; b=yB6nqNrHEdCZ0Ig5RP1OpGM0oSj1X821aA77MWudIc1x6ZD9+t/XpyRc3fxVWSNFff9BLv P8YGEdjhUkRbzNcImX54pt2JFtzqX5XbS4ZCdaMXvqYFnQT0BMt2z8uy3YeyNjlt3N6i92 p3snInsCHf3fO64o0aJx2VmL2bw0u/g= Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-6962e6fbf60so57325696d6.1 for ; Tue, 26 Mar 2024 14:57:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711490239; x=1712095039; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jXtqhW7TrzvsAEXyOy5z64mjAY/B+CgwYFFgZL+QG1k=; b=ddo0z7q8Z26B4RNkaGZtyu7vQ1nwxRq8/B0Zz7N1pshgyLSya8rpjJuenLiRMR+Tfn CaSkdsbzs+m0GMWyoZdNQo6pJ/FN3XnPd6c7Slbwnz+G4mtwvAwnQV0wvEWHXuh6Qtei 8sT/E3ScEdCDYfWWxINukw8EAPbJI5hupodpIon9HJuw5e76er8EoSFAf/V9NUAYPAik BoHMfVDstrcI1rpAe1VUbAVFugLtrH2Rs6Qap4eQ2ofql7t9sE+YMB0oCesCxN6qJ4n+ 9wZzjsdk23UkrBDHSMNUxpYcI2Qw/r/6+40OH+gYHpWfRxKTcjxX8VGN2HKtQrfG2n8F 4UZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711490239; x=1712095039; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jXtqhW7TrzvsAEXyOy5z64mjAY/B+CgwYFFgZL+QG1k=; b=I2k/o+2cRdMulmS9VASe0wFnw2NXLchP4I8LepkTk3/n5Qrrg0zjmPoWh2SGeqM5VL nxCA9GTzrlfylIGRjLnB8LecesBK4j4FGMzmJBSb8Kdky8CIpq2FUSS5QZNAR8II3log wNLFfNorORjqaD23ZSRpmJPm+cQSg9/vvNtUZsOZD5kSzJ4o5pZb/mTrgwNOvpVtds2U 7iXWYZAxsOo+hUf902XhkrSTolUgiQjSDTPsuGbXRc4uT2mBuvqrg3g0R8N7agASKSeO kzvuXIUOiMxxpSsy4Q0BtsN6TdHavIA+pnegPN0wH5ds9DcvjU77ZPZWbblBcnCQGGDc ZCYw== X-Forwarded-Encrypted: i=1; AJvYcCVD9ztGpykMpffQ5AgvWy23CSbTNxxj5MuDyV6ByHauufxNViRsODHn45UM3TCdPiVbtyloNbCMYsXVljRtcf8PXWQ= X-Gm-Message-State: AOJu0YyGiwmlx0itfKivL0nRoMhAVJXFOBr+WuYSnNy+OkLBKA30p80D 9S6Sgc7TxcGc6bCTQd2Pn/PzMUPsOXDDKXoIG2xz3GFUh47sOc39SVZgIILlHwGi3Kp4H3pNC91 BgukOyrvjQC8dZYD5Ca2dRssV1aQ= X-Google-Smtp-Source: AGHT+IEwiQs8QUTSm0qtv3eRNdV07njB0FxU7nx1qsSrehCl42nzo+21HWXDQRIfFt2zmjQDPEa3/s/mlqYLF3/K9YY= X-Received: by 2002:a05:6214:e65:b0:696:76bc:357f with SMTP id jz5-20020a0562140e6500b0069676bc357fmr1124376qvb.6.1711490239244; Tue, 26 Mar 2024 14:57:19 -0700 (PDT) MIME-Version: 1.0 References: <20240325235018.2028408-1-yosryahmed@google.com> <20240325235018.2028408-5-yosryahmed@google.com> In-Reply-To: <20240325235018.2028408-5-yosryahmed@google.com> From: Nhat Pham Date: Tue, 26 Mar 2024 14:57:08 -0700 Message-ID: Subject: Re: [RFC PATCH 4/9] mm: zswap: move more same-filled pages checks outside of zswap_store() To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 333001C000E X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: zi3i5ka5r8mwksisx3nyxfy3ac7fh6w3 X-HE-Tag: 1711490239-962345 X-HE-Meta: U2FsdGVkX1/EcU1/+zK5j8fZuZ20nnnbVGBdeWG4cKAkSr50H4oycl0n5AN4DvAH440YltfpXodFulm2/QEpn3hMb3rgfAUzKHF7S/KK0s3KBQslNBYKBimpryaX9cqqB2AioO/2kE2yFAvIWD+5bZUE2c/XoY+E1guZRMwRkZPysk8p43stg1iwPSr46FZiQCAEaCdzFHG5YWHahU9C1X0ozuwSZa1HkDWo3PYAsjFd3i5EbjMwnrb2f5hZ6CqU5kdza7ITE447/n/t7a8vY7NsqfL5a94B5oLok5+JKy5H5aIyuc/zMNjjYPyZ6VtZFbtNXY8+Z2fixBMdk+WlAcqQV8cQ1ipyUThyOSVhJch2qAu1u6GrwMz5duZYMry7RKfprN8YfJoGS6273SPoihHSavf0kdEx2eN8XCQc4nb02Z4S05xIe6RJkoXNZtNtg+kkHgLe6G6gCCdVaBZ/KQmm5ow2wXjsizujQNvGxMs3eYaFPcs+qmZlOVq1/zqHruFc5AGJs8x5nfiUMO0G84oXax0dkr16V5YJvyZXE+OcxoqS3kGStCH5eWtyraE0pAEDRVxioFKcmTPC057goyCnLo1sWtV9vFRTrSKE8CUJGJw4+nU5M4eWkntcn9n5l9KK0SNUGjtsPkunIbYja9nh7a1X0oIsCRCmv3InkR19OZJhJ2gtV17vJ3PTi6U1Em+8VWzjkjf3FM0cgT6J4RXfMmhRszpnTFmG+qwdbMpNyKdXlFZ0Bqa9FTuFILJfrz9wV9pT+DqYYKf7ytZMfsvdWizWklUDlrUljIFBvQ7j3zetrKcMOaNUugNprapa5ro5++gQIWVxFmQVQ/H6b+y+wKf/jvh+QgjJDHInPyARzt5yMuaiQLdaPV682XdOV+Vao4bU2KMYWAiTAuakGsIzTJpSj3KD1VolhwvT+scKsVU31uRwq34UK0T3ZJoMBeiXBxxH9lTZwQN4zxV EgMpkNd1 P00anHQvhgAj+wZ3kXNtcZEplH4UKGs3z2QFd/aR9KdKDb56GWv4RpdFG6yE2OrZIi9YMcGP5DvwKAoyDdvnLZN2lfIdDQrvCXiSXp5fti0ZR6vjzYrBWPczJ6bfLQIDHuCt19tb3gFwux0YUUrPYLUf7j16HWjR/bSHK0QWlgH2Zrgmhnj+xj/h2VDdqsV4qCrD8D+NxJ005RKTb5P9FOk6z3Juxh9BqunEK4IvVGfb2Jcqs7Cw5+SUuM4O1Mju4zFnp3gJI8si5I5dC2bKryKaTI8xtRFUwBZvk7Npzd9s6KzzNB48aOq4+a+qRUo5YqKCEdDtA3Z/I5py0sO7lWfl0rFbrd9dndijTtbPX6yFT1Wkc5XcGVSIL3lNytEkhCOKvbYg+JWfzx4Iplvts8HP7GwnxoNUYl1ktABRMtRcFTGRQyqHJy3M05AmCOfiPWA+I X-Bogosity: Ham, tests=bogofilter, spamicity=0.128428, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 25, 2024 at 4:50=E2=80=AFPM Yosry Ahmed = wrote: > > Currently, zswap_store() check zswap_same_filled_pages_enabled, kmaps > the folio, then calls zswap_is_page_same_filled() to check the folio > contents. Move this logic into zswap_is_page_same_filled() as well (and > rename it to use 'folio' while we are at it). > > This makes zswap_store() cleaner, and makes following changes to that > logic contained within the helper. > > Signed-off-by: Yosry Ahmed Reviewed-by: Nhat Pham