From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D3D1C3DA4A for ; Fri, 26 Jul 2024 18:01:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 78FCA6B0088; Fri, 26 Jul 2024 14:01:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 740CA6B0089; Fri, 26 Jul 2024 14:01:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 607726B008C; Fri, 26 Jul 2024 14:01:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 40F4A6B0088 for ; Fri, 26 Jul 2024 14:01:23 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BC12781A17 for ; Fri, 26 Jul 2024 18:01:22 +0000 (UTC) X-FDA: 82382670804.26.2043F5F Received: from mail-oo1-f51.google.com (mail-oo1-f51.google.com [209.85.161.51]) by imf13.hostedemail.com (Postfix) with ESMTP id C21C72000E for ; Fri, 26 Jul 2024 18:01:20 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Rx9Qpy6U; spf=pass (imf13.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.161.51 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722016855; a=rsa-sha256; cv=none; b=nivWc+beUVVRARwLIYadqgQdQk4HQlKqvhvPe7OcDgqjtI0SUkJwa7WVIkwKZRTM7tOY4n HmuBCLgN9I4lCm3WTq/3NVbFo7QlmW4VRJZZ7R/2x1UR1uu1kGQ27LpqMuUnH/GRIcTTaJ aSY3rPuBla8Hyk7bjJnBOvY8vgDrLSE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Rx9Qpy6U; spf=pass (imf13.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.161.51 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722016855; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L+auiNf+E4D1L5wzd1qHZcU7FzCvtKL9Bh94+xJW/r0=; b=CwOi1h0W0/viGJQHby1eb/e0P05s0se2sXYAAQk83hYW779CanKUBgrMtXg36qC0DxBSur 7YU+AM+zPG2AunLPz283ruSIFxsSS/kwlYBU/3E2By1WcUhPzQau66eMJJT+aVBlreRVDz 7QcAdfTXwPFkHG9w3w6SaTFbcHH7Mak= Received: by mail-oo1-f51.google.com with SMTP id 006d021491bc7-5d5c324267aso642847eaf.0 for ; Fri, 26 Jul 2024 11:01:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722016879; x=1722621679; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=L+auiNf+E4D1L5wzd1qHZcU7FzCvtKL9Bh94+xJW/r0=; b=Rx9Qpy6U4NppieKovM6YHTvlFTy4Jj246q35utf49fdgAhvMgY7kOhyPEdHq1l3YsD vgk5+iRYJio+dhRDg4AL79Fgs7Np96htn8THpsI6x9jXhlLEOyl7Onf2A/CgUYRK8zjN mtRVbbLDn8rwgYAzY/nXp4Q/69aX+zxJYXvkCNSmXARuzxsq6J/BZ1ZbxRNnHpC5a9rh a2aof8l5Fefk404AlGiPdExmM0A+ezYLotx71r/haAsh/gLgv2dOmSdB24wIeXumO71K xPETP0nqas18dfrIH9bOZnHt3XmXNZBxLf2Gx0Wr83T/vUQXve3qyFe3DWVpJAGd40ER Hd9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722016879; x=1722621679; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L+auiNf+E4D1L5wzd1qHZcU7FzCvtKL9Bh94+xJW/r0=; b=GdWHsCe3hvdQQh29WeyQachVeAuzwJ2jBYU6d2SlXwCmcjIRoa7MAherTi6Sj2VyvM BQZOJdhINoUXuU/+3SlQUfbTkv+VA7ZTZyKxwhDvZR8KvQQpvqairGmIAHSVViSbCCJC 8yXbMNsNFu9WHEE/N8r81QgKU2/nePaCTIQONr9ziEg6PRUq/+0xjMnco9JEuWuhuqIP 6kdeNBeHkQMi9V3PXgs+/p//2ND/IXiSfjLnxLsERPaYeY68wLQhrgaAg+LQwHf6K3G/ 18ZZ4vF+xRrewSrDu2Rvy/Ei4gQdm7b7AIM1BX3qi+dhDcyvGMXUuvZrHw5NHawN9Jpb p6OQ== X-Forwarded-Encrypted: i=1; AJvYcCU+V1e39L6dCpPVmXKha7JOuyD5sFeCso1DNms8Ut7NQx5lpFP24BGlDzEsKnaULu7pqfm5XiKUyA5cC/vcixtJezE= X-Gm-Message-State: AOJu0Yxc1d5wLLaF0+T9KStZJQYB+kF9aDPFHek9IWwD9+3NpvJaXRpl Eh54cQhOxh225tTyRcKWkNTwM6i0lCtkT+uXoP7jvdnFHtw21F9DzD9dU5fLiaySeDeJU1NrzTC MoQ2hT72eb5aC0sz41jWJyH5PoQY= X-Google-Smtp-Source: AGHT+IFJAg9qrZNLPTPgo0th1wrNemU1HEUei5xN+NvA5Ij01oM32yj/xZEJW+sawPDEwEq5xAsgwFxEAd/Pa+vxbJI= X-Received: by 2002:a05:6358:5e04:b0:1ac:ed54:224d with SMTP id e5c5f4694b2df-1adc06b2124mr58860355d.11.1722016879323; Fri, 26 Jul 2024 11:01:19 -0700 (PDT) MIME-Version: 1.0 References: <20240720044127.508042-1-flintglass@gmail.com> <20240720044127.508042-3-flintglass@gmail.com> <9ac88791-54e2-4f7c-9171-5a1d44e01657@linux.dev> In-Reply-To: From: Nhat Pham Date: Fri, 26 Jul 2024 11:01:08 -0700 Message-ID: Subject: Re: [PATCH v3 2/2] mm: zswap: fix global shrinker error handling logic To: Takero Funaki Cc: Chengming Zhou , Johannes Weiner , Yosry Ahmed , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: jduyfj5y4cyue9mdgmtzu6h9k8zk1xur X-Rspamd-Queue-Id: C21C72000E X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1722016880-433455 X-HE-Meta: U2FsdGVkX18SriyZal0DXc45srPc5kvPu90hQDC7xfUYG3QmJrUs7gdFgeROu6GzQubD2qL3zvuDBPmBHVe8g4MsZls+mmaJ3WFNiMpFBSf0xzRPgl73JkHI7VquuedC20QHO6Rjrv2YrmxQmmRb972LtART2erWGmsh+IPuHJrqPw/o2jjwxi9cH+CWOKzIdO1fSISa2etcJ+iXRJHg1cC+tqv6vWY/3FW7ysG+brIYhF05nynm+iLI9HBrOIamRHJgTfROgJDxUN3uoN6aB/wbuvkFjKgzhNdfQh5ejqp0xVgAQ508PG+9eC9Ciq6SGC6NcNWq1CmGUHBIYOVc7sooz8DYbCuz9kxalAQLEO9BJ0+siFlzVFuGnnsKGHu1mINP3SVm9lgvbDbBfaQJrgKFQmH+6Rij+k/XmO/xEepu+7FeuSLuEwwzGVbXSSg2j6KZCUkh7XgC/M1vtBWg6hhTvAIdgVDyOoKdnp2HqU9JNM7U2hg32AB6T/uq92RMm8NpZQ5Npa4TH4tPgS3XhbiUrKNsgXrzHK1ilpwPMaOVYNSjIyVvGowHiGQNEI6mHtgUAwFwS/mscxp3VNjwL+MBPkiM+WP6Vb8Nxu4QhSk4JFPLlrwP5CFsCWJYaM6E9E/+oaYnjHUWr18AfDj4+DKh09I7rB8G1Iux1UDHEMOxtx32O8E0qJXXDHQBfLPEIanL3G/+8oSaQ/ey/2oIYc9W5p466KACbJSOVYk3+IEVYSg5TvZ6y7kJx7L/fF8UgFYPlnwIL5ZKZdaOVmU3ZqqmmoVEx/5cWtNlKXSp1pmGgwttVicw2B4Po1aiaxnK45MCCse++fn5FCfFRnPNX/KqJtxYlYqQhWoL3NKDADxO/yUp7jO2QunFTy9WW2Jqcgyo7ef2qinPp3sgCiLCAnC2vNDQEW3zWssqODptbAyqU03jggBzVDreeatsjMXEKkmKal57CSpRFC6pk8e 6KERZ/tc 3FPAYs04+0qu1BoFCZcnmzlrbb3d6K3aRV+Uq7yzJflRHncbgxHHMSssQJKWv3jpiyHiv4Foq235IlYfThEiMiYXkkJxzQxOGd3AukFrHYIsICTsrILSXUcNAO2C0+yKXxFinUNYETeoxwfF9BAA+q5qxnCdTBKGgFipZrXZJHce9dyA6TRzWcKUzQxsueREnHssgeNCnMUhaaSwJUKd5tsCe7usZ3u3YSrRa2/phU/NxNY7NONC/T3md8KBMouFEWUytLOea4Vlq7zQ2eAvCtYd/yjmQJ60FLzpLYHgBUMp/kXXWHfe5uEHslS/1KZeaDMHtnGyVULKrlnL0/Dg5Pa+hurBbQEZ258oKGSJGvpvkAIxEPPBtSJtWCA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.015475, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 26, 2024 at 1:54=E2=80=AFAM Takero Funaki wrote: > > Yes, the `++progress` counts both error and success as an iteration > progress for valid memcgs (not writeback amount). Incrementing only on > success will overly increment failures counter if there is only one > memcg, one from writeback failure and one from tree walk ends, the > worker aborts on 8 failures instead of 16. > `++candidates;` would be better? replacing the name and fixing commit > messages for v4. How about `attempt` or `attempted`? Naming is hard :)