From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A873C25B7C for ; Tue, 28 May 2024 15:18:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD86A6B00AB; Tue, 28 May 2024 11:18:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C896F6B00AC; Tue, 28 May 2024 11:18:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B516D6B00AD; Tue, 28 May 2024 11:18:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 965C76B00AB for ; Tue, 28 May 2024 11:18:39 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3E60E1405C4 for ; Tue, 28 May 2024 15:18:39 +0000 (UTC) X-FDA: 82168161558.07.4CE7F3B Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by imf28.hostedemail.com (Postfix) with ESMTP id 7DA0CC0013 for ; Tue, 28 May 2024 15:18:37 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OsREd2KJ; spf=pass (imf28.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716909517; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DAI4wTRONpyDHoevO45KRBaZnNMth7l2XRIcdvktxRo=; b=B5cdqzOcV6C6q1JtG6pRbeLK5usp9GvJqugRaZ3myGuLRqUpEXIs0BqJuVxZN/OfqyWf0U Psz3CqzvYvwaO2zxFtjfTcNj6tqGbugMWaKtm8EKXM4Qdw4ibyyPVHVzMVl3NT8Y+5lsgM X59e5ZVEcWRdaMfdq1ixKO4fA17xMt0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OsREd2KJ; spf=pass (imf28.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716909517; a=rsa-sha256; cv=none; b=bY2O0csdssHhSAonPAJF8qlSEHM3tflxk/ld2l3m1ZSCYmtIuKShK+qCW8y4ivkmlmTdMY M9M1xvpuWYH/c3Bg1TM+vI/tKfD51uT0Ab8CdSxAgTGxmP7I+hyZWUUqKzjO04j8mlTHKP TBDO0JIvPoiC/o1MiuXd4eP6Iy23QEM= Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-62a0849f8e5so9104957b3.2 for ; Tue, 28 May 2024 08:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716909516; x=1717514316; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DAI4wTRONpyDHoevO45KRBaZnNMth7l2XRIcdvktxRo=; b=OsREd2KJ+AxtUUrFFvE276OoYJb56lj3JevmBXV5nrEuo7p/3xbf6Z34SRJNyBCw/c Cv1xwJYD7ZQXKEumslZ/nKD3NuDmj3FT+K9AGEH8pV9tJsaHftmsvC706nEod07rbY9V Zt4P+dA1TDbv0G/Oot6jx90cbrW5YvtuLNIWBLMcDOZ9UEVrIgVpfmzRYoHNR73KfCwk TvKCedE+HAEU4YqqTlePTvWd2ee2fJFt8MKciHpq2ZqgGXoyBtizLYkNFL7Zqf5L3sxt At7XE/8v+hEWsKLIh6x8TvHQ07VQBA+03H4lJI04DFFv7tpNr6117KusW3x57zPPl3t8 GgBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716909516; x=1717514316; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DAI4wTRONpyDHoevO45KRBaZnNMth7l2XRIcdvktxRo=; b=NYbiTufFhFkaeTSKl3wln4GVHiL/9KaiCepRLDIagp/34HZG7LXqZ4OXLKeN/rPS02 /8eIln7Mv/TfhcLr6Hhhf+Ih2Xejq/Aj4JK1/iNkXhxivz0a/Qhgz/ntzPZ6ZS/g1y7g H4ph5VofesE/SV5oF4vSuMa/Hd+CoKZ3ar95SoahIKD3Cu6qXzjonGYUd0kBIYjFlFMg LCNfhji7zx091X2nUp0uRj+scNRC11ZFxCO7U8sxrVyjranwx0a2cYf5HdJTSp8Rlj2Z 3GYaeqA+EOF4fV7qHXTAwDnJ7kmL4ZgbmGYEcDsaoM77C4ivwF939iJE/XGrQOD5dhqC +0hA== X-Forwarded-Encrypted: i=1; AJvYcCU9S9nU/TedSSceSweQbtmzX0pbUN958AurxSpKYIQZBLF+d7FnS+fTqe7TP+GWkOIACSm3ahm97Cp/29ZuYC3DvDk= X-Gm-Message-State: AOJu0YxgmEvXG3mCqZHcw1rcVU9QwySpHywzNwURuR2b9MPBGtd3wmy9 h75PRSM1h2oASrJN0TmKF3+IQF5UvuIcovcnyPaQUZ5KQ+d2hTKSgP5znU7HZDk5Ki0zV9AoiJP j4xZahKMWW/G5PqTHSlO3pjRIoZQ= X-Google-Smtp-Source: AGHT+IELtNmAiYU/zHmIId16l19GazG/+CIjmGuOlJuak2gyzWubpM5Tcakcb/jM/SURpKaxrfe74i7P6YqLO60kihY= X-Received: by 2002:a0d:dbc2:0:b0:618:1dab:2f0f with SMTP id 00721157ae682-62a08d59be1mr122427817b3.2.1716909515011; Tue, 28 May 2024 08:18:35 -0700 (PDT) MIME-Version: 1.0 References: <20240524033819.1953587-1-yosryahmed@google.com> <20240524033819.1953587-4-yosryahmed@google.com> In-Reply-To: <20240524033819.1953587-4-yosryahmed@google.com> From: Nhat Pham Date: Tue, 28 May 2024 08:18:24 -0700 Message-ID: Subject: Re: [PATCH 3/3] mm: zswap: make same_filled functions folio-friendly To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Chengming Zhou , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: theu4xuwsdzgmw1kzkdipn3oq4bt9jcm X-Rspamd-Queue-Id: 7DA0CC0013 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1716909517-500529 X-HE-Meta: U2FsdGVkX18U2Baa+xgNxDyQuykpo3wLQFDDiK/wDvXGQyfoPWU15kL0Ca67EuXDwTig6Dp1kqfY+sMAxZ1QwuObFYy8qCzY+XBO/e5mcQ5Jm+dO7MIAT9x+atJLN3xE+eLTyNAZYgXONZJtN0I+zBLlrJeoEz1wZaskEi4ddohVrh6PEQRHZ9WQCGu3flNK4m4SffB6uwVdq5Uk/2Z7naa2KpFWaOqe5h56hC60mnZXKbVdIP9LdMnL5adPFALq9lu6uwwe/N4ISUriB12Y+YGmje4VAQNRQUfS3ivhdyYpDdoxkuW01oMqyaKi/qsfQbwvv3EHNahEyNB4MRm2qT/h7IdeoceQjZeCnDruffBOgVdHp7pzagndNeSZseWR2eGhXazqO8yeKQmUJQgUiS2XEP0DUh87B8K6liRK6CjeQQYlENIgEHMeDTLCA1UPQDPfvXibl8+M9NTfqSF+s0CihHS+t3cwF5gdOoVB/UO/whbLgLkXQGQCDpjuHmvhqdTfwDOQHVwwp7a0E3iQFTVw27yFY0spmrpqeaf4q1aKecZzuX/k93G4KoGxg54moAvHZ1kv99gX/TUD2Wg45dKRoQqeA9zHSuPcKc6m3st+9Dd+h/m+A1Qs/0xpLWkmTWOr26g0r8+emmzWlUDUdVazKY3s2brF9NM1eJ7L1mCPJSMf7hsa9T6qDgR39ombxvxYuDocvR1gsEUGk6ewFnkABY+DzZEPm2Us2V3N5bZT19YxCSomeof0x135WjNf16zygj52dVGjQbUvYZaZCxtbKuzK+1Yw+mtRIkLISFV9aKec14P08PQbmJBvJQz2piNxyuGHDBqPk7fjh779528e83K/K7QWVVO44k7nRwszFtukC1htbPySY+8c4D3t98kS6eK2a/E+Boj8deunCaVOvTdO4fuz3oCIUCzGH15eLNeaZh8N67HWX5TaXHMJW7W7xGZgfsPRlRhN7bM GBc3oVtd FVTT8riyJqm1m0higqCjfNJMEgo06OG7xIuHD6+AG2scPMMq6XS0pv3Y2V/ROMzas56ldYSoKlJntCk6rUnYTDuZN6BjRLXFEKfIHETY+IXyVZvofpyq87B+cYvCG1RORIz1Vlp2A6bdM/Nbi9ShgvflppenrKcc35uKBJ28CS210/pmt/FtLrvUa8w0ry5Qrm5kWKGAwXM0NCcPcQtEHpNYqsaO8j7+N0SPreMBrS/N93gHxBam35eHEtIIHk3I9xULF7C+IvjG5R0bi0z7HrE4bPUUZWGkNASTQw479hyV5nK7NJHhjeeE7hcdxYtnKnaSnxu0JTPKjdNPq2iUa8KkL7jbWTaG05X8IQpHjhRqwoOr8sXFmKITUCjuDCF2Zh4P0MdOHcOGoGB2jIH9v8HhYOikliR2DZxgplz5TtYVWF39t4QvJ5EVeluQQE+QIzEcOrc3Esv/tG4hQIvffq8ycMA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.140023, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 23, 2024 at 8:38=E2=80=AFPM Yosry Ahmed = wrote: > > A variable name 'page' is used in zswap_is_folio_same_filled() and > zswap_fill_page() to point at the kmapped data in a folio. Use 'data' > instead to avoid confusion and stop it from showing up when searching > for 'page' references in mm/zswap.c. > > While we are at it, move the kmap/kunmap calls into zswap_fill_page(), > make it take in a folio, and rename it to zswap_fill_folio(). > > Signed-off-by: Yosry Ahmed Seems reasonable to me. Reviewed-by: Nhat Pham