From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32B5ACA0EC8 for ; Thu, 29 Aug 2024 23:33:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F2016B0093; Thu, 29 Aug 2024 19:33:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A2856B0095; Thu, 29 Aug 2024 19:33:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86A126B0096; Thu, 29 Aug 2024 19:33:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 69E2F6B0093 for ; Thu, 29 Aug 2024 19:33:38 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 082491A1368 for ; Thu, 29 Aug 2024 23:33:38 +0000 (UTC) X-FDA: 82506887316.04.A27630F Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by imf20.hostedemail.com (Postfix) with ESMTP id 4774B1C000F for ; Thu, 29 Aug 2024 23:33:36 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="lAuqe2/8"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724974350; a=rsa-sha256; cv=none; b=srTtgXLUvcwxYGSuhQtieMr9nyZ78FGe4i+KqO3ZO7gcDmXtlgzvuNF5p+oD/TchRsDG4M kCMCXyC+KbSChcvPqAy/jvhqYCVLBG9sSFcIJONbhZeRy/h09n/PHejId993+pnsnSNZNY tNyn32t2ZpWvTWLKO8shbEBMI+HHN28= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="lAuqe2/8"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724974350; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zLp88o8MGxnEEJ3hNktdBtR8nJSvNWUdVerO58Odqpc=; b=rghVcsiPJmnwVG7xgUN2L9bJHWMkWFSKZ/xUE9IvOqPs9HFQ91MD5hKNKnWRzDRaeVsutt 3ZbEvp4h88jgb3g+ElxvXL23+kPDEt5i7s+GDqKF1OZuRWnxhMvIRCUK75Aqm+j2udk+v3 UQTpBFJJL7TA+i9B/Wp6PFf9qzlZ6XE= Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-e13cce6dc85so1289293276.2 for ; Thu, 29 Aug 2024 16:33:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724974415; x=1725579215; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zLp88o8MGxnEEJ3hNktdBtR8nJSvNWUdVerO58Odqpc=; b=lAuqe2/83Gqfhunw8LeX60el5CEBiVany9PvYu/4GSC1/2Tyf2nfZG6ts0kdWBbwtd YI2FEAZ35gEQoZkZXZ/BXzINHGkOAavOVQTPFbzz1H+OFtpPlUKKN4QWLFgf1pulL3gU AyAtYUht33w0w420HZwr/GmxTCP/pM0JRhGqB3gCHsR+RZsNe2v9K/7i54kT3uv1gpmD 8OYkE5k4CujUJhy3onPD3QAQVmf/NmX1RfHTWhAsI98YHVeLrsZ5kkE2q57QJV36Q+zm xL41WvpsZbJdWukFmfaR2XlXb59PDKOg5zVnuBgDh8JT68q3EMnc6loLrq54uVpzF57Q ugxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724974415; x=1725579215; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zLp88o8MGxnEEJ3hNktdBtR8nJSvNWUdVerO58Odqpc=; b=ZMnAD77+87Lxd82GhuHVG6VpdxCvyfoevtLDjH+W1tEYKijNmlqh3YauW7wFvReBri 9vg+2JpwPuPqtbRYff15Dx8zPNZFTbLIKz3T0mYtQpA+HNfEmWal0fSvmmQOgLeTJLD8 gWDZhycYwTlG/CbNmoM1aDhov+SySHJJpOBvLp3+Y/Pq/c6M5OJbuWtOY1Gx+xcsi5e0 38i4vD4yVpKRNkfrSR7GFWxofhk9ICSBiuVXzRvr/lX+oRdNfWL+/fkqQSvNGVXvIGyW D27x25BURcybbg1dOjlcisu5cCDiqZKGhQiACyh2sz5uSyOy1SuMz4BVTpjlqz6kHigy c+JQ== X-Forwarded-Encrypted: i=1; AJvYcCWttpy33DK0j84cKWog02jnKltQJULrfZDKR5BhiBcpEH7BqLYldCr1Pag9VbKnR0JwpaFGrWWJJg==@kvack.org X-Gm-Message-State: AOJu0Yy3QPqRkZJs8txvrhuTO09Bl+2xAoRhK22FsqKoMfB+5056NB7Q /7KsRZFnrWgDa+6O2c6py0uljjrFf99uYdxeA45qdWDXcaJWlUlVjrjiO3kCXbXnlmCgYnu7MVX odBezEd5E1VCHjL8pPAGjURAx8j0= X-Google-Smtp-Source: AGHT+IEFXPFP2jxLqdHYzjcqufUTeKieu48rK+aXcJkFu2d9BozamOQQQ9i6F7bksjvow1s4to3wb/Z97ExpGsCRTu8= X-Received: by 2002:a05:6902:18d5:b0:e16:26e0:fbb5 with SMTP id 3f1490d57ef6-e1a7a1a1712mr706983276.44.1724974415040; Thu, 29 Aug 2024 16:33:35 -0700 (PDT) MIME-Version: 1.0 References: <20240828093516.30228-1-kanchana.p.sridhar@intel.com> In-Reply-To: From: Nhat Pham Date: Thu, 29 Aug 2024 16:33:24 -0700 Message-ID: Subject: Re: [PATCH v5 0/3] mm: ZSWAP swap-out of mTHP folios To: Yosry Ahmed Cc: Kanchana P Sridhar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, nanhai.zou@intel.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4774B1C000F X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: w5jczuoojw4nm3u8y8qq3eex1x63unna X-HE-Tag: 1724974416-955313 X-HE-Meta: U2FsdGVkX1/p5xAhOzifOq36KyZmTSPey0njLX9QPyPOfpPO747VbeIOC/RDvam90Xkrhgv3rmSZPg5arcLCk1PBgFBeuBa+60OTFOy/kMpH/UwCPqlNizE24xo+PIpSnWqnzenBHCzZX8YpJ+jGqSGPMeGwIEXJCJPKKJDXzKlTjHtU3UjtZlqOp31zBWlg0TIvrURPiMi4dwEEvkOgpBsS6dO53eHcOHBbI4JxxqqzVrhDeG+wPaS71kwJRLqVzSkWlDm5CNboPGyM+QyfsB8XdKS/cDDzfQ//z/rzyeC956yIc+4MbIKYW1LygMDumN4KfcJfIo5dOCNYXtxBkW+bDWqZuBcIwbwJI3/E22R1AWKnQX5plkqrFV5RbEjFDp+qKA3i7P5tcxIWcJ92KOYSXjwRgf/Qxa6Ws6a+0qDB9DB9wx0p6apExkazhdOrFEaqKKfIvJ+KeAUjHHCLZabXQ9PcYcO0HSRqApXe0Z9bX99heDNAKe5tt+ROc4NfrUOnXWGsntRpYo4fIfpXeaagimPTwtbJdRRt6c6wbzKLGh+EigJ6yQ6wqFkAWzT9yK+kgKx4mieYSQYxT9qfLFoiCPxnoOqIeWVkdy1R+XIVdvm3hYuVLZ6HfArISYe4Iog/buD5s2+8CIHEl47ZK+KQ5c52gmFh8iMoOnh0ymBTI7iEank0VVQe7L7g+ZxZ31Plva9i99o14y9FpoK9ibSaW0WFbJjfl8Uj38vAQ7ieysirdrCMnQe+YSznQWx/E6mB1kVRn8Wia/Y3+mIbrbYQzP6GzuXdLLIfuVZA5XnBbzrGj3tDzvqSJ0S/5mQ3POXlmPZ7R0BRyl4I4xFTDuhN2VFQ5jKAokkQ1e2GyX8seIVRp1qMzZjKIQp5/oQgfSQaeHgRUmVKmpd8GJx0EPjXgXxVt0ixvUz/2yjwjhGNGL9xQ3ojL12NwmW5e+HPY/OqiyuKEhOM7JWMZ7h dz9dtQn9 4WnAwWV21yJES3kJVGoggZOUSssGWGUudpDdH4gXQ0GKqyEXTdhglbg531ikOvjJBZ7IvVkHhZpR+Mpk3LWVP9nS7bmav5/DGQjhQPXKBWa13AgeFjZDOPq8BaodA1rroVRmOWOl5gFj7WVsI9BL3PQmiXR8VvWIdE2/GjTfS+tLPmUxp5IxmlmPi5beBC+4S8mT+R353hsC1DvqYRtd/J6gfUGddrbSA48pqdiMkFzz3b62tEjLYhKwbsC3go9lOPsBaoHSABK4f4tKE6R3blroAuaeyFzFsGBCGYatXwUlW5F12jA6ApB4JzZohM+yCp3mUSDDGWZttswmNtjxN/3qWsfbF7LZx+Nt9yCyxabZfzVx7IqQwJ4HyEw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.113721, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 28, 2024 at 3:38=E2=80=AFPM Yosry Ahmed = wrote: > > On Wed, Aug 28, 2024 at 2:35=E2=80=AFAM Kanchana P Sridhar > wrote: > Are you saying that in the "Before" data we end up skipping zswap > completely because of using mTHPs? > > Does it make more sense to turn CONFIG_THP_SWAP in the "Before" data > to force the mTHPs to be split and for the data to be stored in zswap? > This would be a more fair Before/After comparison where the memory > goes to zswap in both cases, but "Before" has to be split because of > zswap's lack of support for mTHP. I assume most setups relying on > zswap will be turning CONFIG_THP_SWAP off today anyway, but maybe not. > Nhat, is this something you can share? I think we're enabling it, but we're a zswap heavy shop + THP allocation is not suuuper reliable until recently with Johannes' latest (and upcoming) work, so I don't have much data to share :)