From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B646C4167B for ; Fri, 8 Dec 2023 01:14:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 123F56B0092; Thu, 7 Dec 2023 20:14:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D46D6B0093; Thu, 7 Dec 2023 20:14:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB7726B0095; Thu, 7 Dec 2023 20:14:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DB8756B0092 for ; Thu, 7 Dec 2023 20:14:35 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A3B09120326 for ; Fri, 8 Dec 2023 01:14:35 +0000 (UTC) X-FDA: 81541880910.02.C6EB373 Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by imf05.hostedemail.com (Postfix) with ESMTP id 034CA100012 for ; Fri, 8 Dec 2023 01:14:33 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FpSxyS9D; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.42 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701998074; a=rsa-sha256; cv=none; b=ZxU6l58AL1rA0t+zfOlBmNuM78u/ZTAjQ0N6zCaLHRMFw03HlNdTvVxmENgh0SZ4odex9S OnuoCPJM7rFKhnr5flVMN9mPkGqHbkGprHC2SUSnMub0C2D+3KXyFoEhoBwE2sD/HKkeAl +bmS0zHpIXxcuIJ4e5kwGMXMTsHGX50= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FpSxyS9D; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.42 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701998074; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yo7cHeMTarcGBUaA8OM2fMUJyq8/LpYExJLjCHdh5Nc=; b=KcjkH+Et6In0vSV6nskeMqf4kSxU8nPM9dfn1G6lLcB8nTqON0IFU3YdvT0Ob7IV3EoxdK vxLHgtF204nJvu6MlvLcLz3DEFy/GFWf4SsPE0BwtPMyh1OBev538iUqfyPwW/Pb3NlaSX cKGndmVMI92AzJVk9RvitegRXt4OJmg= Received: by mail-io1-f42.google.com with SMTP id ca18e2360f4ac-7b70de199f6so8031839f.2 for ; Thu, 07 Dec 2023 17:14:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701998073; x=1702602873; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yo7cHeMTarcGBUaA8OM2fMUJyq8/LpYExJLjCHdh5Nc=; b=FpSxyS9DKqZLxTEB8omVs25HxmYOWGmWOsc2yWrBkBIxER0UCdZs8FrCVyUaj72y/N GVWAlaGAbLwSurQ2OxRownKUyHG8EtpTqMn89z9opohIyDbHSVbi2Sr9rJVouJPQuBJM J5MUTM7zDTeabH6y3AAsUKQDm37WFuQXkKBJkrC7gDOJe+vg69qgpjVMT+5nGU2iH4yn uhpRuUi0khOGx17tBzr3OA2NzwAOUH9mz0dTWoAHrc21nLKOBmOQEaqb0WPpCa+CuS+0 TRxlmAFNYgOcTDgHP8G7MCkMOWQqrTDek8mrXxDrA/4RwnUbjHy6osoZcEhhjozEf7dd QWiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701998073; x=1702602873; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yo7cHeMTarcGBUaA8OM2fMUJyq8/LpYExJLjCHdh5Nc=; b=spPbuuHej3BiIjn5eWKRx8CUw4h0/h54v2g07U4cNft2nfN9PDBAneW6M1Szjehuzc OwMYWFMD7l5+nYVWKNQUC+R5UzEVPTApx9+tWi+PCVd1jbNeDJP2oGG8I3xmnsDGmtxS tkzD30AbVbRAtWTUn/gjpd9J0y8dcLpxgR08W2Chp3bN9Z3TcZAKtbGs5Pp/u2eSfHCG ywm70y8nReQGwkdBAx5kH7YygJReNtKV0vBWrib0brTBeZpR3zVWXhHbPqLr/4qE00kH cN/4dk6hEVyt9Gu6UWYMcQK7SyQwbcDKAR3sbJ9zwL9Azj1zjWBMyaVzcxGjocWN2q5c ndKg== X-Gm-Message-State: AOJu0YwWhE8dFGoRD1Q1Sy5UVVz9BAkbug2LcA66tLb39RpmDqQFt+Iy YUdedD5OmH8xMgihW2/zZD6LG7kJgY0f+mLBT88= X-Google-Smtp-Source: AGHT+IGbjmLNlRtCGSEhodbGWN+yzNI4TT0/HC0YbFZhYWMfP1qxatOgxAM6aeeJ3rqqfImLhOJqQviiHaz3CA0yUJo= X-Received: by 2002:a5d:8194:0:b0:7b3:973d:c4 with SMTP id u20-20020a5d8194000000b007b3973d00c4mr4073115ion.16.1701998073117; Thu, 07 Dec 2023 17:14:33 -0800 (PST) MIME-Version: 1.0 References: <20231207192406.3809579-1-nphamcs@gmail.com> <20231207141142.307745be167d044b0eec1b42@linux-foundation.org> In-Reply-To: From: Nhat Pham Date: Thu, 7 Dec 2023 17:14:22 -0800 Message-ID: Subject: Re: [PATCH v6] zswap: memcontrol: implement zswap writeback disabling To: Andrew Morton Cc: tj@kernel.org, lizefan.x@bytedance.com, hannes@cmpxchg.org, cerasuolodomenico@gmail.com, yosryahmed@google.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, hughd@google.com, corbet@lwn.net, konrad.wilk@oracle.com, senozhatsky@chromium.org, rppt@kernel.org, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, david@ixit.cz, chrisl@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 034CA100012 X-Stat-Signature: uh47f6wmrnzao16mb1xkx3rfj8w4ryiu X-HE-Tag: 1701998073-609506 X-HE-Meta: U2FsdGVkX18errI3eB5PdlSQACcGDhdn1Ff883I9YWUW3JRaNIUlAcUY3kKzMNfA0MxX1ixrCGCBAyKapohJxlNqFt7FZMn0Uo79o9XwdJY1FABAk64YNZmyYywdMWDVn43ntx7SJwsBMCnN9XHE7jPX7i6QBrRDpdgnxIDe9hy7WRdKeeIWujjV5nK9aNn0cGcmz/70dtaVOOsHPi+LbT0UWWIIvPAKT8CPRho+UAjBq6aJ6WiSEkdCT750hr3CsXqo4mYx+h944JLLuENtBPd+Huj5uGbn/eKxuF0dzcm0ZFuU6gk2273J3zhAaHI/OIH2B2zTHiCpghZrt823N9fD6r4rjn5zXAlkMVHQmMkUuhBjFODy574T1T1MmFYOc0dw5yVulv0RLwLOPQhQG69+/K7++G8gPb4VAZHn+dTeRJWue0xH7MOg2G96dqyjeaDT1iv1ZgLPJ2zYx8XgERaVHNPR6k588arriswgiFAWeLRnd7wfmekiCI8duhlz/Z49dKayV4eh2OhvzjuOsZzW+2PzT8ssTdWeyZmJEWnRx8c33zW/iYRE+0AquofII1O0iV7UDXSwgP2PRkhTKjqSpNEnE/ICL/2AALbl0tgJoZ9Cnct1Rnd4eFtRwQ8XeH3/o11cgXRqXZ+DoXcYxoU9ZpLOc9hxs36QQOvvy+YrgH5x+Je7sKc1QmGgOvu92rmRkN2m5bjp8i41T8STZnlH7wB5uW/8f40MBqFDNAjrOOZrOvQDmflhar3HOtCcyMIML6MqjZu1cyDvLBI2/Nu81fhXLMTA5f09TThMySWsXKwudU9URBMg6SVy0199Rf05y+J80kUIEjvNUNTU+FBWj7bOLaS2BCsJmJMIcznzxHgVRB2JqcDpaoQr+5vHv/9GPKczJ2VHEqjmyoHk2iADMJ8DnIZcx1/MX/TJs1Y8HdW4vfyCuLKRbPKfb7Vn2kzWoPPNdxZzbDMRTx0 1YZtYBXI mspmxtJZCKAx6yrwMDtGakrDqHprYNNknOI/K9iHXn2+rKVq2vbFMItxLCOhZRKHMbOZQE1nj4oAfJnDm9qoCJrquvgEY4kBQxQ9v2iMFm4QCHhd05pwpjwLni6NyqGB1Rp0vuDc4V63hB3Dl62OslselsXVtygszWwndAnFIeNPLnTnrPQik+Ta6nGjt7QmQKHwz4KV3pm6hzLQ0P35NKqFRn0OzX85dZKLQHDWndjBVKm35z/klo1jtkdGo+78WH9iiVx7IzW/7SqTqpxicM0n/tAQZ1yiaChlFb5GssQaDJ7eHTjuT3oF39/aFHUriedPpHAI7P8fIV438gexaUJvW41rV6J6nIOvXx3/irvIpQTtVNdyvFyCTow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.069254, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 7, 2023 at 4:42=E2=80=AFPM Nhat Pham wrote: > [..] > > I don't have any concrete numbers though - any numbers I can pull out > are from highly artificial tasks that only serve to test the > correctness aspect of the implementation. zswap.writeback disablement > would of course be faster in these situations (up to 33%!!!!) - but > that's basically just saying HDD is slow. Which is not very > informative or surprising, so I did not include it in the changelog. For instance, on a server with HDD, I allocate memories and populate them with random values (so that zswap store will always fail), and specify memory.high low enough to trigger reclaim. The time it takes to allocate the memories and just read through it a couple of times (doing silly things like computing the values' average etc.): zswap.writeback disabled: real 0m30.537s user 0m23.687s sys 0m6.637s 0 pages swapped in 0 pages swapped out zswap.writeback enabled: real 0m45.061s user 0m24.310s sys 0m8.892s 712686 pages swapped in 461093 pages swapped out (the last two lines are from vmstat -s).