From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53B0EC4167B for ; Thu, 30 Nov 2023 00:02:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C50906B03BA; Wed, 29 Nov 2023 19:02:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BD97E6B03CD; Wed, 29 Nov 2023 19:02:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7AEF6B03D1; Wed, 29 Nov 2023 19:02:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9195A6B03BA for ; Wed, 29 Nov 2023 19:02:16 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6A9B1406FB for ; Thu, 30 Nov 2023 00:02:16 +0000 (UTC) X-FDA: 81512668272.17.294048A Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by imf01.hostedemail.com (Postfix) with ESMTP id 9647A40024 for ; Thu, 30 Nov 2023 00:02:14 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mSW1yU2V; spf=pass (imf01.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.48 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701302534; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gQPF4MPwH/jMfAF13F5NsZ7T7VPUowHmiGPk9/r/gxw=; b=zZye3IrzdRGUtCmjVWUB+WKcyNx2GmVFuBwNvumTdyCrvjuB6JuwDl9DrYsmuGQ7P36zF5 NaU0tm0fy/epwfHqcj4ATmDTtFio9FsY4Oa5mqGomvdt7ey0/POsVQXzYkJJzo6p9dXHn4 u5ic4ukVKbfsJ1Pg+d1o/bcuDmqfwRw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mSW1yU2V; spf=pass (imf01.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.48 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701302534; a=rsa-sha256; cv=none; b=niXx/nIv2MR/5lrNWTWDNoM5mKe2c8Y9bt6GGwhlx3J3hC/cmrnvYwJ5dTm4OJRx2fEwKJ 3NwjJvoHzINj77VGTxa4/kiTdExBFcniNoGvgwOBWQjqKoA6YboDn7SIttOI4OsrSKPa8z qVY5+pCr/NG+n68+qqeZ7zKGEjhEq5Q= Received: by mail-io1-f48.google.com with SMTP id ca18e2360f4ac-7b350130c3fso6188839f.3 for ; Wed, 29 Nov 2023 16:02:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701302533; x=1701907333; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gQPF4MPwH/jMfAF13F5NsZ7T7VPUowHmiGPk9/r/gxw=; b=mSW1yU2VvLKq5Sm7pr79CAnnlvqbD4cgO4MspIHWBb1S4OpIQXGBB77UZkD7DBM8pb vNbSxr9mAkrAtSWbODKC0901IwnDDssX9cA4ZMv4de2Vp93mSQ817ETpLHcgZzY6u3pd gNswDat3TUQ2gFM9yTne8Z2hTxUKAS7hYqbwEUQhyNgJ2uDVFO4uMYn0ELJxZHnn08vH rsRyjzTSSfCsgtbvJwv1ExBv7tJgiZMCaXXDB/Aj3GkgRsy6esaucymhiBlig97FRIe8 B2I/0jAaZWqUUJtA1vZIpI1K+5oVVTUGVIZfCA+MfDFzrRMn+Z4Rj8xDiskr7CzZnus9 3S2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701302533; x=1701907333; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gQPF4MPwH/jMfAF13F5NsZ7T7VPUowHmiGPk9/r/gxw=; b=tKB+62XZzloSxLg9fiL8eFu7xQhW9PGGmVvW9Lu6KbjiMQjCfpPlMA9N4SDe3lu97x UbDnhLlko0xSwa1VH5jXejbhdAtZ0INWy4p5C55xw1OMnFUd7usSIYqrRlSYpqH0Zm6M bXtTvDBacPW63SJsLHIWM0SvB+lfoBiceNthwwfsEmDPQGt1y+CwXrAtJ3cDZARek9hQ Q6NSyKLPziBRIdpVZfUg5Ce+ECneROl1htoSubpQo+P73s9z9Xk4Qq++iDa4z2ewFnOz hl4lq/+f6kwwDL00WcxDBeBtSwxI4WWiPIDOPa1GgG78BeH4HaSvsWlunv1oUHsZwgZB QcZg== X-Gm-Message-State: AOJu0YwlJ4Mpi7zDIIgEFcRzL2l6NBZ7t1SHr4P+hSC1cpQ86gesuFtT KXXyziFHggXcTfUsCX3WNaexLFimwlFbXPru1YY= X-Google-Smtp-Source: AGHT+IEvGKUtR1h6T2hlJHW2sorR3kG4m1XN4/Yp/Zr0siI7nKTQvZ+GDecpum6gBmMiYu6vOUei4V4WJUPAPeWiWH4= X-Received: by 2002:a5e:8d18:0:b0:79f:c9ad:19ce with SMTP id m24-20020a5e8d18000000b0079fc9ad19cemr17955758ioj.15.1701302533662; Wed, 29 Nov 2023 16:02:13 -0800 (PST) MIME-Version: 1.0 References: <202311292250.RUfWGNgx-lkp@intel.com> <20231129134313.656e76c2e3fec1361007633b@linux-foundation.org> <20231129135342.5697165df1adfff04c749082@linux-foundation.org> <20231129142935.d9c76a2fe35efd9a4c7b4087@linux-foundation.org> In-Reply-To: From: Nhat Pham Date: Wed, 29 Nov 2023 16:02:02 -0800 Message-ID: Subject: Re: [akpm-mm:mm-unstable 179/192] mm/zswap.c:825:17: error: dereferencing pointer to incomplete type 'struct mem_cgroup' To: Yosry Ahmed Cc: Andrew Morton , kernel test robot , Domenico Cerasuolo , oe-kbuild-all@lists.linux.dev, Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 9647A40024 X-Rspam-User: X-Stat-Signature: 6uysbeq9upw66of66porj9u4yji7hjec X-Rspamd-Server: rspam01 X-HE-Tag: 1701302534-571294 X-HE-Meta: U2FsdGVkX1+9YhC0wQvqZ8oSUb1T4D/1jDZTcjLPS4NWrlZigAy4ujjxIHmwYqmOmioXLUODio1m5w7mDUbF15oL9zENtaPKxsEDDrfINyAlCrE1QDm31bieESKFK3pTE7528RY1tq9hPgCrrxG4KrmU5rHwFMxQb3diYmqCQPC+zg8DJcaI0EZfTZOmV7AI/SNPq2cLP+zILdEdpDcQ3oiTYk9CJYroqH9CJDTPUUDkQ7LMwaJUz+re+eMUwI08f3n1u52/ekhiP1bS4sOOeNZ/lf7VeFLLfNMaIEgQWGc+gHn4iWq8Xq2PY/lTS4WbJgmWdkVwPTKAp8zvmwk+4JZDZIgHnKPnAQ1nuY0ArewvFw5agcTMkU+FBOuALfpXXKKBD/CXlJXnPQfvih+lA4tPeGpH2hZc5LToQfyIn10oBk9I3ExVyCWsCe+DytlhKUsfsphEwp2c9V+cwMf35ZwolFzqb9BNkNQpKWVR5jHCGs5UMWew2L4mktP8raDfYCYps9nt8yHUjDUx9XHHFY54eIwWNSFRoOHr2vG6K0tNZEW/1Sq2j32GrUzFfjdecZ44vwXeAJ/1UW31gBdniJkmNkgRnAMyHdRvx3BQ/F2nNB+IIoM9/wTMOoCJ0/UM5bS9eypcL5WA6+knlYDDQVgkPZ1WTDm1KmMxgzS8xHFln6wgHP35lHwymt0v33f4Dfd6xTRJP5AQp6QilZIFe3Gr1Q9qAdGoFlccKb+u09PYmrUbsMVHGgHv8ithJjcVP1el2gn7Rxq7ou7V9RUSzLS9N0Jt+aTkvjQyDc/i+Qmm66lS/pjClnDccp4Rma6rOcN0bBLQB5E5xcZ5iizB7iiSX5D5FFA6AtQRGx4vSPdx/nHbi3/icVPC1renFzlrGQPUFEGogkAbNyN2iLA+K1AbIWMCom738RzbmHFQSZdT0dQ56I3bOLveGtQGmqKRNyr3RGN0DhYRzN8a3VV VCf2Ff51 fLBr5SETHFDHCQggevUoc+IuXRiJFF6/kLIwNY1cnO19Y4mvWZxy/nsVKAgM10DXKIdcF0Kr3caFedv9kbPb7MxKAf0oOLhQK1UZ6o/kaDEOADk+LbtCQybc+uqOptQPo2jId+ju8F3zk7wuQEroXAtgM0QfK5rjG015kh4xqqVM1OMuyFWAQHc7NjvKpQluL4gQ4iN7aekniJDK97OCghb7eBLUtGKfgCs/GHU/D1+rhckYWAJzzhWjDnGaPMfwvWY9o/h7p9l5Go3N7EGDn6suXAunhNNSc03Qaq/bQnvLr+rLgufsrDnCOgNnQ3fm+V9VdhU6HLug3/nS8CMFZLi9OIkmAYV7rc71r2rjTzuknREKfiAmkyZOS8lyls1NfUFSMylWOiOymonBHwZHGyv8VyJbyZ5QjPjaJDC42SiK4R+zl9FAS3CdWjUdPnPF5dEeS6jxHk8L7uriV1Vg/pBmnYJGSFbku+i/bsYkGfX+7CxptYE5dqjcjhKUokTShq5vw8XqlXO7X6OrxHP9Ppckw8NN7T6YsngYs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 29, 2023 at 2:31=E2=80=AFPM Yosry Ahmed = wrote: > > On Wed, Nov 29, 2023 at 2:29=E2=80=AFPM Andrew Morton wrote: > > > > On Wed, 29 Nov 2023 14:18:15 -0800 Yosry Ahmed = wrote: > > > > > On Wed, Nov 29, 2023 at 1:53=E2=80=AFPM Andrew Morton wrote: > > > > > > > > On Wed, 29 Nov 2023 13:43:13 -0800 Andrew Morton wrote: > > > > > > > > > On Wed, 29 Nov 2023 23:42:11 +0800 kernel test robot wrote: > > > > > > > > > > > >> mm/zswap.c:825:17: error: dereferencing pointer to incomplet= e type 'struct mem_cgroup' > > > > > > css_get(&memcg->css); > > > > > > ^~ > > > > > > > > > > OK, thanks, patchset needs work for CONFIG_MEMCG=3Dn. I'll drop = this version. > > > > > > > > Well that's annoying - the "mm: memcg: subtree stats flushing and > > > > thresholds" series had lots of dependencies on this series. > > > > > > FWIW, the "mm: memcg: subtree stats flushing and thresholds" series > > > has no actual dependency on the zswap series. The conflicts come from > > > patch 2, which moves some code in mm/memcontrol.c, which happens to b= e > > > touched by the zswap series. The first 2 patches of the stats series > > > are just refactoring with no functional changes, so if those two can > > > remain in mm-unstable, independent of the remaining of the series or > > > the zswap series, then either Nhat or I could easily rebased our > > > patches on top of them, and you can easily move the series in & out o= f > > > mm-unstable without conflicts. > > > > > > Another thing is, the only difference between v3 & v4 of the "mm: > > > memcg: subtree stats flushing and thresholds" series is the rebase on > > > top of the zswap series. So if you want, you can take both series out= , > > > and add in v3 of the stats series instead of v4. If you need to remov= e > > > the stast series again in the future, you can leave the first two > > > patches to avoid conflicts with the zswap series. > > > > > > > Ok, thanks. I prefer not to make what is in mm.git too different from > > what was sent. > > > > I've left everything in place: > > > > list_lru-allows-explicit-memcg-and-numa-node-selection.patch > > memcontrol-add-a-new-function-to-traverse-online-only-memcg-hierarchy.p= atch > > zswap-make-shrinking-memcg-aware.patch > > zswap-make-shrinking-memcg-aware-fix.patch > > mm-memcg-add-per-memcg-zswap-writeback-stat.patch > > selftests-cgroup-update-per-memcg-zswap-writeback-selftest.patch > > zswap-shrinks-zswap-pool-based-on-memory-pressure.patch > > # > > ... > > # > > mm-memcg-change-flush_next_time-to-flush_last_time.patch > > mm-memcg-move-vmstats-structs-definition-above-flushing-code.patch > > mm-memcg-make-stats-flushing-threshold-per-memcg.patch > > mm-workingset-move-the-stats-flush-into-workingset_test_recent.patch > > mm-memcg-restore-subtree-stats-flushing.patch > > > > in the hope that a new version of the first series ("workload-specific > > and memory pressure-driven zswap writeback") can be dropped in place of > > the old version. > > > > I see. So Nhat needs to *not* rebase his patches on top of the current > mm-unstable, right? FWIW, I'll have to re-send a v8 to fix the kernel test robots/build issues that I've missed and incorporate the comments/suggestions from Michal and Johannes. IIUC, your series is ready right? Then we can have your v3 in mm-unstable first, then I can rebase my patch's v8 on top of that (fixing any merge conflicts along the way), then send out the whole thing again. Does this sound good?