From: Nhat Pham <nphamcs@gmail.com>
To: Kairui Song <kasong@tencent.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>,
Pedro Falcato <pfalcato@suse.de>,
Matthew Wilcox <willy@infradead.org>,
Hugh Dickins <hughd@google.com>,
David Hildenbrand <david@redhat.com>,
Chris Li <chrisl@kernel.org>, Barry Song <baohua@kernel.org>,
Baoquan He <bhe@redhat.com>,
Kemeng Shi <shikemeng@huaweicloud.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/mincore, swap: consolidate swap cache checking for mincore
Date: Mon, 11 Aug 2025 12:11:48 -0700 [thread overview]
Message-ID: <CAKEwX=O4EW=8T7EwMCiQV8STZcQR-h0Hm9R6Ei2cPB4TBCP4zA@mail.gmail.com> (raw)
In-Reply-To: <20250811172018.48901-2-ryncsn@gmail.com>
On Mon, Aug 11, 2025 at 10:21 AM Kairui Song <ryncsn@gmail.com> wrote:
>
> From: Kairui Song <kasong@tencent.com>
>
> The filemap_get_incore_folio (previously find_get_incore_page) helper
> was introduced by commit 61ef18655704 ("mm: factor find_get_incore_page
> out of mincore_page") to be used by later commit f5df8635c5a3 ("mm: use
> find_get_incore_page in memcontrol"), so memory cgroup charge move code
> can be simplified.
>
> But commit 6b611388b626 ("memcg-v1: remove charge move code") removed
> that user completely, it's only used by mincore now.
>
> So this commit basically reverts commit 61ef18655704 ("mm: factor
> find_get_incore_page out of mincore_page"). Move it back to mincore side
> to simplify the code.
>
> Signed-off-by: Kairui Song <kasong@tencent.com>
LGTM.
Acked-by: Nhat Pham <nphamcs@gmail.com>
next prev parent reply other threads:[~2025-08-11 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 17:20 [PATCH 0/2] mm/mincore: minor clean up for swap cache checking Kairui Song
2025-08-11 17:20 ` [PATCH 1/2] mm/mincore, swap: consolidate swap cache checking for mincore Kairui Song
2025-08-11 19:11 ` Nhat Pham [this message]
2025-08-11 17:20 ` [PATCH 2/2] mm/mincore: use a helper for checking the swap cache Kairui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKEwX=O4EW=8T7EwMCiQV8STZcQR-h0Hm9R6Ei2cPB4TBCP4zA@mail.gmail.com' \
--to=nphamcs@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=bhe@redhat.com \
--cc=chrisl@kernel.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jannh@google.com \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=pfalcato@suse.de \
--cc=shikemeng@huaweicloud.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox