From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50A28E7F124 for ; Tue, 26 Sep 2023 20:06:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9BCF86B0138; Tue, 26 Sep 2023 16:06:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96D646B0139; Tue, 26 Sep 2023 16:06:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 834DD6B0177; Tue, 26 Sep 2023 16:06:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 73C856B0138 for ; Tue, 26 Sep 2023 16:06:27 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3E36E80CF8 for ; Tue, 26 Sep 2023 20:06:27 +0000 (UTC) X-FDA: 81279830814.17.28B34AF Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by imf22.hostedemail.com (Postfix) with ESMTP id 8B44AC0027 for ; Tue, 26 Sep 2023 20:06:25 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iUMOfDyG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.43 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695758785; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ROwwicfVqJzQjY5acEsiiIZMrlm7ip2jQ8qIfyOCsP0=; b=G8vKhkJb/lAkpRkXF8uORzyszE51+GbV/WzPWBSYXpWm1KEKuQEgTUx+wPj4l/4/KxpUdf kBDq7D8n8m2svXfz01e44+lsMymRmPsouzrwK6DNGpZ9mfd2gii/6+gMX9hEP8VmLCTuXf gH6YArODQF30RLAfRDVHj78zEmT6tCQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iUMOfDyG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.43 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695758785; a=rsa-sha256; cv=none; b=Y0ryEJEh8uK7y/YgXOVcDoRulquW4WvSvChsvNy6RTO04F3SSIOtwiW1kzi5T95ezZEpiI jU/0vPdd9N+o1cjlK6CqCQ5LBnIPESXcBAi6p/XKPc1p6JyElj4vpcDetf5CEBBvWoU/bn 1QRE4NUAs3XuFAdDGrbZy76uCo/7Xcg= Received: by mail-io1-f43.google.com with SMTP id ca18e2360f4ac-79fa2125e19so280097839f.0 for ; Tue, 26 Sep 2023 13:06:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695758784; x=1696363584; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ROwwicfVqJzQjY5acEsiiIZMrlm7ip2jQ8qIfyOCsP0=; b=iUMOfDyGbS4ZCVuGhS8+lWX9mMW9jyJlhrWMfwJ2DN9Zxs0gESn2jQ3f8Qh76lc2fH rwuTWx+jTzv5/ogIL1lmNnY4LxmN3FgbBMmItsWPNQ8EddZzD9n8dlA3GiW4KrA28nFB GIzSKEWYumjhnVhfCiunesul6ulqBr/AKKrAwF4i0HGocYADxxA95WYm4+obvIn64g+X uTDg1K2VqB9vKhR8t65JjN9G3+NrD16g9G8suVCmJW1Rey8wwmHUHsdWSjnxt32mF5aO QBCLZ6ajQoyRLGvK5+/1L6O0on4b7/0b5T1w/N/b3ptd7HQRomik2diaiCWyStiCIk2/ 5grQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695758784; x=1696363584; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ROwwicfVqJzQjY5acEsiiIZMrlm7ip2jQ8qIfyOCsP0=; b=iVWxOpvC1sSojZz1z34+VM+t046C525jll1qIesbNL+CEAgD/4Pogo4QqnXBETVQ6+ HCNy0eQaP0aawLqQ+85S9ZRLtNumjqLSu0xyZx/pRa/A1vH3REMCCNg5us3WC/NEX76c lutiPQMpSkYaQ3lXpOqWL2fnG7e9e5HS2VKlOyaIcy4Xpc2ECO3ZxTER+dbo/9Qh9QH9 RhJZIG6OEzc1oxQpaWhARr1QBrHWpc49SUA+GJUXChImdn3JWRfvfQQO5IPmQtpV27mi 62qitlMeUk+DhivCH6zZBeUxDiwSsM8JvathGuo66iZzKmyEqsuVjdu1UKqy7QJ6bCsx Laqg== X-Gm-Message-State: AOJu0YyuZBN8wajqKEP/mCmUj5cbu5e1W8BwjnZrWXk8oHYT0yodlhpl cYZP1yIW0oIq39I+7Coq2Q/AgOB2XmdP9+a4vWE= X-Google-Smtp-Source: AGHT+IEtjxPs4x1IgblTngMLujVLgqNN+U9yZr3AHJwqwHSTTwgo4ZUxCvsuxMVmsbfB1bpGNujHF0wNw3JRaj4QQ6I= X-Received: by 2002:a05:6602:2186:b0:795:16b8:8601 with SMTP id b6-20020a056602218600b0079516b88601mr11403668iob.0.1695758784562; Tue, 26 Sep 2023 13:06:24 -0700 (PDT) MIME-Version: 1.0 References: <20230908235115.2943486-1-nphamcs@gmail.com> In-Reply-To: From: Nhat Pham Date: Tue, 26 Sep 2023 13:06:13 -0700 Message-ID: Subject: Re: [PATCH] zswap: change zswap's default allocator to zsmalloc To: Christoph Hellwig Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, cerasuolodomenico@gmail.com, yosryahmed@google.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 8B44AC0027 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: b5fmhgj8i3sxegj9m1a45hofjfce4jwp X-HE-Tag: 1695758785-723576 X-HE-Meta: U2FsdGVkX1/22aUl5YRQlTZ9hJ2SXZ4tCv2h4O1LTUBzIrB6txilxiO0S+FY8DgogCmK6NXsE3TSnxkRKHMKgRwZ9WdM+z/AF7wAS7pTtfUeGIxqiKu/cRFDsbOz+GWL8nf5eC84+WSt1BkELjyTf/8N8mISUaN7I+yfhzrY9YE//CdZoq+0iL8Fnx8bMnXOrr89NOUwUPAVqfiKW8A9lzXkDW0SbiKdNbVUnKDK5K2tQx4fMGCnqq8+IHHg1Eomvv2XkASukG4XSE489Of8RNSoVNaUK1dbiipOi7yrai8faKthRaccVVCu1O50rQ0+pQOCD5LVPfuYq3z7v34877hs/eu624UUQxqMmQN1ZJPotekqEenv1K1v9iZ6efxkhz9eLNEB8J4jexRqGJAYWFrDEXXRPSX7Wl8+cWDGYTSEz5LGdOGNUV1Cqk6heS41vUuOnU+/akJ6kvBEVi6BzddQKBVNvIS6GQM7AI3YfttTKqjjT7r44HklTwMC8CL3pESD79RrIqQEIzpX6kXKPAGHGquMSg3SMeCp4V0qidwD02QxnD0qFWZ7COFmUchVdOUg0yk3Nb+g/Lhpws0s0/+8XsK1Db47mKV16Xes9Iiwyh0lQE94DYQuAyCfvPfntrczPgkJCcDClPpyNuvn9+C2beyI7GslTtVqmXQ/0LyaJcmDpIACAQeeF2Wrd5MpAdPaiuiMAxsdS4WLFQ0VgkcvAnDn1LNVEAWWav7LUlcbyjteqW2kO59uU5tHU4xy7dzwWdi//cdA55gMbNdKY3JEqBYjrPAfjRu4Ia1PVCIVDd0q3IQDPljxaSVE+bzJcaZz2NACSqrMcvZ1lid7dpeCMjImHevp586Vs4L6X4mcocOcHGa4K1jFBZDWePZSKol3dXctYI1NYIuDFhp3x5OHFuvdv4k+nnu/uxfZM9tb2O+vpPcCqTJ/lVjwuOPHAoOPuXKRrwu3RvHySdv h/iMnMLM JzbxZWjE0aR3+Ju9fx9cgi34PQnYtA63VNNrH0X8m1JJrTSfdlmBz9wVBiTHnGhsAwi/ybUlhulZcaUDZNtWE1wXNx0Bg/mXJZ84g+MkbtJ2oUzGmp9LGTIT1awdiwAGYs8hf+l466PXPjdbzVzW1G/Kydaxvs+m+tOprGEgF3wOVs0yggmkP0DqR20vXN9oNrDaU1LqJ1gbQe+LZGtTuTYvndR7g5XKDb1XyUTwgjvJR846311oQGibbxK9/CMVLXJFhs+ma3KFxfHzb3Nj7OKjTdTsmL98s+LpK6qOj8VJLL1pUUfpDrph+fT/VxO2DpkOw X-Bogosity: Ham, tests=bogofilter, spamicity=0.003968, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 26, 2023 at 12:29=E2=80=AFAM Christoph Hellwig wrote: > > On Fri, Sep 08, 2023 at 04:51:15PM -0700, Nhat Pham wrote: > > Out of zswap's 3 allocators, zsmalloc is the clear superior in terms of > > memory utilization, both in theory and as observed in practice, with it= s > > high storage density and low internal fragmentation. zsmalloc is also > > more actively developed and maintained, since it is the allocator of > > choice for zswap for many users, as well as the only allocator for zram= . > > Dumb question from an outside, why do we then even keep the other > two allocators around? > Maybe legacy users who explicitly configure zbud/z3fold? We have a couple internally, and have to manually undo those configuration after we stop compiling these 2 allocators. But yeah, I don't see why we should keep these 2 allocators around. Time to deprecate them? :)