From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97DABC47DB3 for ; Thu, 18 Jan 2024 18:03:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F7686B0087; Thu, 18 Jan 2024 13:03:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 258C36B009C; Thu, 18 Jan 2024 13:03:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0ABDB6B009E; Thu, 18 Jan 2024 13:03:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E80A76B0087 for ; Thu, 18 Jan 2024 13:03:37 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B16B5120D2C for ; Thu, 18 Jan 2024 18:03:37 +0000 (UTC) X-FDA: 81693204474.26.9DE0075 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by imf29.hostedemail.com (Postfix) with ESMTP id 38159120032 for ; Thu, 18 Jan 2024 18:03:35 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Math81MP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.43 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705601015; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f7SPqDiZNgqprY5vPmS7UZy9a1A1Nyd4TfzIR6Gn4ho=; b=074P7Ojo/V7nOHgx8AOeQ4MdNR6Swj3N7scFmaExfDJUbY/rlDot+jssZHZ08dP67iN+3E 4dChTUEY1j6QLqY/mUjJGHk1RGrYNXmAFdRIdX3/9gY1Ff7iRLEX0hE7A0N7amW0HZrRMO JImUzOKQY5dv6Vvg+mSqzs45sZ0uldI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Math81MP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.43 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705601015; a=rsa-sha256; cv=none; b=fGaoi8CatsqvkxnsNwZgTT/ZUNDTy98MntaCKlmdwotSGJ3KyQHCqEZMfJFsLoJL5wzyJv dGTSSMfWFlOZ+F5iTkQEnVklikDr6ehe21sMjeAFsdhnzoWQrtKV8OQ93EOPlg/PE8DJ8w 55QpvvQnztkNGkaoB2d38yfDEHHMYZk= Received: by mail-io1-f43.google.com with SMTP id ca18e2360f4ac-7beda2e6794so29316939f.1 for ; Thu, 18 Jan 2024 10:03:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705601014; x=1706205814; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=f7SPqDiZNgqprY5vPmS7UZy9a1A1Nyd4TfzIR6Gn4ho=; b=Math81MP8FTVWC3DPG8LbepXYHaQsNZN7HApXvF9dzBEDdoczlbJqVs4mD+GOf+CwP 8SFEvKRLqxP0oMYzs4XZRJixycY69VYqpWoOZrlV2Ok+CanPYEa5oqjntBkyk5pq5iLL ncT6gT8r2VL3gvPNoZbCClN5435BFQN7WSJUaaAnB/QKiVYp3b1mz6/nAk0a/iDA7sEg UwcDQ//w6GjE5MyODPZ/acOHgNh1ttZFIomhLWsR+HQZtJPhf1M0ZbVYUDv2Eyhamfwc divvGZKHjkWtJK+uNaKtyBwVCau/P3jb5WEpB8Y5FISLszTR6U18nRqOKfqXY/hsiz/F RSEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705601014; x=1706205814; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f7SPqDiZNgqprY5vPmS7UZy9a1A1Nyd4TfzIR6Gn4ho=; b=lJXHVeF3nelJsUCr1N/BZ9svh/wAcDwAkkIkDLCZT7Nlq2+VYoDulgrFKDILt7kN1U pthSES6PJqsAF2vRzQ9SGrIjhcB31pz7Ll3nVpUDqoBjN1p52X00eXRUaQpkF8YKxuPu dCCmlFsUj3yZ7DL7A9Rmw+ON6Ld9oVin79JFmIc5AuMa7sPCo6LrCxLihqeW5EFc1Rd0 Vm+7MynWvn2xA0EYVPvPpuiOc0OCbaW0bD4D12gyQ7cAAsC5RGkUx7uVNNc+QFg5Nvd2 LsB99BRxlCrSXwhkEQtEObg/o8BOCleWz0UOlm2s3M3df9Y2KHA8Hp7qPhCLbUJzYB50 JeAQ== X-Gm-Message-State: AOJu0YxFLIDEIdVgOwWNrX014EpFl+2vH9Izyi8V+hC/dCoNSHEukUMZ 8+bNiQgpTcCVDcikhktwt105n5hrQ1wmT9a/BvJ2SLg5gJ9q/dojdYemWSRifymNNHat5xbAJoX OVPN8QtvsZhtVgprxlDDEXq3gNgw= X-Google-Smtp-Source: AGHT+IGhXsnEyFiCrp9mBsrGplHaiMUn19opbcjwSMEhhxF6g3m1TVLIydvXadC1YDZ5+aMsdLe6zx+BzI2VcUbO3Bo= X-Received: by 2002:a05:6602:4f50:b0:7be:c0d4:f567 with SMTP id gm16-20020a0566024f5000b007bec0d4f567mr2016987iob.4.1705601014316; Thu, 18 Jan 2024 10:03:34 -0800 (PST) MIME-Version: 1.0 References: <20240116133145.12454-1-debug.penguin32@gmail.com> In-Reply-To: From: Nhat Pham Date: Thu, 18 Jan 2024 10:03:23 -0800 Message-ID: Subject: Re: [PATCH] mm/zswap: Improve with alloc_workqueue() call To: Ronald Monthero Cc: sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, akpm@linux-foundation.org, chrisl@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Yosry Ahmed Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 38159120032 X-Stat-Signature: wzy6grb1gj41rdj144sfbss9kyd6751c X-HE-Tag: 1705601015-699997 X-HE-Meta: U2FsdGVkX1/CMT8zFu5vfCisKnxsdiCKMekhMpTvFZI91t3/jK9LAxpckDGi+1o7NgOrxWMqsy0924dfcSZC7PQ5y4CF21BxfhQzEaGcFyMUiu3djthMHB6sUrLizS1C33SrMAkc1qdtZMBqGWb4X2tbfYxtiJixYNwKF+CXFKKrf1XGrUWN68oN+Pk7ii7nZZb8YsS7BCXfNlJfxwshkraGLuf4l8EMkqajh0GrIsF5MnuwEkzAWgOyc9+Pq/8g5crsCd8hsRykzWWwwINPpYB7n4V0cT9t9qkPPklA53jgXr9SrT585TbE2xQbFK0APMB7wC+9Uwi6VXl+Ec3RkHPSyVkMf0TnPT8zk5JAaGDjclDG4wjxDrZmF7CxGHhaPHhop5mmDx1mkgNYE+uAeEYhQPcVGQFHJzdeyRKbcsvZtmlH7JRpNPRMZSkeF1Moipp76tEteVMjmEhqGDVBITAQ0f8Lb7YnvzS7MVXYyLpOQouwtJbmTuTAB/MkZDWcy0tA8k+j0n5+3TvQl9wGcu6A6R+3gEjWUf2qz9TSYUobfw8S76OTOC8bGIBxABusuvgsImOY8tLf5jtLqmkZ6jHmT8BtCqwHto+VCcPzyYhztYNBckKFvC5BO/1qmRBrvqjfi8rZPLWVwEbC3G11QVCPzuPG+06Veq9O7Q7qsDMtF39NbYq471lwbgfZgk5TaIKlYfreOxy+nK+STItMkEtR+36PQgLYGpVE4i2ZPpQwJpucTWQ0H9jKUNhSTxL2/y9QKvEIQXXYV7GSKBCvQezBRz4l/y8zs0rNXmDLiFJQ76nHUJXZcLkwXwoIUZdpIwVpWry1AC5G8A06UGv9Gpff5oI1E4vb11+ua/JurPOaBygO5JuCT3apvlWQyCkjSVaFZ/qrfqb28DrHeiADYllw0v+/R5wWlgJkvPweiHPWKiEOqw8VYIb0AfHXjnHaSWkDBUtD/wCXpo9mAPc e+WNlZKU cBMTMHFzurS2bQFvca7hP6s1NLIgoQyCucyuN8Gzqbrvpy+1ZFMPapfoDgTU6HBN2M4BYcJf4+2N/ECw1CiSZxK+b0mikQWpnMdFLVF/3u7kilGbomeLms7TYYAP8JkUDPiiUkKP2Rx3WBefil3mEzrVk/ADCMuGL/0cgs5f2YwXwtqEGHF+h+7RKaf9UWehoCGYPpS6uUzd9+LxoPXjFsEOQgzR1GtH6v+qQlLZd16EDZJZd4/l06BRAc0RyuhMrjYkXmf2q537fNllLQJjRa6YzGA1pbfG4Tpot5h8yDucyud9RTMrst91q7S/yNDhnf1fUaeJ21sLojn9uyz8DsA6fsnpnVOUy5DsoVh0eGrYe1J8DUuNGCIRKhb7AVlRgufb/WyJD2J/qv99n59ESOxJpf/iJFpOJxnEhy9ToqDZ5DGXXoCSSG980oXtQNC6aStWB9VXcq9HBpVeyDzfACgRWVIbfiOBoowjf0FoObxvYOa7dVX9ttf0SwcMFIVRGcTDHPSlX/BWt9e/CoYhWTVkJGQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000037, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 17, 2024 at 11:13=E2=80=AFAM Nhat Pham wrot= e: > > On Tue, Jan 16, 2024 at 5:32=E2=80=AFAM Ronald Monthero > wrote: > > + Johannes and Yosry > > > > > The core-api create_workqueue is deprecated, this patch replaces > > the create_workqueue with alloc_workqueue. The previous > > implementation workqueue of zswap was a bounded workqueue, this > > patch uses alloc_workqueue() to create an unbounded workqueue. > > The WQ_UNBOUND attribute is desirable making the workqueue > > not localized to a specific cpu so that the scheduler is free > > to exercise improvisations in any demanding scenarios for > > offloading cpu time slices for workqueues. > > nit: extra space between paragraph would be nice. > > > For example if any other workqueues of the same primary cpu > > had to be served which are WQ_HIGHPRI and WQ_CPU_INTENSIVE. > > Also Unbound workqueue happens to be more efficient > > in a system during memory pressure scenarios in comparison > > to a bounded workqueue. > > > > shrink_wq =3D alloc_workqueue("zswap-shrink", > > WQ_UNBOUND|WQ_MEM_RECLAIM, 1); > > > > Overall the change suggested in this patch should be > > seamless and does not alter the existing behavior, > > other than the improvisation to be an unbounded workqueue. > > > > Signed-off-by: Ronald Monthero > > --- > > mm/zswap.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/mm/zswap.c b/mm/zswap.c > > index 74411dfdad92..64dbe3e944a2 100644 > > --- a/mm/zswap.c > > +++ b/mm/zswap.c > > @@ -1620,7 +1620,8 @@ static int zswap_setup(void) > > zswap_enabled =3D false; > > } > > > > - shrink_wq =3D create_workqueue("zswap-shrink"); > > + shrink_wq =3D alloc_workqueue("zswap-shrink", > > + WQ_UNBOUND|WQ_MEM_RECLAIM, 1); > [...] > > if (!shrink_wq) > > goto fallback_fail; > > > > -- > > 2.34.1 > > FWIW: Acked-by: Nhat Pham