From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 108EAC47DB3 for ; Thu, 18 Jan 2024 18:08:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98D1F6B00A2; Thu, 18 Jan 2024 13:08:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 93C2A6B00A3; Thu, 18 Jan 2024 13:08:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 803A36B00A4; Thu, 18 Jan 2024 13:08:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6CE146B00A2 for ; Thu, 18 Jan 2024 13:08:23 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3A120402A1 for ; Thu, 18 Jan 2024 18:08:23 +0000 (UTC) X-FDA: 81693216486.17.D009613 Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by imf07.hostedemail.com (Postfix) with ESMTP id 7F2174001C for ; Thu, 18 Jan 2024 18:08:21 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="A/BAU0cG"; spf=pass (imf07.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.54 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705601301; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n9oyBIjEpoT3XMaWPjAXVyQ5+LqPNizEst4EFi9ms0Q=; b=SN/+xYZ5hGlcZsJ9Ymk9kU23G8TX2XlwXOvfK3BwN39NYa1bThGirSlwpXXmAU+zX4ob1e FGdYoEQsuVKtEO50WA+ia9chRh5Gr0YR5Qq7wXyfaPj2PiidAdStoMtI3kQg9mixWzyRaq alNgqoka2eOrBnrxv5ADqrg9UVf0YeQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705601301; a=rsa-sha256; cv=none; b=efHptb4yTi7jiO/xP0j4rt0jfrkZm0oSE86+v9pxeYFmN0pViKc2cSSmLEpZ3n/ZJZ7Wnd BSFlDb7B0Kq/iz/I/c6Oj3lT5Y5luOdSwCkDe2OyyOQyB1XUNMo1Z3OvFla61Ou6GWXcdI WE5S01J3l4VdI7wZfT0Rl3FQSdtIahE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="A/BAU0cG"; spf=pass (imf07.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.54 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-io1-f54.google.com with SMTP id ca18e2360f4ac-7bedd61c587so271359439f.2 for ; Thu, 18 Jan 2024 10:08:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705601300; x=1706206100; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=n9oyBIjEpoT3XMaWPjAXVyQ5+LqPNizEst4EFi9ms0Q=; b=A/BAU0cG6FVIHqQXkconG+mftUhXqqEkqiLc6UMQ7yChgLb8r8f0hPofHD0shLjcvv BLlmEoNSbRGw9/bepq/jR4gmObyvBYyMR77sRlDrP0YTpgE8dGMrOTfJimp+oAKZPWgR KNbYlRkBBJjxo35o4MIHM/+9B9Gyv1j2P+MHr3XF37lW3TOfRYYWYPlHTc/T5UlpLBvt Ztf/i/48aZOSEjVqBO/vU4LPShGc5Edz7/AdRKANNYgPnhgU9YWU/qRI5vfC1UIlqB2G gRIViNzkwlReK93GC8zy+l+wVOIIecfzfuRiv5qnvXU6uvCMb/MYhOEOWJQg+Nyj5qp3 UFKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705601300; x=1706206100; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n9oyBIjEpoT3XMaWPjAXVyQ5+LqPNizEst4EFi9ms0Q=; b=P8WtQaUjVsSWfDGm175aeKHVteouV7kc1b1aOYIIJGlW4QfV4BRYwuwYW1Zw82CuJU Fx65Rvn3KjpekrX4O2xXEkhfyf6TTbbLWE4w1RlAZzbuajy9OXqe4oC+oeiZhgZJFrL2 D4AvaYFHbkAD7RKai/ehVWghzyyNWTl3HivXqJO+dOk0Q/yrBdiAsOI98flQ5bsLuuXX anFxYAwsuFkRuUP2moOA5ze54ha4BC7ekmPlXqs2OJUDVoiNJECtAVPZ/hP2RwuUR6cY gxBGN1qDShebAoIlxnl8h6RC8q8hv0vU2PDxxZcI4duiWUU3jIEg9gkeEczcV4piXDkM ip+g== X-Gm-Message-State: AOJu0YytX1WIlWOZW9PnRwjhGaOduS8HtjfViptA0/Oqn/1CglDgdh66 4TTFyr7sByMgjc7AOHEoRjhefpeBaS7lsMBevaYeui/MZ7eFO+0wqwgDEVibHuUqmd4ZNgm5Fv6 /tWTisSWcP02lyXefjY4HDNrwdn8= X-Google-Smtp-Source: AGHT+IFPx4jMifBcYgXWizqwzIkj3U7a3ZuHUudPepeumwLD+rKp+Cv/jbSzuIaNPFjH+aO8rc3jNodYlQO1f/3cyBg= X-Received: by 2002:a6b:ea0a:0:b0:7bf:37b7:b0c0 with SMTP id m10-20020a6bea0a000000b007bf37b7b0c0mr1609603ioc.31.1705601300656; Thu, 18 Jan 2024 10:08:20 -0800 (PST) MIME-Version: 1.0 References: <20240116133145.12454-1-debug.penguin32@gmail.com> <20240118161601.GJ939255@cmpxchg.org> <20240118164839.GK939255@cmpxchg.org> In-Reply-To: From: Nhat Pham Date: Thu, 18 Jan 2024 10:08:09 -0800 Message-ID: Subject: Re: [PATCH] mm/zswap: Improve with alloc_workqueue() call To: Yosry Ahmed Cc: Johannes Weiner , Ronald Monthero , sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, akpm@linux-foundation.org, chrisl@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 7F2174001C X-Rspam-User: X-Stat-Signature: 8yk3g5zzq5jp3j9xoaxamtu6bj4xcbtd X-Rspamd-Server: rspam03 X-HE-Tag: 1705601301-812309 X-HE-Meta: U2FsdGVkX1870Ay+Zj8PKuJKTFFlhhOJu48Qc1ivSnUffPPN0rhxUjbVYVkX2MdjW0oCg2+XDaP5sec8BdtQ8jxbhC0+HxSl6f1e9fLvnc14IYYOLkgZjW7VEOs7CgSlONpdcn4A9o1S/apgIiuyQ+5YDFEYMBlbiTRzBI7LaZoGnvUNeNYflhCAkWKWrU2XdvKpR/JFxLdhH31jP3xFUoJ38tf4q4pqcTdQWMNU0Y3FOqNMJpdmbV/0LCYX4diN7m++H760uAMo5GtF8zgh+dy5yjq5pFmK/sWfTIVkOTKJakDCDdcYz799BFx1bf3OwO6QxF2lAPd7g7cHTLxRENJmmNozFO8U2hgGgtyt1xi5T7DrDObdH0TkOmfMSAKBAAcbs/mF65HPTsaQz93tX6cvUewIMIbheylrdEu0zujTlJ0hxvbpfPdBf5UHpO0w8ipsaomZCR7eUdO2VBcelGJaaoHts0hkiW/o970Lz6KJS04mRRJxzxFaoZJa69qrw362jPtCGhTs+u321OklQPbbRrqiCw3rWjWSY2UTnGAnrAEdsLLTtKWNRdX1Elbx4oVtn1jPG/5QaJph0H7DB03FSumv57nwOKSodUpBfHWnz5kXni4K2i7zNxh+XM5AOpwVQuUWVP54dkz/U8vw7SvA6f6H2R+Qv+4vaMQobZXBBX2tzUIOTmKaQlYrV8WVs8vncIFAdA2LOIC/9JJqxUGRmiVxKVrk6hiws3YL/rYgsWfo9T9Xz2V+PRmf1ltCZpfCUVjgTKtJOMkZpSSktgTZ+zJqlnBubMzSwRJHgXYvy8wZE2d+I703L3WWy/L7V33rfiK7dxlLmllX1AqyI07obmGZ44mT3Z21AwPVsb2UzAyZckd/FpjDYGXVwS9I7HvDwzx5esS/7U2xRqxgaKk9X16iXOP5fKAEFUX5h9QNyD00dPG/kMUKIQYJqgN1ouJ/Db/VF1PwAkcAuEj ksgkrxsl 4+XI6GR1PSLEsMP1ZF/RIUD1wMjK9lXvB7idHVr7KcfJMsKAzVVngCcMHJFuKI8nGutD09JP4JMmW7EyrKzUzk43UQbuMfP69sytthEVqMcFh6Z5FKox5rVJNreeeb5on9dYkdonI8598vHplwXnbIordaCFhVjlUAlP35BYjKmpI7+hsEmO/5QX/2wuioxrWuFt6pByjA828NNt7wGRrJXBsUWeQqxP3foaI4f70lUALuy92sUuiNNDIT6quOLRNM7HdRqZ+K5x7W1et6b56vVSJf35sA8E3qXn38chOaExcd4Uazc8ipFGcVKXcaJxsVo2H6dmNQr/nY2S6GRButpbp8qsETVMDN6IaokLbrcV7BSGN2dPFrBCYF3wP2mrZan9T0S/yLrnczwiKszN6KGBN15/WUB9L9KpWFR3p8m/wUdDcXr+hcvJWj8QreKiFkqRwLL+o5HVw/ojKFEaCYZanPbJlJKSW8vo/fhPC+6yqR2R2eMWHoEXX0TjqzT3ieLhVnW48RLv+OiKb7pBIrTt1jJHmAnXQVybqIRiZjQKsskI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 18, 2024 at 9:03=E2=80=AFAM Yosry Ahmed = wrote: > > On Thu, Jan 18, 2024 at 8:48=E2=80=AFAM Johannes Weiner wrote: > > > > On Thu, Jan 18, 2024 at 11:16:08AM -0500, Johannes Weiner wrote: > > > > > On Tue, Jan 16, 2024 at 5:32=E2=80=AFAM Ronald Monthero > > > > > > @@ -1620,7 +1620,8 @@ static int zswap_setup(void) > > > > > > zswap_enabled =3D false; > > > > > > } > > > > > > > > > > > > - shrink_wq =3D create_workqueue("zswap-shrink"); > > > > > > + shrink_wq =3D alloc_workqueue("zswap-shrink", > > > > > > + WQ_UNBOUND|WQ_MEM_RECLAIM, 1); > > > > > What could make a difference though is the increased concurrency by > > > switching max_active from 1 to 0. This could cause a higher rate of > > > shrinker runs, which might increase lock contention and reclaim > > > volume. That part would be good to double check with the shrinker > > > benchmarks. > > > > Nevermind, I clearly can't read. > > Regardless of max_active, we only have one shrink_work per zswap pool, > and we can only have one instance of the work running at any time, > right? I believe so, yeah. Well I guess you can have a weird setup where somehow multiple pools are full and submit shrink_work concurrently? But who does that :) But let's just keep it as is to reduce our mental workload (i.e not having to keep track of what changes) would be ideal. > > > > > Could still be worthwhile testing with the default 0, but it's not a > > concern in the patch as-is. > > > > Acked-by: Johannes Weiner > >