From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D3FCC4332F for ; Thu, 14 Dec 2023 20:33:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 062988D00E8; Thu, 14 Dec 2023 15:33:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F2D518D00C7; Thu, 14 Dec 2023 15:33:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA6E58D00E8; Thu, 14 Dec 2023 15:33:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C3A328D00C7 for ; Thu, 14 Dec 2023 15:33:21 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6EEDCA2025 for ; Thu, 14 Dec 2023 20:33:21 +0000 (UTC) X-FDA: 81566573802.10.E45CA19 Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by imf14.hostedemail.com (Postfix) with ESMTP id 7CB50100007 for ; Thu, 14 Dec 2023 20:33:19 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kQNqHtaw; spf=pass (imf14.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.49 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702585999; a=rsa-sha256; cv=none; b=6x9ZnWgkN05CPZ/kPC2FW1H6CWRutpg+LDeLLehg1b2xe4DT3BVrGz1JUgcyyjKM1V6eDT 8mk62lXCo2myYTtcufFszEkdnCcNtlXyG1ZF0kpDaeGyfRKfIewHxrpsrQYD8CtiDYSM47 T4GUodQPVphBPMQ8coXg2VLOqED5UGU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kQNqHtaw; spf=pass (imf14.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.49 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702585999; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0kRc/nvAz1X4FEFIeTOixtRA67BZizfz7Bxvt/ZwY7c=; b=vpjOO3lRIIudV9yaaQm+uf4ItFA4DF9tiDVN21Rxex7+RN2RhjdlEGA2TGxYFBVjmrHH2m r40LAoU2j3gFek0POSUDW9ykzCCKWQuI+e1xNm1YAU1FCyzH0PujxDb0LuFS5DwVtqAp/J Om8HIkRboZ5EmM7nkT7D/4hOCuRklYE= Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-7b701b75f36so335302339f.0 for ; Thu, 14 Dec 2023 12:33:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702585998; x=1703190798; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0kRc/nvAz1X4FEFIeTOixtRA67BZizfz7Bxvt/ZwY7c=; b=kQNqHtawijUyrHuGmO2InT0ynYizqgwy4lp756FW8/krpivKLdRCNMtc7dKRSdWSI3 +tfb+uVfyXraPurSc6I54evdImwVP4zEe2Q6ouWjjSTFk7DeZMA5jFa/VsSGMzwMjalh 0ru/bMUq+j00xB2eylXjPXBcCBci00epFmEOb+I2heK9tAhVGPfsErXEA1t+ZxtAww5l Wq59UyWqcOjROL847gYyDQRSltNxn/ijCIVrah7SwZQZieasjE31kBpBfAZ4BJQfQ77F haYXcNY5E1AW0QuFMHxbyvZ0E6swQQtrke+Ln3brPwq9dczFVzS2/J2EVh7R5/+ootl5 O5uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702585998; x=1703190798; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0kRc/nvAz1X4FEFIeTOixtRA67BZizfz7Bxvt/ZwY7c=; b=daZ3ohJfjySlUKDH8opB8CBUUam6Yn4vVIpS4HvTRgpUVaKf4UHJRLio4NULf6wRfS Z41M9FNwV5iXdGTaEnIjVa0ddacI1f3Gg4UBbO96p8blBffS1QH8RhY9hf0NRTCzFU+c 8E5XENZgrS4iZg+mxaK3PeKGDxreShGe+QQTn4Kcx8NP4RA79orog2I23yFFmPYoO38l g5qg/zemXGrR7CQw2feuk9gYfWJSi7+QjqP4/zd9yjYLbs49fqb0RFD9bcmIeNSCz6Lk I/tPspidKJU1HzLgy7QDy2i7Lh5Uymhn3XXaOyzW7+zJNvD3sSevoG2ZRwJwJuMOixFl bwLA== X-Gm-Message-State: AOJu0YxGoTNlzmt7t5haam0cdGRCh/moZr+I+xHOlP+GAfIPeL5VKfln Rv1mXXVTWLsrlAoCRPcPfBPHkrICdviMeWRpnu0= X-Google-Smtp-Source: AGHT+IHiglzed4eR7BGmo0AdxJVFnF6y/40c0buM2ThY7VhWH0naYI84JXe48NYtFhYD11W6KBZJqx2nqUBXY6ZR+ao= X-Received: by 2002:a05:6602:6426:b0:7b4:28f8:1e03 with SMTP id gn38-20020a056602642600b007b428f81e03mr13987242iob.34.1702585998604; Thu, 14 Dec 2023 12:33:18 -0800 (PST) MIME-Version: 1.0 References: <20231213-zswap-dstmem-v1-0-896763369d04@bytedance.com> <20231213-zswap-dstmem-v1-1-896763369d04@bytedance.com> In-Reply-To: From: Nhat Pham Date: Thu, 14 Dec 2023 12:33:07 -0800 Message-ID: Subject: Re: [PATCH 1/5] mm/zswap: reuse dstmem when decompress To: Chris Li Cc: Chengming Zhou , Andrew Morton , Johannes Weiner , Seth Jennings , Dan Streetman , Vitaly Wool , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7CB50100007 X-Stat-Signature: c6wyeyocuhqg14o7raixg98y7kfxtbha X-Rspam-User: X-HE-Tag: 1702585999-297647 X-HE-Meta: U2FsdGVkX1+r5lO3o85tHayhGYeS3+Wgruc1UFrE+mmGQIYMMKtngACQ73iWaZjaXv/6QeeTYub9eS6Kact/sAcvvWsQcq3BMM7tinxJldqdbol5U7/RKbkJEiSEVdZ5i0BhEZEFb3rxtfc02zchpZ8fGqZGgUXTAnEVB8lFQXXVICNq5M7zAEr8JM1TVPtHd18sB2AAoDphj/2hoBDuHNJT9UqJSEwxmFYV/v5wYTPvU/3v+4imzbSC2FayR3tpegRae0Sg4pBvf0DBM8ynLZL2v+0pPPBzKag9pVgTMsDl+cyF6IVO53MeD1nUB7VBWvNHXvppxNbdD/2Mh3omdG87o0xrl5EW/a5e+QeQxn7RCQhe5cQKINrosTy62BY4kNcfp7iFc0LkfsrpBdEXvY8tnzG+rtZjFeP4hH+TDmx6mIQmOhtYSvgJWvpcI2SCbqlvmTk2nDfupKaS3sg6M7lIgdUqcKsGBk7EavolIqVgoUMkOpLWnG8PuebU0ewsJRdIdq7Hb7Bs9cK36tYV/GNd3K2RbH/JI8HEnvdLODU5TkOfDwsPP9Fs20PfKgoVRyENKeGcI7zgU4BEInCJyhzlAHcAYlv3hFdhurpIMs+JAjO7KbCkZZy5kg6UwSHqTee0nmAB55iXdslRLsOQeoioELv2TlFcQyPd3KPR+LTPnjAv7Ca1R8lQZIgSY8wk8aVD2zOFO5VNSlF/2fePrIfG6HnVTu3tYZzUmgfDH4e3PGec0WsGxnF2Y8ICpZ7+0WEk4AizWjG8QOKZ3lPhwEbGSbG0Zw1KSpiN7gm0ML4Di24hbWw6LWJunWiwucNBc14viFIMDVPFyIuRBGYumidLRH24V/yfhbadqxokWcmpjcwRsPJyzywkU/poyVw4aZlTOTFpyds3glchbM9HoZkFteyaJq+ceuZNBZJLOeodllMNCuwnQpz8FVOANXRF15Sx5fC+rPFwagXhbks LfMYuS9x lxBm0oM8x4JB5NoHFusrEqxg9kHYiF2RR5dym4Cvyb+g35a64X1UlNvUHK9Znehre4mTxtHIduruTrgevDCkaAg7dH0Q61g3ymyyomQpiUEj+IqJkcUfZIoUWAYfYgbUJ9bNJVw1WdlfaH0g8n1hAWypr4Tdct6XOPKwjo+jEKyGJNH/VQZwxATsofuGiPz2Z2RR/9SoHTXIrgfHOaNgFt6mS0kqWyLzsfD71Tfc1rp4jmESqC48EIpAxJ/MjOX26rI9Vg1MCWCCwAgRsXEKyQs7XJ8nndYlXxwHKgNVJU/7XfaExx768YGAaUZFLYbr+XUbHsYB483yOAhlREUOZHRJukQXUI7Bv8/iqqX9J4aJzCrwTYNCrPIKJWc4tsuGBU09zVZcHevg4e+AJEgAB7PNh3J2/WIRIVC9JoLJNyI3FpU4ZRPDJe8H+aN6tBcr+ePBrT5Froushivc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 14, 2023 at 9:59=E2=80=AFAM Chris Li wrote: > > On Tue, Dec 12, 2023 at 8:18=E2=80=AFPM Chengming Zhou > wrote: > > > > In the !zpool_can_sleep_mapped() case such as zsmalloc, we need to firs= t > > copy the entry->handle memory to a temporary memory, which is allocated > > using kmalloc. > > > > Obviously we can reuse the per-compressor dstmem to avoid allocating > > every time, since it's percpu-compressor and protected in mutex. > > You are trading more memory for faster speed. > Per-cpu data structure does not come free. It is expensive in terms of > memory on a big server with a lot of CPU. Think more than a few > hundred CPU. On the big servers, we might want to disable this > optimization to save a few MB RAM, depending on the gain of this > optimization. > Do we have any benchmark suggesting how much CPU overhead or latency > this per-CPU page buys us, compared to using kmalloc? I think Chengming is re-using an existing per-CPU buffer for this purpose. IIUC, it was previously only used for compression (zswap_store) - Chengming is leveraging it for decompression (load and writeback) too with this patch. This sounds fine to me tbh, because both directions have to hold the mutex anyway, so that buffer is locked out - might as well use it. We're doing a bit more work in the mutex section (memcpy and handle (un)mapping) - but seems fine to me tbh. > > Chris > > > > > Signed-off-by: Chengming Zhou > > Reviewed-by: Nhat Pham > > --- > > mm/zswap.c | 29 +++++++++-------------------- > > 1 file changed, 9 insertions(+), 20 deletions(-) > > > > diff --git a/mm/zswap.c b/mm/zswap.c > > index 7ee54a3d8281..edb8b45ed5a1 100644 > > --- a/mm/zswap.c > > +++ b/mm/zswap.c > > @@ -1772,9 +1772,9 @@ bool zswap_load(struct folio *folio) > > struct zswap_entry *entry; > > struct scatterlist input, output; > > struct crypto_acomp_ctx *acomp_ctx; > > - u8 *src, *dst, *tmp; > > + unsigned int dlen =3D PAGE_SIZE; > > + u8 *src, *dst; > > struct zpool *zpool; > > - unsigned int dlen; > > bool ret; > > > > VM_WARN_ON_ONCE(!folio_test_locked(folio)); > > @@ -1796,27 +1796,18 @@ bool zswap_load(struct folio *folio) > > goto stats; > > } > > > > - zpool =3D zswap_find_zpool(entry); > > - if (!zpool_can_sleep_mapped(zpool)) { > > - tmp =3D kmalloc(entry->length, GFP_KERNEL); > > - if (!tmp) { > > - ret =3D false; > > - goto freeentry; > > - } > > - } > > - > > /* decompress */ > > - dlen =3D PAGE_SIZE; > > - src =3D zpool_map_handle(zpool, entry->handle, ZPOOL_MM_RO); > > + acomp_ctx =3D raw_cpu_ptr(entry->pool->acomp_ctx); > > + mutex_lock(acomp_ctx->mutex); > > > > + zpool =3D zswap_find_zpool(entry); > > + src =3D zpool_map_handle(zpool, entry->handle, ZPOOL_MM_RO); > > if (!zpool_can_sleep_mapped(zpool)) { > > - memcpy(tmp, src, entry->length); > > - src =3D tmp; > > + memcpy(acomp_ctx->dstmem, src, entry->length); > > + src =3D acomp_ctx->dstmem; > > zpool_unmap_handle(zpool, entry->handle); > > } > > > > - acomp_ctx =3D raw_cpu_ptr(entry->pool->acomp_ctx); > > - mutex_lock(acomp_ctx->mutex); > > sg_init_one(&input, src, entry->length); > > sg_init_table(&output, 1); > > sg_set_page(&output, page, PAGE_SIZE, 0); > > @@ -1827,15 +1818,13 @@ bool zswap_load(struct folio *folio) > > > > if (zpool_can_sleep_mapped(zpool)) > > zpool_unmap_handle(zpool, entry->handle); > > - else > > - kfree(tmp); > > > > ret =3D true; > > stats: > > count_vm_event(ZSWPIN); > > if (entry->objcg) > > count_objcg_event(entry->objcg, ZSWPIN); > > -freeentry: > > + > > spin_lock(&tree->lock); > > if (ret && zswap_exclusive_loads_enabled) { > > zswap_invalidate_entry(tree, entry); > > > > -- > > b4 0.10.1