From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBE2BC48291 for ; Mon, 5 Feb 2024 03:48:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 269236B0071; Sun, 4 Feb 2024 22:48:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2171C6B0072; Sun, 4 Feb 2024 22:48:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 106FB6B0074; Sun, 4 Feb 2024 22:48:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 01C8F6B0071 for ; Sun, 4 Feb 2024 22:48:52 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BFBED80198 for ; Mon, 5 Feb 2024 03:48:52 +0000 (UTC) X-FDA: 81756368904.10.EEF7C46 Received: from mail-il1-f177.google.com (mail-il1-f177.google.com [209.85.166.177]) by imf25.hostedemail.com (Postfix) with ESMTP id 0CDC4A0010 for ; Mon, 5 Feb 2024 03:48:50 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=d+fHhpmg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.177 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707104931; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5gj4GfNndW5LkU+ifPKRGdE3GovZ7M7Z/ViVrpmdWeQ=; b=isQDJJ2po2C53W/3iad2LdYjvtaa0P1uloahXHYV2y9KGjAN/6eAa3sENFbboMlxWiVnuA WDR1r4CRXsAaeKcmfHqz1MSthXYuLeERHgw9ziMMPFj3nS/Ccrr5NfIM/MppxoWdoORsGi UEvnBxfHJy1eswCoMTBgwOSoChPps90= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=d+fHhpmg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.177 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707104931; a=rsa-sha256; cv=none; b=QyMTMwYzrP0zKljArt4m0Yv8F++WQICS7Zsx2KapuP1YvZZwsuBEHQnW1Gb4b+PziUn5Uv ulwZ2Hq0GuA1TtywIwC7tTRbyTUl/3zzDdSkRxElYuaewyvMR746m+MfP7n4Q2Xnw5GR5U Si2Jo+qw6Jw0FuNh+J9HCmTkdtlUgXo= Received: by mail-il1-f177.google.com with SMTP id e9e14a558f8ab-363ba083d84so4449945ab.1 for ; Sun, 04 Feb 2024 19:48:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707104930; x=1707709730; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5gj4GfNndW5LkU+ifPKRGdE3GovZ7M7Z/ViVrpmdWeQ=; b=d+fHhpmgXffDmAd4cUf3ZKits+NEmYGEeUIwyZ88e3302Bc+NKumoPU9xdyqmzTlXA 5u8RFRj605tAR8VqYz/lncO+YyEBrZppyso2EZpnpQls2qZxeO/ToeQ1kQc04goHdGic Gi/mdtSf6PmFaOdm9xM700914IWldWQt5KMWPxCbQ1ase0kDqvKyxHkM/81RsBLLTzCc PUN7/Deg+6CgniCHBEY3GKJW2iZgZpb8BFhDQ1dfF/hhtUAT9KPjIjuhaCZH5f71GwX5 dWeA4aEUBZ66MTXmDmsY4Vfo10LWRdfSi9uT4eunzNIxYbpyeqIWu3f/0IZHH8mPg56l svhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707104930; x=1707709730; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5gj4GfNndW5LkU+ifPKRGdE3GovZ7M7Z/ViVrpmdWeQ=; b=SVFJjApPhSuPB8oc77hnQmPlEMO5NlTOo9hUThDL59Jv7V4coEW8zsa/C7IYspYt3D UpXbQ6mJmXLnvLO11EyFkLHuV106GZypyNTTgL3e5Yl7LT3bceDT+lmjbtDbZZIsKcio Y512Z0CB5LsfQhhncOR9dTsf2xZfhV3jclImYEdK0WlUgVdHKlUEbh/aUJuNFNFc1XE/ D0JB5ZorotpJyduc+v/1LV8MNvpVAiWo3jFrKO0W6/YSX9IlYzUSUBFXgQGB08Ydawlg TP5t8GLe6jsGeXUakXv5zjSVMFTYGeFWxqHVCzEhNp1L6SAX2iqBoeXJDB7ZaeK2EqYK aEFQ== X-Gm-Message-State: AOJu0YyMI5M803waQHpF0Pp6kQJVDA+beqeXgRXqJ/MpPZI0waFB/Fbm M77jjNAePYuqEofSG0U9xg/cBmw333AU8thDT5HWWXLQs4ZCipn3AuuyFrGHL2ZjnAkAmZm8Iza 1okTYDGEl18sYuNcKbqyRruDSFdY= X-Google-Smtp-Source: AGHT+IFRMLjtsdDgwlkMvwDBJc/wBTdkYch7X/QKUIlAyWYwSYbhXAi7m2/CpKXl6EQiqGtWvzEyEV4s43veWs+Gd3Q= X-Received: by 2002:a05:6e02:2191:b0:363:a442:3723 with SMTP id j17-20020a056e02219100b00363a4423723mr3694023ila.3.1707104930090; Sun, 04 Feb 2024 19:48:50 -0800 (PST) MIME-Version: 1.0 References: <000000000000ae47f90610803260@google.com> <5ea0950d-1b2e-47ae-b8a0-8bc0e99479f1@linux.dev> In-Reply-To: <5ea0950d-1b2e-47ae-b8a0-8bc0e99479f1@linux.dev> From: Nhat Pham Date: Sun, 4 Feb 2024 19:48:38 -0800 Message-ID: Subject: Re: [syzbot] [mm?] WARNING in zswap_folio_swapin To: Chengming Zhou Cc: syzbot , akpm@linux-foundation.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, yosryahmed@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 0CDC4A0010 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: xj439a4zp8usnbr379wmmm4gyexi5kh1 X-HE-Tag: 1707104930-712667 X-HE-Meta: U2FsdGVkX1/knDME+E6ZAanHpve5V4MxKMcwY4IWKUCxCL33FrHA6F23XuNDPzyWWmalsxkmmchKrBmdZPrKGJMGq1nlZRNRkvofwT2i0oAc+Qt/Qz0rmxWfbllPRhf4vcvUske2doyBfrx+bSaq0xUlKSb8W+FO4SJAWmvqqYsBH6HGcd9Cd0r4mhOZGckD+gzF+gtYLaQisnZGg7HPam3dcBnpBRxtCRPRa211cUapCFybDXvXXeN9tVbNTi6AV+wFsaVczgl6gcU2jzD5ad9TF1uINcI4FGrKBRLNLqCDwt159F9SG9ZBmUqae0lULcgw99O/rF4DY4p1mJ1j8Jb+DMRwGq7HHiFvKPEXLtHxUJNHM0D2lXsGWiwuEiyIvnETojnbRff/y4Cxn4b5m8R2kCwObfJOZ8Ay4FGSJz53MY6BIGPggLndEmz4Cij63ixZqSKWrykb7X9t0Hp3HmYLoLO4yuxjo8UGDj0qzPvckmqJcVx/wYKZ/jIzTr8GrHOQMss9AwF76+6J1Al8mkMEgrBTM7583k7cWeqjzQ6YVXvzzfhzgxEEMv4ZhvDSmNCn29w1INRSEfrIPqRDDmk++R97/6hU/B45cQWQtXVBh8QoBlqhdaXdIoO5NMHeSCPIIwCe4uGxBe9l/0K17qOVUzmS8ABYchbaOtendQGpVI64aj3Et+nqRzPeUygmGFwY3zNxrmsMjHg3qkGx8kLNSmYxkhYtUVGDG0X7OwW50yoq1BpGOG8NEsi32AJHNa/LXJ4Wt811+kbwxE8XIz4RfZ6Q5ziSiZR6bqvaW2iqV3JWcia1Ei1mJctoKpCCyZ8wyvXwdzco2bNdlne9Hz+8BQSauLD5VgqIoE3Gn4NhW89Bt6o0mFm0b79+qfK87GYkihMe+FcoGU7op/eH8e9D3fKAelB8P+JKX44//QzSJ3pLZFd/z8wAjv33cttpvirMDlTmKIeVzdFNxml m7dHB3ec f2dYtvMEwqh53BoUCurV/8twGTcBpozrxpgMw3ecpPaBc5VjXftU0QEilzLvNn4FTVJWMOB6aFVGw7s2B8/xjxDn+AOlOAN4E4L5n/J6+jaRnzP5i9ZEgZZvGSkVJptEa+3x1w5Gsh8ubF3QqTd6xwpX9iAw9CXv2ZYkq4q2ujWPPCPY9O3XMGFvY1vq2n+66b4H8gz+PY75ZFKFckDcKBQFcXx//xSDiNsiwrjtlrYCGwbbJ/1Y5YbaTufGPJDEsfCXf75QU58ikQdTDErILLSwmjHV/bTulGgrzTD1w45FVjI2esne8woiwG6AeuewgPURRA38szm07yk3wLuHgExzqpdujaofM43VTa9XpUZS7oBx9O05rcdhty8daG8yMLVhMmQ+ouPGwk/ESO2t45/dZm47zUp94v4kagwAeYtrA3bTvZGzCZFZh9en3SaIoehFn8BbgwU5qWi8XIA26I761JHS61CxlL0z+E+3uxhhJVe/UbhkyGg5nTsENiRjZvbmAEEPLhhPtbe3xhmSakkEZBrSVlp3dqz4oMidiVQczeclK7JoGbcDFNxdLQEwsiOKypuRn+itAF0odDv3OBodBnjvQ7SFx3O6+wIcfzVDAnOR7kIS1PSuZRGjC3892inJcV/v4YXNDugivGEC9iOPng2WksFivgOEB6YiCrOKDDTmYw4gs9f+foLhV4M97LZfpFrPRrd9JHA6wXtIKsAb+DdnYZzKVYNZ+jXA5OYMjrCXLzEAz//gaQQN94ZtKuHPvMBrJm67UqkSghsTto/Zkl8+uGUhRMEiC9k0bYuiArezuANFPQBVBEPaLMmUmmCofpy38h+VuFhHkITDVFocXUDMJFqwiUAFPvPEUgf/4CLMA2cgwpq83Yo0Xl4Jnw3yu+6Ksps6qqOoSibB5r7PzWYCv/mvXvvQZzBdV3tKL5ayvbBj05i9jjdplGFOOdqa+MzKWkLYq/J8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 3, 2024 at 6:59=E2=80=AFPM Chengming Zhou wrote: > > On 2024/2/4 09:28, Nhat Pham wrote: > > On Sat, Feb 3, 2024 at 12:37=E2=80=AFPM syzbot > > wrote: > >> > >> Hello, > >> > >> syzbot found the following issue on: > >> > >> HEAD commit: 861c0981648f Merge tag 'jfs-6.8-rc3' of github.com:kle= ikam.. > >> git tree: upstream > >> console output: https://syzkaller.appspot.com/x/log.txt?x=3D174537bbe8= 0000 > >> kernel config: https://syzkaller.appspot.com/x/.config?x=3Db168fa511d= b3ca08 > >> dashboard link: https://syzkaller.appspot.com/bug?extid=3D17a611d10af7= d18a7092 > >> compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils fo= r Debian) 2.40 > >> userspace arch: i386 > >> > >> Unfortunately, I don't have any reproducer for this issue yet. > >> > >> Downloadable assets: > >> disk image (non-bootable): https://storage.googleapis.com/syzbot-asset= s/7bc7510fe41f/non_bootable_disk-861c0981.raw.xz > >> vmlinux: https://storage.googleapis.com/syzbot-assets/b2b204c7b4a0/vml= inux-861c0981.xz > >> kernel image: https://storage.googleapis.com/syzbot-assets/170ec316e55= 7/bzImage-861c0981.xz > >> > >> IMPORTANT: if you fix the issue, please add the following tag to the c= ommit: > >> Reported-by: syzbot+17a611d10af7d18a7092@syzkaller.appspotmail.com > >> > >> kcov_ioctl+0x4f/0x720 kernel/kcov.c:704 > >> __do_compat_sys_ioctl+0x2bf/0x330 fs/ioctl.c:971 > >> do_syscall_32_irqs_on arch/x86/entry/common.c:165 [inline] > >> __do_fast_syscall_32+0x79/0x110 arch/x86/entry/common.c:321 > >> page has been migrated, last migrate reason: compaction > >> ------------[ cut here ]------------ > >> WARNING: CPU: 2 PID: 5104 at include/linux/memcontrol.h:775 folio_lruv= ec include/linux/memcontrol.h:775 [inline] > >> WARNING: CPU: 2 PID: 5104 at include/linux/memcontrol.h:775 zswap_foli= o_swapin+0x47d/0x5a0 mm/zswap.c:381 > >> Modules linked in: > >> CPU: 2 PID: 5104 Comm: syz-fuzzer Not tainted 6.8.0-rc2-syzkaller-0003= 1-g861c0981648f #0 > >> Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian= -1.16.2-1 04/01/2014 > >> RIP: 0010:folio_lruvec include/linux/memcontrol.h:775 [inline] > > > > Hmm looks like it's this line: > > VM_WARN_ON_ONCE_FOLIO(!memcg && !mem_cgroup_disabled(), folio); > > > > Looks like memcg was cleared from the folio. Haven't looked too > > closely yet, but this (and the "page has been migrated" line above) > > suggests maybe there is some migration business going on - > > mem_cgroup_migrate() clears the old folio's memcg_data (via > > old->memcg_data =3D 0). > > Yeah, I think it's this case. > > > > > Here's my theory (which could be wrong - someone please fact-check > > me): swap_read_folio(), which precedes zswap_folio_swapin(), unlocks > > And another case is !page_allocated, the returned folio is unlocked, righ= t? I think you're correct. That said, it's probably fine to keep the protection size if we find the folio in the swapcache anyway - IIUC, we are not performing a swapin in that case (since !page_allocated means no swap_read_folio() called), which is the scenario that the heuristics cares about :) IOW, something like this: if (unlikely(page_allocated)) { zswap_folio_swapin(folio); swap_read_folio(folio, false, NULL); } make sense to me, both from the correctness POV, and the heuristics POV. > > > the folio. Could this be sufficient to allow for migration? If this is > > IMHO, folio locked is sufficient to avoid concurrent memcg migration. > > > the case, all we need to do is move this to above swap_read_folio(), > > while the folio is still locked. __read_swap_cache_async() already > > charges the folio to an memcg, so no need to wait till after > > swap_read_page() anyway. > > Should we call zswap_folio_swapin() in the !page_allocated case? > > Thanks.