From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2664AC48BC4 for ; Sat, 17 Feb 2024 08:52:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0318D8D0003; Sat, 17 Feb 2024 03:52:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F22D98D0001; Sat, 17 Feb 2024 03:52:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEB0D8D0003; Sat, 17 Feb 2024 03:52:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CF63B8D0001 for ; Sat, 17 Feb 2024 03:52:33 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 84AA416019A for ; Sat, 17 Feb 2024 08:52:31 +0000 (UTC) X-FDA: 81800679702.09.8D53B74 Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) by imf11.hostedemail.com (Postfix) with ESMTP id DB71D40013 for ; Sat, 17 Feb 2024 08:52:29 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VI5hdCmy; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.44 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708159949; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nVcADDj0nEymChB7ziMte5ZKS47sKPhemhFyVJVaOIQ=; b=LsHZ3PNep/UHXYvwaZGcjZ8luFpsuEN3ifY22MJY7P9bB5rvrH19ffq7eiPagHwdBhT13P fgCi93U1p2p3wox0IcZ/2eN86e4642vqvQLbOqpcp1egEqdjGLw33FSj1oQjczAI0dgly0 2+UoW/bFJU0BuLKluwDK4yRA08IptWY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VI5hdCmy; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.44 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708159949; a=rsa-sha256; cv=none; b=LIdpm86jtmGirlf7yZPJCC0S9PVCBo8XXj3QnGkJ22UIGQ+JRYbLQUOdvrKw4q8yOHOcj6 7JycpMkvHjv0sLAVBVYdioo0yeuyLmM7iSeQbUBAxpMjhutrNeepczbUik00mr3Oo1Jk5o 2ddARrIK4c8l0zWZGV68Us+IBNsRw20= Received: by mail-io1-f44.google.com with SMTP id ca18e2360f4ac-7bade847536so142808239f.0 for ; Sat, 17 Feb 2024 00:52:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708159949; x=1708764749; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nVcADDj0nEymChB7ziMte5ZKS47sKPhemhFyVJVaOIQ=; b=VI5hdCmyTqiXk51hEH488scKXbxjYkmJM9d9SCzc5QI7eVPyCMCImLbqXE+vQrZCLF Mg83mP8n2ct/NAe3i9AwqLKivIEjFdwItw3MsPOrS5MRgaC+el1Ny/fJNZy3hyf6nbkH PQQ87TPTwf7wWCnURNFGezjnBxZzTB5f/7ARt8vfmjeYC0q5EV/sPZDPzsVJwMGMylL4 SQdcKR00Lx2kH1nE4Gkbt6rZub1VI4eKcwsQOGBYO4kysp1qJCRUrwg1AbvmufgXIFoI KjNECmZWak++3flIU8vyEWMpuZiva/wQzl+B/KvXn7nlIOGZ6A7cRiEJuVBC+krvpbVL Qw7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708159949; x=1708764749; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nVcADDj0nEymChB7ziMte5ZKS47sKPhemhFyVJVaOIQ=; b=Wliq8IHREpbXQiRFAtzLP1gyrRha71yAz06ygMGkEzfGkwwD1YzBpuPRaR+zDUXyA5 v/Ccg2qtW8eb44jp17r7ulzfdRp6aKC7sP13ucPpiZxMY+xRgZvOsXVhbM1F2qVzqppI 4DvAV6H7Hnu6xRD+Js94qRejeztbMhPHDs/kXse3FpmJG1mwPvydlME87qnKZlMP/mqz UEzb5kLlH7fjSnieoy0dbry65Y69UYkgAg6o4OgSsI6QZe74nKnK5xCAXljPcp3wWv1+ 0jKh+ALS+XPeFQjaH+lkfLUEBahAAWaRmyurq74Rwfqn+SDqquDho2vs1yG2jWuwXYuL 1eiQ== X-Forwarded-Encrypted: i=1; AJvYcCUQO2VpCVJTf0xhwdVL3tJ3lPnQ3jrXBg0k/T5dtlxcHqu2qBFZ4xdkSjlFrqVKc5NUTyIAVoWrqvlj5EU/IPFJgv8= X-Gm-Message-State: AOJu0YxDBlebQdgh08uWSWmb7yqIsZNI6TLmLW+dSwXqQS5ayUQ1AQfE wz5K5WeOKTKhRMkeyU7tjE29M+E+sl3a/iPa4ZMqQLY4a4YwB4DoY+VmInyB+YinkMCsBmVKNr4 DcyKO1lsBiJC/KqMBRLOfY9QvBlI= X-Google-Smtp-Source: AGHT+IFnJx52DSiIMZjoNsoOtv8syD71vB7wTyErRdSiRACxA0ljiaGtrESflzGZtF4GlcfjZGVMM4ws+4SzXrDfLho= X-Received: by 2002:a5d:964f:0:b0:7c3:e13f:a41c with SMTP id d15-20020a5d964f000000b007c3e13fa41cmr7885899ios.18.1708159948921; Sat, 17 Feb 2024 00:52:28 -0800 (PST) MIME-Version: 1.0 References: <20240217053642.79558-1-21cnbao@gmail.com> In-Reply-To: <20240217053642.79558-1-21cnbao@gmail.com> From: Nhat Pham Date: Sat, 17 Feb 2024 15:52:18 +0700 Message-ID: Subject: Re: [PATCH v2] mm: zswap: increase reject_compress_poor but not reject_compress_fail if compression returns ENOSPC To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org, zhouchengming@bytedance.com, senozhatsky@chromium.org, linux-kernel@vger.kernel.org, Barry Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: DB71D40013 X-Stat-Signature: dck9uhzisa5ck87eiw46d4oddbsg8cn3 X-HE-Tag: 1708159949-34510 X-HE-Meta: U2FsdGVkX185k5RDwZWnBHW7XoglK608tAg/jsmaOanoQwz9U/VL3yPa43/M/e4+E6hIjziyQdgqaHzzsnsF+6odsOeCoT4fgi+gMZGPsROxQCogLPX4K4jZTjqHd3gDQzTwcXID1ehnPWJfWc3zjsQyX+Wfy0wKTCBzFO6ejOrFXZ/DMb3QiQnaQLCTLSs0RQ8eCWpdaP53e2asbktRydMDHNhDKqvFzNwfgDkgNafcMhe55tKSPjrADtPo98D/bEK3Z3fU3ywDI8ZhRlSmO0Fh6iFtIcKewhlP8uzCt5GMg6hUb8ydNSf1ZZyMyUri/zEinwCp3qmr/PxqEF5MWhZhT5TT6DNxRcXxeJYpZ20GeVNz8rydeh+EYg3kIGWEik0swJDl5Vz//EM5hpSR+7vPg/TRkfmrYoX6T7JDdusNe4l41//KfGUtc5WoJ9tBgYzMtPB2SzWtwBnmEECLTwvMy2gloBEXN27CAEH9a+92W1xkj6KDjCiMUWEOqJtvFUb94jRWFpenuNd7jGV0emPzXTtIwKwq6IjJ92APz3s9BC2ENE3t2cO/0x4B9M8fpSvd9GY8zq5KosKK9MBfUQZn4eXDIhSNbdkBfFxazoHY6pRhWVBWd0tEOJYlMt0zBO7BiZjkDdxLGTNK1+HyGkL5TBytgAH+y9j3FbQuBYWwvgvrP0KUx/WOUP6/ghnqeWlJxrubHmw3/YvY9kB6kxnoGPEbJ5AssConrf+wR3Jg9YbVdaBlzTFFPE2wBUq1UVuB1nZ8r3dkQ4wWUFSr5XSo1uXRBOnyqbD2VhBhsQ/iZjshTOYif+1lyFtoz4nHOgjtGDICfMaUYzFQNKtIvVTdl6s6I4sOFeQzX7fvq4wARYjkGDcS8+ejqclAm8ks11pBU99plq2jYWj33/dCwx3wis0L3SIr+m1wNbbz9GDFBlVvyGcKnV5MsJdJG5WcLwbITVeUs+kGYbLMJ0v EL5Zl7We f0GMtt5lUK5SymVxnbn1ogfG5wDtEUo3Uonzja082YajnyOH/e0oR0AV6lHATwEz+/CbSpYRNfMbLgm0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.140369, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 17, 2024 at 12:36=E2=80=AFPM Barry Song <21cnbao@gmail.com> wro= te: > > From: Barry Song > > We used to rely on the returned -ENOSPC of zpool_malloc() to increase > reject_compress_poor. But the code wouldn't get to there after commit > 744e1885922a ("crypto: scomp - fix req->dst buffer overflow") as the > new code will goto out immediately after the special compression case > happens. So there might be no longer a chance to execute zpool_malloc > now. We are incorrectly increasing zswap_reject_compress_fail instead. > Thus, we need to fix the counters handling right after compressions > return ENOSPC. This patch also centralizes the counters handling for > all of compress_poor, compress_fail and alloc_fail. > > Fixes: 744e1885922a ("crypto: scomp - fix req->dst buffer overflow") > Cc: Chengming Zhou > Cc: Nhat Pham > Cc: Sergey Senozhatsky > Signed-off-by: Barry Song LGTM. Reviewed-by: Nhat Pham