From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 200DBCF6491 for ; Sat, 28 Sep 2024 23:26:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FCB16B028E; Sat, 28 Sep 2024 19:26:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 961256B028F; Sat, 28 Sep 2024 19:26:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B0F26B0290; Sat, 28 Sep 2024 19:26:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5C3F96B028E for ; Sat, 28 Sep 2024 19:26:44 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 14F4C80D9C for ; Sat, 28 Sep 2024 23:26:44 +0000 (UTC) X-FDA: 82615733928.03.A4295E9 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by imf21.hostedemail.com (Postfix) with ESMTP id 595891C0007 for ; Sat, 28 Sep 2024 23:26:42 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Y4qa9ndz; spf=pass (imf21.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.51 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727565837; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NWBwFAR5Ik+IG8bbMy7WMmwPVqCgbJTOb7GVlUolyvI=; b=n3nqqPJTVdOlBdhkkDbIagcXP+0kSH00ZZSmBvrLNrvmKclUBscBvfn5Yr9ou7q4GmoV9r HLW/0Ojvm81DHxQQFXIWVS14aIol6El33Zc+N3INP/78qRQROvN8N00+4DGLdc4vsT5HqW G6vCDGNsyIXLZtAwE9btDczLIIvlh+g= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Y4qa9ndz; spf=pass (imf21.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.51 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727565837; a=rsa-sha256; cv=none; b=dvANMgAs/ytOCRHPHpQ/pSneEZi/Fqk8n4tApvUW9ug9eqTFTb9jWBbfnNnsVGQP2FCvGT fEq29+D8NZW6L+TWgqyz1p53xnsXzqYqv/Z/Cq7lbriWeSWFAlkGoup3nfcGsOqw7zGZYg CkMaqWwaf8E5hzmhbDQHm9bzAus/m5o= Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-6cb25aad5dfso30114176d6.3 for ; Sat, 28 Sep 2024 16:26:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727566001; x=1728170801; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NWBwFAR5Ik+IG8bbMy7WMmwPVqCgbJTOb7GVlUolyvI=; b=Y4qa9ndzbF4dYDYcWZoxvVlpC0CBvCf1YySCeLimgJCGA/LXLl65czAwf1iackpdCH MHWRdbUTBkQtNLzX/n3pYnXddguNgs8OrB+jvhG6e9pX/FWk7hmRFcOewfCyU8sucYzF kUYWuzSwqLQPKYxFx9mrJYllTnPsL7IKfyjHUBGrupumt4DFI7a6itYRSgs5RcoLy8bK Xie7aNHbaN0x9QoHn2fdZckeDB4r0ZSYfsVKV6mpWJlNPXPxk6GhUBVFv8jZgIcSO2nq xomWuafIHT97JVUhopAx3l6pv2mHbEkCFfjjKqsUHqtA7w2eyq4SLsISurjGioaClgZk nG2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727566001; x=1728170801; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NWBwFAR5Ik+IG8bbMy7WMmwPVqCgbJTOb7GVlUolyvI=; b=oBNYybQ/juhqeAqblgHb8h0cmBKHli8HeFIS0fvpfqLpclXp5EknMWsFcNCRxecVJc JHMFcmE3WKWCkOHTTbi9HHHVHrWEi4sHceM+NXUKMgI1QFkWZh0daRFGpRgKcVH2ppmv 7MMGHc4HiWLrl0YqEwL943w3UlgON/f2EVY9odLm5MYy7MlznLOVWPUAErDQD2BtZkqA aJQymvfLT4itKDFagk1Jp2L03LnTZIkeZ1WXgoXqFJRTX88MJvRSUfCTIyjAfOHm56Pd JqQcn8gm9/WkfhCR91ZIQ6USCeLMyXMpbou25+Unz4ZpAzcS6YaAn3KFYhjV1NTlTxsc NUHA== X-Forwarded-Encrypted: i=1; AJvYcCUa5f1Edg5E6hXHvysiUzd7qoKF+4doqLrTkQjKtn6apbgAGWr6pb79xv3DzxuNMlFG69IR7enuFA==@kvack.org X-Gm-Message-State: AOJu0YwZimkG7Rv8WDpSqRCXTRMX94wz1OIi5J2TPY6Nc1bat7fSAbRy IvHa2NdFWgh4q99E8MNBiUDvjza7gMPJ3PrN5KA64NUlntwQadOYZO0c5gJXTctP5Q3aWjiV1lM iLExnpXv+ugNjKIPu+8n6dakMOqk= X-Google-Smtp-Source: AGHT+IHYUgCIc63IqxiuuY2XZ5p0a6uGfaFwjwZFIA/gs9PifTlgRHT6xQafXPDfTM5sfn0U3gtjyjfeVyOiqMM8r9I= X-Received: by 2002:a05:6214:458d:b0:6c7:c63f:b414 with SMTP id 6a1803df08f44-6cb3b6407b6mr135464656d6.33.1727566001312; Sat, 28 Sep 2024 16:26:41 -0700 (PDT) MIME-Version: 1.0 References: <20240928021620.8369-1-kanchana.p.sridhar@intel.com> <20240928021620.8369-4-kanchana.p.sridhar@intel.com> In-Reply-To: <20240928021620.8369-4-kanchana.p.sridhar@intel.com> From: Nhat Pham Date: Sat, 28 Sep 2024 16:26:30 -0700 Message-ID: Subject: Re: [PATCH v8 3/8] mm: zswap: Rename zswap_pool_get() to zswap_pool_tryget(). To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosryahmed@google.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, shakeel.butt@linux.dev, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, nanhai.zou@intel.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 595891C0007 X-Stat-Signature: sjwos9papytotouk3q9zcjyg1t78n1st X-Rspam-User: X-HE-Tag: 1727566002-655749 X-HE-Meta: U2FsdGVkX1/uicTYCshGqQwIxEeDkfRh4YEonTdtGxrS1bACtVgeE6L2/bsKC5CygWCSvMnwxR2CY0GGVDEIrsikVX7tEU5wkaEgYbBBoF5UXEl7p0vPKHnGd3IJH7HdrL4xIGqofGPAFNFViTj994zrSJqxliclLLSV/sXz4ACnU8GEOdFKuM0RtiJ6uC6lqUTrNjURoLSUD9YDroP0PF948466bAJusA12di9NamWKew/cXaCoXOsG4aWZeCEyHZwA61ThcK/uJJNR02Gy4fiqvNNGhcYmAgzQioH6YNDK6+/0HIKdKCAxYlVajnff7Yx9ZSeisosvLJ80hIPFIDiYpuB+N4QAKr4GtBO0uYl05OCXfP2H5/olCGTWLbWEdiaNdQ5fF9pUYlHugvSwxxtJa81wHxqpkgLEn27aQXC5tkDpoy4Uujw2AkndByMdqQXaWWJ4fT8ZJQcqEuleJEyp0wqBQU5G9B01zlztLcqnQNKj56QAzYE9a2PUvXTmsZsVJRJTqZRpzy7VKHz2oIuI7c2tVi2NdE37LZ4SvaDCFJWdhhYtb5F/ZpUqoyyLO7ShtkqMwvjntXwmrzjc26OMuQ2HDFbT3Lr8e6yCwBsi4nDjvMT4mb7s2+mtX2qzMqCCFTtlNkSoKtUOMSu6wjdnKQK1f2tyDRvNQ1VW8e8jSmcLRa/rK7NQ9iqlHf2D3CBXhRfY6j7R1rRVswXFAz8dnOhcA4uzkI9X/0/a42eA96AlR+xjyuJIwnUZY16fkJI/kLS14n8Zzn2PHTMmr5itHgChc+59/Wq9zEhU3rWL7OytTfz6lD880ZuDwRvZgyIyOvrpKDycegsBtdbedG+s8TyW7UNPSOrcfgxLi/TqHER+VrfdsL39b1ZsXkRbJ2GCU/i688nKCQyGIHXaE2oKeAyHDu2Z96djYT/5vfC73TWnQIGNQW1FzfgGs3ki957TDdnjlQPH4RVZPpA rdiEDDUr D6xdjdW35NwXa/I1m/hNRMItT3FJnWqGyhBvIFjpEHjvlzAYsAk/pH2pUvNKzsAWPHAexAKMfBCEXqszWOapsGUgknZ+30ZfP/F3Anv/en0DWfL/Kp1zg5MLxUR0wpxWNF/8QsGDm1HAkmvuDcNy6DILWRFOeFAw8VXv7bh8Po6buMpv6i4o0Mtv/GMAZ0p7uF0RkZzX1gUSgCTAE7ZqZHGiv479uOedJx0RjruS4aJbi/b6ziOMonPzw0qiT5wA3ySJFHRWWe73vEPw2IYjQMXC0IB7t3tez/MS/owDitg9oqvpwkPv9NKI93c0aXG3UGCN1ISavnROcexpfAt/hnWV7qNFaQwXPRQMFBrve1xt2+iPXFWY9MTVi3teb/expglHbHgCchuCzWpUUME5B3HUJY3fftlBN0wXY X-Bogosity: Ham, tests=bogofilter, spamicity=0.031208, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 27, 2024 at 7:16=E2=80=AFPM Kanchana P Sridhar wrote: > > Modify the name of the existing zswap_pool_get() to zswap_pool_tryget() > to be representative of the call it makes to percpu_ref_tryget(). > A subsequent patch will introduce a new zswap_pool_get() that calls > percpu_ref_get(). > > The intent behind this change is for higher level zswap API such as > zswap_store() to call zswap_pool_tryget() to check upfront if the pool's > refcount is "0" (which means it could be getting destroyed) and to handle > this as an error condition. zswap_store() would proceed only if > zswap_pool_tryget() returns success, and any additional pool refcounts th= at > need to be obtained for compressing sub-pages in a large folio could simp= ly > call zswap_pool_get(). > > Signed-off-by: Kanchana P Sridhar Reviewed-by: Nhat Pham