From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AC40E7717F for ; Thu, 12 Dec 2024 18:11:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CE2B6B0099; Thu, 12 Dec 2024 13:11:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 17DB46B009B; Thu, 12 Dec 2024 13:11:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 046346B009D; Thu, 12 Dec 2024 13:11:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D938F6B0099 for ; Thu, 12 Dec 2024 13:11:36 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5E30A1C5728 for ; Thu, 12 Dec 2024 18:11:36 +0000 (UTC) X-FDA: 82887098658.03.D48DBA0 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by imf01.hostedemail.com (Postfix) with ESMTP id C431340010 for ; Thu, 12 Dec 2024 18:11:15 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EJrXRj6d; spf=pass (imf01.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.52 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734027083; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fmL3IjdHxzakIx4CxIGIr9XO6NTz4sWtktTZlSVEfDA=; b=eJ379xe8tCC0MzY9ETOO/bsuUhFA+skW8NujnXKVT1cNM9pW4yPR9mUnBvZF/47DtJCt+8 4B4PqJnPYYNU/TIv0UFbUXzr8BnDGsfDJIm4x+9voeuH7ciVpZMOcpN5Zqb1JA0uelJ/9u B1YtyPMBN9KTSnFOEhIEa8yC5H5vWOY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EJrXRj6d; spf=pass (imf01.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.52 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734027083; a=rsa-sha256; cv=none; b=QPoFnJOkgJUF33Y92yIP16F67QZBuYT60OnuTh6uHnanljtJOvDRXAR46KmhfJsAAvo+Z+ j6QHd08oWyrdHy+JH0EhCVue10hbmwZt8gCf0Mqa56/ttKhvb/NgaBcsdLioq97CZ1OV++ beGwCmbLuRaR3ACRuXrTK+82RhQpKG8= Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-6d888fc8300so4633736d6.3 for ; Thu, 12 Dec 2024 10:11:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734027093; x=1734631893; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fmL3IjdHxzakIx4CxIGIr9XO6NTz4sWtktTZlSVEfDA=; b=EJrXRj6dGpBa/jpNHCkL390eIk74fueK05vOlM6psrR+7g6SRNtfwZsmF2dTZ2CIax Hnt/tjYJ9yxz2l8pyqFpqtyqiyAoiWpMoKzHskqE5VxEhQlE7ByfPdBZpryLmHTNe6Xv yLwj1NojEptHaO8/Hur9BRGWBywTCMMYug3X6BThent8svC3B2ZrHTeyIgPPBwAUu0a6 GVF229JOwn9IjGsVARN998lRJy26hCCsT9OTAK86/a6CLOUt5rfAc7YB4/us2RN8f+M9 68rcBfc7JXvhm0n5KO97upxf61ieQljyu4E02+qTFWDTg9aMkbFyH9mnaOeWnTCBsRc5 xscg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734027093; x=1734631893; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fmL3IjdHxzakIx4CxIGIr9XO6NTz4sWtktTZlSVEfDA=; b=mIeLk6fbRJdyCWMGPBVixNFc+lxR3ON6gXUFGT05ffm6ew9qQBlnCaIVjNAh6R+NdG 0SZfD45naKvTs0XIyNRccbep0Sgo+AcSew9OQhyo325W50797ddZRfMzeHgtVJX0BZuu jgkLjU3x5zoFmi201/NEGvDfaM8kYonuvodSs6Z9FpFUm5etu0j7P3LkleiyqbYsCI5t nrz48shz4iyI5zK+7ahC30QmhadGNYTM0AnUOAgGD2njRhiN9JXaIhjoU7yW8d3w3Txh Fma6Jh+eLnqZb1pSmTJ0BBPH2fTNg9c3YqpQrLYpCVnOwptwjeBnMcaKr7tm2n0OwWkm 2c4g== X-Forwarded-Encrypted: i=1; AJvYcCXU6EOHcusGJ9TkF0SKJP7QjSXTcHcRkLCgfRaD8zMu0KwIE2FR01AFQ+FJQtW90/yg79zrA+dllQ==@kvack.org X-Gm-Message-State: AOJu0YyuXO9bJdKWZI4YoUF/Npuhp7GFV8McWviAoaXC0hp+vUhIpFvW ee/pMB8KFr4jfTy9RpOlbddIP1d2vfbN5wuJEdci58ekWjw2UM0JURcK9Fq/gKpeatf2XIY9xOq zCuZAAEFJ6tkzz7Q70NaukN504bo= X-Gm-Gg: ASbGncviPu4teBxwhgPD09cDH02cXQNspXoswXl4Sr9w5pcbobyXyDNdwsCAXx87jm0 DXwbLdm9Okh/xb3le5DDjaxX8jXkadRjvLuMp2bkqldgFzi3ToG9Nrg== X-Google-Smtp-Source: AGHT+IGdSVDteaH2QQbaWou/DQ1MrAOaTamUlb5Me1k16b6VG4xFSaTPJKAjeBQlXrI/yb9wHqeA55Hx8Uz5Hkk9GWo= X-Received: by 2002:a05:6214:2584:b0:6d4:2910:7f12 with SMTP id 6a1803df08f44-6db0f827c69mr21459886d6.41.1734027093508; Thu, 12 Dec 2024 10:11:33 -0800 (PST) MIME-Version: 1.0 References: <20241212115754.38f798b3@fangorn> In-Reply-To: From: Nhat Pham Date: Thu, 12 Dec 2024 10:11:22 -0800 Message-ID: Subject: Re: [PATCH v2] memcg: allow exiting tasks to write back data to swap To: Yosry Ahmed Cc: Rik van Riel , Balbir Singh , Johannes Weiner , Michal Hocko , Roman Gushchin , hakeel Butt , Muchun Song , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: C431340010 X-Stat-Signature: ibrcof4yr4y5ggq41aixcko7qxksduqw X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1734027075-805233 X-HE-Meta: U2FsdGVkX1+vsKitr/5ePc7yk/TQcxIRcuH1lhkzM4nnKDXMw9Uc9PMWeYUTm30JSwt2ZH0NXUZp2eQ63NGWeCAGwizDu2QM1tUZRI8muuRXh6ZdvloIQGTZYN7H0uF60PiqbrgIQ2Q1xZ+9MraSY+kN0seH2nTjYx/vxkFk4+S82H2Ro0H/R5nlZGnGO4e/V89qAv2x74CSv9QxB4XA7z0/puH8PBcVHJsJP9xwe+hBX9JQMjnN2143EI1cJz5s91xR8YxQZUk04piTbEuZ3EEtANEZjDzxbhiN6kMdwdTXNY2TdEjpQyfwgYoCrjnWvh8Um+aU6/2Gas8+e+J/qI3e7j9Y4R8y6TIiWmmmpaex/O9I9XDGzISyvbKgYQXPZcj8co+CYXsEnl7h2XsoHZMVQruG9IGT2mXqLwAiY+d/06I5pK3EFuOowYwalLWm26ty3825RP51Bu9NGzz2t1G+/pNWVl7p2apWtoTUFvGDScgY9bFB/koEh6i1/Q8HYJPVY4nNyqQICo0XTj6y/ZleZUirnY6Nsb3uN2/oweuCyrOQBtcZNayKdGl7O+Yi6mNaHSi3GwG9JI9nufXy6oA0eXVsZyISCCyxf1ibrv7M6NHl8Cyo9USEEUOrgZHhVNdFQJcHFrWPHrctznbeooWDrs3TRSwqohnOFwshxILvJdjdptng4oixZDrJ318hmt5vmjtNe9fAo/o9SIXDJi2l1K6rS7eReXy0a3DWyj2nAy2Rirg2xU604PfL33oAnI6Aod5w6VmNQ9bD9G2MOzhMF/I5yCly7NxoNOeYJEsJm+empOyRQEx94RqigpoWasgDthG5yppjOTdzJI60zQNwRxAzEjFJLejzsLXvaSOBezI4+B7cDbkSi3pOXRyLePve36CN8lLZLQKy30pxMba88QPhrclF3om6TsXAZPkgLzLH6h9RcqsZc5ABa2/rSwAH/sNP2uzfRhfVyXk sO5iRcQJ sUFkcaxOmTKLJMoiidqW99+IgzSwb4hknxt8EO+KzgEFdjZCiu+ljqzDz7LXgZIEiahLb5UyBFUVMSRg8uJu3Nq7mGI4VwsRDGNhySZ67Fvn6GEQdGACCyUKFYLbyx0Ub+OJwhZOw3iN7BWQmXhrrAN3pzAcCm/xtk8Vc5vKb5WGRIb1oJYw8XaTXi8UNAE2aaBQXlQJnWZH2xOWyszRh+Z79yme7pSkUYSbioLSkSdmqjPLO81LfHduFzJXn+aQluS5r8eF8YuB9vb8x2hhAeLFb68/rM/+slS6Ptl/DV2WY8CifcdTIXQ7IfJWISPszsfSXM24KWrZ1qiqoVJJQrJWaWHLIgQrTKmA+QP50llQZb5ls7JIi23kbH2JJKwAj1lPTmc6Scy2/Xcnq1sPo7w+P3A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.169271, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 12, 2024 at 9:07=E2=80=AFAM Yosry Ahmed = wrote: > > On Thu, Dec 12, 2024 at 8:58=E2=80=AFAM Rik van Riel w= rote: > > I still think maybe this needs to be fixed on the memcg side, at least > by not making exiting tasks try really hard to reclaim memory to the > point where this becomes a problem. IIUC there could be other reasons > why reclaim may take too long, but maybe not as pathological as this > case to be fair. I will let the memcg maintainers chime in for this. FWIW, we did have some internal discussions regarding this. We think that for now, this is a good-enough stopgap solution - it remains to be seen whether other more "permanent fixes" are needed, or will not also regress other scenarios. And they are definitely more complicated than the solution Rik is proposing here :) > > If there's a fundamental reason why this cannot be fixed on the memcg > side, I don't object to this change. > > Nhat, any objections on your end? I think your fleet workloads were > the first users of this interface. Does this break their expectations? I had similar concerns as yours, so we rolled the solution to the hosts in trouble. AFAICS: 1. It allowed the pathological workload to make forward progress with the exiting procedure. 2. The other workloads (who also have memory.zswap.writeback disabled) did not observe any regression.