From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40BB1C47073 for ; Sun, 7 Jan 2024 21:29:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A40E6B0072; Sun, 7 Jan 2024 16:29:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 853FC6B0074; Sun, 7 Jan 2024 16:29:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71BC76B0075; Sun, 7 Jan 2024 16:29:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 622966B0072 for ; Sun, 7 Jan 2024 16:29:25 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 241EFC0181 for ; Sun, 7 Jan 2024 21:29:25 +0000 (UTC) X-FDA: 81653806290.27.4233422 Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by imf12.hostedemail.com (Postfix) with ESMTP id 69E4E40005 for ; Sun, 7 Jan 2024 21:29:23 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gFLQYPM0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.49 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704662963; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w+A9E7kevV/RA3nngibl71YMsf/zK8ry/8PO6emuYBQ=; b=3yI0RXzcSyqyJlfeD0Vdu+LRpZbtcdamlThsTDyAWNCu5IIYnhNm0NgxzUkyag1utWmAzb 6v0knKri7AvrEV5q9NZC/AiFbxacgWQLiJ9ev0IcKMOW4GEo8u/06W4SAwD7AUrWqHI7y5 6ReLvz1PP4o9m60JPlD4zGsujf+um2w= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gFLQYPM0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.49 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704662963; a=rsa-sha256; cv=none; b=7NwwBZLploL5wQPrec/2ZTpPdG3Tf2O4x3XaR2Ad59qq/b/HK5WpgSST0gcg2EF1DkV1bd GuzayZy7+O9rMbE2VuzqltnXtTz6PQgdOC8sB+S4vVrcRtYUCrSc70pH2taIrVq+rVuDV4 xlPkTfHtwBi5LsUcKH8H3qaOW11PoSM= Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-7baa8097064so74404639f.3 for ; Sun, 07 Jan 2024 13:29:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704662962; x=1705267762; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=w+A9E7kevV/RA3nngibl71YMsf/zK8ry/8PO6emuYBQ=; b=gFLQYPM0B6pz8iE9Ofl7lgZAxbmC10Fxa803Du5bvdgLQlllNgrFQCD8a23tAn0deL 27erl3K/VrHMeV1cjg2FqSIGWS0m7pvFbM/mqkNsdmIeEaeHNT2t0A2Uk8SgEiF6BR8O CsBbqmIVHYD1f1FR32BEExyRv2CFRSzLT4qAOFR4tneXA0mUuH6YpU1sHkOeARh9u9Gi YQnbyFgsBZgPEOYorymEkEtN4QyB1lrGMg5tRsH7nX4qs8yuSQyJ+nv+B+YXOoWuhk6s nU3VVZMkBNNihftK1nioherv6aRAwywhzGIS3GbLmuFE2VP5pn/zRxVy2jF/q8y/Xx6Q KfzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704662962; x=1705267762; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w+A9E7kevV/RA3nngibl71YMsf/zK8ry/8PO6emuYBQ=; b=pCCUpXSb7ppXs1EtXx98aw/XO9CB9sLlbWAC65NIAfExiZyIgbnB+JJfqgs2IaP993 aKXVSv5o6igu5ULXC+NUhNqk0KHEikFRyoH4DQRLGffoopMn/nbPq7B/QfHlBGCZk8cR Qww1NUzMopomJc8WGHqCaDO++U5Tn27ypmBih51m6ES8PiBDd2als6lgHNXCr9kKzIE/ aJGNtLMHIxTgrNzitjREGgcEY1z7VQlea3HDIuXB5pUeG/7BUmKxs9rsD5886UqxldMq Jzvxvwx3ht+6w7fgQEqNVEuydtIwt89GbuHWv1PZHcc9DzSU6IFuXZkXToifqksRYhNw e54A== X-Gm-Message-State: AOJu0Yx/EVcmNFiVty5s9cGeg+gNC5Yvs7D3I6No1Mdd8XBU9ZzUR1+k m8huf0USbhZ1KjyjK/ThuOtVq9VToWKzs2pq1Ew= X-Google-Smtp-Source: AGHT+IG5qDMpUKh4eFvjrtkXIIIvLbkauOykKNFxNFJAPWhbBgDPUuBPa2vo9QUlGerGEOkPE8DsMjU7YnV+HdX+N/4= X-Received: by 2002:a6b:ef09:0:b0:7ba:9a74:731a with SMTP id k9-20020a6bef09000000b007ba9a74731amr3555049ioh.8.1704662962484; Sun, 07 Jan 2024 13:29:22 -0800 (PST) MIME-Version: 1.0 References: <20231024142706.195517-1-hezhongkun.hzk@bytedance.com> In-Reply-To: From: Nhat Pham Date: Sun, 7 Jan 2024 13:29:11 -0800 Message-ID: Subject: Re: [External] Re: [PATCH] mm: zswap: fix the lack of page lru flag in zswap_writeback_entry To: Zhongkun He Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, yosryahmed@google.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chris Li , weijie.yang@samsung.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 9nqmdm7dnwktu5qbfx8b4jmmobcp79gz X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 69E4E40005 X-HE-Tag: 1704662963-471642 X-HE-Meta: U2FsdGVkX1/OgbQNwxIef7hMsHNZ+VGgF+SpPG+JMQaDrRt8A8GbfDfynTqRQjZ90rD7/LZKycwUSfDudQseHH2drEDZO8qEzWujbiAgPiXE5Y1+c0qDC7PPH9cXsnFbOK0h8O7kJhrV2ouIwn8CwizLCYlK5HzuvQjIKaJket9auUuSUaKBwvJ/SnUS/89QP4hgz7NBXHhyU3tVUpNcz5NL2hDxlnIoxYNw7FyKAeGQlP0R5MF81eT9XE1oRzzAXP8hXuUco6zd4fH4580KXaNPLuHffmq8yO9SF/YQ5lmyD1S5H/oa07sPyMOCRfI7zWBdtXg/o7B+P+B8RQhKwfnuHSIdd6TFN3MGQQ1TjqmErGvZlHIo7r/S4vUE0YItoeSXXlnarRID5Ak/VVmkrAB40FHAZlOJgCmpxwR1cyhZZpsiPpGF+aUVFGDmBayDAl9Z0Sg/kjOc737+Jgu+uWtFvS/daiC9iNPhQTmmsd6+kGTHGwC3VNW53zZ3CDRLt3E5KDmUMi8WxTq0h1P4rdYKxkV6OIWHV4ud4XTKQ7AvT7WuAy6cYXsP8C71O+etOvyUres1lFoaeLDgH4g1bxyjkn26Ge1y/XAy97taFXG3cX1GRcrNoNttCf1qAuwlfiMlPrn9qodRHwuevc/onrlqYTLQAX0Q7muGecJa6byMQE6IIfj0j3VqlaGWOQjqlySte2jfrT5YUpLnN2FHg42v6L9G/eaXwWitUt366PEHB0I0w5RogOOnK9JlibCpvSnfryzPW/tldNLhJJ1DmrmlHp7AXhUpOPBhAGQBefO3D7xTSIlzflZcuHIqAyuF7qDKJT6uW4QmGOK3QBHZUNj5GdB/VQmhuNJqMIQka4yUucHP1kd9JDCODiH6hLLbRWyuLNpRvK6voP6K8kY5/1hc7Ykb9vIy+5x/HwiNEBw0oWjBMrAS0OT9AWl2sI71Q3fZXTg8/Zh+QJ5llTc XfYcWhVy 08JYuY8oeDI4kkX0iYuGj4JlhBRLE4n70Rs0bSPAtv+M3SiNKEeYa8Xa0iFagfGU3d+lgME1kIss+vrfJBiwZ3o+eqtM47m5JDwtKTNhcvrIUR31U8f/EQnghy+HdplgHhePYo5C5a4K3etpYLlpwmxo7RBnB8879he2LksCg4M6XK9BRZc9/HR/V2L1GcbMzRvB89bIz1Pt2VBYxUu5JBG5lNoe4lRI5lR4k83tEqCcp6N+aMc595iN0nZbIDo9TLrHlqKhmnqE2XI6gktC4Y/f/4zOH8qPFehxyTyFDfZ/mq4Pvb7H6aD8wEGfwu+GTRayMnotK23/B2KJAI8pm/vvPs+upEIi/9vtm1Hj/LAjSCafNd6FdrBHStcpCrMT/1IyXL0lvIaBVEabZd/NT2sHf//+AAoGxIEwFSkwGEa8tgFnWbso0zwChhgRCHp+6lS9s119u7K4ffYy4a/zDFtE4r8AvH2B1/5+ffrMuouaUmrB827+TDh35sC93jspeMzfD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000171, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 5, 2024 at 6:10=E2=80=AFAM Zhongkun He wrote: > > > > There is another option here, which is not to move the page to the > > > tail of the inactive > > > list after end_writeback and delete the following code in > > > zswap_writeback_entry(), > > > which did not work properly. But the pages will not be released first= . > > > > > > /* move it to the tail of the inactive list after end_writeback */ > > > SetPageReclaim(page); Ok, so I took a look at the patch that originally introduced this piece of logic: https://github.com/torvalds/linux/commit/b349acc76b7f65400b85abd09a5379ddd6= fa5a97 Looks like it's not for the sake of correctness, but only as a best-effort optimization (reducing page scanning). If it doesn't bring any benefit (i.e due to the newly allocated page still on the cpu batch), then we can consider removing it. After all, if you're right and it's not really doing anything here - why bother. Perhaps we can replace this with some other mechanism to avoid it being scanned for reclaim. I would cc Weijie as well, as he is the original author of this.