From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6EC4C77B7C for ; Tue, 9 May 2023 23:59:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF2B06B0071; Tue, 9 May 2023 19:59:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA28D6B0072; Tue, 9 May 2023 19:59:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A90906B0074; Tue, 9 May 2023 19:59:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9D8366B0071 for ; Tue, 9 May 2023 19:59:39 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5C5C9C0A02 for ; Tue, 9 May 2023 23:59:39 +0000 (UTC) X-FDA: 80772386478.13.95C5C22 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by imf25.hostedemail.com (Postfix) with ESMTP id A2427A000E for ; Tue, 9 May 2023 23:59:36 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=jI8LJRH5; spf=pass (imf25.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.222.170 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683676776; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i2CIzUyY1pWutjRxzxqcAiM7lwH82V7tG/M1dYLRQig=; b=3KiE0rTmiBP465QIEpx7l5w8ClyylDSTqQF30nSPluBJc8JwbthpQZDo/dUFY18VlYQlx/ A7XuZVwLN0Ekk2T5RBwPkgo73vLwh70uGFfDh9nzE3VFBCOmpSXi+5s2X1i+uEYmT49giE a6gLFacL6CUNLHomXyADheXcB/JxSfA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=jI8LJRH5; spf=pass (imf25.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.222.170 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683676776; a=rsa-sha256; cv=none; b=aYycbW7UvEB1aVEiqMFvm4SdKlCby02r41qzmLNwjFS8dXtvKVbXspxTJ2zHDajMsq6ifJ 0oqtmYT5YZtf2o60xRCttQHxoYtCEVrDysJnsRMh4kRJMvOHdgJJk9/EZzPwUFYsn+NGv7 AHGWbLmzt+TKJbW9fps8SCDlE3tvJHA= Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-757731a32ecso183197885a.0 for ; Tue, 09 May 2023 16:59:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683676775; x=1686268775; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=i2CIzUyY1pWutjRxzxqcAiM7lwH82V7tG/M1dYLRQig=; b=jI8LJRH5HE2/jo+5EPTMZh/8e0w9EsjFRs/cVmfpauAyhq4BiDm8Y0BcNbnAiicBu+ qOFHeosHNjCs3DHCtFLqzprXhsqxJ8uu6si2Zw0H/6Q38xnNc+uEB7+hGBZqIJJjqJI+ PmABkbUooyN7ctUH9+9NtjB/80sSrAd9r5UXjJHW26s45fKQO7g9Mkg2I0ZUfE0VykR2 ujrLc6d6S4Gl2PdsHGQMYRa5Dc7zLR8bLxPcBCGU6avdR7jQtq9jlcz1cwjP+J62I+74 08+t0+q/SLvgvLniEnuI7vZ1b7MB4kZoFNdwCKN0mXtQ+JYAp4ng0Eurru3wu8P9qHoK mwZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683676775; x=1686268775; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i2CIzUyY1pWutjRxzxqcAiM7lwH82V7tG/M1dYLRQig=; b=YYklzarqX1WSGzgU5Xwhb/gwOn1jtnkdi341qwhRQOvMYHQwMHrFFKh5b75ZZas2nx +vA7Ccn3Bfhw2FxAiXQtfDaE3xO973IZRy0rPpDIuKx2LNvQ431mZOD68qkyXcYTXYPf WoG808E7sBH00WZ5NVAzpMuQfaYVSllgjYV30KLGj32nZkbHZAdAy+piQcm3/CvpI2K1 Vc+TtVwwpjn6cBQhl3xcaWBQo+NSPlFMHoOmoUomDawOthH4rLpKOIi+t+mnislwhd3F Bf6cMoU+dza5W6yQgu6MVUBUpdKAfCABKSkp0h/Fn7wo5MdgIvgBfiW6KZ7+Y1PKKhfJ isFA== X-Gm-Message-State: AC+VfDwVKVB6x61smxt0vvNKC1ROT7993v9TYNcF4eyKztjyoikizqM8 bvlVrn+dGDriEJ3b88jK2zXGq7/H6UbF6N4Mq84= X-Google-Smtp-Source: ACHHUZ7y8VjeUvO5/Wkeb0tjJYKRtYDwlti5aiDj6m11crDGesHh5Dybn4VPchLfolL+ylorYxrIekFoHfewFb5kecw= X-Received: by 2002:a05:6214:5006:b0:5e6:7942:c607 with SMTP id jo6-20020a056214500600b005e67942c607mr24043513qvb.13.1683676775499; Tue, 09 May 2023 16:59:35 -0700 (PDT) MIME-Version: 1.0 References: <0000000000004c3e6b05fb414be2@google.com> <610781bc-cf11-fc89-a46f-87cb8235d439@I-love.SAKURA.ne.jp> In-Reply-To: <610781bc-cf11-fc89-a46f-87cb8235d439@I-love.SAKURA.ne.jp> From: Nhat Pham Date: Tue, 9 May 2023 16:59:24 -0700 Message-ID: Subject: Re: [PATCH] workingset: add missing rcu_read_unlock() in lru_gen_refault() To: Tetsuo Handa Cc: Andrew Morton , Johannes Weiner , linux-mm , syzbot , syzkaller-bugs@googlegroups.com Content-Type: multipart/alternative; boundary="0000000000001ecc4905fb4b8cc0" X-Stat-Signature: ihttouqoszor66szycu4w31mee6c6a8p X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A2427A000E X-Rspam-User: X-HE-Tag: 1683676776-17909 X-HE-Meta: U2FsdGVkX19tLd4xc2NdokgIqP8koNjmam+Xa6OFZ/BCuHrCujYu2rpSJgAtr2fgk5GDleijI/tYKZH1TGcW6NgTzXg0JL+/oPWrI6ojhmU1Y+n+JrSZUDPYT/uUwg8mZIgjLCDXZVAXifv7qpIQUzTT7lque51B9OZbcfun4r5WNCm9eOtN5G+Y0p/JhxfHWSWeiDApg3SXJE14uy83Q2q6m1G5nSk/WE7t3JfrDEK/FrDZo7YHboYnRbK7v4VvcJ5Cf7koTtfQObHZLAkKDu6IWm+ZSMP5SPEjjXEXc5Xo00lnZPUJmnC2EBFP+vfdSrYBc30eaVGx64Emdj91fQu2JfdsvgW5oqrwnCKwAANgyTaRHQMHXMBXlnJ90eUT6n4+V5LG9/uJVyuS5E0FMzzaGWEooNvGMuQ9mWrMSDvbtlT2SwEFmDvDtj7k1H0M8ha655XK/RSw/x2FxE1ujg5nca0JxE6jejsGJg2DnG9yf3JgXmlLUlt7LqSBLMAWwI/KWBgXGsUr8HLTVGlKrKvn6EcobUxtqLX452lYExZnicHxMkNyq/h3RP/24TiLH1JpuyfO87Bk2QfDwYuJmthgGpdlVx2cmn3F9XVxVKKJgkow84M9B/cloFb+asFRfXippg2e8/XS8WiC5qbeMNZiv3BpMdUjIVeqrTukYijdkPREeVicHK1eWrDUdlf564vDTnzBIfogvNLipLof3jmgOIpPpNIlbAgreGF0WtgKPmJgmNGcAojU0C+fF/ROsqKjqWqHWjwMlTwJWobZmS24lAqL/ZoRn5XNWGyWgfvKDWgD889z+6wZDDK8YMjZYPih9ZXASvgoSBHA0GZxjauIjIyMMSW4Oma3M1DQJEE+zJZakaB+MricesdLnIWjd0hGmm5d2+SFQXLJlzKSdnJ8BtrkyrBuaRi5mdJCI4EZ0PV+gVv8uFGSec3NOCgh+5wPffj5vKLcdhL29qG psvocG6e UOhTELzRRVeJxgLiBWBsoFJ2eiMaGFRBMKU31jWM4PPck64ZVRd+Tg4dXIlCFM7fuwK78JcZxkWm8s+UZCdG5B+21YRHAmnxT90kuRFpZ018AtKb4Qjs6YXo1g7Y7zvdvQUCdb7XFE2tVUgg5QtG/jv/1UACzqe1kxlIHjKcnMX/vZGCX3tP6QvEKAarx1quzd4lcLS8rpKYcxUgabWB+rrayWCKLu160YrW1nDrh94fbVN9VplGiM1MG/YV7ulcEZ7z52LqEkYVRVQKMsGnwq28BwXjpvE1jl/BZcXKXVfQECkzEzU6S35fqDhZyyQ0D13casTi5niFxF4iW0aGtHqb1BfIDQoQvR9iocTpLo67CjopKpCjp7Ovyb973SQagyaQ4umhxjp1r5ytUzS6IAJOo7XLcNizFLXTt4lKnT1w5WuHIbYT+buAlpbDuE/UG+dzuOPbtrLNTPwUKMSNSjIWI93vc9YnHmE7nLw3T742+rE1KgDtuMeNhd7+dV3BXL3eDDDelwyWoQ0foeaKLnLJHujqirFutXQY7bVEQ5Zg7JjbWu2RenvVihjnEqj+jiZ46AvtX/rfFu6jUKI+J0ufKH3MEJNbIrJnhxmhEiZGoZEB9FDSk0sjupXMt9xfZ7U9Qx00x7MSZKpnmWH4YN4j+PM44yvyxCLOiQ5Gfdb6PQoMb4XULmByDP6n6Ndkh3DVOUsN5cfEzXRA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000043, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --0000000000001ecc4905fb4b8cc0 Content-Type: text/plain; charset="UTF-8" On Tue, May 9, 2023 at 3:23 PM Tetsuo Handa < penguin-kernel@i-love.sakura.ne.jp> wrote: > syzbot is reporting sleep in RCU context, for commit d66c718d28ac > ("workingset: refactor LRU refault to expose refault recency check") > missed rcu_read_unlock(). > > Reported-by: syzbot > > Closes: https://syzkaller.appspot.com/bug?extid=3c6cac1550288f8e7060 > Signed-off-by > : > Tetsuo Handa > Fixes: d66c718d28ac ("workingset: refactor LRU refault to expose refault > recency check") > --- > mm/workingset.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/workingset.c b/mm/workingset.c > index d81f9dafc9f1..90ae785d4c9c 100644 > --- a/mm/workingset.c > +++ b/mm/workingset.c > @@ -303,7 +303,7 @@ static void lru_gen_refault(struct folio *folio, void > *shadow) > goto unlock; > > if (pgdat != folio_pgdat(folio)) > - return; > + goto unlock; > > lruvec = mem_cgroup_lruvec(memcg, pgdat); > lrugen = &lruvec->lrugen; > -- > 2.18.4 > Thanks for the fix! Acked-by: Nhat Pham > > --0000000000001ecc4905fb4b8cc0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, May 9, 2023 at 3:23 PM Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> = wrote:
syzbot is = reporting sleep in RCU context, for commit d66c718d28ac
("workingset: refactor LRU refault to expose refault recency check&quo= t;)
missed rcu_read_unlock().

Reported-by: syzbot <syzbot+3c6cac1550288f8e7060@syzka= ller.appspotmail.com>
Closes: https://syzkaller= .appspot.com/bug?extid=3D3c6cac1550288f8e7060
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>=
Fixes: d66c718d28ac ("workingset: refactor LRU refault to expose refau= lt recency check")
---
=C2=A0mm/workingset.c | 2 +-
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/workingset.c b/mm/workingset.c
index d81f9dafc9f1..90ae785d4c9c 100644
--- a/mm/workingset.c
+++ b/mm/workingset.c
@@ -303,7 +303,7 @@ static void lru_gen_refault(struct folio *folio, void *= shadow)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 goto unlock;

=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (pgdat !=3D folio_pgdat(folio))
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0goto unlock;

=C2=A0 =C2=A0 =C2=A0 =C2=A0 lruvec =3D mem_cgroup_lruvec(memcg, pgdat);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 lrugen =3D &lruvec->lrugen;
--
2.18.4

Thanks= for the fix!
Acked-by: Nhat Pham <nphamcs@gmail.com>

--0000000000001ecc4905fb4b8cc0--