From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F508C197BF for ; Thu, 27 Feb 2025 22:35:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6774280004; Thu, 27 Feb 2025 17:35:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D17EC280001; Thu, 27 Feb 2025 17:35:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDF4A280004; Thu, 27 Feb 2025 17:35:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9F250280001 for ; Thu, 27 Feb 2025 17:35:20 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 18AE45228C for ; Thu, 27 Feb 2025 22:35:20 +0000 (UTC) X-FDA: 83167182000.07.BFE77C5 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf04.hostedemail.com (Postfix) with ESMTP id 3C0F840003 for ; Thu, 27 Feb 2025 22:35:18 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QY9O2NKh; spf=pass (imf04.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740695718; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zFM8VWziXs6qPoRm1OGpOhZo/LlHLEag1S842GTC5Ws=; b=XKUhWuiMXIO8hK+Ns3XIt8whtdtsgGvFQDLNHe+XoIcL6Rj+GEu2uXDeRxStQve/qregqe t4MwxZ6Q7YsEbeoqD0LpaOlI1z5FST7fax0qQfoQC4CiPSKcAYCNcrQ8V8vr+kHGOetmaV DrsFh/nDZbJv6WUC6qaIRiQwT8i3LRg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QY9O2NKh; spf=pass (imf04.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740695718; a=rsa-sha256; cv=none; b=twDCpnmTzlxhkdL29SWnwJP98JCtjVtr5gac7zLy6IVrNkXm6HrwwM5egFI7aNl0ZdnY9A dNwZH6/TnsanWrUtGddDhxy8CbWcaARPGskzp4zerIYHAWzL6T6ahLk5AMRuDLIBwytSlU Sg/BLFOs9Qhw7Dxw5cZWcW3OxsFkRX4= Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-46c8474d8daso13356291cf.3 for ; Thu, 27 Feb 2025 14:35:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740695717; x=1741300517; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zFM8VWziXs6qPoRm1OGpOhZo/LlHLEag1S842GTC5Ws=; b=QY9O2NKhwRDiwcsPg2EwI81oPpBf0KDDWjXcOc5VcywEg4HeY+MaXb3Ir7jqdR8H3d /Wcm0HzY8YU4rr/1G9G5orqusm5TMtVnnmfO+W1I7wrmQDFqR+LWB6MdtCbSoQ3MjG/n akCO3EKA8UGjd9HVWqhVd9MQ/YfmFUHZrXpRdTZGfydKfNl/zRU3dTZEbz9A4bXyaIqZ PTe6pFBInlxumsE6ET4ffUKPJ5soeS4DiEoGTlliE0Q09crSOEXgiWi6ZqVqJuDaq/W6 xpwM9ZqwsDf16e4KXWZNjSYdXyUSnNL90whnDgtbe51IfvIICRMPkVxdjoCOh8XZ8gYF anbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740695717; x=1741300517; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zFM8VWziXs6qPoRm1OGpOhZo/LlHLEag1S842GTC5Ws=; b=xTFbgvSgybS+LHEx+0tilEr6fQxsozw3if/Nt1E54SxP2qYzkE7Q1VM9HWLvhGcN0J qY/eaxYfzfLPJSh/bnpswnNUcirZTjR9meAXvK2Lj86UjxJRoi9tu058fqLEvCn9b7F7 bYEdrqdztTvDP7Ec8UB9AzEipHSsz27bvmiHTd88iZpDESIOi56oiV95RzkkegIVPIgH nkvyuHv60MQXEfyOOnNuEwnicjcscNS/EpAHC/DgSvmLTA51BGTY5gFe5kgG31mzPBrD Rnk7mP0DdrW9SLPnAXtpBRgXZVRCds5rWX/2SnsiHjBAnFfOyuahsPSNZlLZRgXKiyvd 5ZuA== X-Forwarded-Encrypted: i=1; AJvYcCWiFIWNNYSpAPkwhZXGi4d78g9ulm8ttS2RhHkDsIMUg8JUVtarKMPbOhjU6vRypJ+bu+C0EbXrEg==@kvack.org X-Gm-Message-State: AOJu0YzDdfWgJn5ItpFlaD973JjbMXUsvTlB/ON+7HnbK84vH9/eks6P JRmw7ZyhuwxH/EknIkdd0+0eRDhZmmGtbSSxjGClVPI2mEAYG0uW9G9+7k1A7l+lTsTna7ldYqx M1UzRbm7su3NzGMCuIwLDaqh30S0DU+r9 X-Gm-Gg: ASbGncuxmxu05ryG9MzSozUgo0BknYhPvTqkFiNDag1gJ2sc+eA2iOQkp3lDljIqjOq v0ud3WWn+vAswiqbUe4q8mOGvmAB2ID6yxLkO+3HyfOAMR2b2yISoVwWtBJBhUz1JpMQk6ohoXj wWzwdGLdXMgUfHWPxap7xOGpU= X-Google-Smtp-Source: AGHT+IEKEh9+VP9PxT3Ome4pZ0WRyhZginhvWUAbbhlLQjq1Ic8MRf9Imw9JTqKSE/JzbaFoS6MWQBoZH8PBhIZstDg= X-Received: by 2002:a05:6214:2683:b0:6e8:97fb:12a9 with SMTP id 6a1803df08f44-6e8a0d8fb33mr21616166d6.28.1740695717316; Thu, 27 Feb 2025 14:35:17 -0800 (PST) MIME-Version: 1.0 References: <20250227001445.1099203-1-nphamcs@gmail.com> <20250227043141.GB110982@cmpxchg.org> <20250227061616.GD110982@cmpxchg.org> <20250227160528.GF110982@cmpxchg.org> In-Reply-To: <20250227160528.GF110982@cmpxchg.org> From: Nhat Pham Date: Thu, 27 Feb 2025 14:35:04 -0800 X-Gm-Features: AQ5f1JrIyB8NeFMvyRWqGR1j-hVWPQwf0WPDBa5kdP0n3rnMfWnOIWA_Ki6zHH0 Message-ID: Subject: Re: [PATCH v2] zswap: do not crash the kernel on decompression failure To: Johannes Weiner Cc: Yosry Ahmed , akpm@linux-foundation.org, chengming.zhou@linux.dev, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 3efjuwutziwodprito1xpzxn79snpqhs X-Rspamd-Queue-Id: 3C0F840003 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1740695718-105652 X-HE-Meta: U2FsdGVkX1966BtHuNqPwU97eTag2A/80VC75DS3g4iif/iYh9QjLyytfvcfYJGkU9MCgHksdF6trFxKNG0MfJxztb2/1AeZtxGuflmtyoZ3TsUYh/WCKNS6gojC5yJwfktICfZVFHCxF6dPh1pTS0L4sIlwJS6yTpI5ftNildaSnZEOygtuHK0V8K6Sd2fvJcVXNnb31XEE3SD5Vg19MF83rwzKIoAC43F1Va0dCEdAbWDGgfdi2m6FHRbZI+7YdaW5EQLD1QzzG7Id9+CL3WFnnyM1P1SuivEWqCPnMHl3UhSaEO1oYk6KXZ+DUymERHmkc/YFJCEd6mhKWkTnb3Flor81mHbFb3zT6bWukiuU+aquWAfNDPpNcEz+Q073hNGP7B1oWUWtvGulS1vSnxlVB1v4oetkgP8FiizdbWExgNLpWo80aoHFopLeEhxjN3243taoNx/vfOGsb/Pq8kMYXDQp5A6qEzqyIupKVrtXAYMGbnnXHjR/beSzpFtJNjtTMl2k78+rBQ6ZN+tPhoKqaloWVgSZZeBm5Rt95HcaGda/49L7g2zqSOGOwfl4nRxvTX1jpVV8mTis7lGZXSvRbHJWO7D16G2kNVyJAZVI5EJCsDexb93qxVcQ4LF1fY4dIrkJWKURA6YEHwdEFz4o8RvgMKgO9IZImaRpD9leQp9FZUayJkn9A0kADKxmvWwLXFlv5yPBsisBPLvj0Mu2RBTwQLSi61FHCSwMHMhgw7+JCJn6nAL0lHyI87gPc0TVQ6UKrzx1kIxHDndNbv76tyMHNAaWvMaDdqVMxy6QMRmhgG0u96L8qmZNkD06PGJ1GwKssTokhm0Mlj7S/5bbTRdd6nmXlJ2ynbG0zXpi85rwWYHZ5AbsMl1Spb6tTN+OhVVplg8C9ShEs2NI9Sh7kIvQ4Jt2BOlWD7UdAQAx0/e3yT4Dc5hR3zRS/gKJx8N76QZYfKvinEO6iFY lh0SGRKT xuWsbUmcOqS3Ta60/lJ9oAjX1RinpUarEwOt5XaQMg1UdAjyCXy2HoWMflEY8p0Q+6RO7RNrtqWZZQ83WpQ2k22YL7zMxuUOuKqJMvXsJzTBUVqc7a1mNMM2NAByn2mnGWJy9yfp7QkWKURAaN6fGbAG/h+C6NNAe9CaN1bep6Sy99hLIm6vaJTrA4fa7AR2xOWIQqVvXSmzuXVKcHp4nB8Cnmk+Y91497FmO5TNB6satlIuc+9ohQlZ4zSPyEHTKwoACITJ+mLgjbXSF4zoAIxTSNCS7Pfa18MLHdhVmlwHFZtZL/dLIkvUUZ1qsP95aKsyX2Ss7eBe09ZdVOOWQYERfJenT6BX+931SiQn5WbC5KoMwHtdE+RHA3dfZvcYUyBj2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 27, 2025 at 8:05=E2=80=AFAM Johannes Weiner wrote: > > On Thu, Feb 27, 2025 at 07:29:45AM +0000, Yosry Ahmed wrote: I like this actually, > I'd actually rather push those down into zeromap and zswap as well to > follow that pattern more closely: > > diff --git a/mm/page_io.c b/mm/page_io.c > index 9b983de351f9..1fb5ce1884bd 100644 > --- a/mm/page_io.c > +++ b/mm/page_io.c > @@ -538,6 +538,7 @@ static bool swap_read_folio_zeromap(struct folio *fol= io) > > folio_zero_range(folio, 0, folio_size(folio)); > folio_mark_uptodate(folio); There should be another folio_unlock() above I think. > + folio_unlock(folio); > return true; > } >