linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Nhat Pham <nphamcs@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: ffhgfv <xnxc22xnxc22@qq.com>,
	"vitaly.wool" <vitaly.wool@konsulko.com>,
	 linmiaohe <linmiaohe@huawei.com>,
	akpm <akpm@linux-foundation.org>,  linux-mm <linux-mm@kvack.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Linux6.14-rc5 BUG: spinlock bad magic in z3fold_zpool_free
Date: Thu, 27 Mar 2025 10:22:41 -0400	[thread overview]
Message-ID: <CAKEwX=NqqsO6ajKffUFE1Y4B-YUhABudPbgAKy=16nN_k_-+fQ@mail.gmail.com> (raw)
In-Reply-To: <Z-Rmo_xx_btMKO99@casper.infradead.org>

On Wed, Mar 26, 2025 at 4:42 PM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Wed, Mar 26, 2025 at 03:43:28PM -0400, Nhat Pham wrote:
> > On Wed, Mar 26, 2025 at 10:32 AM Nhat Pham <nphamcs@gmail.com> wrote:
> > > On Wed, Mar 26, 2025 at 10:11 AM ffhgfv <xnxc22xnxc22@qq.com> wrote:
> > > >
> > > > Hello, I found a bug titled " BUG: spinlock bad magic in z3fold_zpool_free   " with modified syzkaller in the Linux6.14-rc5.
> > > > If you fix this issue, please add the following tag to the commit:  Reported-by: Jianzhou Zhao <xnxc22xnxc22@qq.com>,    xingwei lee <xrivendell7@gmail.com>, Zhizhuo Tang <strforexctzzchange@foxmail.com>
> > >
> > > Please stop using z3fold :) We already removed it upstream.
> >
> > To clarify a little bit - we've found that z3fold is buggy (for a very
> > long time), and does not outperform zsmalloc in many of the workloads
> > we test on (both microbenchmark and real production workloads). We've
> > deprecated it since 6.12:
> >
> > https://github.com/torvalds/linux/commit/7a2369b74abf76cd3e54c45b30f6addb497f831b
> >
> > and will remove it altogether:
> >
> > https://lore.kernel.org/all/20250129180633.3501650-1-yosry.ahmed@linux.dev/
> >
> > Perhaps Vitaly can fix the issue for stability's sake (or in case
> > there is a reason why you MUST use z3fold)? But I strongly recommend
> > you experiment with zsmalloc :)
>
> This group are syzkaller kiddies.  They have no understanding of what
> they're testing; they're just running their fuzzer and sending emails.
> They don't care what's useful, so there's a lot of noise from unmaintained
> filesystems and so on.

You're right - I just realized they did it once already for zswap:

https://lore.kernel.org/all/tencent_49DA3E780998A9B96ADC9FF658CC84641808@qq.com/

It was also due to the (soon-to-be-removed) z3fold backend. To save
time, I'll stop engaging from now on, unless it's a proper issue.


      reply	other threads:[~2025-03-27 14:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-26 14:09 ffhgfv
2025-03-26 14:32 ` Nhat Pham
2025-03-26 19:43   ` Nhat Pham
2025-03-26 20:42     ` Matthew Wilcox
2025-03-27 14:22       ` Nhat Pham [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKEwX=NqqsO6ajKffUFE1Y4B-YUhABudPbgAKy=16nN_k_-+fQ@mail.gmail.com' \
    --to=nphamcs@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=vitaly.wool@konsulko.com \
    --cc=willy@infradead.org \
    --cc=xnxc22xnxc22@qq.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox