From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 714B7C61D98 for ; Wed, 22 Nov 2023 01:19:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05B786B0540; Tue, 21 Nov 2023 20:19:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F26746B0541; Tue, 21 Nov 2023 20:19:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA06B6B0542; Tue, 21 Nov 2023 20:19:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C7C1D6B0540 for ; Tue, 21 Nov 2023 20:19:34 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 997F01203A9 for ; Wed, 22 Nov 2023 01:19:34 +0000 (UTC) X-FDA: 81483832668.04.86E4001 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by imf18.hostedemail.com (Postfix) with ESMTP id D24FC1C001C for ; Wed, 22 Nov 2023 01:19:32 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kqW8DP2c; spf=pass (imf18.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.52 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700615972; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cihilcVY5OStqtWe30Okdv2euw2yNNgkn3qMNIzpAgo=; b=SW0T2ZxoYlvoisPaNHqAUCE67h7oQJqKTC1NjsFQEBa6tj3u+JxxIyTb4Y52Op6cljvvXr pcFFvPzHqwxmOEhIMVig9dKAe1kE/b7UQsktjjnlvGMxqpe0S5MP0n36D3WrRp/RhTwhUT Huq/SkzyPpJ28Nc2czNUIWMhYbm/YgM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700615972; a=rsa-sha256; cv=none; b=of/cTru5xqmqt2JwhJ5k/JvqscL+op8hb82kw3A6iKPV3v55hoUeydPx8GLMoIq0L/o+N1 PfgoDw6S1v1OB5pPRUF1Q7JMJnAaNISo/H8/TtCmXVU6gHCEuNEy+elLVXJcxWLz5p4zvr ohddKfdPtUO41seV8bjLTC9Ywekjngg= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kqW8DP2c; spf=pass (imf18.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.52 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-7b34ee2a243so32627639f.0 for ; Tue, 21 Nov 2023 17:19:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700615972; x=1701220772; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cihilcVY5OStqtWe30Okdv2euw2yNNgkn3qMNIzpAgo=; b=kqW8DP2c8DI1fIOKjQZ8ZDSH/Y53NIQi8PRMOSZtzNJinxw5vjIOeWdTIKqc7yJuDf p8qVAcFpKkbqUPbVBIx/HNkv1V1K//OXXiMOPBZ6+mGF7KCT6J9N4Ewr5Ct2XNScNExt a+bB+FUZwTBK1bdhviOICbwowkrDVSftmVRt8RFlmYEuf4jWM68iBETf9mvh54HVY/fD hs7ajEMvPd7tay/omWi9KPF5jCAz2ZVyWmVBPha3kRwsaQnLATHspHK2b7RdTMttVRw/ VcJZhL639YcMb6Nyq0rBfl5PAwJKVVXx35u8fMODTq/V3w0jenSnYRZtAPyr78qcfvLj Q/0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700615972; x=1701220772; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cihilcVY5OStqtWe30Okdv2euw2yNNgkn3qMNIzpAgo=; b=g7yfHQQ12bxyGGhxk5AwfdRjYWbZgQF4Za3K3WUVq90MpLLiE7t4jthvxBqJ2c0d+W ZXMp/ZRQbyY4J24tR6ey+NQVs8C8i3MT1w+u+2qEeZIN5wVpXDSRVhbhfrqzdYC8dJwM CJ6fbEBYad40lWMtNxxOfR0o6OYK1pWQFBzQGE+Ik7udUxjqcGVWGPK4+jL/2CeekAj6 bp1BkstcL2QvC7mjSCa6//H6++COsTfeRCYBWXrJxwF2Ze99VKL+2Fx2yFWgutPvT0+R ZDnvYBRNO0vMDT3xUiUl5cBRFFf2Kw6CBe2PiHNB2Xl2EiBu482la9kI8Jb4WF3bbrEy QzPA== X-Gm-Message-State: AOJu0Yww5wl1ro3ECspgINRvdHor5WKHYCaX7MYId6VGl449IR4bM92C 4uaksdC56DhXVnnd4WlFDQB2KijY6AKygcYdrSY= X-Google-Smtp-Source: AGHT+IE6W+Qq26H8vhTNqXDl2/rLQcAxjTvAPuQ9FR9DHaFVqUa+5jIx+4GJB/W5WQBTbwRqtf6oMtvFHyqFXFzoNPg= X-Received: by 2002:a05:6602:3999:b0:7a6:7e4c:1bf0 with SMTP id bw25-20020a056602399900b007a67e4c1bf0mr855787iob.16.1700615971940; Tue, 21 Nov 2023 17:19:31 -0800 (PST) MIME-Version: 1.0 References: <20231115172344.4155593-1-nphamcs@gmail.com> In-Reply-To: From: Nhat Pham Date: Tue, 21 Nov 2023 17:19:19 -0800 Message-ID: Subject: Re: [PATCH v5] zswap: memcontrol: implement zswap writeback disabling To: Chris Li Cc: Yosry Ahmed , Andrew Morton , tj@kernel.org, lizefan.x@bytedance.com, Johannes Weiner , Domenico Cerasuolo , Seth Jennings , Dan Streetman , Vitaly Wool , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Hugh Dickins , corbet@lwn.net, Konrad Rzeszutek Wilk , senozhatsky@chromium.org, rppt@kernel.org, linux-mm , kernel-team@meta.com, LKML , linux-doc@vger.kernel.org, david@ixit.cz, Minchan Kim , Kairui Song , Zhongkun He Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: f539czzdpq8jc4quttungd7ygxgw9spu X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D24FC1C001C X-Rspam-User: X-HE-Tag: 1700615972-186870 X-HE-Meta: U2FsdGVkX1/cIOuHWJ+olMm62TjL3U8lkWaYaX2+zvvSujU+ZKJ9T3ki51QW+iHHlUi/iaGA+sAVqy9Rs7dwZyUA4Ab2mCjrmQ48bqsP4XquMx0DzC3ynE9xyBBq5DctXfcpjvyqZOnYyGj9K7k9d/nqpeOmZCeAfkSipMrrwGchvuGn+rt2IMFwdpYSwUBO6GpRhgE2pgOQApjCnNoRauHsEbwCJKTVtvd9Q7Se41OC9viv3R0V3bVMhgGiWOWbLLuhYzD+9k7dQq10gAghYQnlEOheZNN7u0zafmHDOkb1oUh24Z0yV6Zqg+S957h4uZo16WbcP3zHGiQy0ldfqTH3ef9LjVmZWdU93Qlyjjg/ov4bDMzvzBX5ln2gUFuEv3xeRmPLC4DMDdJkG5A582+44oaGRAwyQ1dB/o4brd4YPFHpgwfhMkb56rdF6XEtkZDIc5QT6mIeFUEkn8QH26K/EHwLSUTlDNGE0oHcvZgWRMowXBL37XRB/+4REi2luASfXC1vj7KajXj9t3VaCo9/xSRp95BK0xGhUfrqm1cY7UfQHkS3MOwDcFYM7mW31tNzSBjBZx6nLrO5jjTRTASbeMVvw2nB4gKvf4FJnc/3pO+TKuRGGhTu32PRRvbKcKPaH3klC7JUkKqNCV7ycqQ++TAVrVOb58L/Lv6+lc7q9OYhuFjYsQImz3ZhSAtpVHJpAjwMwyza61x2lPdCMEp7CqFw02rPR7mHGG5fOU+PaoPgTCvSL1u6jwAwvxTcTrdANGUEl2Pj9aahdBysQTNCBKHD0sEgXLbOBJJP5RypeCNWPEzVA2jI4Ih9snlRIM257W5ApsIfpbxMHOQ9YekF6P0TewJbjkW+wcV7wh4cKwVQ+LiSmDabpmjSypJsmj3HnqMnnTLlOscfpmrtqsfWx4A68uxUIMOHpf1nrfpbY8cCfNmZy+GwTB9cTLFJaQ1j/RmzRE9N3WTghTn 2MkOKO91 rDxi6lJBgXlIZL1UyeuFHSq4sBVsXKfc2XCgGcW4epfPPUx6/cEBpxL+z9akpNAeq3GZ3kfLrp5e6pkpEM5Q1gX5DHhldvoW6rQTnZzX6aHUfU093wDXgu4j0Nv7LsK9Rqw4Az/nQ5UQNqa5TBChlZBRdJM7T4TCFj87I03noH1YDLeB5RpBT/ibbiiNgXD1T6ZpWYbjxRtkkEj5UGgy8pia45B5MNQsqHorE2zEyNvty5Em5dFiWGoetvnFAs3wyUead4W9/kv8hO8IpMJXEMFzE2wpjssfjv/aTbQ3DBCb8f5eZ3nGORmuvL6YN7m+btjdGfRLRoVNrAXptPg5MNadHyCORuzaRhv4OKcULwpJKQHBLSASLVH61dYgwd1EYe9oiNgwOK2QSmE3hhRB63CS0e//2A5uIBkjWCwC9O09IrM5xsilQHC2tZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000064, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 21, 2023 at 11:09=E2=80=AFAM Chris Li wrote= : > > On Tue, Nov 21, 2023 at 10:13=E2=80=AFAM Nhat Pham wr= ote: > > > > Hi Chris! > > > > Thanks for the patch. Would you mind if I spend some time staring > > at the suggestion again and testing it some more? > > Of course, by all means. That is just the minimal version to be > functional compatible with your zswap.writeback. > > I might consider a follow up patch to add "no_zswap" and "none" to > convert the SSD only swapfile, which can't be expressed by > zswap.writeback. > That should cover all 4 combinations of zswap and swap files without > creating a custom swap tiers list. > > "all": zswap + swapfile > "zswap": zswap only > "no_zswap": swapfile only. > "none": no swap. > > All keyword names are open to suggestions. SGTM! There might be some functionality duplication between memory.swap.tiers =3D no_zswap and memory.zswap.max =3D 0, but otherwise this seems reasonable to me. no_zswap sounds a bit awkward, but I can't come up with a better name. > > > > > If everything is good, I'll squash this patch with the original version= , > > (keeping you as a co-developer of the final patch of course), and > > update the documentation before re-sending everything as v6. > > Great! > > > > > Anyway, have a nice Thanksgiving break everyone! Thanks for > > taking the time to review my patch and discuss the API with me! > > My pleasure to discuss the swap with you. We should do the online > "swap meet" and invite other developers who are interested in the swap > area as well. I look forward to this meeting! I'd love to discuss more about (z)swap development (and more generally, multi-tier memory management). Generic page promoter/demoter that takes into account workload (cgroup), access recency (LRU + generations)/frequency, and tier characteristics (latency, bandwidth, etc.) will be awesome to explore! > > Chris