From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6E9FE69E81 for ; Mon, 2 Dec 2024 19:29:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 469146B007B; Mon, 2 Dec 2024 14:29:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F1926B0083; Mon, 2 Dec 2024 14:29:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26C196B008C; Mon, 2 Dec 2024 14:29:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 05F4E6B007B for ; Mon, 2 Dec 2024 14:29:40 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id ADAE480296 for ; Mon, 2 Dec 2024 19:29:39 +0000 (UTC) X-FDA: 82851008100.30.D6F7A6C Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) by imf06.hostedemail.com (Postfix) with ESMTP id 48880180016 for ; Mon, 2 Dec 2024 19:29:29 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mjf1nxIQ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.49 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733167766; a=rsa-sha256; cv=none; b=3ucQrO6Tj/GxEtVvOxL9mhcKFG2qotCkxHM0nzf/uoxirypCkIdRV3N0uqASTM9SZ8FiTP iXvSD0iL0chVh7sPtqK/4bEN8HiB/Y/Xx3r1jX9BFuMyivJYJuRlGYfu/JVlMMhZDjxBbZ g9vQ3RJXUd3Ogt/QAYMRJ3BjXWWl2TU= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mjf1nxIQ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.49 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733167766; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8xrzqyS10xGMTwkWM0ZBFAfF53qLo6Ora90vofptx1E=; b=557Vt4w7ruk5JY9ya1caTzmKvpZW33ZcWjoz686o9QY/dzdV4eVrRKkwxF7rbHqMly2Jr/ pT9fswEsR3Jx8PhBEJz1S5iy1hs0pVKPCL1AXvztz7eTjxkXySe9J+BkkAWlVtV/gjepLV j7F0clqosl1m81XrfvwTNWbZKGFd50A= Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-6d88d3d1eb6so26638686d6.0 for ; Mon, 02 Dec 2024 11:29:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733167777; x=1733772577; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8xrzqyS10xGMTwkWM0ZBFAfF53qLo6Ora90vofptx1E=; b=mjf1nxIQcP0uPTrxnXPBKSLOi1sh9gEmUu6ukHMy040+If8Y7lUWMHwIbsy6AS/eSS RIzx4icpwy8ByAg3fqBZxUCH6PZIbISTB8JsBQdXxsC6EeaNgwdLUbRDCVVdtvb0HFwk /uTNn57e3/7owfcpXB7iWd1h+OkLbwsc3LkYKU6td08ZP/8S7h0/OsVr9ukcXvqWJwDx jEsJ1wZ5wY5UswAiLoypwL7K0C8tPuPtmzplDU1Si1diyGQCNEESxL/kwHQrwFJH7/Mq N1WjU0sZTYSVJuY0Tvk9NCgqWe5Wm26fwYD7YzzWyBT/eDzpzTJ8q1P0ZUXIBxznQd3N Ejrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733167777; x=1733772577; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8xrzqyS10xGMTwkWM0ZBFAfF53qLo6Ora90vofptx1E=; b=syH1ORiqyxzAm3qSjGsNbUlLDq+BQstFyVZyDH1OLLeO/pih/YT2eHl1rg7rBFrvkC IQ1ybHwghJp8XtFdnvr33QISTEaptbF0GtSzAuRCrTmHtmQknBQpEPI46BEEazDlITPF ghK1KsMc4l2yEy9e2CoASDSpSaFlbtqgnG0qx/BHIirOoogMLOWR47BqCOo0TjfV2/TE bvRVFucKth5WMmTXH+9igsuyZNTfb8wsiIcbDkBn/YH0/wond8pAQP9Ts5F4c/XGSsDF TBSLPkVQKUbv3AVYZeg14qjeaMYLlZdKgcexFIQGCN3aOG7ar2l2udE4rAFNTLCKwy8u bGfA== X-Forwarded-Encrypted: i=1; AJvYcCXHQHLPCbNZ4Z97X2hEioSZYsqHtjCMvTChxs5ksJCSOsD+t1a/W0ZWpmXLnUPtuBfL33gmxslT1w==@kvack.org X-Gm-Message-State: AOJu0YxNgb3WjJSEHf50v4JVlL+Wq8/cLw9Zbh+ByrVC6ARbcrvX1Zfp WBqUPYEiLObewbKy0K9QdmbThNqYjbhZKTZnc65VfJLKmQaedooRgm0pvn8jVQ2M6lsshd72KHT x3X91jVaLfGylIMBVyCabs/UR7h0= X-Gm-Gg: ASbGncsf0RNkvLfqvU9NdbthKoWOCIYxMohEjturOsT0Q1/5wWjPkexyO9ninJ/FjuW kGplyecutwBGsgVWIuZPujVAJwLmaJlbdpA7LbG36UsXvI1E= X-Google-Smtp-Source: AGHT+IEXJeoKT2zRJJd9fucPMIMzWYpgG7ramp/+EBhfzTABaWBnluvLXoeeKLZc4kCHRWcUcv60G2ddLxZ+NR0/8Lo= X-Received: by 2002:a05:6214:403:b0:6d8:acde:8a98 with SMTP id 6a1803df08f44-6d8acde8e80mr48098236d6.14.1733167776961; Mon, 02 Dec 2024 11:29:36 -0800 (PST) MIME-Version: 1.0 References: <20241129-list_lru_memcg_docs-v2-1-e285ff1c481b@google.com> In-Reply-To: <20241129-list_lru_memcg_docs-v2-1-e285ff1c481b@google.com> From: Nhat Pham Date: Mon, 2 Dec 2024 11:29:26 -0800 Message-ID: Subject: Re: [PATCH v2] list_lru: expand list_lru_add() docs with info about sublists To: Alice Ryhl Cc: Dave Chinner , Andrew Morton , Matthew Wilcox , Johannes Weiner , Qi Zheng , Roman Gushchin , Muchun Song , Michal Hocko , Shakeel Butt , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Dave Chinner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: z8dkqrxt9qa83zcn3doptaynu3byn9so X-Rspam-User: X-Rspamd-Queue-Id: 48880180016 X-Rspamd-Server: rspam08 X-HE-Tag: 1733167769-11512 X-HE-Meta: U2FsdGVkX191FgBuaNmnJBUCltXW25pOBm7R4w06xEYio404Ah3FAMNiZ0OvBYEGUal6PdxM8plZhJnMCIquztfEPMB+X+C0zZa7UytfjnVmkep4qTJwsG2ktbAnDltszZgw1fhtLMRrImBMTC19XysCdZM9s4eYjPjhtSAWWoj0bs2Ah7cFSjEPjazcgrJK42pZrTo1WVlyl3X75z/qu8GsQk9jyoOzaGcTnXOyru928fgoQADf2WI0IYC9pdLv4/nxsImHkONs7U6fk4QCm/fUheQLyb0iU+yPGpexZQdT4abU9DGo1T68CztYrFGwSdHuj7cwFYipN/g64Er3K6eA1kVnFzDoIYrTlfMu75ei3iwdLQG7UKcPB6S+XBboHu/52BSPOQzcfTmfl8EkC3uL8poJRDItpojLKBUGa1lAOkBQh573r3opYsoUx1Y3Cc+JM2sPtIe6Hx8QHW8IK3EH2fBf6TIv4qBg43etWcGjfcuAnRMfUife/cTkxEV5jM1U7vKDFw70aaIC8tCAidCeUcTJXxh0pLHkfDeYZ0qwPPz73CsrO9UJVAq8e5AF93TwN0CEodiKb9yXay2tR7EpwXN2wtL6VvXyvGx3LVspkKcqf2eD2iK+suxgjc+j6tV/ezuXZsr9NOGSAd4NWpHqCOls0s08SMztIglrbeNwO5e8usLV4TffVjgFtzme+gLgWa16I6mNqqFCD7e5edP8RtzL/aYB32bs3dEMsG/HJssuEZCPKf1Vcn9g1hwqO8yByj0zlecK8hBWFsFViaOz+m5uXJ8nD5EniAMoUjIkV+oCSAgbAkfBkWBaT+gehGr6uzzaXA+AxS1fdkapJKCY7oX2IUb9qKDsygH9LwBSO5tHeVKmuK1L5g2C6VjCxTcY7FSQpB6bbE4nH3xQ+Spoi/szuv/wD5ODuoK9/dIZ9T1+9hLkH/tXWF7vgNdBdHrxPWTKFZKkTGbEZ0G 32CdFGSf 1yAGhgVipKy/FWiG1rQ0ve+zAlxJ79QU+UdkNcMyclnWBtosuT4X3UEqYNnP/fLuB2eQKwZsnNuhxnIoUGXe4jSStUYRnGNbjBpYvmKBzu/IYJkGxcc6nGlAMS8Geid4anggJ8TIfIT/95NswpQZjHEuCLN/+yMkSyKYGVQrA7B38tGFUSelqL5OaVeZTy/J8Htqrgv+fpGSil+s7FrvIRQ2LxYfGWkboWUgnPavx1t5Wks42FtgmCwtqAdxTjTPvxXu2/jUTkhwYcwwsre/F+HfVlxMgmahFqruUr/6mpxlxe2jP6TwgNIqkOkqpRs+IgJFee+vFE6bIbw+T3LVhmUo+2vim6k+0aROZ8Cf8XAzj1rcbPltWrWtm/83F8HaTh9V8lXoTFHSi34aqlULDqrOTG+XQ0qzoQ3N8xsybZw8Shx98YwETvXg6O/nMTuez6F5k5mzewj2b4ak= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000340, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 29, 2024 at 6:58=E2=80=AFAM Alice Ryhl w= rote: > > The documentation for list_lru_add() and list_lru_del() has not been > updated since lru lists were originally introduced by commit > a38e40824844 ("list: add a new LRU list type"). Back then, list_lru > stored all of the items in a single list, but the implementation has > since been expanded to use many sublists internally. > > Thus, update the docs to mention that the requirements about not using > the item with several lists at the same time also applies not using > different sublists. Also mention that list_lru items are reparented when > the memcg is deleted as discussed on the LKML [1]. > > Also fix incorrect use of 'Return value:' which should be 'Return:'. > > Link: https://lore.kernel.org/all/Z0eXrllVhRI9Ag5b@dread.disaster.area/ [= 1] > Reviewed-by: Dave Chinner > Signed-off-by: Alice Ryhl LGTM. Reviewed-by: Nhat Pham