From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46674C83F11 for ; Mon, 28 Aug 2023 14:00:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3D448E0019; Mon, 28 Aug 2023 10:00:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BED648E000E; Mon, 28 Aug 2023 10:00:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB54C8E0019; Mon, 28 Aug 2023 10:00:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9AC228E000E for ; Mon, 28 Aug 2023 10:00:43 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 543B3140440 for ; Mon, 28 Aug 2023 14:00:43 +0000 (UTC) X-FDA: 81173673966.15.A4DAAD6 Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by imf13.hostedemail.com (Postfix) with ESMTP id 7D6FA20022 for ; Mon, 28 Aug 2023 14:00:40 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=VpaK78lo; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.48 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693231240; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u1ZjYInOLZfLCJ2rqNlLw1AWAIzZa8U1nQs8Z12ar1I=; b=LkgrYf7Eou4v9Mu++rr+eeg0vJ6IsXX4A1QNy3R+hgJpAb14FyAtRELd4Cy7I4gab6WTEH A8JCL3HXe44ftmOWVdDmm1EQLlTcgKoiHWgZljQ6QMvGFbhu+tPohIKUJNz3oItWMCqklL Jx6SIgluAE/C2CpwlkuVWDTfZTYDT6s= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=VpaK78lo; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.48 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693231240; a=rsa-sha256; cv=none; b=aCCG9W6e5N3o+HIjEyYAeN5bSNX+B2hXR6F34WHWAJ7bfT6KL4TYjqIkf8K/fd6yDAoKAJ q8f6ZidNRRfLrYXQojecpx/hGDzL1hE4bYXIE8Kht74vL4UC198VYZI064AJSz2gcyNVyX qbovQd1O2assihQ1RrfQgXGV7Er0l5U= Received: by mail-io1-f48.google.com with SMTP id ca18e2360f4ac-792717ef3c9so93112739f.3 for ; Mon, 28 Aug 2023 07:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693231239; x=1693836039; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=u1ZjYInOLZfLCJ2rqNlLw1AWAIzZa8U1nQs8Z12ar1I=; b=VpaK78loG20c+SLJ+GOeGHVwA41coT9y4LuJG4Wh6v6fmtTszx6Zp0q+8SjbCsrZtE t82U+jJZIOX2qXxiKvFNiZl3X2isQINMeGgVlXhfbe6FTjMHY+QZgEF+vfESF7rKxY4O +w9c7l6xM+5EM9xECiaKdsZH+NG9vYwmZfVf9ajd8/sGzY2pNix2hC6Y1ZK9MZtHX1CC lSpjIn3stX1wjRQgAn3n3pfRh3vDXwBvkN5TcN39nKiau04x35riQHgVUiSKLKdAHzoX 4zWWFefqkCETOLCMI9iKrjYLrWkk4uzV5UkQiC+AQJBMPCLvtAp19mbOBhTVscmuXTSJ w9Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693231239; x=1693836039; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u1ZjYInOLZfLCJ2rqNlLw1AWAIzZa8U1nQs8Z12ar1I=; b=QUrYaLQAs9lGUjN75L+tPgeTBpOhrDGkahMiBA3CKwLUxBdSM4k+VoWv0RVSTU4GfE 1XejsuGDacQy4oEdK5ZLoydcicjxOjURuB/SNSJhAKdK0WI6oQ/Mj1/LjyxbQR+0qM7d VyUnAsjvtCP6IHF97Y7CVLab2oMun1hasRjBEjU2dZjI6IipluzmXQSXDyswdeG9vLN8 KY37mX8a6E3oBq0bg4Ggo4XiqgBTqWPeUxsVAa7uOa/BDVOuLvjaw19WeoVQ3uIdI8Ii yg1zBAkVKAtlOEtDtmL+Kj04c6HPlxefHlGKc7I2wC2kSTnBR8rVXBqMUSHf6IaS0o6o H42g== X-Gm-Message-State: AOJu0YzpiYfP1EQFW1f+bVbETw63tGQA5up7muChdCmKrlmD7xxQ32O5 uqSzsvSLBt+FuAYkUKmWOp8MKovFi/FJt/EYGwU= X-Google-Smtp-Source: AGHT+IHBbWKvoCsoAWsBsb8FJc28TavkJak5o68tpykf+H0mKP9cBCYzcQgKx0spSr9vQVyliKo/Ml0rF9Px9VxXofk= X-Received: by 2002:a05:6e02:dca:b0:34c:abcb:97e8 with SMTP id l10-20020a056e020dca00b0034cabcb97e8mr16520973ilj.24.1693231239587; Mon, 28 Aug 2023 07:00:39 -0700 (PDT) MIME-Version: 1.0 References: <8417dcd7ebdc464d12850873d6c48f95293e673c.1693216959.git.maciej.wieczor-retman@intel.com> In-Reply-To: <8417dcd7ebdc464d12850873d6c48f95293e673c.1693216959.git.maciej.wieczor-retman@intel.com> From: Nhat Pham Date: Mon, 28 Aug 2023 10:00:28 -0400 Message-ID: Subject: Re: [PATCH 2/6] selftests/cachestat: Fix print_cachestat format To: "Wieczor-Retman, Maciej" Cc: Johannes Weiner , Shuah Khan , ilpo.jarvinen@linux.intel.com, reinette.chatre@intel.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 7D6FA20022 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: pzmx558rt13u6kn6fw7w1noapmpc6jc5 X-HE-Tag: 1693231240-279019 X-HE-Meta: U2FsdGVkX18BEeYPtrNtj3IxUY/9Og81VtxpvifmMQE1nhZ2uIgDkayUm11xasWAeKbrnrbrWH/YAP8cbY86Lr4OFaSEfdLsJYkwJCD44nc0+PhOl8SYMwJFQw67XLREnj+cXXsy1TuVgzutbs1oHA+OF493BNbum+nfq1khgih5BWmnYhWTxMhqUnWBo/20QEnwSbGBJ/W+BkYkDQcrrUUCsQZxI+qfzfymgd2VC3gUJJEvZt4BTFWiG1WPnUxjv3JhPH0UaVsfWSDCV7v60D+UNy4dyEDtkXqtKO+PKBvhSB2EVNySH5TxmWnhIDZOS0EGxKDQC8vYTAzOa7sPeouu5avUCZH8QU6xju2WUISMLhZgGTwq6tBekENsCUQB6OZY7Jt814/9XhoX+ShGKTS/WbKKeRs2Wc4e+JARZ3OqhjfH000gZEpxNv8q/95P/fsvdiT/tYmnSyWdCFHTjCQ/pFnOYxpGZJFHHK3dnAbLawnG1s08b2ZhakqWoBXAM4xVJrgjAYK0PCGp64McWMoVGkqLDsNk7/iOsgqeBXyEOn3GcEoiCv9xMrRj8uxltrBLucOu+H+kpRgOfP+vNwbUzpNzhtHwfg0JX0WI8uqB9oHRcTBqmPhUTdmrFhhBBbjowtxaE5rNn8zCi0Br9CMtm5Q6LI1ZAzVnOtmlss8g/PB6ldW2vk3EZmFPS/o2D+mRuBeUj9BAvSjqiWPrxX0beyJFWz4MJjNy4eBmrjHSLpPYvcD+PJ/THNbP4ulL8z/YXRcoeuYe4yuZ6HaTAAQn6+eAVhwdb+AHQ8Bvju+hxEtKGvV0b6VhmFr7AGzwVmKMOwHf2LGG2V/nW+3zjTMgeLUoNsZZAVdmSG34+4VCAuuzJif8D3V2SaQyG3F7e0/ogaTK8aKTEqWSfpG7DVGMtkmKYj+/bUZx96pDWYUAMpeqn22VpzRTq7GC/8Vtzaje1DxtY3ZMH2MTOUM JQQNYU8/ tBKUbu/Q35aVXiuBzRJ7QTiP6GX8HT1ssRt/cgdUDTT/9ndye3MZWWMXK73jpqB5CO+EeaigLDXPqr5tGYrBmQIKaZs5FqI7trcLKInvp05fJL4AD6iQHsmgco8FKUye+nKomIQtN7Xfs0VjImX8BgC5bkqOLLLKMVhKmy7qk24jCHhyguEystK9QIvJ0HliybgtMY9UIxMYgIGowo+WiKWMq56HzrM5qKgTe+/c8NU2HTsOo3Ml7IvK0VmtPK/UFLV2PZaMPOeIcTzfDBVuOFQU3dzSdky5qzHsIiNep25spzIoyCCdYNdMygfVqndCZhZiT0i2nIGrq9Nc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 28, 2023 at 6:50=E2=80=AFAM Wieczor-Retman, Maciej wrote: > > The format specifier in printf() call expects long int variables and > received long long int. > > Change format specifiers to long long int so they match passed > variables. > > Signed-off-by: Wieczor-Retman, Maciej > --- > tools/testing/selftests/cachestat/test_cachestat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools/t= esting/selftests/cachestat/test_cachestat.c > index 77620e7ecf56..a7adf42afb20 100644 > --- a/tools/testing/selftests/cachestat/test_cachestat.c > +++ b/tools/testing/selftests/cachestat/test_cachestat.c > @@ -25,7 +25,7 @@ static const char * const dev_files[] =3D { > void print_cachestat(struct cachestat *cs) > { > ksft_print_msg( > - "Using cachestat: Cached: %lu, Dirty: %lu, Writeback: %lu, Evicte= d: %lu, Recently Evicted: %lu\n", > + "Using cachestat: Cached: %llu, Dirty: %llu, Writeback: %llu, Evi= cted: %llu, Recently Evicted: %llu\n", The fields of struct cachestat should all be unsigned longs, Is there a compiler warning that prompt this change? > cs->nr_cache, cs->nr_dirty, cs->nr_writeback, > cs->nr_evicted, cs->nr_recently_evicted); > } > -- > 2.42.0 >