From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A55FC36010 for ; Tue, 1 Apr 2025 18:55:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 767B9280002; Tue, 1 Apr 2025 14:55:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7190F280001; Tue, 1 Apr 2025 14:55:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DFE9280002; Tue, 1 Apr 2025 14:55:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 40809280001 for ; Tue, 1 Apr 2025 14:55:45 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 304E01607AB for ; Tue, 1 Apr 2025 18:55:45 +0000 (UTC) X-FDA: 83286379050.22.09DE36F Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) by imf27.hostedemail.com (Postfix) with ESMTP id 5978E40005 for ; Tue, 1 Apr 2025 18:55:43 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Pe1SnS9J; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.50 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743533743; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9Q9uOC43r/9w7VdgkgSAIWaOsjrV/IhDIvRZfNVDIJE=; b=ZMsaksdAvetQr4Gbd+OQTLKHEgi6k2wTzGhGG2fnO9QsQHQ7T2V4o0wZqG9iORRHzfcs+j q+76nv1NhgCRQzm6H1+aij/aNEWmsYe/9sW+LbLSs412JMjg0FfoELyjUUG6kTjr6mlcyN pJXXo57Yolh0kAt2D7tya9I75ALvliY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743533743; a=rsa-sha256; cv=none; b=NXHyK9CUNPH3TE1YSIqxtYzeBjELYUoIMehRJku/3rDrS8+KQY3mMYueEbD0Wy46n5LvDw IS86Qf2J0TWFCVdozW6AojuZWqNCAkl1Bj+qdvRawlSVFwMeOJSozKoKT/VM/+wIrSgX6X A4y4UM47p2BmweDx/X6djqI5mrnSxOY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Pe1SnS9J; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.50 as permitted sender) smtp.mailfrom=nphamcs@gmail.com Received: by mail-qv1-f50.google.com with SMTP id 6a1803df08f44-6e90b8d4686so51952696d6.2 for ; Tue, 01 Apr 2025 11:55:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743533742; x=1744138542; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9Q9uOC43r/9w7VdgkgSAIWaOsjrV/IhDIvRZfNVDIJE=; b=Pe1SnS9Je2I6Ek4W6cSsnV42G2JAeIeLCCQPUbXhlT95WM3Txn5TEscT6KSbJW2c9g 0yDh3ZbVSL8wfYykidFSqMgGfCHmip+eyuEYq9Jf2rzFNN6puMRaf03z1oYgpQGzCVZl HXVHRjeZz3mj46TrhWPTH4PP9hRHGEpJ5/yfQhnWGfiBYhZkJb+qckpO8idAjwtcqedQ MxjQCPx9J+ZYefpkyYRGq0VGsaFDAZqVUb32ftXYBefT/3x3Oe6LNLY8qG3oq8Xhroze PKR9FMjgFoYGTsIVjP36G+nDTrJ52sz+OpciaEXbroMDjigvu2ACT3fuwWRLB5yowVQS XTZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743533742; x=1744138542; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9Q9uOC43r/9w7VdgkgSAIWaOsjrV/IhDIvRZfNVDIJE=; b=OX/IetURWFsxajSTaR/oKfGhWcm880Hfbmkz12PRSy9QK9d0SedoUFYgWJATR8GzKu 35ee8c1yTv1lbngn3WOYX2P76qxVBznYhbALWpJhM6TpKMOUlfkqgVOIR5OPNwrKHUsm imW9IjasFqy+Ts+xWsa7yIvB905gIafAl4Ct5fWqMjSlcf0QdC9fXH1o5YVGl4gZDfLV +i7U9Snjdu0YYH4zumJHmBC8PQaC557zxlszS8IXheCXY2Idi46840z8ty1agA886oGl BUYznv2t+deG3+zFdziBWWmWG/xB+cBlUcl5gaCff8GNMyw0jqg/AqfUvuL+M3m5/p6i edHg== X-Forwarded-Encrypted: i=1; AJvYcCUZZi/wpRBv5OI5FuTieqaz090eL6QC+8cksETzUfwdBGtpktIZ2QnHfkkmz1Kk5uDrL3TNXMffFQ==@kvack.org X-Gm-Message-State: AOJu0Yy3D9DiY87aLq5Q1ZQ+pFghvbYOg5N1jlJ1BwBhURfWndCkGZjU K9WDWi/tx0PKPEXeqR4aVvx6vhPjrf9EZxoSXnFCCH9CgBLhijb6fCtT8iv7LZuCQeOUtYRkhF1 mppiD6OupWw8+06NSSbKV9AZlrnA= X-Gm-Gg: ASbGnctg9NlTtO541A7vy8g2rAk5jIPttx2/hUTLWAc9lZKRxTdasQbxQCYga7Q73vb 3iBwyvu3eO9ZRjGvtJ75lOGf8OZoXlhvBmVSedxMa+kvs4NEAMbqxXKReit9eeWNhUCvS/ExfSV 4fpMJ5O4lTSc17mvt2c+G6zBFpYJj6TXbczq3elpzICw== X-Google-Smtp-Source: AGHT+IFnu2+L6M9/jMcN/WMSFnMO0o304vss+SI8PfVCPL4VqXbrE5Ld+sLK7fpk0gDBEv357bnG/lQZ8KxPgToEfSo= X-Received: by 2002:a05:6214:1cc7:b0:6e8:feae:929c with SMTP id 6a1803df08f44-6eef5e03c9cmr67441426d6.21.1743533742419; Tue, 01 Apr 2025 11:55:42 -0700 (PDT) MIME-Version: 1.0 References: <20250306230015.1456794-1-nphamcs@gmail.com> In-Reply-To: <20250306230015.1456794-1-nphamcs@gmail.com> From: Nhat Pham Date: Tue, 1 Apr 2025 11:55:31 -0700 X-Gm-Features: AQ5f1Jpqb4LGQmN1IeGxg07gpgFgPdxEt7PZxoeyxHEsv2aAY8GuoW4vp3YJT3U Message-ID: Subject: Re: [PATCH] page_io: return proper error codes for swap_read_folio_zeromap() To: akpm@linux-foundation.org Cc: hannes@cmpxchg.org, yosryahmed@google.com, yosry.ahmed@linux.dev, chengming.zhou@linux.dev, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5978E40005 X-Stat-Signature: q7qmf64f3roj6kgr6wqt5mho68bqwzc3 X-Rspam-User: X-HE-Tag: 1743533743-451838 X-HE-Meta: U2FsdGVkX19NQ+revl3UDEfOQ03hijLqIAgfrgS8fQ2zSRplY52kb0xOy2AuYv7euFHRkPzrEivPb2FDI1IoarFVpGE2fv+d8tpnUGpV5AKQwdPFuUqCRAjur9qdAE9e2WIyB9bfFKtTVhrKoq2tGJC0vfYwa3qFGwmumlHunJdK7UN7zAm7aeQMhRgJprZ2CY9g4o4l2oRysXlhhir1ICVltx1Elm8hJkdPGbydRzs6bN7iItlW00MCzr4fX56zhmolZg6HW1Vcv9AMQQpfxz6r+J3eMrOwTCGDiKQXsBEGckmiktA0kaoPIq8r3ElEnNNPj0d+htOjCB2VbJ1DQUvS+fosUlJhCOtoo7+K6bopswFtn3JJaioBvVII7KWgdN7OhaENI6rTauOfjlGR0QWj99Mlv0axClHI9JdQVFyLWkDChMxIeN6yhjtrfMLWGtN1Cj4ijbGDGc0AdKSh+xPxe9jAmEXN4au6Z71biOgmVjaMRzEu++kocLzHjxiCGRRUAGLEwVMW9/dMoWwaLIaoI4s6u++IFNMCd/bIs0fgkAY1WsCEoT49HxtQ4dTyMjofvsvg3t9U9fRSqfXZ3JNHgHqGYyXOWdmqRATM1AraZsBMeRaRd5FO1cLC5joiNlNvqn0kY1j0siN1XxrfM5MAgWpj88hrvLQ0CHmSbkD2V9piQfxwIziluq6tRBqch5xEsCeNYaeWDLxeNU4BPdKtMDGQceBQd3DvSsrvXPRk74WI2AuSQ/kc8kraCJftD/2IqPa06dCn+G7Uaun6tMDeI7Z9nTl8hn/25LSz+HAegdLedZDf9XE/5uSKXtwMDsCuOzKahKlOOr1AlpGrPem/iEWSxAbW5BEHodjhc/opKT5xvx7rhzkQuarb/21cTPeL+ImnoWKUpAFMsT+AayzjM6WztbF8oWfajyxi/xZkevUI+QUhxV/C+OdhyU8+P9eCjVOFCJKOyHAocBx TT59g3LU lRLKEzZ2sy6NIG5sOpLDlGL+DabJ0CpB59U+SeyuPCyRWzhdcYhx1Xe4ZjRKfOReuHHxBN7Pi0lBiGdMEH5qicuhPTGP85x6sW8mFJwy68NRCXanLIktWfwzZKAvwir2HvrBRE0OZFRV1K/1o3/1hMTUr61aAgNgewG+7SRPgowYINt1x1dGmdCp0+mdwwnW9imyx4ZFmlfzWpBYjkjEGNxNiSr+R1ppNU78MvSMCqNzEjueSbpaFZpP37i9prkDRy6sxPm8bQSPEUglBqSe8L/WdnskBBKhypNErtj6olFJQ3rT2r8cvgi6QVtbl3soCcCmGAO0KTQH9w/txyFnmIeR7KGh/cal8/gdXSoLaq9ptJiCfbZLMfkj0j0dyf4chzPFm3b4mHgOpSaFd8eh5QiBKC3kAey52FcQ8ynp08TO8OfmGxry+YHhmcib8bl8snEALLBFMXQuMdIjcyuWE8GAJHA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 6, 2025 at 3:00=E2=80=AFPM Nhat Pham wrote: > > Similar to zswap_load(), also return proper error codes for > swap_read_folio_zeromap(): > > * 0 on success. The folio is unlocked and marked up-to-date. > * -ENOENT, if the folio is entirely not zeromapped. > * -EINVAL (with the follio unlocked but not marked to date), if the > folio is partially zeromapped. This is not supported, and will SIGBUS > the faulting process. > > This patch is purely a clean-up, and should not have any behavioral > change. It is based on (and should be applied on top of) [1]. > > [1]: https://lore.kernel.org/linux-mm/20250306205011.784787-1-nphamcs@gma= il.com/ > > Suggested-by: Yosry Ahmed > Suggested-by: Johannes Weiner > Signed-off-by: Nhat Pham Hi Andrew, I think Yosry and Johannes signed off on this patch (with the fixlet). Looks like it was not merged for 6.15-rc1 - let me know if there is something I need to do. It's mostly a clean up with no (intended) behavioral change, so no rush of course.