linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Nhat Pham <nphamcs@gmail.com>
To: akpm@linux-foundation.org
Cc: hannes@cmpxchg.org, yosryahmed@google.com, yosry.ahmed@linux.dev,
	 chengming.zhou@linux.dev, linux-mm@kvack.org,
	kernel-team@meta.com,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH] page_io: return proper error codes for swap_read_folio_zeromap()
Date: Tue, 1 Apr 2025 11:55:31 -0700	[thread overview]
Message-ID: <CAKEwX=Njxjg+G6H4X77YPnZ=mQJaR-K8du1VP6voDLZ55ZaepA@mail.gmail.com> (raw)
In-Reply-To: <20250306230015.1456794-1-nphamcs@gmail.com>

On Thu, Mar 6, 2025 at 3:00 PM Nhat Pham <nphamcs@gmail.com> wrote:
>
> Similar to zswap_load(), also return proper error codes for
> swap_read_folio_zeromap():
>
> * 0 on success. The folio is unlocked and marked up-to-date.
> * -ENOENT, if the folio is entirely not zeromapped.
> * -EINVAL (with the follio unlocked but not marked to date), if the
>   folio is partially zeromapped. This is not supported, and will SIGBUS
>   the faulting process.
>
> This patch is purely a clean-up, and should not have any behavioral
> change. It is based on (and should be applied on top of) [1].
>
> [1]: https://lore.kernel.org/linux-mm/20250306205011.784787-1-nphamcs@gmail.com/
>
> Suggested-by: Yosry Ahmed <yosry.ahmed@linux.dev>
> Suggested-by: Johannes Weiner <hannes@cmpxchg.org>
> Signed-off-by: Nhat Pham <nphamcs@gmail.com>

Hi Andrew, I think Yosry and Johannes signed off on this patch (with
the fixlet). Looks like it was not merged for 6.15-rc1 - let me know
if there is something I need to do.

It's mostly a clean up with no (intended) behavioral change, so no
rush of course.


  parent reply	other threads:[~2025-04-01 18:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-06 23:00 Nhat Pham
2025-03-06 23:42 ` Yosry Ahmed
2025-03-07 17:03   ` Nhat Pham
2025-03-07  1:38 ` Johannes Weiner
2025-03-07  3:08 ` Chengming Zhou
2025-03-07 23:34 ` [PATCH] page_io: return proper error codes for swap_read_folio_zeromap() (fix) Nhat Pham
2025-04-01 18:55 ` Nhat Pham [this message]
2025-04-01 19:01   ` [PATCH] page_io: return proper error codes for swap_read_folio_zeromap() Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKEwX=Njxjg+G6H4X77YPnZ=mQJaR-K8du1VP6voDLZ55ZaepA@mail.gmail.com' \
    --to=nphamcs@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=chengming.zhou@linux.dev \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=yosry.ahmed@linux.dev \
    --cc=yosryahmed@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox