From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F6F2C4167B for ; Wed, 6 Dec 2023 01:30:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D35FD6B0095; Tue, 5 Dec 2023 20:30:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CBF946B0096; Tue, 5 Dec 2023 20:30:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5FAF6B0098; Tue, 5 Dec 2023 20:30:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9F6AB6B0095 for ; Tue, 5 Dec 2023 20:30:18 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7FC96A0337 for ; Wed, 6 Dec 2023 01:30:18 +0000 (UTC) X-FDA: 81534662916.18.3DC3EE4 Received: from mail-il1-f177.google.com (mail-il1-f177.google.com [209.85.166.177]) by imf23.hostedemail.com (Postfix) with ESMTP id AA195140003 for ; Wed, 6 Dec 2023 01:30:16 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XBWJFnic; spf=pass (imf23.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.177 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701826216; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wOFBk06V0iPHoZN7l9Hfj2HO9+qghCOI4wCxtS6Vf3U=; b=mXF1d0HyLo6dG/Rd2sIz1cWeUofLKeB7qgRdoxBwmvhZwudZPsjqIAKF1kDAeDV9rpFZQb Vy4w2sZZh66eIaSkf1R2IcGaI+JhqjVTfFuZuVIrPYrPbAq/TPki2g1/IpCFhoHLly4+ko xE0QI39DE1l+95/YTc+BjiQXpjfzINk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701826216; a=rsa-sha256; cv=none; b=3GpKwJOZCq2ZRBw13RzrnxsPCYZYkVw2CQRSiGx1wCYu3Mz5O0MJy+edK+JY4prHOqLHue lt8hyN7/44z4VxbXKhjkktqftm/124qYWHarb9CeuB/tFfah3aq6kHOFE4spTlZ3sH8x4n rF5hiU6v98o0pJ7KB277HdHaB4Uq2kY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XBWJFnic; spf=pass (imf23.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.177 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-il1-f177.google.com with SMTP id e9e14a558f8ab-35aa6107e9fso26326765ab.0 for ; Tue, 05 Dec 2023 17:30:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701826216; x=1702431016; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wOFBk06V0iPHoZN7l9Hfj2HO9+qghCOI4wCxtS6Vf3U=; b=XBWJFnicf/rAN5fY547gP1Kv/DoJLz5SFtt+en6X01GAt2mKtc5vFqHwb3E8W/msrU 7vtBVCf9T8I1fuTvtLy4CP+7mDvhXG81lvbovBJAUeurKHg+c8KAvHeA/BJDKemq4qcE ypMYczF4QiUbhhDxkRlNle55wIB+P1LogiFtaNPU+A2U1IEPG4fFjsrGDs61HRQAf6kX 7xappNEOLBOF/Q8z6MTGl7u0n1ZYJfYFS3TyBJOHxIiocB4omFvGOia5qwJCFH0Xk7ys 7Uz58O/jnxH8VIgcyz/bboKElsCGAHQvAca+T7wQMz/rywqMmtzgfzVPwWB0xyN8vo3m B2Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701826216; x=1702431016; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wOFBk06V0iPHoZN7l9Hfj2HO9+qghCOI4wCxtS6Vf3U=; b=Ha7fOT2l+iUNlQ5Ef+Pp2iQBVEiRtwsweClPLCeTKVN08F4sQtKkFR2kRyMQ93o0qB Jjdd0RumzuL4aZ4Q6bfuN94sm2yCT05S77xd+VOJsHYpcjMqHcHez19dT7AyaRRTgaUM NPXWULWlCqC1G4G8oBgkLZbqGJa19d4dT9zxvV/wr9g2pIKZItRNO58Nn6hkFoxDzFQz n7jlo1LaYw+yB6D09Fd2lX/XgjFRLPGrHt50xe8YYy8/YWrNiyi6wyDzNv70v5Dn4CoY esrx1Slr9cNyXUVpP3xny9zoFucRzLHWFh/AzTqvB0o6fnfhiVTMBqS2DVghUtBvSjF8 13sA== X-Gm-Message-State: AOJu0Ywup+8h1Ms+jsJXHVw6M6nQtEkNNg7PvOh11nEZS/prqthWoWTK sIDXzZHxJMbB5zNF+tQ3Ur/MmDPVvjIDQs1BZLQ= X-Google-Smtp-Source: AGHT+IF2PzzcXijWvJLhFkxW0lUiLKOLnKj88t1aot7T1boed55yc6mphki+baIkOQ/o0Za8IiIsvrgTw5HjllN1YhY= X-Received: by 2002:a92:d604:0:b0:35c:f8bc:ce0b with SMTP id w4-20020a92d604000000b0035cf8bcce0bmr244781ilm.18.1701826215722; Tue, 05 Dec 2023 17:30:15 -0800 (PST) MIME-Version: 1.0 References: <20231130194023.4102148-1-nphamcs@gmail.com> <20231130194023.4102148-3-nphamcs@gmail.com> In-Reply-To: From: Nhat Pham Date: Tue, 5 Dec 2023 17:30:04 -0800 Message-ID: Subject: Re: [PATCH v8 2/6] memcontrol: implement mem_cgroup_tryget_online() To: Chris Li Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, cerasuolodomenico@gmail.com, yosryahmed@google.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: AA195140003 X-Rspam-User: X-Stat-Signature: 55b68qcyqopmezt7axyk3eaoge8k6e7p X-Rspamd-Server: rspam03 X-HE-Tag: 1701826216-613376 X-HE-Meta: U2FsdGVkX18AOdJ+Ol5isMs6gjDhQ0tcgJwzwV0/rc4ECylTNYsxUol2aEpzk2KfLBDi3KSYGl/OCjufNIE0cGjDpB0z8mPLfBIKg8L07yxgjJbWIuA0uPDTcTbqj9aIi2Ghvv8iC7dgQLdXTgRsIKkJEzKA2crFT3mgZW8b+PQOclyNtvtgV3iV1P2d5f3OFdr7Of6s1+W4YabNPAWZraCRsA3YOYerEFJRwqZ9BD/O/M+B/hTlpJ8zyrdBkuPoTsBVftIXtQocnP3Sz4tV6ZpEfX9bg+ogJX5MaI8UKAjoa4+yxkPcpzzh1S24qNFrXQBrkw0NIcPOAW8vMIkzYKSkhUMZmH5RguxHK5oxKwM2eWv50ZbYRFsHaJl0MxGHsOXbOWqb+Lqv6yQ3KGLjY0lO/m/RqyxqtvaJs9d/CXq/o0oAXZnk4am5OgsppcGcfa/fHVKVGIoQB6+YNX4l5mRekkYUnhw4r/A/86gZ+IAzjilHL1+zoN/CC6aUglkKdHWQi3qYKUssxabTXH84RIpYv7xd1Lq0SkKrqYoUP3jeqh9S04E8gZs4MwqZVkmCOyYuD0rLjB17tLeHybR91K1AIhb7EmfUNtnetiRaOvcxYkVRcqKryzWi2dNI0CN8qblKiFQNfLHb/tF5jd1GyNkh7LCJpTfTej91JW3irL3tNM/ZCwJFaHyrf3EMnvHC4/CLt2v/mNNfgd9E5TZYpV4VeEV1pToNC/gT6VakjuocY8cHa0OkvrFpZXSMOhyZGzDyncTfDnfFKYoCrp8Re+kOeCCGztBBcHn+vRH7w/vm8UFH3iXOe4DdrazKkXh1IJ7xf+rGrgOxBaSCt6A9yiiKZLi/kJdCeQftMhBWllTug+PmK1C/HkoMJ2Tk8eTBQcmhHqy4izzQAZkxFL0nflRDROTpBqv36nsfaB0SafMsYmSAcpH4eUFW/HYeDeYxX0RZE2qOQxS2rcaIJPO WcICa2bK 7KdlWbGYVc3U5poCGkX9trqxO3KVW1WDb01RmRx67OrcQdGBTje4B4b4op2ewpGa8Q6pwzesVOHp/lNcX/S0qBg8AIesgO7cnuarKPNBGQxnsW+DzU+n46OnnUK481cban195L+0gthlVYPIQdOzyRpnl3jFlFJUtHvBDoZ9vb7V6Uq77N2bq6CFw3COoB2FazoHJiolOUFn3Vg/mKVNtB89wLnWVdTrdZSWKvtlrQa4foHcGOgfRctiYNI5qp1Ay/QpcslcoWIgjits3COBRSJu0N0TcoofTHW44eEZ9it6WDJrBrhFfLPjwkWOFwKW9vHw8lNKnIyN92W73ihpJgc1e5Jbf0GZ7ushfI/wlIyjr8zvsCcOzecWd733YiDpWBH+RSmU3PONcN8P8mrPhm01cysFBkjOxkb6cx2LYXi+i2+MirNSgGo9EXmgIG5O09+Qvm7ZH7Z08lCaP9yR42RI9o70j2N2YsRk/yhic+OjKnyY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001891, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 5, 2023 at 4:16=E2=80=AFPM Chris Li wrote: > > On Mon, Dec 4, 2023 at 5:39=E2=80=AFPM Nhat Pham wrot= e: > > > > > > memcg as a candidate for the global limit reclaim. > > > > > > Very minor nitpick. This patch can fold with the later patch that use= s > > > it. That makes the review easier, no need to cross reference differen= t > > > patches. It will also make it harder to introduce API that nobody > > > uses. > > > > I don't have a strong preference one way or the other :) Probably not > > worth the churn tho. > > Squashing a patch is very easy. If you are refreshing a new series, it > is worthwhile to do it. I notice on the other thread Yosry pointed out > you did not use the function "mem_cgroup_tryget_online" in patch 3, > that is exactly the situation my suggestion is trying to prevent. I doubt squashing it would solve the issue - in fact, I think Yosry noticed it precisely because he had to stare at a separate patch detailing the adding of the new function in the first place :P In general though, I'm hesitant to extend this API silently in a patch that uses it. Is it not better to have a separate patch announcing this API extension? list_lru_add() was originally part of the original series too - we separate that out to its own thing because it gets confusing. Another benefit is that there will be less work in the future if we want to revert the per-cgroup zswap LRU patch, and there's already another mem_cgroup_tryget_online() user - we can keep this patch. But yeah we'll see - I'll think about it if I actually have to send v9. If not, let's not add unnecessary churning. > > If you don't have a strong preference, it sounds like you should squash i= t. > > Chris > > > > > > > > > Chris > > > > > > > > > > > Signed-off-by: Nhat Pham > > > > --- > > > > include/linux/memcontrol.h | 10 ++++++++++ > > > > 1 file changed, 10 insertions(+) > > > > > > > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.= h > > > > index 7bdcf3020d7a..2bd7d14ace78 100644 > > > > --- a/include/linux/memcontrol.h > > > > +++ b/include/linux/memcontrol.h > > > > @@ -821,6 +821,11 @@ static inline bool mem_cgroup_tryget(struct me= m_cgroup *memcg) > > > > return !memcg || css_tryget(&memcg->css); > > > > } > > > > > > > > +static inline bool mem_cgroup_tryget_online(struct mem_cgroup *mem= cg) > > > > +{ > > > > + return !memcg || css_tryget_online(&memcg->css); > > > > +} > > > > + > > > > static inline void mem_cgroup_put(struct mem_cgroup *memcg) > > > > { > > > > if (memcg) > > > > @@ -1349,6 +1354,11 @@ static inline bool mem_cgroup_tryget(struct = mem_cgroup *memcg) > > > > return true; > > > > } > > > > > > > > +static inline bool mem_cgroup_tryget_online(struct mem_cgroup *mem= cg) > > > > +{ > > > > + return true; > > > > +} > > > > + > > > > static inline void mem_cgroup_put(struct mem_cgroup *memcg) > > > > { > > > > } > > > > -- > > > > 2.34.1 > > > > > >