From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCCEDC072A2 for ; Wed, 15 Nov 2023 17:26:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62BC36B03AA; Wed, 15 Nov 2023 12:26:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DBE46B03AC; Wed, 15 Nov 2023 12:26:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A4B66B03AD; Wed, 15 Nov 2023 12:26:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3A36D6B03AA for ; Wed, 15 Nov 2023 12:26:05 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0D98D1602A2 for ; Wed, 15 Nov 2023 17:26:05 +0000 (UTC) X-FDA: 81460866690.30.B4CD550 Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by imf05.hostedemail.com (Postfix) with ESMTP id 479CD100009 for ; Wed, 15 Nov 2023 17:26:03 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XhIQbT8t; spf=pass (imf05.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.50 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700069163; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TxkFYGMJuy8RDq84rB92XeHb3mxQtE5maYApNhXE5PM=; b=Vw51yVmipvDLYBDAFnewN5Q6Rml3BPnjFvVo7gliHzRJUeHshDs4Yc32u9b9RxEtbjCNGP r5xFTVA0zAa6ambsi6EOX1h9BhelxfYAtCNPTlnW686cuDKdnOPUYbgqQHQGLN7LxT8u/c Q8Pz9q+8niP3nT/VM0pHgdXW8Fzxy3w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700069163; a=rsa-sha256; cv=none; b=LYtg8PdCkqXH43OSa6A6nKchSStRh0n30x5E8p6eZULjxO5fjdi8p9ejNcHbOiXxEt5IXr znvBOitrXNjdUEYIwEPEMDEyhfslQvYRzvPYMa2w2LLOTc98kYBIpIgiOUfCbUmX66gGcu XEzeIIuWFkquinJyRND5gzz6OIONSa0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XhIQbT8t; spf=pass (imf05.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.50 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-io1-f50.google.com with SMTP id ca18e2360f4ac-7a694a365d9so291275339f.0 for ; Wed, 15 Nov 2023 09:26:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700069162; x=1700673962; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TxkFYGMJuy8RDq84rB92XeHb3mxQtE5maYApNhXE5PM=; b=XhIQbT8twz1BTHwjSyU+CF2p62/FjKachHCVDccr6szfoSYsE7iRcijcdScnvB1yVe m7rlzzyJftaAoUR3hskU3YLotxsCuHP2VfRtxdY4uf6rMv3gG2/T/nN/jL7a+B3tX7kd Jc1Hn8MULXSmGUFOzJFNV0wplK7QgqUY/Z2u73jR4rFEdo3TlNhtfoDNJn74Fgm+AJw0 UbSvDBOQPSv4GXQdsj0riWv/2Ge8f89aZu9aaIlzEqcUBG5n+53HsTs+8F/N6azI3L06 4uXvnoV7OlZGDK/yx6EauzAw+4t8SSlVmpcIryYyWt98XSEqPtKaFTt+xkggYR89zP38 bJkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700069162; x=1700673962; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TxkFYGMJuy8RDq84rB92XeHb3mxQtE5maYApNhXE5PM=; b=p8xIYF+2CRLK85PFPGbxlmbPvvbs+1lY3Y8DQ9Fs8yyZr9E9L9nKEYOzPW5suSwQ0l mppDv4DbaBTPHWmM+90U1JiJYLfPHoiv17TmPEfnWeSUzmPHWOFuy2Gdvx4O8zsmPQqd +nhBGg1/dYWE7riR+0NCE4i8mSSv9WM1DD0fKx/men14xnOErZTOofTGdGi4f7G+Q3sN vE71atmBZ76swuOew9z1qR+NvthIdSYFF3GWMPgm0GUTbL1BdXAvneq8nn1BTjgNZ5IH gIyGZ3W2QqJTyVwncqD2kFpKPUt2LZmDkbioXDzb4PQ3LlRQSxFftlkHUsqt+EZaYlT7 i2mw== X-Gm-Message-State: AOJu0YxGySnEC9e2TEhuoFKYz9ziRyuG9S5ZtuvEn3m9mMN3SUCO4ljv DEDynYtpuo/GhklfoiFGCMSqViAqI3Z829VWsc0= X-Google-Smtp-Source: AGHT+IH34e4GBjpe1mpBbZlZSoOKNesoEU1gW9XC0SNba4mFFL+AdZvbgoUXu86ZZicWfkyXXL+Zw0B7saZHo491jAU= X-Received: by 2002:a05:6e02:b2a:b0:359:4e76:fbf4 with SMTP id e10-20020a056e020b2a00b003594e76fbf4mr18185838ilu.13.1700069162224; Wed, 15 Nov 2023 09:26:02 -0800 (PST) MIME-Version: 1.0 References: <20231106231158.380730-1-nphamcs@gmail.com> <20231114145040.4b90d49d4ace1621c87f9c79@linux-foundation.org> In-Reply-To: <20231114145040.4b90d49d4ace1621c87f9c79@linux-foundation.org> From: Nhat Pham Date: Wed, 15 Nov 2023 12:25:50 -0500 Message-ID: Subject: Re: [PATCH v4] zswap: memcontrol: implement zswap writeback disabling To: Andrew Morton Cc: Chris Li , Dan Streetman , Domenico Cerasuolo , Hugh Dickins , Johannes Weiner , Konrad Rzeszutek Wilk , LKML , Seth Jennings , Shakeel Butt , Vitaly Wool , Yosry Ahmed , corbet@lwn.net, david@ixit.cz, kernel-team@meta.com, linux-doc@vger.kernel.org, linux-mm , lizefan.x@bytedance.com, mhocko@kernel.org, muchun.song@linux.dev, roman.gushchin@linux.dev, rppt@kernel.org, senozhatsky@chromium.org, tj@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 479CD100009 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 1xx6cu15mg7pydk1k98du8h7aomg76dr X-HE-Tag: 1700069163-282923 X-HE-Meta: U2FsdGVkX1/uHW7wntPMx9GKpAQ8wJZGT2OIv156k4wgxvcxJFw8X8eTjcC48PGE9CbzKM6VSE+Xgh62WUBU7zYP8uYBBOeIzsj5143RgPBj67r85jtC8HU+IfaZzHyz/LHcEulQWX69TccK/H9j//aRCTDMfTRLIFARNxn+p9fl7W32USGJEHKujOKeuWNwX0sD9zcGVQV8GVZ8+TOwc/0hoBvvYbFws+uu3oP10TF7nDEmoe24eH+42OJQHxH0c4XoOZLuS6UvL+HB6CEtwvUbrWWKf7JOEI3R/xz3pBIF9HfhV9sq5X06ZsLFgUORYxE6XEKnhBNNr84jJp/I07GEtXmiYB+fnasO2hJzqE/wBZrefyOLz74F5ookvjK8gIUclO22pT0tYCN/hTfHmh1pG43uYOW57G1CfuoGubl4OGCfsAaweG89O/cmDY6om7abbz5Pidugc5AuGzVDIsoS99+KyF04b6s2RNVTC/BPvr7/4vJAF9p4crTFjanchvZzWzuKfMlXtu1+1asOQOZJQWyJizbSAd0bo3Za+k0OvZ7xTV6mCd1vdMOyRoDr9x4cShK+esVPnziYivrOqtbSLtHIcX/767uh921hzL3GhqajcOiYN053lbul1/po9c4NKg5olZhwSejfPPjHZEy3iOie8To83lHbMTe2pzDxoiT/XD3ePirj/zGJV8oxZZUDA5Kq1oDdSsave4K+jpe5mFh5AetncAR86dfAbPeC0x26G0QVreQRHA4YCvwwQpEzS08IjxWRwfvzqxgDDGN2rBZ02i4vXLfGalcYnAdf3posiz2EYvLsQ+pv9W204iEy54DnOD8AituynVTLZmhyMfW+G/ggMQbNr4/Ry0wkNRLbiQ1ndsajukU7+hxPRhhN8fx2jmz7Rb//tAER0Y3amX3PvwnaobULbigRP2+bA2Gl38HnnsOJoSajYzbw1HGx+4h3qdrfU2+KlSr xEGbQWd3 sCCI2DJX1k8I7cXClpryhhfkglt69+qp57mEog4/HXjA2vPcmN5ra438spdjsxRn5A4vo2uUFUBklsHmT2+yjqWF9qlX4tdRF2S2lBcm75N4TlZrEfM2qBaPOOhhA9K0qMDEMWGbxnf9JPzRtcsGvj+dZfh+MrR9TTf5uZ+Coeaxc9s/yTAmonYUUeg0kFBEuqdl1wEBy8zRnsXipDnPNbgFnz+cR944dIbKCJTmZ/Du9sKX98FXVpzGHc/+IEmLPu5AkvNTJpV+vqpzxt/uyMW56Yc1l+EzcgGSvHjOWNCscGJtWIT97bLu9EWNFeboXIJkentufFMj2Csi92/KGQWt5FUVbS9w375IuaGHUkcxrBva3H44GJ4i00g+aF91l9yGVWvCOLN9LfBpnPps3CUkTWrhOTTexmHbUVBwfJ3EXn2ve+wWWLcEVkg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001977, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 14, 2023 at 5:50=E2=80=AFPM Andrew Morton wrote: > > On Sat, 11 Nov 2023 16:06:58 -0800 Nhat Pham wrote: > > > It's a bit of a micro-optimization indeed. But if for some reason I nee= d > > to send v5 or a fixlet, I'll keep this in mind! > > I'm seeing a lot of rejects against current mainline, so yes please. I should have been clearer - this patch is to be applied on top of the shrinker series (which is still under review). I originally included a comm= ent in the patch log, but it must have been accidentally dropped when I reworke= d the patch according to Chris' and Johannes' suggestions. Nevertheless, I have rebased it on top of current mm-unstable (with the shrinker series on top), then sent out as v5 (with the second suggestion from Chris Li) just in case. Let me know if there are still issues! My apologies for the inconvenience and lack of clarity.