From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B3A3C28B28 for ; Sun, 9 Mar 2025 22:21:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65061280002; Sun, 9 Mar 2025 18:21:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FDFC280001; Sun, 9 Mar 2025 18:21:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C6A1280002; Sun, 9 Mar 2025 18:21:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2DD03280001 for ; Sun, 9 Mar 2025 18:21:10 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E0BCB1405D2 for ; Sun, 9 Mar 2025 22:21:09 +0000 (UTC) X-FDA: 83203434258.01.F2EAA9D Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) by imf04.hostedemail.com (Postfix) with ESMTP id 0DDBF4000C for ; Sun, 9 Mar 2025 22:21:07 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GJo9d7zh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.222.181 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741558868; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mda49N4Llb9FH9F0+WkzWs1rqlShmxC1BmbC6l/Iyuc=; b=tfhCmJhX4KX0fGJMOr1Oc8cK91srEP7/IS8fWKqonQtK71PxbgIqS2kZV2Bf39wl5PKW4m VQVVXyoFeNLmipbCkFuLoEX/+/uB5g8rg6zVGyeWpG67rfThbw3xos9TFfAqPm0edg+7Sa kLSgzMSuaSBTTOpe9NFhs73pg2y8Fbk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741558868; a=rsa-sha256; cv=none; b=FwKkJ1erpIk44m7rc5dB2YHLW5JsFNQBDE7lbKQ93Fnu9HPlI3YdVlpjLg4UjSrdDGsFLa UKUyvL0t8XYnX3+yuJZpKrbgXFhtjDlGcJPri6MINHJcFeT39N2BpK18etUu8nPqqN78qx CdEsa61pp/pn/INe+CvHQH+Kna9HLH8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GJo9d7zh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.222.181 as permitted sender) smtp.mailfrom=nphamcs@gmail.com Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-7c08f9d0ef3so212287385a.2 for ; Sun, 09 Mar 2025 15:21:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741558867; x=1742163667; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mda49N4Llb9FH9F0+WkzWs1rqlShmxC1BmbC6l/Iyuc=; b=GJo9d7zhQVlXrW+o4Osl/7fz/aihli0CvfCLRmdIxaD6+44ZxdWC310KqB6LxtZeOb JrNtPXfIxQ8ZW9lfpQnMhyNfAIwQ6TbU43YmVD0VxtsXHeEuQNyt8pW3Xp8n8S5U328I p3RhnmtUdvyhhIMKE8RFN2bgm83TU7GBbXxHNBEsWt1smaATlbhIDgALHwi6fh0QjerL hSj1Z0csV+lY7GFgzNjvBJVU2RA1+2udP0USoP/r4Zh326Jkd9n4QtgRyy5pvgMcGmfr QadmihxyRq7CX+aoohZhM8gpXfVuqVVl2qSuMj3hIAC4aSDIYBzLsCzzb8k6uXsUTJhu 0ohQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741558867; x=1742163667; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mda49N4Llb9FH9F0+WkzWs1rqlShmxC1BmbC6l/Iyuc=; b=hZC+er1ocWQVtWi8eJwdYCjBtN0rXVFx/NOr6lt1t+zhFzGsJoCQuw0WvS6tO+E47J w6f37iVxrTv7WVtywCoM6i2mrUPkZJMz7gEJNXakalc70AD+75zihX4MTf01eWbx3v7J ygOzcNERQiKAlkY9CJMpJB81qr2Arf2bzqAT9uexrUFEB2xnKdChnHU1tafA3iLgvWOA /VTczXTLNk6NduB7ttVF1MrTbWdylq195e0Pn3NuHANsm1AZj+58a5G0rPXxfb9O4rT9 RIoQreHjcc5lLTwipe5UvlL6IHP6lrX0vZQqb8ahCVnkQI1CrIKmpFBjP4ehVHQD2Xx2 4taw== X-Forwarded-Encrypted: i=1; AJvYcCWQd5qOUOKgHkqM2wRVhFCbo+FcfqaCvvgfOd8l2X7EV1pRhJRKJ7BbG8mPTItnN9NSvU3yQOEFRg==@kvack.org X-Gm-Message-State: AOJu0YwzSRb2NUjpDp9naamW885ZIbHQqHaHxlL87zGuRrwIhhsKvigh tLCFNs7xXF9FHdjeu2dCZfkaDGV6HwW6rjlssgXP7a9/NBwgC36nYGz4uSDMCx3ZVXBgt1TjVzg HlYpXzn4dzkeTAbOt/CBeV5a713k= X-Gm-Gg: ASbGncsdpNBtIRjkd5jsnjteetZVQVBu8uwHcoHxTDBXM9n2QTpie/rH6fcLqkSAAt2 uj0sBJZeibumUwO13aZjBKSSkUJsWAy5JLcHYIgk3Uc9Po80bjHy2c1dkMd2itphBAA8Nk9MCbB rpQQLDHEodtTpUJ6VWtfMVonWGYcEPtTdXoZg/ X-Google-Smtp-Source: AGHT+IG+fco3RuCq16yz4lbW6ruVn50Joad/g3vYtByAHgzqgrRMAuGi2/nhyl0Yv1EsoL43F5pb4oFJGb6pP0Pnks8= X-Received: by 2002:a05:6214:76c:b0:6e8:955b:141e with SMTP id 6a1803df08f44-6e90066bc53mr146725396d6.21.1741558867007; Sun, 09 Mar 2025 15:21:07 -0700 (PDT) MIME-Version: 1.0 References: <20250307120141.1566673-1-qun-wei.lin@mediatek.com> <20250307120141.1566673-3-qun-wei.lin@mediatek.com> <20250309010541.3152-1-hdanton@sina.com> In-Reply-To: From: Nhat Pham Date: Sun, 9 Mar 2025 15:20:53 -0700 X-Gm-Features: AQ5f1Jp-fSSmHXAcHy1ZOYNbNwFx7b00IGaeSLZw1VYfH3gufSDCE7BUgw17nfE Message-ID: Subject: Re: [PATCH 2/2] kcompressd: Add Kcompressd for accelerated zram compression To: Barry Song <21cnbao@gmail.com> Cc: Hillf Danton , Qun-Wei Lin , Sergey Senozhatsky , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 0DDBF4000C X-Rspamd-Server: rspam08 X-Stat-Signature: t69kn3mqesy33onqck31cjtnecnuksa8 X-HE-Tag: 1741558867-273722 X-HE-Meta: U2FsdGVkX1/PAnkRN7KjvNHDjIbFbhljgZCPMpyqLgxypdmgsIjJXSKwVEAvmMEJl9jyrykNunY5Ic49VRqsH5z3zdIAv56zw0848C8nGzdP8PyAVhvPprXAZcKsIQa3gWMa7f3s7QR45Kf72MP/tJsCLTbtg2V/FCp97hL6j/HehvGodC48F4ZKmYyBDBsok5gMgnaRrU/vDgngimy4F1awcuRK7ucYt619UwEOi72f3xHb6s44FiocdzWRQFxUdDJQeEMvG8K5ThuUXnqmFMtnnP/Vy0qGuerftOOOWs3oZXnNCRHuNL+eMhunTAZmTZM7qKCGVAJw7iSp0+GRY2/C3guH3ZDIV6Q9qyjCSlmOzEyQGmUtlL497iVrI3tJ6W7CKeRjvHZ/azwsxwny4fMbOmyXcDwLEpJYFpjVvgVDjrqrwTklK65cN4XRR6zgX04mOTO9hXG6Hh+2bFKN66bCLbM/L4hLelq1SgGaPWL58kxF6L+P3F4OUVyzRdvUSguegFymN73d2G9NyfiJrhi5xBdBJF2X5g/v5GXcnC1APi8HTbID+x/jzZhuiEFzGkAbAKGagYpfN5HDRNSu0fxcyMSC3PG0lnOD6cg3aeMUCvE7YUEuZNUnR/IJi946J9ygNffkwVmGOki0w4qLku3AtZwejWEStJt7VWEwPvBhWe/y5M3sR7hHfBrLqWLmmsZCSjajlxoDyIRwVE4Kwd6BP+09+814bppuvpxiYf+F7af5aeGUZL3+mkA3FB+hytdBNFSyAJe/oJ8Ml3TGCRkpK+tAauJxE8Hr/KdoL5cL7PVtKUm7gK5RsjmK5J4Cih4uWK3YAxb2MG0kUyAVjlapTEvnkFxT2rV2QSehZvnxptptAGBR3WDM2YBZIY+oK03OP3CxRYgTQry2KRLFMndjaEjvDpE8qJ+5WRkyRdCS415Hiy+/MFmiBXMC7g60G4FHEvfduNx+ap/ldoH gmsYlJkC /ge2Q2R5LoMMvDddkcnwn9SVKvMq97DMoRO878+RfBEqZqawde3GRNT0IthptY7phF1TFHkugm64BYRWhZmtyh1XeXOqeNF2CbrhOkM4n0SOdqDIenC8RswMm7z4ECT6KzEln1nmZZAs5mrXA7U4294Ktm9TeXiHBMuYUorHY11qGy4d6u+LhrjXHKXinflI0ka7SEz4Zh+XLg+ndljX0tMwt52nvF22mcI4nlwYaiJfflDn5MtscAGcvWceRYNHnZ1tDMBzqMMUxfQmLBqeQ8TqsNzhux9GM9hYAGTkvcVbyby9d24UZIl/3ykFHsbnBlGmcFnaAIV90MiirUFHbIQN5EVcM7ZBsk5C+U5iZ66MBr1w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.043956, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Mar 9, 2025 at 1:44=E2=80=AFPM Barry Song <21cnbao@gmail.com> wrote= : > > On Mon, Mar 10, 2025 at 8:56=E2=80=AFAM Nhat Pham wro= te: > > > > On Sat, Mar 8, 2025 at 5:05=E2=80=AFPM Hillf Danton = wrote: > > > > > > Could you explain what nr_kcompressd means, Qun-Wei, to quiesce barki= ng lads? > > > > Who's the "barking lads" you are referring to? Please mind your languag= e. > > I also feel extremely uncomfortable. In Eastern culture, this is an extre= mely > vulgar word, more offensive than any others. > > I strongly feel that this violates the mutual respect within the Linux > community. This is a serious case of verbal abuse. > > Regardless of the existence of nr_kcompressd, it is still unacceptable to > invent an interface that requires users to figure out how to set it up, w= hile > kswapd can launch threads based on NUMA nodes. > This should be transparent to users, just as kswapd does. > > void __meminit kswapd_run(int nid) > > { > ... > if (!pgdat->kswapd) { > pgdat->kswapd =3D kthread_create_on_node(kswapd, pgdat, > nid, "kswapd%d", nid); > ... > } > pgdat_kswapd_unlock(pgdat); > } > > On the other hand, no one will know how to set up the proper number of > threads, while direct reclaim can utilize each CPU. Agree - how are users supposed to set this? The default puzzles me too. Why 4? Does it work across architectures? Across workloads? This makes no sense to me. Can we scale the number of threads in proportion to the number of CPUs? Per-cpu kcompressd?