From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCFEEC4167B for ; Thu, 30 Nov 2023 00:18:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 499106B03F5; Wed, 29 Nov 2023 19:18:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 44A076B03F7; Wed, 29 Nov 2023 19:18:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 311126B03F9; Wed, 29 Nov 2023 19:18:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1E3466B03F5 for ; Wed, 29 Nov 2023 19:18:39 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E56861603B8 for ; Thu, 30 Nov 2023 00:18:38 +0000 (UTC) X-FDA: 81512709516.26.37354FA Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by imf10.hostedemail.com (Postfix) with ESMTP id 22287C001F for ; Thu, 30 Nov 2023 00:18:36 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Bg0wNjOk; spf=pass (imf10.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.172 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701303517; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X+bEWaLtTDsM8rXiSV0y1h9NASZYkUH3bDX4VG92SEw=; b=B0/j3TUoF2hmSZ4Dtf8Ass3I5DXU/a1QEeKHOOZvgMH50IDQDD/D+cQ5QM4vP0WrSROE+2 Lsl2a3besuYqwK2pLa7chX0WE0pnyGAwW84uemKUH2qJZLkpcGCujOOaEEcxsGyOinRLiZ 6RuD75wC8Xb6PxuGhzQXLG/FLKRWrDw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701303517; a=rsa-sha256; cv=none; b=r26hPRl80StqZX7HXmcLbYcRPAMy28CE3+G0zX9EjO86gYMnmWHOP6wq2lc1NSbDhqT2Wm DcOtcQbT9Xnz4YPUJzDgTNpnzsmimtRoqJIjUDWuDmi+ghw/fTeth2P/SdW8vKhYm+blPW /+qKG6Ov2KxJwnrsZuvDjVp15on5yhk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Bg0wNjOk; spf=pass (imf10.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.172 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-il1-f172.google.com with SMTP id e9e14a558f8ab-35c63f4b1f9so729705ab.3 for ; Wed, 29 Nov 2023 16:18:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701303516; x=1701908316; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=X+bEWaLtTDsM8rXiSV0y1h9NASZYkUH3bDX4VG92SEw=; b=Bg0wNjOk+Sie8QVfAKZI3WASZ0CVL/g4N4gyfx9L8fDsNR39cPsuw8seYcWYS1Q8a0 +7SDzzo6z8agYYrhsh6Zyc0/r9+rp6TB35f/iwUfpZWRC12hoxj4a7bl8Rblm4BvMP6M 2Dp+nv/louhVY8phJwOrT4xRL8usFxK6ZLrT7vn6+uI95ElpEJ8CUoH8U5aq5SZFiEMK 3AUilHLFxklbMcGR4UpF1J2LpTt3wzKuycdpDmmfmIYy4ASDRQXorRxv5leqWz7kahzf fjGX0x7H/oHY44yWG5/4TH2vhZlAlNZFfVDZRjg5ANjBChwbJ+V4qQPv+BnCRvfd+wqp c0Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701303516; x=1701908316; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X+bEWaLtTDsM8rXiSV0y1h9NASZYkUH3bDX4VG92SEw=; b=egzeW8ZzVibF3CoKuSRJpBtz0V2YZAub9fs5CYki6ENYrbLe8qFrh6aJ/T9LPKNa3S Iq+2Upd0myD7U+o3KfhdyvFec6zekeoWnL7NI3C1yaVAXhaC1y1AP/sgdSEmPejxYBrs 9+3G1LOF1dY6hEykKywCf6h9MhtoeLvRdAe62mJNiGwJwUmGyroPxRYAVRIVUZQxDg1T htdWoboapAodEn1q496hb3tKxR2l+RgXTcvlfRfafE3fE7Ud60f7fcAb2rOatZULrQys KyqJ/CifEGEUqTxqXEChCIuDEoqi2Sk/OT1NYoKVRkTETJzI0w6vk3qGYEhN3wGu+G0C c3eA== X-Gm-Message-State: AOJu0Yw4Is7GwfSNU+uXxODm8Gftx32ebbl+rK6rQa5kx0mvBfKYCkol xeBNSwzjhuF+aC+WCkXEVevm4nbNcg7555VFVmJtHzHeRl8= X-Google-Smtp-Source: AGHT+IFGTlpCFsO99/0ZfBSSbS3g84w4StHb6x1TNufg7m4gi97RVCjTBM1VjGz4S+N7pg8go3KChNbhkBTZbq0hZEw= X-Received: by 2002:a05:6602:4808:b0:7b3:989f:ee4e with SMTP id ed8-20020a056602480800b007b3989fee4emr18532726iob.8.1701303516252; Wed, 29 Nov 2023 16:18:36 -0800 (PST) MIME-Version: 1.0 References: <202311292250.RUfWGNgx-lkp@intel.com> <20231129134313.656e76c2e3fec1361007633b@linux-foundation.org> <20231129135342.5697165df1adfff04c749082@linux-foundation.org> <20231129142935.d9c76a2fe35efd9a4c7b4087@linux-foundation.org> In-Reply-To: From: Nhat Pham Date: Wed, 29 Nov 2023 16:18:25 -0800 Message-ID: Subject: Re: [akpm-mm:mm-unstable 179/192] mm/zswap.c:825:17: error: dereferencing pointer to incomplete type 'struct mem_cgroup' To: Yosry Ahmed Cc: Andrew Morton , kernel test robot , Domenico Cerasuolo , oe-kbuild-all@lists.linux.dev, Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 22287C001F X-Rspam-User: X-Stat-Signature: s358315mmmc55pg58bnyjeucyj1crqgp X-Rspamd-Server: rspam03 X-HE-Tag: 1701303516-128944 X-HE-Meta: U2FsdGVkX18cBMM1JIiseCR+2n5EqJPya3+JF7Rd/Om9dPEAYh30l6z78EqDwKP2NTi4nTJ75Oennsk0GJyM5bYmWZcFAjxeuK4f2vGVOYK6J2Uret7jHu6jK0e7yl56IHBb60lfWSxnpBaReFnDVyn1wnblgO4OzKxfVBONwmxwzq43PiVB6hf3+UP/Wi9erV+YjdzRK2TqWF97n3/+bhm4zVJ7C7GOE3tSY9uIaIRU6uBLPAry+DttzqPzTeP4ymMxfYr7TNu9djh9RRdVAbsGETvyeQRjrlGvmOX1F0sfW4eo7qYL6bub/EJ6llmBekY9zdnpIC2udmi5SXTeeIVx42fFvBwf0fkij/wrBLTn8BpfpaYySnZZkBXdT+X6WVYuXpTfIGw0Q/PcVG9bgTH3JpSoaWytvV+ZYDOliy+EAg4ajIisyhBU20yTvP2oqn4VmJXSDEfeCCCHGBuc+9/aO0+9ldxzWvBH2zpl83Lxzuz6LWg9cI92F84irBRjSjV/x40mAnUgXGd8Yp8NUz89c4Q1ji+w6QeS8yKP1RIwFXnWwDKBD8fEJUy3vf6h8az4yAE6WXbcLbzKlz3x4MBAG8MnkHkEH+7jvLcqURcByzVZfje5l0Z5CYuUaRaDuQLdkqwF5VTbdejWdrFGeLsQch+J6/J3hW6By9rC1//EAEzfSHeC/nRHTUNFMryr1cDAKM/jp3fvL7LH0q2naRnXzpFdPl0ndz++M/F96bOreOTmRdPe9SfbTtpcVRSEaNs/PxG38m4rJk67Nl1nhToqLjQRepK7M7PYn+icU7frg8cVLNZg7ufkwpw3RymH5DnCaqu8ghM/SI/mZRAsWFGqEaEp+PiOaCIEscphNQoIE06WO3pUvI2fERO9zefZkCC6BR62X/sEq8JGSSVjCI+Ksu5cg4AMS7n0XF1tTBPlIc+xzqScn6XJzaBDGWsAzhRrsOcCUMo39obIJcM VWcsNj3f BPZ5zQopY+F1DCE20XGj8CX1AO5vISFXQC/lbIY2gyiaNktWQE6gmmJ8oR2XI71RWhn+1+rBdTiPYcvk9JC4ut9kGdlfsFkjkVmTB1bFPqp/UoDI4ECM1EP34RveXdMHufKIYrhEVlz+qKU96xeAwqHmla2lff+VaNRR8Nre9lBU89hse5q3P1QH0AX+4s6JPfxzYIpDNwquBaPWBUt34OWcGzfRvSe55z/i/M2YdHeP3+lwQmQGCK96wdKSRkC+HsuYdy1qDx+zGMb/7IxQ+cDcmBTAtIl8YYQ9s6FUm7yJwoKh3C06MIOfE1agnoS8gUOeHif3XZwQ+14oa2ZDPWxybAe/jqV/nB/LTrdPnuH855goW0cniRSC6KJ1wBH9QxH0HTumcMQlOF4tzZuhDv+3DD5bJ+eT9ymZqSiZX5OuZOMGi2hTFrsgh+44pIQ9Aop7Wy2MKnJmK/rutdnKXIwaDcsArxGN0ckFg3wJOH6H0EIhYhltEMRRtmwjT+g74xm9glPhhgLFsLJ2M+01MIUwzUaFoTYqjmlPqboFhdurKAUukc/QlcygCv3LEqbitw+sL X-Bogosity: Ham, tests=bogofilter, spamicity=0.044725, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 29, 2023 at 4:13=E2=80=AFPM Yosry Ahmed = wrote: > > On Wed, Nov 29, 2023 at 4:02=E2=80=AFPM Nhat Pham wro= te: > > > > On Wed, Nov 29, 2023 at 2:31=E2=80=AFPM Yosry Ahmed wrote: > > > > > > On Wed, Nov 29, 2023 at 2:29=E2=80=AFPM Andrew Morton wrote: > > > > > > > > On Wed, 29 Nov 2023 14:18:15 -0800 Yosry Ahmed wrote: > > > > > > > > > On Wed, Nov 29, 2023 at 1:53=E2=80=AFPM Andrew Morton wrote: > > > > > > > > > > > > On Wed, 29 Nov 2023 13:43:13 -0800 Andrew Morton wrote: > > > > > > > > > > > > > On Wed, 29 Nov 2023 23:42:11 +0800 kernel test robot wrote: > > > > > > > > > > > > > > > >> mm/zswap.c:825:17: error: dereferencing pointer to incom= plete type 'struct mem_cgroup' > > > > > > > > css_get(&memcg->css); > > > > > > > > ^~ > > > > > > > > > > > > > > OK, thanks, patchset needs work for CONFIG_MEMCG=3Dn. I'll d= rop this version. > > > > > > > > > > > > Well that's annoying - the "mm: memcg: subtree stats flushing a= nd > > > > > > thresholds" series had lots of dependencies on this series. > > > > > > > > > > FWIW, the "mm: memcg: subtree stats flushing and thresholds" seri= es > > > > > has no actual dependency on the zswap series. The conflicts come = from > > > > > patch 2, which moves some code in mm/memcontrol.c, which happens = to be > > > > > touched by the zswap series. The first 2 patches of the stats ser= ies > > > > > are just refactoring with no functional changes, so if those two = can > > > > > remain in mm-unstable, independent of the remaining of the series= or > > > > > the zswap series, then either Nhat or I could easily rebased our > > > > > patches on top of them, and you can easily move the series in & o= ut of > > > > > mm-unstable without conflicts. > > > > > > > > > > Another thing is, the only difference between v3 & v4 of the "mm: > > > > > memcg: subtree stats flushing and thresholds" series is the rebas= e on > > > > > top of the zswap series. So if you want, you can take both series= out, > > > > > and add in v3 of the stats series instead of v4. If you need to r= emove > > > > > the stast series again in the future, you can leave the first two > > > > > patches to avoid conflicts with the zswap series. > > > > > > > > > > > > > Ok, thanks. I prefer not to make what is in mm.git too different f= rom > > > > what was sent. > > > > > > > > I've left everything in place: > > > > > > > > list_lru-allows-explicit-memcg-and-numa-node-selection.patch > > > > memcontrol-add-a-new-function-to-traverse-online-only-memcg-hierarc= hy.patch > > > > zswap-make-shrinking-memcg-aware.patch > > > > zswap-make-shrinking-memcg-aware-fix.patch > > > > mm-memcg-add-per-memcg-zswap-writeback-stat.patch > > > > selftests-cgroup-update-per-memcg-zswap-writeback-selftest.patch > > > > zswap-shrinks-zswap-pool-based-on-memory-pressure.patch > > > > # > > > > ... > > > > # > > > > mm-memcg-change-flush_next_time-to-flush_last_time.patch > > > > mm-memcg-move-vmstats-structs-definition-above-flushing-code.patch > > > > mm-memcg-make-stats-flushing-threshold-per-memcg.patch > > > > mm-workingset-move-the-stats-flush-into-workingset_test_recent.patc= h > > > > mm-memcg-restore-subtree-stats-flushing.patch > > > > > > > > in the hope that a new version of the first series ("workload-speci= fic > > > > and memory pressure-driven zswap writeback") can be dropped in plac= e of > > > > the old version. > > > > > > > > > > I see. So Nhat needs to *not* rebase his patches on top of the curren= t > > > mm-unstable, right? > > > > FWIW, I'll have to re-send a v8 to fix the kernel test robots/build > > issues that I've missed and incorporate the comments/suggestions from > > Michal and Johannes. IIUC, your series is ready right? Then we can > > have your v3 in mm-unstable first, then I can rebase my patch's v8 on > > top of that (fixing any merge conflicts along the way), then send out > > the whole thing again. > > > > Does this sound good? > > Andrew said he expects a new version to be dropped in place of the old > version, and my v4 is already in mm-unstable on top of your series. So > I guess you should send v8 against Linus's tree (or mm-unstable at the > same base as your v7), and Andrew will replace v7 with v8 in place. Ohhh I totally misunderstood this email chain then. Woopsies. Ok cool will = do.