linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Nhat Pham <nphamcs@gmail.com>
To: ffhgfv <xnxc22xnxc22@qq.com>
Cc: "vitaly.wool" <vitaly.wool@konsulko.com>,
	linmiaohe <linmiaohe@huawei.com>,
	 akpm <akpm@linux-foundation.org>, linux-mm <linux-mm@kvack.org>,
	 linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Linux6.14-rc5 BUG: spinlock bad magic in z3fold_zpool_free
Date: Wed, 26 Mar 2025 15:43:28 -0400	[thread overview]
Message-ID: <CAKEwX=NbpaQcq_awoPKmAuPWL=D4C2W7o_9D3J_SuDFvtbo9Ag@mail.gmail.com> (raw)
In-Reply-To: <CAKEwX=N98tC5Tq+XYLgAP4MDUBAO01ceE4e+mrk9i3YniL2Vkw@mail.gmail.com>

On Wed, Mar 26, 2025 at 10:32 AM Nhat Pham <nphamcs@gmail.com> wrote:
>
> On Wed, Mar 26, 2025 at 10:11 AM ffhgfv <xnxc22xnxc22@qq.com> wrote:
> >
> > Hello, I found a bug titled " BUG: spinlock bad magic in z3fold_zpool_free   " with modified syzkaller in the Linux6.14-rc5.
> > If you fix this issue, please add the following tag to the commit:  Reported-by: Jianzhou Zhao <xnxc22xnxc22@qq.com>,    xingwei lee <xrivendell7@gmail.com>, Zhizhuo Tang <strforexctzzchange@foxmail.com>
>
> Please stop using z3fold :) We already removed it upstream.

To clarify a little bit - we've found that z3fold is buggy (for a very
long time), and does not outperform zsmalloc in many of the workloads
we test on (both microbenchmark and real production workloads). We've
deprecated it since 6.12:

https://github.com/torvalds/linux/commit/7a2369b74abf76cd3e54c45b30f6addb497f831b

and will remove it altogether:

https://lore.kernel.org/all/20250129180633.3501650-1-yosry.ahmed@linux.dev/

Perhaps Vitaly can fix the issue for stability's sake (or in case
there is a reason why you MUST use z3fold)? But I strongly recommend
you experiment with zsmalloc :)


  reply	other threads:[~2025-03-26 19:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-26 14:09 ffhgfv
2025-03-26 14:32 ` Nhat Pham
2025-03-26 19:43   ` Nhat Pham [this message]
2025-03-26 20:42     ` Matthew Wilcox
2025-03-27 14:22       ` Nhat Pham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKEwX=NbpaQcq_awoPKmAuPWL=D4C2W7o_9D3J_SuDFvtbo9Ag@mail.gmail.com' \
    --to=nphamcs@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=vitaly.wool@konsulko.com \
    --cc=xnxc22xnxc22@qq.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox