From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51C5BC3DA4A for ; Tue, 6 Aug 2024 00:35:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D04F46B0083; Mon, 5 Aug 2024 20:35:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C8E606B0085; Mon, 5 Aug 2024 20:35:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B08306B0088; Mon, 5 Aug 2024 20:35:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 821DA6B0083 for ; Mon, 5 Aug 2024 20:35:02 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 16219A5AF2 for ; Tue, 6 Aug 2024 00:35:02 +0000 (UTC) X-FDA: 82419950844.17.38A2080 Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) by imf21.hostedemail.com (Postfix) with ESMTP id 58A251C000B for ; Tue, 6 Aug 2024 00:35:00 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XLCWVEXe; spf=pass (imf21.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.161.46 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722904438; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Os1pWRnghW77CcMhqb/vY3gTxewE7tQNvKDtva3Qkr4=; b=Rg/iH9aUzt6xBrfdUTXON9nrz08AfYKx5lobtFeRKG1MU5FBNHIOOLHwSP5O+jufs5jgfU 11mF9kT8ktAj8Uo1J1QZBObfCl38HG1f7wpLEDMDsxBXGAoRDDO12Mcf+X++kAv2dfgnor ydKwOtoJUab/GCZIMrPBzORLvflstT4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722904438; a=rsa-sha256; cv=none; b=sTbhscVo3agH9s0yY6n1jgmoPMJ5ygqm0S50X1UjGY50NfgUJsj7Ld+7w1c0msfXVRLyoT g89EemNpdjTBGo1b0XFRu4GwupMNSvo5lAG/2C9pZYl0Le/w9/HpqgNhCJ2X1cQBbfXTP4 P8c6WS6C9b1wpczd73LAuoLy8jLhAfA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XLCWVEXe; spf=pass (imf21.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.161.46 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-oo1-f46.google.com with SMTP id 006d021491bc7-5d5d077c60aso107672eaf.1 for ; Mon, 05 Aug 2024 17:35:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722904499; x=1723509299; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Os1pWRnghW77CcMhqb/vY3gTxewE7tQNvKDtva3Qkr4=; b=XLCWVEXeICCYY//aHYpr3Cq8b0B+ckuzlhMammLXJJFe4+CFiIsTU3Iev4TUNo8UfK gIFpnYd+JkqfiVXPIvAt5124EoND1sulSwCrB1wKp7VYk8c1BW6I2YyXCTYof7cudJWy 0n7kY5VrAbykoU6f3rYrCfRzttG9Z9aEN27ienZPWYkvttyiinfGNG6eyy1z8rwiVy+/ k2ZEx9Q09yPfYRwogPRycFzaGJGSzVJcAITxM3gng+jGKxdTl6ln/M5ED36NFEwO7Amq phud1XzQ/kos6eMHF5ek7mg4F8guiwih7TCtNyImvDIg4mPpQf49/+24qrB12TtyEvev EBiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722904499; x=1723509299; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Os1pWRnghW77CcMhqb/vY3gTxewE7tQNvKDtva3Qkr4=; b=W+RjYALzhG4Uw0PPTXoGBGJA4mbrcvd1Cf/MOk6x1VzbFTpjsW0o9kgGH3/X8b1Uk9 ebWAAPzuTuxzDcideAgFOlLgXbkbE1VFVLkZojzN7lyDSG8TMpiduRiMow18ylr42T8r 7B46gCBt92N57FKfM1xcLAt5mTJrPJQDHg+zDPOXRllPhr+g4cJ3ula9nJYPT+oKWZTb At8z7kAh46GIaaRkCzwDseUMRojj59m1G+ZJk/mE1fDSMhS2TkeCOsglN0fWJb4cXxxo EDRi1Pfkt2ILFGJfTPZsq7xZq9pDNN+V+jRhBfol0umDM57sRgW0iuobDUSnosYSdxKv yB7w== X-Forwarded-Encrypted: i=1; AJvYcCWcw9u+PqrjDX3YGcAKhDIwsJJxixI28WyUesCXXHrF9sfdqPn5UuZtidfspltvHSlRVeuUMd20hrNB5jKR7Gj7tXs= X-Gm-Message-State: AOJu0YyrdT5CmRPVLuVM9k8E2Il8Wbo0E2ECTU7qWXID4b54HFcZofZj eaR4fiNc2isEbDkmiUzVqmC5YUsAPf9ic0RbdVg9EfHkMuT3UggWfsp0scZZDqM2DIL2Phy2puZ q4KvgSSMH+nGGWPNy9Ll/xav5il4= X-Google-Smtp-Source: AGHT+IHnPtZRLSAqkjpB1vyWpMQHFpm1d1/WsdYfYWVLmvW/TVJp2gPcpSZM8wKb5QCjTJzO6EYXHcPxTN6BgbBEYjE= X-Received: by 2002:a05:6358:310a:b0:1ad:1c1e:9799 with SMTP id e5c5f4694b2df-1af3ba8983amr1548382355d.17.1722904499131; Mon, 05 Aug 2024 17:34:59 -0700 (PDT) MIME-Version: 1.0 References: <20240805232243.2896283-1-nphamcs@gmail.com> <20240805232243.2896283-2-nphamcs@gmail.com> In-Reply-To: From: Nhat Pham Date: Mon, 5 Aug 2024 17:34:46 -0700 Message-ID: Subject: Re: [PATCH v3 1/2] zswap: implement a second chance algorithm for dynamic zswap shrinker To: Yosry Ahmed Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, shakeel.butt@linux.dev, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, flintglass@gmail.com, chengming.zhou@linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 58A251C000B X-Stat-Signature: k433m31xjcpxxe9yz1rkfq3q1fs5ey7d X-HE-Tag: 1722904500-300850 X-HE-Meta: U2FsdGVkX1+NUllfQzQSKIfKD2/R7GZL+3UKol6aP7bes8UGdX5brS2kbcpebdSPugVPB+ncf0WvKwqkDCoB0f717VWBaDPJL8AfZc4ta2boCIcp0TiIjrj0p176XsOJxIC0uONfYKgejtaTUR9rQeLhbyow3AOLx7CWfMNUzj0xMifnaumjRDiii/Jpc9bndPcxCWi6WsYY+ADKSf/6soozWIM+g+61WR2KLm77fbNZYNBzVBDcZU5gLgfFCvL6tNls8B1g5CKjv3lz2xB009q6bt1PniIDqh+HkNJdHqnbls3ukgL/dfS9c5Xf03PF8/cazJ1QyWAfe6NZ0BpsIC659hWhaJBq+V/ToSiFJnFgyJshLHZYYsqjg/7MIxJkxvLfmywvGQoZfGOFb0ezEiNFqmxoxLS/zM/6XKQ1ihKigiR3Jf0AP9MPhmLzfx205rK19+Dv0D6uGAtUjg+BwEH/HPnJUZUDZ4J3lqgHa989BPOC7ihCcKFtee/tu3RDW5ccAOqq0WoVjlR+Xngmo86f4TaVBqBynLC8iD/ln4/G4TO3RXWPJxMQT4bTrXOsjB99XVBiYI6us4J36Z646OpDZ4ccF+jmUZCfNFn9PFXSOXxdJPhMluT5U/qBRgxjoZ+uwVukLKdmgBBZ826zmlncuhbI+NUPVepiBaVCzOVyGAX+Ft5XHzI7yd7wU3+X9Pk9lN9G/fT1uGLqf5RW4jkyU7tS5DICJlqAXPsaZ90XvGBSH2xMw1dn1gC4Gd52Jkoqxe0u2iWK4j1m1S/zmyciuoZSB7yER5CVkeHhsA3YHCOsQNVsQ8zV23obpam8anLbkEqXqk3R4eEQKdatk/e+7Ak6QRTMxRfX0Lk16U0Rwxl0zIu6qK4FOCAeLtLzewG+jtrdjeTO8OhJhtrZIBbzhXapioEB3XPPxGAaIQ0kvlLcEET5NyQJ5oED8SyFpHEEAX7ILZXaZ1CWwEF Q7cRRtBO GqeQFCFPk1OkjJ184FloBY5kY9e41WG0/v0wmjM3w050IpQo2CKUfTUjTHriKtd9k3NjnAHQwN+f8sondek0CnakFPfjIEeE241TW8Fwc/i34PYpgmZkITziAXGDINEm+35uQZPgn//qUXkvLwUS7TduKC9hDRT6K+4S8gz2uRQ48rOxn5a95e8/Xic7tf3Zx9Ua4Zk974y9yHq3YJcsfgqD2xKSLA1zfIdEVOJhP3PHmOqRKFTE+HabAZEX9cbGx0gPHkPDCAVQJ59QLN2FMyP3gwWfjlqh5NCE4DBIizR3fPI0LqxXODgh4NbLtyMQEnro23+4rXmvV/dr3VKG5oqUTaQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.038508, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 5, 2024 at 5:13=E2=80=AFPM Yosry Ahmed = wrote: > > Nit: It is unset and reclaimed by the writeback logic in general, > which isn't necessarily triggered from the dynamic shrinker, right? Yeah you're right. Just sent a fixlet correcting this :)