From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC9CFC4167B for ; Thu, 30 Nov 2023 01:53:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F2868D0029; Wed, 29 Nov 2023 20:53:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A3FD8D0001; Wed, 29 Nov 2023 20:53:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46A348D0029; Wed, 29 Nov 2023 20:53:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 370278D0001 for ; Wed, 29 Nov 2023 20:53:30 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EF1B71A06A6 for ; Thu, 30 Nov 2023 01:53:29 +0000 (UTC) X-FDA: 81512948538.22.900F874 Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) by imf01.hostedemail.com (Postfix) with ESMTP id 34D0A40015 for ; Thu, 30 Nov 2023 01:53:27 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LuyuB+qb; spf=pass (imf01.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.161.44 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701309207; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I8qVK9GAx0H0665gMp4/XaEH2mFpe/0oyKDd4JFknoA=; b=AYYpl4NQV9YyLCXyopJpzB9sJ2wA0vlLfhcd/vXm/DzBLnn0ZHQlh8E6Ikusq6BsqkObdW 8miE2h8Kj8zNESwXEr69mr3KUbmeblFkvvp4rO01FgmVLpQC78P0EeeRZ8gbcw/Oq0qJIx YSH8eBJEir0Q1g9KdVD2fuz0YNIKulM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LuyuB+qb; spf=pass (imf01.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.161.44 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701309207; a=rsa-sha256; cv=none; b=AY2hCz18V67kiEHBwqE82jfzu7Mdi1a4iOWUoXRoJglLYOm0iWu0D8VSNAXRhnyEW+i801 qXmlgZKE0hcjOeSN8n6jduxFlfIyrvdYOz/UpVPTfD3p3HfFcsyFyYgLSjYukXQSuBALlJ oKY4EBYuxJxAO1+5vGUtqulwImjt7Nw= Received: by mail-oo1-f44.google.com with SMTP id 006d021491bc7-58dd6d9ae96so242938eaf.1 for ; Wed, 29 Nov 2023 17:53:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701309206; x=1701914006; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=I8qVK9GAx0H0665gMp4/XaEH2mFpe/0oyKDd4JFknoA=; b=LuyuB+qbj4ISbflV2zshtpLUostK9PI4R0U+dyc9yFVYov0VkpL4+Te/etU6HMuJ8w LeuWsMMIp2dLXcigDS0tEuZNDXkpf08LGJqOV8HwKgwW3NK29mp4UGj15kMo8yRSnGl3 yDs4zQLSx63w0DXwjXeoYUvs8O/W4349zVS2mnEP+G0VG4WWDI+xaIJL6WbJWiZG4uIJ 1q1vtX30bqC+WjL8ZE74xTp594MfEn1ebNK+iGUHGCkTsgbc0Hny5N2TjIdIzigVSDVz YW/WuwOXhovVtZvj+B5KQWlStTvUM8ZAbhpVGe5vSQMrqWUABqjOlk37RfLgPDVVDZw2 6o9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701309206; x=1701914006; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I8qVK9GAx0H0665gMp4/XaEH2mFpe/0oyKDd4JFknoA=; b=E/FeQBJjptHmhZyNryG3ieaUE14bK9gEEIZYlF32jSR7+dcHjRhCBhKFEBg3U0NgyV 3sbGyB1ZckGsWoMZhqzSjJjO1irX/PY8tGV0MveWa0sVKrpZSxbONzd7g7TpcTYlCEBT B6F2E3pyrKF8tVedFbgW+d7pyDln4mgeHFs92F5vCIXpNUVdzlhITLeu3v6XhRzCHBg0 kQ/Szec/Vt0U9obwfzMkoi6fobOj/pWh45p/qFCNuqv+1yaNNlfy5IsACPmB+GjshX3W ms94bl3trI7se7Ata7LSRo5tXjU5gGy9iDyx4t9STwP44zpCQ/ZURVhmou/mf4un0asG Mulg== X-Gm-Message-State: AOJu0Yx0Qjdc3dCp9pdzD0dADRPkME/59Hn2VmMn82fXhgICTFLIfKRj loOCjeBIYcvOP7WL7U4IdPSDv+lLRwhC+SZ9qNQ= X-Google-Smtp-Source: AGHT+IEOKxVDBmFp8Gax7e+6/3Xpm9wFFIta8ZNQ1zGpU0q8pPtB1GfxxJmjAzk02CUnHcILxV1rRm8Zt7Jk3nJ96cA= X-Received: by 2002:a05:6870:9a98:b0:1fa:2d7e:f67a with SMTP id hp24-20020a0568709a9800b001fa2d7ef67amr19389875oab.31.1701309206203; Wed, 29 Nov 2023 17:53:26 -0800 (PST) MIME-Version: 1.0 References: <202311292305.43bnw55s-lkp@intel.com> <20231129133431.73512e280e870efaa17f9f4d@linux-foundation.org> In-Reply-To: <20231129133431.73512e280e870efaa17f9f4d@linux-foundation.org> From: Nhat Pham Date: Wed, 29 Nov 2023 17:53:15 -0800 Message-ID: Subject: Re: [akpm-mm:mm-unstable 179/192] mm/zswap.c:298:24: error: call to undeclared function 'obj_cgroup_memcg'; ISO C99 and later do not support implicit function declarations To: Andrew Morton Cc: kernel test robot , Domenico Cerasuolo , oe-kbuild-all@lists.linux.dev, Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 34D0A40015 X-Rspam-User: X-Stat-Signature: 3cda8xw6jy8hknr384eanaxdbab5gb45 X-Rspamd-Server: rspam01 X-HE-Tag: 1701309207-875791 X-HE-Meta: U2FsdGVkX18Uca04V0d8nZRl2iP6h660BOsyNK+NE1fYjBGWirn4WM1siNZpaz4uPJjGhbYL1U4gat3xrFIAgUiWd+VR5xMV6ag+bU9cir/OrP/S82Zo9sdTVAcj4VCPMf0q2MjJeDVJH8Urz/jj61/sRb6+dsh7VtLT7UR1bJIyvpdYheDKdCZfa49kaquZBBffYn0A+g/lD49ad9XSSuTdsRcxiyZLHZUBp/lhy64Au0FPb3Hj2bcggb0bdc859PUGoYJlfzh0DP16Skk4aAFK0cB3Y4n/lTV95FzSUwjNrZMZegH4WO3Xu1J6/eiqiITT2NQ8XtsesmNE7c/UhXlLdi40OuzdBKiWLar4FTVdYP3LgBeFyyB/256QFysHwzwrLVi1YjNLsF+eVoCAZ6TdX+QdcvfiR3vgjSO7LPrD1zvyF7AU9I4ZKzYHPJdt8CsltZOXZstSUU9FZdcoODBFLfNmYhQGTUjBihy5iMtI0FeC/S4yh+CbsNLtqkqi3ucQg041GdL/ixhZqSeMEgw0yP4FGjPtxx170RzpnssJ6swT8efrmTAjXaCGF0lrFOFpsl2L12inmHG29OshUxzDcLbi+uNYoJEdyF9V6x+9gUUJ6c3IXMz9EumSFhAYvOPmNtBEQ/iIj/4FXJyNOo4RbFbNL97Y/i4sJ31y5W8nddP47Q2XX93TlFBVd9FN3kFrMdIIT0YT92XJSQSYQpj2B4L1F4VXBZ4AaTqqn8VjDIvZIMH18hnNAX4ZLCTYOexy1rX6PEFi7bVmKSb/Mlt8UnxmlZQz44sFOnxhiPCK2R+qCOw/dyF5cBybDTraNkMyTNzqHBUkA9jxmAqqiZnwUHeau7cPVM8v6yKHSXXe2unaBjjUXY6ZgyEK5OKQt+JdJBsaR92QiqmdgwW8V9gnTgX7ZWJGwfXKYzxZ29QGXket45wd2miUJ3x/IZiIJVrXSRme1iLvBcbYGX9 oUA78+AD gBgJaupACCe4USX8XTm/mAqa14RSUf3POEoD7SzJkZw0H1w4YbriYsPtNaek7wB1tAp9VG0xaIHK0ZGdkdGhQArm6moHQPhEozplHftolYWJ4cTzMOEQ9WKZj4UzSoz+MjWyDu0R/hGKheLkDcpDu4lOSW7SKbLdquKYzESAatVExuUhg4KozxCztVY5BzZY9Z7SSYek0PiL1E51OK9q1jj7BqeMg3mFxIbIVA/MIQPoWGGEtXAzFGCdW4PgHwgHQ+olyAYHJyP2QEeoE5ZJSrbmScT1paCpOpWPsWZEP5pulR/wV+mbfORUCUJS9Qb5gimgA/dpPFmvfslujtS0McBWkFBySIsmi84sK3XIU0R3DHmijQ0AShk1Ed4oZdEh6g3ge8IZFi/2QuYTcMqCutWCC4YORr0aTph+mehMjLj0h0QbSuP2NGVitDPUHHoVerC7C5m7SK6fAd82sSQxsVGcUPdIOIzZVDuXtyGCH+i4WRATvUvPH8MQcpNvPZCIk7oVq9lnpqV4RfZjTJJU29j5fTWVhk09LdjyAXsfbhZptvaS6dEtgFO6K459UZwwepwomL/B+32IDDXpalddQx/sceVr35ANXq8jExCOPQwtuOdUa2F3m60zqkfCNeD0Qt7yeOfG4mJ+Dyi07qtEIHZNCVg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.040038, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 29, 2023 at 1:34=E2=80=AFPM Andrew Morton wrote: > > On Wed, 29 Nov 2023 23:42:15 +0800 kernel test robot wrot= e: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-= unstable > > head: cb1d236cb1038fa1bbae9913803f1c655b86d931 > > commit: 70dd375afcfe1839321ea8a65749404a99f0e773 [179/192] zswap: make = shrinking memcg-aware > > config: s390-randconfig-r071-20231129 (https://download.01.org/0day-ci/= archive/20231129/202311292305.43bnw55s-lkp@intel.com/config) > > compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.gi= t ae42196bc493ffe877a7e3dff8be32035dea4d07) > > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/arc= hive/20231129/202311292305.43bnw55s-lkp@intel.com/reproduce) > > > > ... > > > > >> mm/zswap.c:298:24: error: call to undeclared function 'obj_cgroup_me= mcg'; ISO C99 and later do not support implicit function declarations [-Wim= plicit-function-declaration] > > return entry->objcg ? obj_cgroup_memcg(entry->objcg) : NULL; > > ^ > > mm/zswap.c:298:24: note: did you mean 'obj_cgroup_put'? > > include/linux/memcontrol.h:1352:20: note: 'obj_cgroup_put' declared = here > > Well I'm going to assume it's this: > > --- a/mm/zswap.c~zswap-make-shrinking-memcg-aware-fix > +++ a/mm/zswap.c > @@ -29,6 +29,7 @@ > #include > #include > #include > +#include > #include > #include > #include > _ > > Can't test because my gcc plugins have gone stupid yet again. > > cc1: error: cannot load plugin ./scripts/gcc-plugins/stackleak_plugin.so:= ./scripts/gcc-plugins/stackleak_plugin.so: undefined symbol: _ZNK6frange6a= cceptERK14vrange_visitor > cc1: error: cannot load plugin ./scripts/gcc-plugins/randomize_layout_plu= gin.so: ./scripts/gcc-plugins/randomize_layout_plugin.so: undefined symbol:= _ZNK6frange6acceptERK14vrange_visitor > > help. Hmm I tried including memcontrol.h, and it still screams at me the same way with !CONFIG_MEMCG. I think obj_cgroup_memcg() is just not defined in this case. Let's just return NULL here when !CONFIG_MEMCG.