From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C562CEB2CB for ; Mon, 30 Sep 2024 23:00:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A60756B02EF; Mon, 30 Sep 2024 19:00:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A104D6B02F0; Mon, 30 Sep 2024 19:00:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B1746B02F1; Mon, 30 Sep 2024 19:00:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6C2386B02EF for ; Mon, 30 Sep 2024 19:00:06 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0A23980C18 for ; Mon, 30 Sep 2024 23:00:06 +0000 (UTC) X-FDA: 82622924412.21.6938084 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) by imf12.hostedemail.com (Postfix) with ESMTP id 2DE5940008 for ; Mon, 30 Sep 2024 23:00:03 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jwJiXC9U; spf=pass (imf12.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.222.172 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727737139; a=rsa-sha256; cv=none; b=vRbD1W8egrZBMsW5jVKQgG85qZQhZv9XUU8u9Z3ZlUhnWlyLZdp2AWmFfAjFridvbnJlmQ B3QWVeIrqrvYnr+r2XirHQ2sYscDTmURWlbabFDRlKVvaHR3eNiR/ZpcMc0g4wrs5F/Q2t s9uEc3mLo0TetIlpOkBYRjnh8e3QNUw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jwJiXC9U; spf=pass (imf12.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.222.172 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727737139; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dWCw161eoqkVuV7viOnfQRwVUca6IZkChfEd1pCOSUw=; b=xkmk28YdBrT8f79pWvqVGIVo3xjH8Ca5c6O2c1XJRogxbTKA4lzlHUSYJNQO4zufTJuuQl D5X8aGZfSUUiYaKrJnRybALKkC5OO+yrPsuAH9yiuJcv2M2TepKPeIxkVvQqvJ2uE60Dtx idDO0jPeBFnxyIWO92WszCfLJ0kBNUE= Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-7a9b3cd75e5so476217585a.0 for ; Mon, 30 Sep 2024 16:00:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727737203; x=1728342003; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dWCw161eoqkVuV7viOnfQRwVUca6IZkChfEd1pCOSUw=; b=jwJiXC9UmWoqEJZujKh8kdvNxhpl50AkJLzmtR3ulKE+bzQLykzFszlwfeU43bmEmt oPXVehQ/pzYmyFRLvMqNZik1HUhgAaa/sb8lKMOI6A4oHYsaWzDAfBnug9obwmDO+uWL vWlQ14Hv9v72F3i8PWsPCyY8MfA8is/xfkjMKjpzWSunoEgozKRrJtoG2+XD8jedZ/ie T5PiIrClslv4HpIEkJhdnK4nQA0xp8E7xI8K++0NjlZRFCuDKxEQI2OobJtJNCmylOZF EpN51ZU/FccGXM7CQeewBhuO0xdtnUEikU4iAnftQqj3NoUHV6QT58SS4p8GBlwO/dww n0cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727737203; x=1728342003; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dWCw161eoqkVuV7viOnfQRwVUca6IZkChfEd1pCOSUw=; b=DedopZr2GYmqeXscW6TtR/loNoo5eF5gKTmAbEKSpyumYcL8EajisWenilItHWYgIy GKKSeyQjewmgCrOUC5zpJqK5sbDW//Vogty+4dTXO8Gk1xgnqmfn0Y6/L9yKb6aDx+Pz L9zgUrg116jOT6PungpUqx8VZxoroteyoYZfto96AkZnnGdoy2fB1bUJxDgdhJ3t5WCY TfhI+3X6q9QbnzOkVlEB1f3om8FEIHLfK5ibpFPcb/nMm83YdnXWdk1WG5lX+5IsCS5p oTLEL0wU+/YSfy5fm00Af8BNjKlSjazU/+EPx0+mURfwWPI52MEPklgs8r/plWQImLta E9jg== X-Forwarded-Encrypted: i=1; AJvYcCWpzfhxKEftFmjjCaP6NWh1VI3zIFxrj33PbxfUeGOXF8G3sLAdmcCa1JKNUmj3m44XVMFojXgV8g==@kvack.org X-Gm-Message-State: AOJu0Yy0MHlUH+74gRx/572bIuUEmzeEXBY8e11uq0J+DAfmIkcrk4rQ pCkiBljW7+1dXd9EbU1Feeabur2qhRKMx3iM2pKG+oZQvDJl/YZhqM/vbjQzMQAu/K2FrkFgCwF VEJ7X5/9PJNfPR8nbIpR1T5udMvI= X-Google-Smtp-Source: AGHT+IFZ9twSP35b/wVX61vJ7nPQkTmPmsJWc6ptIYcbPtWl0SJecJMaYU5WnYGVEbOPOcoSRij5rrrpKgXHlufrqZk= X-Received: by 2002:a05:6214:3b8a:b0:6cb:4e9f:13b1 with SMTP id 6a1803df08f44-6cb4e9f153emr147643306d6.19.1727737203001; Mon, 30 Sep 2024 16:00:03 -0700 (PDT) MIME-Version: 1.0 References: <20240930221221.6981-1-kanchana.p.sridhar@intel.com> <20240930221221.6981-5-kanchana.p.sridhar@intel.com> In-Reply-To: <20240930221221.6981-5-kanchana.p.sridhar@intel.com> From: Nhat Pham Date: Mon, 30 Sep 2024 15:59:51 -0700 Message-ID: Subject: Re: [PATCH v9 4/7] mm: Change count_objcg_event() to count_objcg_events() for batch event updates. To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosryahmed@google.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, shakeel.butt@linux.dev, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, willy@infradead.org, nanhai.zou@intel.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: nrbeaeekk547zsn6iu8zyztg6t776q8e X-Rspamd-Queue-Id: 2DE5940008 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1727737203-27501 X-HE-Meta: U2FsdGVkX18bJcmWaIZZFlUdGLPV0fg4TuR/F+OtfrQYwibcpVNN9ogpdlPqbtsohUZmKiX4dBp+ehP2pZL6d/FE5UTyMLuU1J6OyAtzub9Rl3n8abJIaPgM8lSYEGkq9YqQfaHs7FfDeI68H8UprxdKRghh3kyM/yybKzpnV5h6H/PQ1n/AreTQO+g+nfF0DWgmnm+/Fffz0fQgszXbEZjUFX5yMpYqGFlM0Hy6coJeWXJOwvCiRetIXyLBSjseC5YJ0MkpeZQTb3dnsD1n/81V+nVOL4869LNQOCp92p92r/mkX2ffwOs2jgfpnP1Hi2WtfUKd0nGU8G1us1VZGVTIg/bn6k+j67lBROChGu7UjU5e+fX9dXYAYrFHzcoJm9rchklPM/2fPmTX3x43ybWDOEmAheW+LRMMuVXjdZRQnhf/0LHaNubHhw84P+gdD5L1WtSRWncenXLmEPUaMqOiMzw+/JUjvk68wUHHsjMDwwTiH3cTn0MLhU/jYd/rkvrL6H3g5GxN9SfgvHEpzTly6e426ChrxNg1QMlBIFw4Yn3OWQmLXO8v06dDwl7CQQpF1uCfQe5wDgpSdf8LNkYgL4hNqptdYWtkoWbVfD5evwf2xKvtzbfPqYt/0/AasQqngdOTYjAF+bhP3BgOFHf6CiN03VYX63SgfHtz2kejJCwS8Q2SDazuWJ3jbb9FRPnpwIgWDIPwwe2VFjoNTrBqZR29lxFqvyKunmwj3Oopao66GDYaOGcT/7dCKUCLAss+T0DsYzu3l4+ZavY7W3EE2ldGWA278fi3qBpaRnp/mh7l1VIDiQB7CoTWvIjGskqKK1jgazd7+F4WCbGeU3UBc73ikfQJXQZlAPHHV/y4kZ7O/xyPMjHCGvgK54mRUVrLT7juautV/9HjFWnDzQD6ku1gM7ZXCBvljqhz+xc9g6qdMIZ12PjiNvd68sifSpnBI9AntF1p23kUQAG PNzQkpd+ Nxvs7sh0mhcc01JX5+lPp1jtmfuL1UrAuZk6/Ce0886H+E3nvfbfVDgmxhypml7KnyVN/zxf8xW92WMb7TgRF7IDQmZBZZ3PmouhTqIYrmJF5alu0IwP5rgVNGIEH7TWj19VEsL60ZyjGoUFfjMUytbmOGU3i5xQp1XkBXHmcT9gXxMIPBGHQ8qu34I8STytTnCM4nEOWghvJ/COloHmORbIo6peMR1wMbyWCJ1sD2AQ9m6ldh8AtunGcu03WQa2kF+Hz/UE+89ZdupJj79dcXCEXXRymdQysAep597xdxuJMv0QrXN3a5eHOYp4uJiVTCzIllQbewFYx0Njm71kIQC0VLhWyPQfWljZ1dfPHs90KBpsEQcqnVPIvl7bAP1YGUr5Nxmr6ibl+2tiaC7EpJrbqtGz1NNJ1U+iq X-Bogosity: Ham, tests=bogofilter, spamicity=0.060108, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 30, 2024 at 3:12=E2=80=AFPM Kanchana P Sridhar wrote: > > With the introduction of zswap_store() swapping out large folios, > we need to efficiently update the objcg's memcg events once per > successfully stored folio. For instance, the 'ZSWPOUT' event needs > to be incremented by folio_nr_pages(). > > To facilitate this, the existing count_objcg_event() API is modified > to be count_objcg_events() that additionally accepts a count parameter. > The only existing calls to count_objcg_event() are in zswap.c - these > have been modified to call count_objcg_events() with a count of 1. > > Signed-off-by: Kanchana P Sridhar LGTM! Reviewed-by: Nhat Pham