From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B3DCC4706C for ; Fri, 12 Jan 2024 20:13:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 15F178D0001; Fri, 12 Jan 2024 15:13:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 10F486B00A0; Fri, 12 Jan 2024 15:13:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3F8B8D0001; Fri, 12 Jan 2024 15:13:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E4B8E6B009D for ; Fri, 12 Jan 2024 15:13:42 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B9BB4A0370 for ; Fri, 12 Jan 2024 20:13:42 +0000 (UTC) X-FDA: 81671759484.10.192BD3A Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by imf16.hostedemail.com (Postfix) with ESMTP id 0740118001D for ; Fri, 12 Jan 2024 20:13:40 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=L8gXuSAU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.52 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705090421; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8DVdUR7buxaSZgsNyBuJ3Vi9ZupYqJqGpn1NqWbOy7E=; b=GNonp+VutaKvXb2gm0/b6Q+H4gpXBlvgOrhbbfa/exI4zfmvgvYOjL90Ms6gP+rNBM8rVG e5ddrlch4e/THhjE3OhbMw/ruRRQ0IZAEGMnpnOPuKmtkFCgaf38i5gWHUTiTbj8cnUMFF KiMUfJTq/qtsw7dWKWN56g3+VL51ojQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=L8gXuSAU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.52 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705090421; a=rsa-sha256; cv=none; b=VaW7UG8PleFX54rRNTxQHzhqyP59XKFGQRFo+2K12z7Un11h6SleTSFWB75IkNK+8jaAjG qL4Qo5yXXAGAKTlCakptyWmTV02mJu0rnLxcKiDJzVy8U5rVAeAAiItx4snK76T5IlOw0R b1lgYdlbPgdo61IHiWXyIlrm5Gteo+o= Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-7bf2ecba260so4423939f.2 for ; Fri, 12 Jan 2024 12:13:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705090420; x=1705695220; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8DVdUR7buxaSZgsNyBuJ3Vi9ZupYqJqGpn1NqWbOy7E=; b=L8gXuSAU4cGPqK/vkZ1pQaoYXb78DLp+TlWBeEiwpoDw6FlXdjnMGU4o1V/uLZ1Ocf 1L3Gtf7EQkwRTX2l/ZcIPTdfQBzY76o+Jn1KwVyt51r10+lcoQQ0/+Sa3vEMUKNiC/P+ rOccx69u0mEvkiQVnw3b05Hl7F4rGHlXYPmC1c31c6wlVUVDKFYXwlarktX4DXqII4Kj vsAQsTj4+PhPMPcLuaB9A1TfHQKuBDYr6zKFSMpstVxEiuoxmH2JVvoi21PAZbMoI5AB KwwKq+LHMf9Ged4hwL5i0eiUpHQGxRxqTqhHmPD9MIUxfb34ud5xha1CHSQpzRGlrcQq SjKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705090420; x=1705695220; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8DVdUR7buxaSZgsNyBuJ3Vi9ZupYqJqGpn1NqWbOy7E=; b=FbFxtfWxYwaEddkqh94yxo/udW5IYz2u5c3TZKd/pkdA2gkFewxzTTeTDFLn81aNJJ K9TaqHvtKBLdtcC/FsgNyTh0EQCIwg7Is/vbiqnoQmEdmfl4IZcl9pBpuE2d7gVTV18N 66nMRGABD7RGO2BHSLMpNLy8XCu0GmJAaUi+7e/i9Dfr28s4VcGHvXNXoe2GkLhQ6+HB aNpKp45Ff+fhhPCV7IxaLw3QXOU6POU8ici/GVt8Whn3NYzxpSDwZLEZrKeuU8f2o5Js yCFVTTse/njbSkaAvJX79mbB3xlLwZS0pwUgyrsNW4uGBeJdK7eewj9phXWLJ+52F4hm pfhg== X-Gm-Message-State: AOJu0Yynh1S8HBRMmWsT8UGY/3N/+ic0KJ2yfBDdoHSHbQN4zxQ3QfY0 RJKv8eoQDRyQef2PGgo+YolstU7xU2BcnPJ2OOE= X-Google-Smtp-Source: AGHT+IGtNExBQDITOeAzpzI8w4wiEssGRxsB//UqmPRz3KcbPpLnhwKnSz7qACcQ4d6yB+nGNV/rrbvuMXfFRhBcNsI= X-Received: by 2002:a5e:8815:0:b0:7bf:27ff:dadb with SMTP id l21-20020a5e8815000000b007bf27ffdadbmr1338144ioj.2.1705090420103; Fri, 12 Jan 2024 12:13:40 -0800 (PST) MIME-Version: 1.0 References: <20240112193103.3798287-1-yosryahmed@google.com> In-Reply-To: <20240112193103.3798287-1-yosryahmed@google.com> From: Nhat Pham Date: Fri, 12 Jan 2024 12:13:29 -0800 Message-ID: Subject: Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED To: Yosry Ahmed Cc: Andrew Morton , Vitaly Wool , Miaohe Lin , Johannes Weiner , Huacai Chen , WANG Xuerui , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , linux-mm@kvack.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 0740118001D X-Stat-Signature: ummfwsdyk7o7c1ghrxp173jwddkyzsr3 X-Rspam-User: X-HE-Tag: 1705090420-125724 X-HE-Meta: U2FsdGVkX19YGUZ/iUcuvWnLcvLQFdgcdyeTtiR1TSTbw1nteSccOXMoiDhIELWsl8h+SmfuSE6bHc/Gry+SoMY1U606fMc8LsXJ4apQwGSSeMjGMBTQtSopXINRv4+aAW4nab15PuzyudR9hchkDpE15X3uPwcv2gtzZHM8CUuOHHFFOwvHZQhOgffHmYdfcr0ctJ6OejUo2HN/AZQ98rYi7fZOiN86CkC+Y7l2ksTV3n42+p5SwJk07UAv6BjSh+Ik/0u4aPf1dtp+MkxqNY7/H0zh29xzqo2phtvq7ChW3myLfZJFuwKmC3GdLGHj+aw5+EZ7VZY6Gu2HoCp2IVJzPr3BN3uutKiNoGoxpl+j387QqwndxwHP5ijGh5wn8yDn3pefc2jp06CROw26uLKcWiI4YIJL7DszWfMn1QCCLuGH9Md0JZAD6y+rm6gNX83K6VoWiQ33UORTMHq7OYTah0un/MvASt7lMkrI1Nc6kb0D1ZsamyowdMaNmuH+SQ3KzEQV0OOZCsp0ewaAc8mol2VqcECC0q32IMaIMYicEsbhR3BLFNHGxrgW251UgkvGXInD9vLU1lpj+Kx12Qt9uKNOYHpOWpw4quUhrDMGZqIQj6Pv/XjdezXKpIXpGqe4tCil8tt3PDagZt/RnMMlxkSn8fEMnq3avhZcvIqRWhpg+f9u4X3POCQTXCYJgQ4WArt4+IzB+/wRoahw+PTidisQrsqi66c4be2mEp4EzcoO/yzq3IqHJZMHGC/0hl9WZWEUpwlKrzFXXa25M6cVoU3PBdFqVisbBzT8FdRTfaNKZYjIuHfQpORj4+iQkYw08bMzlaiR3g8uRi37h/G64TKyr2nFiPpR9TEGnhAkOjS1wH2tqEMalZvrExeQnZSObN4V9GgxMrgeyWhALJfSTe0BNFNoKu6Wp/vxVQNjbZf4ZATmgls0iTDGCrUf1Iu6pxevIJrQ0ixs11h hFw1yIMZ rn50oK5xlEnZuzMGEz94TiK1IR3qBUmmsZfWqLPGmr601dDLXRtmB+Yvb4M5JZNDTZnJHQ2MsI9jxZ38soVZts77L0zOIf/zXALD1t+KNy+6zwh4IWq0GtShPB7RXdj3XrbVMnwRObuFloW62dNLhaJGIGNz8Pbq1kOzmwivvI+QtUV6cjXWClKy2ZPZOEOPMUh3rbup6G8wQOoR44n0BFkEOchMElU5FLLxAt7OXzx82yDKA6Ey8xWyUSC3HdczJYkJxwYvPh91MFM+c+bh3McTosXjFuJsoulkaXe4ui7UuIUzoQf84Wp+12y2oils0Txz430su5ZZ7HvGhGbH+dZSAsqJ9E5R8pCd/bmt60JjHfsCvl3ZZzHukbwpO7fnLpJJL9s4ENMLJHncdDRdRo3AtC6dQCYGGKPFYs/XkU+OKl04/p+Vg/HhXpgwV3+Xmh4D6/2GVLdulwbhCyQe4Upv2qCVkx6TEPxEy1DIjLVkPFmySnQsmQpmNjwCAJMmjBeS1e4gaLrn/XY70atf4NXmFVw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 12, 2024 at 11:31=E2=80=AFAM Yosry Ahmed wrote: > > The z3fold compressed pages allocator is not widely used, most users use > zsmalloc. The only disadvantage of zsmalloc in comparison is the > dependency on MMU, and zbud is a more common option for !MMU as it was > the default zswap allocator for a long time. > > In hopes of having a single compressed pages allocator at some point, > and following in the footsteps of SLAB, deprecate z3fold. Rename the > user-visible option so that users with CONFIG_Z3FOLD=3Dy get a new prompt > with explanation during make oldconfig. Remove CONFIG_Z3FOLD=3Dy from > defconfigs. > > Existing users, if any, should voice their objections. Otherwise, we can > remove z3fold in a few releases. > > Signed-off-by: Yosry Ahmed > --- > I have limited understanding of Kconfigs. I modelled this after commit > eb07c4f39c3e ("mm/slab: rename CONFIG_SLAB to CONFIG_SLAB_DEPRECATED"), > but one difference is that CONFIG_Z3FOLD is a tristate. I made > CONFIG_Z3FOLD_DEPRECATED a boolean config, and CONFIG_Z3FOLD default y > so that it is on by default if CONFIG_Z3FOLD_DEPRECATED is selected. I > am not sure if that's the correct way to do this. > > --- > arch/loongarch/configs/loongson3_defconfig | 1 - > arch/powerpc/configs/ppc64_defconfig | 1 - > mm/Kconfig | 13 +++++++++++-- > 3 files changed, 11 insertions(+), 4 deletions(-) > > diff --git a/arch/loongarch/configs/loongson3_defconfig b/arch/loongarch/= configs/loongson3_defconfig > index 33795e4a5bd63..89b66b6c6a1d5 100644 > --- a/arch/loongarch/configs/loongson3_defconfig > +++ b/arch/loongarch/configs/loongson3_defconfig > @@ -85,7 +85,6 @@ CONFIG_ZPOOL=3Dy > CONFIG_ZSWAP=3Dy > CONFIG_ZSWAP_COMPRESSOR_DEFAULT_ZSTD=3Dy > CONFIG_ZBUD=3Dy > -CONFIG_Z3FOLD=3Dy > CONFIG_ZSMALLOC=3Dm > # CONFIG_COMPAT_BRK is not set > CONFIG_MEMORY_HOTPLUG=3Dy > diff --git a/arch/powerpc/configs/ppc64_defconfig b/arch/powerpc/configs/= ppc64_defconfig > index 544a65fda77bc..d39284489aa26 100644 > --- a/arch/powerpc/configs/ppc64_defconfig > +++ b/arch/powerpc/configs/ppc64_defconfig > @@ -81,7 +81,6 @@ CONFIG_MODULE_SIG_SHA512=3Dy > CONFIG_PARTITION_ADVANCED=3Dy > CONFIG_BINFMT_MISC=3Dm > CONFIG_ZSWAP=3Dy > -CONFIG_Z3FOLD=3Dy > CONFIG_ZSMALLOC=3Dy > # CONFIG_SLAB_MERGE_DEFAULT is not set > CONFIG_SLAB_FREELIST_RANDOM=3Dy > diff --git a/mm/Kconfig b/mm/Kconfig > index 1902cfe4cc4f5..bc6cc97c08349 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -193,15 +193,24 @@ config ZBUD > deterministic reclaim properties that make it preferable to a h= igher > density approach when reclaim will be used. > > -config Z3FOLD > - tristate "3:1 compression allocator (z3fold)" > +config Z3FOLD_DEPRECATED > + bool "3:1 compression allocator (z3fold) (DEPRECATED)" > depends on ZSWAP > help > + Deprecated and scheduled for removal in a few cycles. If you ha= ve > + a good reason for using Z3FOLD rather than ZSMALLOC or ZBUD, pl= ease > + contact linux-mm@kvack.org and the zswap maintainers. > + > A special purpose allocator for storing compressed pages. > It is designed to store up to three compressed pages per physic= al > page. It is a ZBUD derivative so the simplicity and determinism= are > still there. > > +config Z3FOLD > + tristate > + default y > + depends on Z3FOLD_DEPRECATED > + > config ZSMALLOC > tristate > prompt "N:1 compression allocator (zsmalloc)" if ZSWAP > -- > 2.43.0.275.g3460e3d667-goog > FWIW: Acked-by: Nhat Pham