From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F15BC27C6E for ; Fri, 14 Jun 2024 20:29:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D33E26B00EF; Fri, 14 Jun 2024 16:27:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A7256B0120; Fri, 14 Jun 2024 16:27:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44B5F6B00EF; Fri, 14 Jun 2024 16:27:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 444726B0120 for ; Fri, 14 Jun 2024 16:25:19 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EB5A8C0971 for ; Fri, 14 Jun 2024 20:25:18 +0000 (UTC) X-FDA: 82230623916.20.9C761E8 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by imf30.hostedemail.com (Postfix) with ESMTP id 2E4CE8000E for ; Fri, 14 Jun 2024 20:25:16 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jOSjdUj+; spf=pass (imf30.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718396715; a=rsa-sha256; cv=none; b=aIzwgt8bA5/1nZsGh+EgfXtBdaDrunFUd563BCfwDtnmWhiyUed9pkyoQT5z406X+vtBLp zoDi+g4R8mXOvcQraIPjT6qQxFEgf0zs2LNC1w4QMhZlrJs6BDV6m9/5STQ8poj/gJymHP PM99BOzxCRJ/b0zr1gNPR7fP1QrzWjU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jOSjdUj+; spf=pass (imf30.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718396715; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=axdjSQ1Zu5/EILmUtDEnQjyhEPcv2TO9jZPPXchqyvA=; b=tRRTdj+Jg1pGvPRvKxLJmxxLGwwrmgm0plTbCJOsf6sbZpYKfb3bOfJsFZ3qX8yOds3/3W +11faGM0EoyQIOk3g3pzpUURHihQ5I7nOMYs7ZDE4j4zxQ2sM2MHCgee0EQA1uh26L5BH1 KVMRqDva6Zlma4nS1cWKOuaAYGpRpDU= Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-630640c1e14so32742837b3.1 for ; Fri, 14 Jun 2024 13:25:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718396716; x=1719001516; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=axdjSQ1Zu5/EILmUtDEnQjyhEPcv2TO9jZPPXchqyvA=; b=jOSjdUj+vkPe8Wd4xJpf0gx/1Xdp8DZMjyu7dtCVZSYMMwqDdmw5REgQXINHk7b1Mc AxqQSF7ppDBLEIuR02StTPjU0cn6JZdjcrx2ZnZS0CRGTkt9HN5hgbEmuJqHDYyjPdom YoYo8rglZ0D2mAeBaXf6sy3BvnESAvISve/klk4FwxOo2PVgIrZ375mu4r9INRYoEM8K x0c3dcmBCxcmGdvttWIim27Wm+Y9MI6SyJsrlW3b8tOVkmCVvf8kWMLoGwpXzjXlIM8g 6UtnPJXeZcPHWsvUx/OLNo/H/oSgIOHUbskWrkzuYhcXaax6NehAfq+KoeJG9mXD2LjP VccA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718396716; x=1719001516; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=axdjSQ1Zu5/EILmUtDEnQjyhEPcv2TO9jZPPXchqyvA=; b=cikxtdUhoBIbAcTA8HXpJfNgPPa9JZOFeQ/20oe1mhQRMaTdoz3oKokQQ+b+ViNQar Ya8eEKY24s+ZcGB0373QQDR4/f2HNQmXWOHfb6xDqNy4X8p7UIY8/G21lIURneMl1DAT 8VDyu3JZ4RVZW/7L40bytteElIQnVy4ouNS75TnHNh+Pg9nReVndlxkj2ZqqTEtUWxEr uybhru5fugRtM/HE8Km+9Pe2A7m2BnGacKYf5pwptnV8FxhgTUMZUJF+r2yEAhguNMgd rtOrYTefhnpJdW1AIxSMYlzH6IkW8wdI1BVbG0dJ8rW4irAQTMxuYTpudWLnOVCc2OY/ UOAw== X-Forwarded-Encrypted: i=1; AJvYcCVB1FVLso4plvN/8vYHEUCwgFhG5N7sj+AK2rEdoEghDtexAhxSwlc3ue9+ciSy9k8Dr8SXo2GeHFTCydeTqv2/0x4= X-Gm-Message-State: AOJu0Yzwhnx7EUeJ6NfqNyEppR8bY57N4vLGnoV1Y3mX9f/hnL4wuUAM M2CTQ4v/ZVpuSZjYwxbeMqx5fc0d4i/FlrKjjRBWF9tTsf9cVA1nst0YbBTyBjVh3k3OAXNykop vKaTs97ZRGfN+2RULfebUpM2jTKo= X-Google-Smtp-Source: AGHT+IF5bWN9+eY2hIDkgu4ftLzJGI/Ah+wbUOVd528kWaq3VpHpLrmx6VFVBQSGo3TKJ1KBAXAZEMYHaVdbMqVirLM= X-Received: by 2002:a25:ce4c:0:b0:dfa:c779:2404 with SMTP id 3f1490d57ef6-dff153dbb88mr3765848276.30.1718396716173; Fri, 14 Jun 2024 13:25:16 -0700 (PDT) MIME-Version: 1.0 References: <20240614100902.3469724-1-usamaarif642@gmail.com> <20240614100902.3469724-3-usamaarif642@gmail.com> In-Reply-To: <20240614100902.3469724-3-usamaarif642@gmail.com> From: Nhat Pham Date: Fri, 14 Jun 2024 13:25:05 -0700 Message-ID: Subject: Re: [PATCH v5 2/2] mm: remove code to handle same filled pages To: Usama Arif Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, shakeel.butt@linux.dev, david@redhat.com, ying.huang@intel.com, hughd@google.com, willy@infradead.org, yosryahmed@google.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: q19ryxsn6bt3sjhea696jamewssqa1os X-Rspamd-Queue-Id: 2E4CE8000E X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1718396716-792690 X-HE-Meta: U2FsdGVkX19VwUp/ADZmeQiovEh/9u/Lq/jXQAEwN9QN2JBtTThE0s24aIPZ3vdMK6uDsvihhvFVqlnmGqUoa71NIwMKsOQY//TW3jyIDdc1GjUdzjzexIjqOwhCtJVrSdct3IFEnP8tojXa6nFXyk9m/yaJtFMLnIwjH56Xs+2kVb3Qb8bUEeIBoZQJZvY7GiJYaXwhlCefURaRaL/Bz/ll8UqEAup5mpmK7sMFxYFWGX5n+0Z5/mKcr3yYVCBXbOSPYJUzCxpUzHksEHv/teAM79F6GTd+LhMUi1nJ+11u9EK2fqq7HtxjFsdqPTPKDbczsTqITzGvAzWbPdCK1/ogk/QKXPx5DgkseJfsvP73ooIQvNubdPSfSacSK5q+KZ6tWwyQ1QC+tx8N+d640zEk9x1YNHoH+DVlOAvzkO44n5n8D2aGl0RP4xPov05eK3EE6u2PYz/lvrIHrhVlDyHs/zvox22uUbMAo/tm8HX+ag+HM5W21IM4TDeTaAXlbr6H0Vrfm1VbUqPTWqqLRqemoxecctAPxrDDjFOnZhROOuuWJN3ePa2c9u2dHCQl8kCk8G1vLDvXBSkjHM6n7X3Vg7RbaHtDNw9xHC/qfx9EIuaQBmHoqNms+ls877h5qbQs4NXpS4ab3f005kGMBWHP6jGZTQ04DKP56OwnIJ+W3mN1VGe5OTcgpG4dNLciu5ffzbkG7KZG3GzTLyKin3nYySN3rDoCz7tPW3Idukmkn5+R4Y5TykqPG/UWuQra8oMrTwBD66NgxeUg9XOXjCtr2JMXTYyuPz+VJlXVBn9j7TPCmSPHiPl6AkR0I81Qz5EqkUCF3sllPnAH+F2+0XpG0EA5QUMhdWN0T+asqIcRu4tceeO9tlBdWMmFOtUSYQC3MXY6B6RE/NF7g28XPQHhfi4lF9j+t3LyseBOH2ACmD9Ufi5MrZeIsUiGIh+nbtz2v7u3M2eIp7aKjbv 4wI6IdMl IjnhxQHoL2vpkFZUtvOzMOd6Ux5pDcdeATjbgjrbQHtJ+v4bNglXO0PPLtrhXr5LOOFFx45LSwwwJn0QFFfBpDcsAjGGTk0rS/6adz/TIij86chQNH4lmRRQesqdI6FZVGq5c1cL2E2iP7nvClPx27OAUWDARi+ti0TjwYi/AKiOrBNgxEiQu1le+Vx2yM8gsMEBJTdCHU8DBMo1Lx7D2sajwwnQvADaP6TZ5TdBKxPh+52n5akT3RAVHWiuBTabXzO375UfHSPIGcmcBSQCKNypkc920FvxfjFTvktonubWJY9w0thoHNLlpsd5gKrIUKp3k X-Bogosity: Ham, tests=bogofilter, spamicity=0.207800, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 14, 2024 at 3:09=E2=80=AFAM Usama Arif = wrote: > > With an earlier commit to handle zero-filled pages in swap directly, > and with only 1% of the same-filled pages being non-zero, zswap no > longer needs to handle same-filled pages and can just work on compressed > pages. > > Signed-off-by: Usama Arif > --- Other than my previous comments to re-add the stat counter somehow (which will probably helps with testing in the future), this series LGTM! Reviewed-by: Nhat Pham