From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29431C04FE0 for ; Tue, 8 Aug 2023 17:02:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 34C6F6B0071; Tue, 8 Aug 2023 13:02:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D66F6B0074; Tue, 8 Aug 2023 13:02:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14FF38D0001; Tue, 8 Aug 2023 13:02:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F41206B0071 for ; Tue, 8 Aug 2023 13:02:28 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B9E01160D59 for ; Tue, 8 Aug 2023 17:02:15 +0000 (UTC) X-FDA: 81101555430.17.7EBDCF4 Received: from mail-il1-f171.google.com (mail-il1-f171.google.com [209.85.166.171]) by imf27.hostedemail.com (Postfix) with ESMTP id 4C2FE40173 for ; Tue, 8 Aug 2023 17:01:17 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=mAHyKZ7q; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.171 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691514078; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rmtOfsr0i1ygbtrC3L/L4cye7XBRT5d1Yjylj9UYt+o=; b=TYVy7jhr6x88naUs01snueJOdbSoH+GRyXiUBa4x3wrY5PnHhbeQioxTsiNJZSjtNVL6gQ dgnwM8Nk46WWNo8oFEgzYC+UL9czv5sJZiEcoN2htYpkYqfvzeiI2tVyFdbP55SDCBNfuI ZJItWOeNMdOgZGLutVlTj1C6HxqrF8E= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=mAHyKZ7q; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.171 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691514078; a=rsa-sha256; cv=none; b=z1TewzjcepQsHMLAefeyw/cdTyt2XZ5jC8BEmdcTouUU1y6d5GL01OjvC9dk7I0elGUO67 NJCM9OfKtHltD2a0f7lkuf7oCC5LBnEcAXRDD6sAb6BRRdWXa755X4sEptslTo4EzrVjhd /torR3H1S9h/Zknhmjz/4NwfrQ6qfYg= Received: by mail-il1-f171.google.com with SMTP id e9e14a558f8ab-348ccbf27eeso24736195ab.0 for ; Tue, 08 Aug 2023 10:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691514076; x=1692118876; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rmtOfsr0i1ygbtrC3L/L4cye7XBRT5d1Yjylj9UYt+o=; b=mAHyKZ7qrfbGV4//kbz1NMHuX0i8RD+XN6YSmrvjBgegeGjsLG/FxgtSfrTYpasYKY RiRV6Va3Aqd0f1HdXRPYsXH9918WYALJhvRPkK7g0gqIDnTYACu+w9s/zcv2+qnlfMb9 UY9qS0qGMt1tdiSi7hBYoWFSXSMtbowmu5sS8MhnIOg64988QMd/zBmsOIhFQ/rWb7QZ shx/Fa/7gj6WOzhZnQHwIRLRF8xEYp/U6oYUZCHMGqvPfUkQ3Fs/MOD7gCxievTVHZea 3ttEteoeXpWMf60mUALUSNm84Z3YfmgWIch/r3oGHib/vQE9kIOZso2/AcQsCoKJwZFn zAgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691514076; x=1692118876; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rmtOfsr0i1ygbtrC3L/L4cye7XBRT5d1Yjylj9UYt+o=; b=JLvomojsouq1om1E7SX9ffE7iDN5ehIufsInIC1y4xnltngiMvmAlZk0fdXRIobTwH PHTfHO8XUd7lOMXJyPRUUflLO4Jt8Ggj4PHRKtAa1Ydz2i+19y2cyQRiep3RD411IAob eCGJClij2Og4VFEO4CGbYz10lbWeQ4rgSimb1zp3GWdo/QjwJcPrA4xMLQbGDITQYhHS P70SykZld+TROdhwxJsvwvhL2SFEFV5PFqI2K7X/O3NMW08fRe5fiUStsadPOfKw44/s M9YX0UJq+x3wnbWfhvD3KDXbsZJ/l9OqeqFWn/Y87olxEW0XAtB1JIY2u8ZP+yv1iGf3 ZoMw== X-Gm-Message-State: AOJu0YxzGNprgAqrVFSb6t9z5MSkqRGIGHgZbuge01GLWVGyeOw3Nciy QDq3zMHGXodD0Qg5Vs80RpYnHXbm9N3bGecGpOQ= X-Google-Smtp-Source: AGHT+IH8/XWwKzyQOGXMCu1VzXzHa0sYnNFbSJuF2e5NLWSIdi6aGP5l1Q+jVi4/l54BwgrZ6cxnmuTZGY8/ATL0QOM= X-Received: by 2002:a92:c5cf:0:b0:348:824b:8949 with SMTP id s15-20020a92c5cf000000b00348824b8949mr346370ilt.15.1691514076097; Tue, 08 Aug 2023 10:01:16 -0700 (PDT) MIME-Version: 1.0 References: <20230808062056.292950-1-xiujianfeng@huaweicloud.com> In-Reply-To: <20230808062056.292950-1-xiujianfeng@huaweicloud.com> From: Nhat Pham Date: Tue, 8 Aug 2023 10:01:05 -0700 Message-ID: Subject: Re: [PATCH -next v2] mm: zswap: update comment for struct zswap_entry To: Xiu Jianfeng Cc: sjenning@redhat.com, ddstreet@ieee.org, akpm@linux-foundation.org, vitaly.wool@konsulko.com, linux-mm@kvack.org, xiujianfeng@huawei.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4C2FE40173 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: mb31aphbhf3ipmsonuk4rjzt9gct4rk4 X-HE-Tag: 1691514077-416601 X-HE-Meta: U2FsdGVkX1845COC5UVu8xBi/4PayRXju8xGvFtN6iOAAEv2R+fwN1GAE998GfOdAqJFqqjpJRfif1CUUHsrpKh+CyqFeHbeTcIAP0tAWV2kDZrihOJ6p9vb+lyb6a5kTuRJDIyNtftdjjWnc53TJRgwrFAFkpP5WI0WSq+kZHYPw13RC0PG86V9z876FXYwa3BP40O4LJhLCKj2xvCpsBV/aSXyKKDGonqoepf63e6+bYBRbwtpf87mjRIPZhKA7Z77m27YuAS6MdFPWLWVlTuOFOYIuUNza+dA7wTpt4GXpHgfEdDuTxNCbYEDeCLSqtuJKYzbn6/XPMy3XG7A3t5D30tb7lJK1PQMGjLE5YpIDZUkU8EhYATrDBqkiZJDyLMk5xPfJz7gTQaMVVRSWRBOUznu+wddlQu6/yFkk/9zclKcVwzC45zkHIwAJwDMqoeCg43OQfK5HshMIexzosltTzHHWaj+R5pZ7MDLTWJDmHbswoJ+gZUbrd0GbWjyT4sME2XGb8V6bqbf2sxqJvxSEYWn6QW96+XtzjTP6OJ82s8gWJUlm13IbQ5WcNONzkcRpsDlLYgkmqTNHDge8AfDU93jGqBx7ZkyOGaZ9TiUBepMw2b6X5GR4FPMHLGKywcgpiV8j3mJb5Zo76J8ByzQisOlGGzCXZ5wNbDddQueEG5lSGig1nkxDFbuokg6NgU96022OVG2AzanJXjCK9zeoNe0d4KLoVKpdeiZyVSLM9WP6mQ6gcRZ8qkUmvCKe2Fskkklb7sTlMLQamQK54WqNpd0XlTVXxQRfaxy2KJSOm8IvJKA61bfY3TV41h/sV5w6Zt9O5YmyfyPzSipoHX8UC0nbkGYT1Pi4Dmq2jMAK45H6DEj42jNYD20PrNeg6XwYwEm5u7BavpMl/ESg5zZ6VdQqq226XTRHObwioxKm06NaZ4OdhGRWHNZYXe2reUfS1W2qgrtDifEJ9s VHyxf48d sluXpTrXfSTXN6ZYBT4OusLdxXoCUkCFRucpb/tQHTSRBgru22hP1p6GKpfVz5obRpHSHAkepKKrhmmcd+upTsVl2IQkl1pmXkVmhztN8LfSFIdESNRXOVUO2tVSlrhY3OudbbUEERaQlxGN8ubQoMhjQO6q2uvmDYySy8WQd0NCfxzEEGkv/4GD9lzwWLw8dbxACfK3H3oAr5xbIhLijh6zjG/e0DnlukTmVBtTay/Cr6XS2WB4ffX1n+uUG/xLbgu15K3zHBGV56+DMLlgPo4NBo/rB9+u/Sm+EwlZx5I40blZbdrzQq9ghvRYdPJVEhKlOeGTcNZPNA6NlBppuz4M3WtYlURcF2bcCuwaMQ5L/1WSbwh8o9QqceHQfUV7NczT2qwXC/mtteiKmgaRRieKtbJIb1nMooqy3h/5j+OwbZ175LgUFDNRJQN+/E9k+CXGYWZsMXsI7ZsLjNRd5og8RsRD50rO4QDQemdyyUfcHagtjeT6XBqpTJw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001374, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 7, 2023 at 11:22=E2=80=AFPM Xiu Jianfeng wrote: > > From: Xiu Jianfeng > > Since commit 0bb488498c98 ("mm: zswap: remove zswap_header"), the > 'offset' has been replaced by swpentry, update the comment for it, > and also add comment for 'objcg'. > > Signed-off-by: Xiu Jianfeng > > --- > v2: reword the comment > --- > mm/zswap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 5b56d38e7339..1e17f11a7896 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -182,7 +182,7 @@ struct zswap_pool { > * page within zswap. > * > * rbnode - links the entry into red-black tree for the appropriate swap= type > - * offset - the swap offset for the entry. Index into the red-black tre= e. > + * swpentry - associated swap entry, the offset indexes into the red-bla= ck tree > * refcount - the number of outstanding reference to the entry. This is = needed > * to protect against premature freeing of the entry by code > * concurrent calls to load, invalidate, and writeback. The = lock > @@ -195,6 +195,7 @@ struct zswap_pool { > * pool - the zswap_pool the entry's data is in > * handle - zpool allocation handle that stores the compressed page data > * value - value of the same-value filled pages which have same content > + * objcg - the obj_cgroup that the compressed memory is charged to > * lru - handle to the pool's lru used to evict pages. > */ > struct zswap_entry { > -- > 2.34.1 > > LGTM! Thanks for updating the comments. Acked-by: Nhat Pham