From: Nhat Pham <nphamcs@gmail.com>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Chengming Zhou <chengming.zhou@linux.dev>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 5/9] mm: zswap: remove zswap_same_filled_pages_enabled
Date: Tue, 26 Mar 2024 15:01:18 -0700 [thread overview]
Message-ID: <CAKEwX=N=mbaHFwqgMsc8Zb8tCLfSeowBEPyd1H2nOO2L8Qemgg@mail.gmail.com> (raw)
In-Reply-To: <20240325235018.2028408-6-yosryahmed@google.com>
On Mon, Mar 25, 2024 at 4:50 PM Yosry Ahmed <yosryahmed@google.com> wrote:
>
> There is no logical reason to refuse storing same-filled pages more
> efficiently and opt for compression. Remove the userspace knob.
>
Agree. Absolutely no idea why we have this knob in the first place -
if you have cycles to compress, you probably have some extra cycles to
check same-filled page state? And that is the only cost I can think of
- it wins on probably all other aspects: memory usage,
"decompression", no need to write back these pages etc.
Any actual zswap user who has data or counter-use case should chime
in, but FWIW, my vote is:
Reviewed-by: Nhat Pham <nphamcs@gmail.com>
next prev parent reply other threads:[~2024-03-26 22:01 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 23:50 [RFC PATCH 0/9] zswap: store zero-filled pages more efficiently Yosry Ahmed
2024-03-25 23:50 ` [RFC PATCH 1/9] mm: zswap: always shrink in zswap_store() if zswap_pool_reached_full Yosry Ahmed
2024-03-26 21:49 ` Nhat Pham
2024-03-27 2:21 ` Chengming Zhou
2024-03-28 19:09 ` Johannes Weiner
2024-03-25 23:50 ` [RFC PATCH 2/9] mm: zswap: refactor storing to the tree out of zswap_store() Yosry Ahmed
2024-03-27 2:25 ` Chengming Zhou
2024-03-27 22:29 ` Yosry Ahmed
2024-03-25 23:50 ` [RFC PATCH 3/9] mm: zswap: refactor limit checking from zswap_store() Yosry Ahmed
2024-03-27 2:42 ` Chengming Zhou
2024-03-27 22:30 ` Yosry Ahmed
2024-03-25 23:50 ` [RFC PATCH 4/9] mm: zswap: move more same-filled pages checks outside of zswap_store() Yosry Ahmed
2024-03-26 21:57 ` Nhat Pham
2024-03-27 2:39 ` Chengming Zhou
2024-03-27 22:32 ` Yosry Ahmed
2024-03-25 23:50 ` [RFC PATCH 5/9] mm: zswap: remove zswap_same_filled_pages_enabled Yosry Ahmed
2024-03-26 22:01 ` Nhat Pham [this message]
2024-03-27 2:44 ` Chengming Zhou
2024-03-27 22:34 ` Yosry Ahmed
2024-03-28 19:11 ` Johannes Weiner
2024-03-28 20:06 ` Yosry Ahmed
2024-03-29 2:14 ` Yosry Ahmed
2024-03-29 14:02 ` Maciej S. Szmigiero
2024-03-29 17:44 ` Johannes Weiner
2024-03-29 18:22 ` Yosry Ahmed
2024-04-01 10:37 ` Maciej S. Szmigiero
2024-04-01 18:29 ` Yosry Ahmed
2024-03-25 23:50 ` [RFC PATCH 6/9] mm: zswap: drop support for non-zero same-filled pages handling Yosry Ahmed
2024-03-27 11:25 ` Chengming Zhou
2024-03-27 16:40 ` Nhat Pham
2024-03-27 22:38 ` Yosry Ahmed
2024-03-28 19:31 ` Johannes Weiner
2024-03-28 20:23 ` Yosry Ahmed
2024-03-28 21:07 ` Johannes Weiner
2024-03-28 23:19 ` Nhat Pham
2024-03-29 2:05 ` Yosry Ahmed
2024-03-29 4:27 ` Yosry Ahmed
2024-03-29 17:37 ` Johannes Weiner
2024-03-29 18:56 ` Yosry Ahmed
2024-03-29 21:17 ` Johannes Weiner
2024-03-29 22:29 ` Yosry Ahmed
2024-03-28 23:33 ` Nhat Pham
2024-03-29 2:07 ` Yosry Ahmed
2024-03-25 23:50 ` [RFC PATCH 7/9] mm: zswap: store zero-filled pages without a zswap_entry Yosry Ahmed
2024-03-28 8:12 ` Chengming Zhou
2024-03-28 18:45 ` Yosry Ahmed
2024-03-28 19:38 ` Johannes Weiner
2024-03-28 20:29 ` Yosry Ahmed
2024-03-25 23:50 ` [RFC PATCH 8/9] mm: zswap: do not check the global limit for zero-filled pages Yosry Ahmed
2024-03-28 8:15 ` Chengming Zhou
2024-03-25 23:50 ` [RFC PATCH 9/9] mm: zswap: use zswap_entry_free() for partially initialized entries Yosry Ahmed
2024-03-28 8:31 ` Chengming Zhou
2024-03-28 18:49 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKEwX=N=mbaHFwqgMsc8Zb8tCLfSeowBEPyd1H2nOO2L8Qemgg@mail.gmail.com' \
--to=nphamcs@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox